13239 2007-03-30 21:45:53 -0700 REGRESSION (r20343): Drosera hits exception trying to call "count" cross-process 2008-05-17 09:56:04 -0700 1 1 1 Unclassified WebKit New Bugs 523.x (Safari 3) Mac OS X 10.4 CLOSED FIXED InRadar, Regression P1 Normal --- 1 darin webkit-unassigned mrowe timothy oldest_to_newest 16366 0 darin 2007-03-30 21:45:53 -0700 This is actually a bug in changes made to the Objective-C binding. I have a patch. 16368 1 darin 2007-03-30 21:51:07 -0700 Broken by r20343, which fixed bug 13129. 16361 2 darin 2007-03-30 22:38:06 -0700 My fix breaks the Democracy application. So I don't really have a fix! 16363 3 darin 2007-03-30 22:42:44 -0700 Correcting the selector names in -[WebScriptObject methodForSelector:] and -[WebScriptObject respondsToSelector:] does no good. PyObjC, normal method dispatch, and Distributed Objects, are all far too low level to use either of those methods. I think we'll have to add the count method back if we want to call it. What's less clear is exactly what PyObjC code is doing something bad when it sees a count method. I downloaded the PyObjC source code and could not find it. 16326 4 mrowe 2007-03-30 23:28:17 -0700 You're right. I'm not sure what made me think respondsToSelector: and friends would work for this. I couldn't find where in PyObjC's code things went wrong either, but the stack trace when "count" is invoked is underneath PyObject_IsTrue which determines which Python objects are considered true in a boolean context. For number-like objects this is those with non-zero value, for sequence-like objects it is those with non-zero length. The fact this results in "count" being invoked suggests that Python or PyObjC believes the WebScriptObject is sequence-like in some way. I'm not sure how or why exactly this is happening, nor who arranges for PyObject_IsTrue to call through to "count". It seems like rolling out the obviously incorrect fix r20343 and reopening bug 13129 so it can be addressed correctly would be the right thing to do here. Do you agree Darin? 16192 5 13904 mrowe 2007-03-31 03:34:10 -0700 Created attachment 13904 Patch This uses valueForKey: rather than count. Arguably this addressing the symptom rather than the cause, but the presence of -[WebScriptObject count] breaks at least one third-party app which is bad news. 16198 6 13907 mrowe 2007-03-31 04:58:28 -0700 Created attachment 13907 Updated patch Mitz pointed out that I had missed removing the interface declaration in DebuggerDocument that had been preventing the use of -count from generating a warning. 16181 7 13907 mitz 2007-03-31 05:02:37 -0700 Comment on attachment 13907 Updated patch r=me 15891 8 mrowe 2007-03-31 22:06:56 -0700 Landed in r20643. 15893 9 mrowe 2007-03-31 22:14:05 -0700 <rdar://problem/5103227> 80799 10 timothy 2008-05-17 09:56:04 -0700 Closing since Drosera has been replaced by the new Web Inspector debugger. Moving to the New Bugs component so the Drosera component can be closed and removed. 13904 2007-03-31 03:34:10 -0700 2007-03-31 05:02:56 -0700 Patch webkit-bug-13239-v1.patch text/plain 1522 mrowe SW5kZXg6IFdlYktpdFRvb2xzL0NoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBXZWJLaXRUb29scy9D aGFuZ2VMb2cJKHJldmlzaW9uIDIwNjM3KQorKysgV2ViS2l0VG9vbHMvQ2hhbmdlTG9nCSh3b3Jr aW5nIGNvcHkpCkBAIC0xLDMgKzEsMTYgQEAKKzIwMDctMDMtMzEgIE1hcmsgUm93ZSAgPG1yb3dl QGFwcGxlLmNvbT4KKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAg ICAgICBGaXggaHR0cDovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MTMyMzkKKyAg ICAgICAgQnVnIDEzMjM5OiBSRUdSRVNTSU9OIChyMjAzNDMpOiBEcm9zZXJhIGhpdHMgZXhjZXB0 aW9uIHRyeWluZyB0byBjYWxsICJjb3VudCIgY3Jvc3MtcHJvY2VzcworCisgICAgICAgIFVzZSAt W1dlYlNjcmlwdE9iamVjdCB2YWx1ZUZvcktleTpAImxlbmd0aCJdIHRvIHJldHJpZXZlIHRoZSBs ZW5ndGggb2YgYSBKYXZhU2NyaXB0IGFycmF5CisgICAgICAgIHJhdGhlciB0aGFuIC1bV2ViU2Ny aXB0T2JqZWN0IGNvdW50XS4KKworICAgICAgICAqIERyb3NlcmEvRGVidWdnZXJEb2N1bWVudC5t OgorICAgICAgICAoLVtEZWJ1Z2dlckRvY3VtZW50IHdlYlNjcmlwdEF0dHJpYnV0ZUtleXNGb3JT Y3JpcHRPYmplY3Q6XSk6CisKIDIwMDctMDMtMzAgIEFuZGVycyBDYXJsc3NvbiAgPGFuZGVyc2Nh QGFwcGxlLmNvbT4KIAogICAgICAgICBSZXZpZXdlZCBieSBHZW9mZi4KSW5kZXg6IFdlYktpdFRv b2xzL0Ryb3NlcmEvRGVidWdnZXJEb2N1bWVudC5tCj09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIFdlYktpdFRvb2xz L0Ryb3NlcmEvRGVidWdnZXJEb2N1bWVudC5tCShyZXZpc2lvbiAyMDYzNikKKysrIFdlYktpdFRv b2xzL0Ryb3NlcmEvRGVidWdnZXJEb2N1bWVudC5tCSh3b3JraW5nIGNvcHkpCkBAIC0xMTgsNyAr MTE4LDcgQEAgc3RhdGljIE5TU3RyaW5nICpEZWJ1Z2dlclN0ZXBPdXRUb29sYmFySQogCiAgICAg TlNNdXRhYmxlQXJyYXkgKnJlc3VsdCA9IFtbTlNNdXRhYmxlQXJyYXkgYWxsb2NdIGluaXRdOwog ICAgIFdlYlNjcmlwdE9iamVjdCAqdmFyaWFibGVzID0gW2VudW1lcmF0ZUF0dHJpYnV0ZXMgY2Fs bFdlYlNjcmlwdE1ldGhvZDpAImNhbGwiIHdpdGhBcmd1bWVudHM6W05TQXJyYXkgYXJyYXlXaXRo T2JqZWN0Om9iamVjdF1dOwotICAgIHVuc2lnbmVkIGxlbmd0aCA9IFt2YXJpYWJsZXMgY291bnRd OworICAgIHVuc2lnbmVkIGxlbmd0aCA9IFtbdmFyaWFibGVzIHZhbHVlRm9yS2V5OkAibGVuZ3Ro Il0gaW50VmFsdWVdOwogICAgIGZvciAodW5zaWduZWQgaSA9IDA7IGkgPCBsZW5ndGg7IGkrKykg ewogICAgICAgICBOU1N0cmluZyAqa2V5ID0gW3ZhcmlhYmxlcyB3ZWJTY3JpcHRWYWx1ZUF0SW5k ZXg6aV07CiAgICAgICAgIFtyZXN1bHQgYWRkT2JqZWN0OmtleV07Cg== 13907 2007-03-31 04:58:28 -0700 2007-03-31 05:02:37 -0700 Updated patch webkit-bug-13239-v2.patch text/plain 1920 mrowe SW5kZXg6IFdlYktpdFRvb2xzL0NoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBXZWJLaXRUb29scy9D aGFuZ2VMb2cJKHJldmlzaW9uIDIwNjM3KQorKysgV2ViS2l0VG9vbHMvQ2hhbmdlTG9nCSh3b3Jr aW5nIGNvcHkpCkBAIC0xLDMgKzEsMTYgQEAKKzIwMDctMDMtMzEgIE1hcmsgUm93ZSAgPG1yb3dl QGFwcGxlLmNvbT4KKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAg ICAgICBGaXggaHR0cDovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MTMyMzkKKyAg ICAgICAgQnVnIDEzMjM5OiBSRUdSRVNTSU9OIChyMjAzNDMpOiBEcm9zZXJhIGhpdHMgZXhjZXB0 aW9uIHRyeWluZyB0byBjYWxsICJjb3VudCIgY3Jvc3MtcHJvY2VzcworCisgICAgICAgIFVzZSAt W1dlYlNjcmlwdE9iamVjdCB2YWx1ZUZvcktleTpAImxlbmd0aCJdIHRvIHJldHJpZXZlIHRoZSBs ZW5ndGggb2YgYSBKYXZhU2NyaXB0IGFycmF5CisgICAgICAgIHJhdGhlciB0aGFuIC1bV2ViU2Ny aXB0T2JqZWN0IGNvdW50XS4KKworICAgICAgICAqIERyb3NlcmEvRGVidWdnZXJEb2N1bWVudC5t OgorICAgICAgICAoLVtEZWJ1Z2dlckRvY3VtZW50IHdlYlNjcmlwdEF0dHJpYnV0ZUtleXNGb3JT Y3JpcHRPYmplY3Q6XSk6CisKIDIwMDctMDMtMzAgIEFuZGVycyBDYXJsc3NvbiAgPGFuZGVyc2Nh QGFwcGxlLmNvbT4KIAogICAgICAgICBSZXZpZXdlZCBieSBHZW9mZi4KSW5kZXg6IFdlYktpdFRv b2xzL0Ryb3NlcmEvRGVidWdnZXJEb2N1bWVudC5tCj09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIFdlYktpdFRvb2xz L0Ryb3NlcmEvRGVidWdnZXJEb2N1bWVudC5tCShyZXZpc2lvbiAyMDYzNikKKysrIFdlYktpdFRv b2xzL0Ryb3NlcmEvRGVidWdnZXJEb2N1bWVudC5tCSh3b3JraW5nIGNvcHkpCkBAIC0zOCwxMCAr MzgsNiBAQCBzdGF0aWMgTlNTdHJpbmcgKkRlYnVnZ2VyU3RlcEludG9Ub29sYmFyCiBzdGF0aWMg TlNTdHJpbmcgKkRlYnVnZ2VyU3RlcE92ZXJUb29sYmFySXRlbSA9IEAiRGVidWdnZXJTdGVwT3Zl clRvb2xiYXJJdGVtIjsKIHN0YXRpYyBOU1N0cmluZyAqRGVidWdnZXJTdGVwT3V0VG9vbGJhckl0 ZW0gPSBAIkRlYnVnZ2VyU3RlcE91dFRvb2xiYXJJdGVtIjsKIAotQGludGVyZmFjZSBXZWJTY3Jp cHRPYmplY3QgKFdlYlNjcmlwdE9iamVjdFByaXZhdGUpCi0tICh1bnNpZ25lZCBpbnQpY291bnQ7 Ci1AZW5kCi0KIEBpbXBsZW1lbnRhdGlvbiBEZWJ1Z2dlckRvY3VtZW50CiArIChCT09MKWlzU2Vs ZWN0b3JFeGNsdWRlZEZyb21XZWJTY3JpcHQ6KFNFTClhU2VsZWN0b3IKIHsKQEAgLTExOCw3ICsx MTQsNyBAQCBzdGF0aWMgTlNTdHJpbmcgKkRlYnVnZ2VyU3RlcE91dFRvb2xiYXJJCiAKICAgICBO U011dGFibGVBcnJheSAqcmVzdWx0ID0gW1tOU011dGFibGVBcnJheSBhbGxvY10gaW5pdF07CiAg ICAgV2ViU2NyaXB0T2JqZWN0ICp2YXJpYWJsZXMgPSBbZW51bWVyYXRlQXR0cmlidXRlcyBjYWxs V2ViU2NyaXB0TWV0aG9kOkAiY2FsbCIgd2l0aEFyZ3VtZW50czpbTlNBcnJheSBhcnJheVdpdGhP YmplY3Q6b2JqZWN0XV07Ci0gICAgdW5zaWduZWQgbGVuZ3RoID0gW3ZhcmlhYmxlcyBjb3VudF07 CisgICAgdW5zaWduZWQgbGVuZ3RoID0gW1t2YXJpYWJsZXMgdmFsdWVGb3JLZXk6QCJsZW5ndGgi XSBpbnRWYWx1ZV07CiAgICAgZm9yICh1bnNpZ25lZCBpID0gMDsgaSA8IGxlbmd0aDsgaSsrKSB7 CiAgICAgICAgIE5TU3RyaW5nICprZXkgPSBbdmFyaWFibGVzIHdlYlNjcmlwdFZhbHVlQXRJbmRl eDppXTsKICAgICAgICAgW3Jlc3VsdCBhZGRPYmplY3Q6a2V5XTsK