132389 2014-04-30 10:47:17 -0700 Web Inspector: Ensure UIProcess checks in to webinspectord after spawning a WebProcess 2019-05-02 20:57:06 -0700 1 1 1 Unclassified WebKit Web Inspector 528+ (Nightly build) All All RESOLVED FIXED InRadar P2 Normal --- 1 joepeck webkit-unassigned basuke commit-queue graouts joepeck timothy webkit-bug-importer oldest_to_newest 1005418 0 joepeck 2014-04-30 10:47:17 -0700 Since we aggregate WebProcess WebViews under the UIProcess, debuggers were expecting the UIProcess to connect. In some situations it was not connecting so the views never showed up. We should always have the UIProcess connect to webinspectord if it is spawning a WebProcess. <rdar://problem/16676218> 1005425 1 230495 joepeck 2014-04-30 10:58:04 -0700 Created attachment 230495 [PATCH] Proposed Fix 1005470 2 230495 commit-queue 2014-04-30 12:29:47 -0700 Comment on attachment 230495 [PATCH] Proposed Fix Clearing flags on attachment: 230495 Committed r168035: <http://trac.webkit.org/changeset/168035> 1005471 3 commit-queue 2014-04-30 12:29:50 -0700 All reviewed patches have been landed. Closing bug. 1532143 4 basuke 2019-05-01 16:55:29 -0700 I cannot understand this patch, but is this XPC related? For WinCairo case, there seems no reason to instanciate RemoteInspector object in UIProcess. 1532633 5 joepeck 2019-05-02 20:57:06 -0700 (In reply to Basuke Suzuki from comment #4) > I cannot understand this patch, but is this XPC related? For WinCairo case, > there seems no reason to instanciate RemoteInspector object in UIProcess. Yes this is XPC related for Cocoa platforms (encourage the UIProcess to connect to webinspectord when it creates a WebContentProcess that may have a page). This could be made PLATFORM(COCOA) if needed. 230495 2014-04-30 10:58:04 -0700 2014-04-30 12:29:47 -0700 [PATCH] Proposed Fix rwi-uiprocess.patch text/plain 1861 joepeck ZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJLaXQyL0NoYW5nZUxvZyBiL1NvdXJjZS9XZWJLaXQyL0No YW5nZUxvZwppbmRleCAzNDJiMjVkLi5lMGQxNDk1IDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViS2l0 Mi9DaGFuZ2VMb2cKKysrIGIvU291cmNlL1dlYktpdDIvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMTkg QEAKKzIwMTQtMDQtMzAgIEpvc2VwaCBQZWNvcmFybyAgPHBlY29yYXJvQGFwcGxlLmNvbT4KKwor ICAgICAgICBXZWIgSW5zcGVjdG9yOiBFbnN1cmUgVUlQcm9jZXNzIGNoZWNrcyBpbiB0byB3ZWJp bnNwZWN0b3JkIGFmdGVyIHNwYXduaW5nIGEgV2ViUHJvY2VzcworICAgICAgICBodHRwczovL2J1 Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MTMyMzg5CisKKyAgICAgICAgUmV2aWV3ZWQg YnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgV2UgYWdncmVnYXRlIFdlYlByb2Nlc3MgV2Vi VmlldydzIHVuZGVyIHRoZSBVSVByb2Nlc3MuIElmIHRoZSBVSVByb2Nlc3MKKyAgICAgICAgZGlk bid0IGNvbm5lY3QgdG8gd2ViaW5zcGVjdG9yZCB0aGVzZSBXZWJWaWV3cyB3b3VsZCBoYXZlIHJl bWFpbmVkCisgICAgICAgIGhpZGRlbi4gQWx3YXlzIGhhdmUgdGhlIFVJUHJvY2VzcyBjb25uZWN0 IHRvIHdlYmluc3BlY3RvcmQgd2hlbiBpdAorICAgICAgICBzcGF3bnMgYSBXZWJQcm9jZXNzIGFu ZCBtYXkgaGF2ZSBhIGNoaWxkIHByb2Nlc3MgaG9sZGluZyB2aWV3cyB0aGF0CisgICAgICAgIGl0 IHVsdGltYXRlbHkgb3ducyBhbmQgc2hvdWxkIGRpc3BsYXkgdW5kZXIgdGhlIFVJUHJvY2VzcyBu YW1lLgorCisgICAgICAgICogVUlQcm9jZXNzL1dlYkNvbnRleHQuY3BwOgorICAgICAgICAoV2Vi S2l0OjpXZWJDb250ZXh0OjpjcmVhdGVOZXdXZWJQcm9jZXNzKToKKwogMjAxNC0wNC0zMCAgQWxl eGV5IFByb3NrdXJ5YWtvdiAgPGFwQGFwcGxlLmNvbT4KIAogICAgICAgICBodHRwczovL2J1Z3Mu d2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MTMyMzYzCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2Vi S2l0Mi9VSVByb2Nlc3MvV2ViQ29udGV4dC5jcHAgYi9Tb3VyY2UvV2ViS2l0Mi9VSVByb2Nlc3Mv V2ViQ29udGV4dC5jcHAKaW5kZXggMjhhODQ4NC4uMmM2YmJhZCAxMDA2NDQKLS0tIGEvU291cmNl L1dlYktpdDIvVUlQcm9jZXNzL1dlYkNvbnRleHQuY3BwCisrKyBiL1NvdXJjZS9XZWJLaXQyL1VJ UHJvY2Vzcy9XZWJDb250ZXh0LmNwcApAQCAtODksNiArODksMTAgQEAKICNpbmNsdWRlICJDdXN0 b21Qcm90b2NvbE1hbmFnZXJNZXNzYWdlcy5oIgogI2VuZGlmCiAKKyNpZiBFTkFCTEUoUkVNT1RF X0lOU1BFQ1RPUikKKyNpbmNsdWRlIDxKYXZhU2NyaXB0Q29yZS9SZW1vdGVJbnNwZWN0b3IuaD4K KyNlbmRpZgorCiAjaWYgVVNFKFNPVVApCiAjaWYgRU5BQkxFKENVU1RPTV9QUk9UT0NPTFMpCiAj aW5jbHVkZSAiV2ViU291cEN1c3RvbVByb3RvY29sUmVxdWVzdE1hbmFnZXIuaCIKQEAgLTY0Myw2 ICs2NDcsMTEgQEAgV2ViUHJvY2Vzc1Byb3h5JiBXZWJDb250ZXh0OjpjcmVhdGVOZXdXZWJQcm9j ZXNzKCkKICAgICB9IGVsc2UKICAgICAgICAgQVNTRVJUKG1fbWVzc2FnZXNUb0luamVjdGVkQnVu ZGxlUG9zdGVkVG9FbXB0eUNvbnRleHQuaXNFbXB0eSgpKTsKIAorI2lmIEVOQUJMRShSRU1PVEVf SU5TUEVDVE9SKQorICAgIC8vIEluaXRpYWxpemUgcmVtb3RlIGluc3BlY3RvciBjb25uZWN0aW9u IG5vdyB0aGF0IHdlIGhhdmUgYSBzdWItcHJvY2VzcyB0aGF0IGlzIGhvc3Rpbmcgb25lIG9mIG91 ciB3ZWIgdmlld3MuCisgICAgSW5zcGVjdG9yOjpSZW1vdGVJbnNwZWN0b3I6OnNoYXJlZCgpOyAK KyNlbmRpZgorCiAgICAgcmV0dXJuICpwcm9jZXNzOwogfQogCg==