132384 2014-04-30 09:03:12 -0700 [GTK] unit test for tls redirection failure required 2014-05-07 03:13:25 -0700 1 1 1 Unclassified WebKit WebKitGTK 528+ (Nightly build) Unspecified Unspecified RESOLVED INVALID P2 Normal --- 131675 1 brian.holt brian.holt cgarcia mario oldest_to_newest 1005378 0 brian.holt 2014-04-30 09:03:12 -0700 Create a unit test for GTK for bug 121548 1005702 1 230573 brian.holt 2014-05-01 03:26:40 -0700 Created attachment 230573 WIP patch 1005703 2 brian.holt 2014-05-01 03:28:49 -0700 I've uploaded a unit test which should test for the problem, but I'm having trouble with my environment - after running an TestSSL (with or without my patch) correctly the first time, any further runs hang. 1006331 3 cgarcia 2014-05-03 03:54:00 -0700 Ah right, this is due to bug #131675, that broke a lot of unit tests. 1006338 4 230573 cgarcia 2014-05-03 04:45:55 -0700 Comment on attachment 230573 WIP patch View in context: https://bugs.webkit.org/attachment.cgi?id=230573&action=review I think this test is actually showing that your patch was wrong, since we are failing with TLS errors for a non HTTPS connection. > Tools/TestWebKitAPI/Tests/WebKit2Gtk/TestSSL.cpp:222 > + // Load a page with an invalid certificate that redirects to http. > + test->loadURI(kHttpsServer->getURIForPath("/redirect-to-http").data()); > + test->waitUntilLoadFinished(); Shouldn't this fail?, the comment says it's a page with an invalid certificate. > Tools/TestWebKitAPI/Tests/WebKit2Gtk/TestSSL.cpp:226 > + // Now load a page with http and expect that the previous TLS failure should cause the load to fail. > + test->loadURI(kHttpsServer->getURIForPath("/index.html").data()); > + test->waitUntilLoadFailedWithTLSErrors(); I don't think this is correct. The errors of a previous load shouldn't affect new loads. The problem is supposed to happen with redirections, not with two independent loads. > Tools/TestWebKitAPI/Tests/WebKit2Gtk/TestSSL.cpp:252 > + } else if (g_str_equal(path, "/redirect-to-http/")) { > + soup_message_set_redirect(message, SOUP_STATUS_MOVED_PERMANENTLY, ""); I don't understand this either, this should redirect to another location, you should use a redirect uri instead of "". 1007271 5 cgarcia 2014-05-07 03:13:25 -0700 Unit test was included in the patch landed in r168417 in the end, so this is no longer needed. 230573 2014-05-01 03:26:40 -0700 2014-05-03 04:45:55 -0700 WIP patch bug-132384-20140501112558.patch text/plain 3888 brian.holt U3VidmVyc2lvbiBSZXZpc2lvbjogMTY3OTkzCmRpZmYgLS1naXQgYS9Ub29scy9DaGFuZ2VMb2cg Yi9Ub29scy9DaGFuZ2VMb2cKaW5kZXggZjA2YzczOWJlYTg5ZTY2N2EwYWRiYmY0ZTY0MmIwMThk ZDNhNmM4Zi4uMDU0ZDgxN2VkODQ2ZjBmZGI1MGQ2NjEyZDkzMWVlODQyZTBkM2RkOCAxMDA2NDQK LS0tIGEvVG9vbHMvQ2hhbmdlTG9nCisrKyBiL1Rvb2xzL0NoYW5nZUxvZwpAQCAtMSwzICsxLDE4 IEBACisyMDE0LTA1LTAxICBCcmlhbiBIb2x0ICA8YnJpYW4uaG9sdEBzYW1zdW5nLmNvbT4KKwor ICAgICAgICBbR1RLXSB1bml0IHRlc3QgZm9yIHRscyByZWRpcmVjdGlvbiBmYWlsdXJlIHJlcXVp cmVkCisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0xMzIz ODQKKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICBDcmVh dGVkIGEgdW5pdCB0ZXN0IGZvciB0aGUgVExTIGVycm9yIG9uIHJlZGlyZWN0aW9uIHRvIEhUVFAg YnVnLgorCisgICAgICAgICogVGVzdFdlYktpdEFQSS9UZXN0cy9XZWJLaXQyR3RrL1Rlc3RTU0wu Y3BwOgorICAgICAgICAodGVzdFRMU1JlZGlyZWN0aW9uSFRUUFNUb0hUVFApOgorICAgICAgICAo aHR0cHNTZXJ2ZXJDYWxsYmFjayk6CisgICAgICAgIChodHRwU2VydmVyQ2FsbGJhY2spOgorICAg ICAgICAoYmVmb3JlQWxsKToKKwogMjAxNC0wNC0yOSAgU3RlcGhhbmllIExld2lzICA8c2xld2lz QGFwcGxlLmNvbT4KIAogICAgICAgICA8cmRhcjovL3Byb2JsZW0vMTY3NjU3NjU+IFVzZSBKU09O OjpQUCBpbiBwZXJsIHNjcmlwdHMgaW5zdGVhZCBvZiBKU09OLgpkaWZmIC0tZ2l0IGEvVG9vbHMv VGVzdFdlYktpdEFQSS9UZXN0cy9XZWJLaXQyR3RrL1Rlc3RTU0wuY3BwIGIvVG9vbHMvVGVzdFdl YktpdEFQSS9UZXN0cy9XZWJLaXQyR3RrL1Rlc3RTU0wuY3BwCmluZGV4IGM3YmJiNzUxYWJhZDQx NTJhY2VjZGYxZTUwYTA3NDk3Yzk3NmIwYzAuLmY0NGRlZTNjOWI5NDdjMTM0NjhhOWEwYzg1YTgw NjhhMjg3MTMxNjMgMTAwNjQ0Ci0tLSBhL1Rvb2xzL1Rlc3RXZWJLaXRBUEkvVGVzdHMvV2ViS2l0 Mkd0ay9UZXN0U1NMLmNwcAorKysgYi9Ub29scy9UZXN0V2ViS2l0QVBJL1Rlc3RzL1dlYktpdDJH dGsvVGVzdFNTTC5jcHAKQEAgLTIxMiw2ICsyMTIsMjEgQEAgc3RhdGljIHZvaWQgdGVzdExvYWRG YWlsZWRXaXRoVExTRXJyb3JzKFRMU0Vycm9yc1Rlc3QqIHRlc3QsIGdjb25zdHBvaW50ZXIpCiAg ICAgZ19hc3NlcnRfY21wc3RyKHdlYmtpdF93ZWJfdmlld19nZXRfdGl0bGUodGVzdC0+bV93ZWJW aWV3KSwgPT0sIFRMU0V4cGVjdGVkU3VjY2Vzc1RpdGxlKTsKIH0KIAorc3RhdGljIHZvaWQgdGVz dFRMU1JlZGlyZWN0aW9uSFRUUFNUb0hUVFAoVExTRXJyb3JzVGVzdCogdGVzdCwgZ2NvbnN0cG9p bnRlcikKK3sKKyAgICBXZWJLaXRXZWJDb250ZXh0KiBjb250ZXh0ID0gd2Via2l0X3dlYl92aWV3 X2dldF9jb250ZXh0KHRlc3QtPm1fd2ViVmlldyk7CisgICAgd2Via2l0X3dlYl9jb250ZXh0X3Nl dF90bHNfZXJyb3JzX3BvbGljeShjb250ZXh0LCBXRUJLSVRfVExTX0VSUk9SU19QT0xJQ1lfRkFJ TCk7CisKKyAgICAvLyBMb2FkIGEgcGFnZSB3aXRoIGFuIGludmFsaWQgY2VydGlmaWNhdGUgdGhh dCByZWRpcmVjdHMgdG8gaHR0cC4KKyAgICB0ZXN0LT5sb2FkVVJJKGtIdHRwc1NlcnZlci0+Z2V0 VVJJRm9yUGF0aCgiL3JlZGlyZWN0LXRvLWh0dHAiKS5kYXRhKCkpOworICAgIHRlc3QtPndhaXRV bnRpbExvYWRGaW5pc2hlZCgpOworCisgICAgLy8gTm93IGxvYWQgYSBwYWdlIHdpdGggaHR0cCBh bmQgZXhwZWN0IHRoYXQgdGhlIHByZXZpb3VzIFRMUyBmYWlsdXJlIHNob3VsZCBjYXVzZSB0aGUg bG9hZCB0byBmYWlsLgorICAgIHRlc3QtPmxvYWRVUkkoa0h0dHBzU2VydmVyLT5nZXRVUklGb3JQ YXRoKCIvaW5kZXguaHRtbCIpLmRhdGEoKSk7CisgICAgdGVzdC0+d2FpdFVudGlsTG9hZEZhaWxl ZFdpdGhUTFNFcnJvcnMoKTsKKyAgICBnX2Fzc2VydF9jbXBpbnQodGVzdC0+bV9sb2FkRXZlbnRz WzBdLCA9PSwgTG9hZFRyYWNraW5nVGVzdDo6UHJvdmlzaW9uYWxMb2FkU3RhcnRlZCk7CisgICAg Z19hc3NlcnRfY21waW50KHRlc3QtPm1fbG9hZEV2ZW50c1sxXSwgPT0sIExvYWRUcmFja2luZ1Rl c3Q6OkxvYWRGaW5pc2hlZCk7Cit9CiAKIHN0YXRpYyB2b2lkIGh0dHBzU2VydmVyQ2FsbGJhY2so U291cFNlcnZlciogc2VydmVyLCBTb3VwTWVzc2FnZSogbWVzc2FnZSwgY29uc3QgY2hhciogcGF0 aCwgR0hhc2hUYWJsZSosIFNvdXBDbGllbnRDb250ZXh0KiwgZ3BvaW50ZXIpCiB7CkBAIC0yMzMs NiArMjQ4LDggQEAgc3RhdGljIHZvaWQgaHR0cHNTZXJ2ZXJDYWxsYmFjayhTb3VwU2VydmVyKiBz ZXJ2ZXIsIFNvdXBNZXNzYWdlKiBtZXNzYWdlLCBjb25zdAogICAgICAgICBzb3VwX21lc3NhZ2Vf c2V0X3N0YXR1cyhtZXNzYWdlLCBTT1VQX1NUQVRVU19PSyk7CiAgICAgICAgIHNvdXBfbWVzc2Fn ZV9ib2R5X2FwcGVuZChtZXNzYWdlLT5yZXNwb25zZV9ib2R5LCBTT1VQX01FTU9SWV9TVEFUSUMs IFRMU1N1Y2Nlc3NIVE1MU3RyaW5nLCBzdHJsZW4oVExTU3VjY2Vzc0hUTUxTdHJpbmcpKTsKICAg ICAgICAgc291cF9tZXNzYWdlX2JvZHlfY29tcGxldGUobWVzc2FnZS0+cmVzcG9uc2VfYm9keSk7 CisgICAgfSBlbHNlIGlmIChnX3N0cl9lcXVhbChwYXRoLCAiL3JlZGlyZWN0LXRvLWh0dHAvIikp IHsKKyAgICAgICAgc291cF9tZXNzYWdlX3NldF9yZWRpcmVjdChtZXNzYWdlLCBTT1VQX1NUQVRV U19NT1ZFRF9QRVJNQU5FTlRMWSwgIiIpOwogICAgIH0gZWxzZQogICAgICAgICBzb3VwX21lc3Nh Z2Vfc2V0X3N0YXR1cyhtZXNzYWdlLCBTT1VQX1NUQVRVU19OT1RfRk9VTkQpOwogfQpAQCAtMjQ0 LDcgKzI2MSwxMCBAQCBzdGF0aWMgdm9pZCBodHRwU2VydmVyQ2FsbGJhY2soU291cFNlcnZlciog c2VydmVyLCBTb3VwTWVzc2FnZSogbWVzc2FnZSwgY29uc3QgYwogICAgICAgICByZXR1cm47CiAg ICAgfQogCi0gICAgaWYgKGdfc3RyX2VxdWFsKHBhdGgsICIvdGVzdC1zY3JpcHQiKSkgeworICAg IGlmIChnX3N0cl9lcXVhbChwYXRoLCAiL2luZGV4Lmh0bWwiKSkgeworICAgICAgICBzb3VwX21l c3NhZ2Vfc2V0X3N0YXR1cyhtZXNzYWdlLCBTT1VQX1NUQVRVU19PSyk7CisgICAgICAgIHNvdXBf bWVzc2FnZV9ib2R5X2FwcGVuZChtZXNzYWdlLT5yZXNwb25zZV9ib2R5LCBTT1VQX01FTU9SWV9D T1BZLCBpbmRleEhUTUwsIHN0cmxlbihpbmRleEhUTUwpKTsKKyAgICB9IGVsc2UgaWYgKGdfc3Ry X2VxdWFsKHBhdGgsICIvdGVzdC1zY3JpcHQiKSkgewogICAgICAgICBHVW5pcXVlUHRyPGNoYXI+ IHBhdGhUb0ZpbGUoZ19idWlsZF9maWxlbmFtZShUZXN0OjpnZXRSZXNvdXJjZXNEaXIoKS5kYXRh KCksICJsaW5rLXRpdGxlLmpzIiwgbnVsbHB0cikpOwogICAgICAgICBjaGFyKiBjb250ZW50czsK ICAgICAgICAgZ3NpemUgbGVuZ3RoOwpAQCAtMjgxLDYgKzMwMSw3IEBAIHZvaWQgYmVmb3JlQWxs KCkKICAgICAvLyBkb25lIGluIHRoZSB0bHMtcGVybWlzc2lvbi1yZXF1ZXN0IHRlc3QuCiAgICAg U1NMVGVzdDo6YWRkKCJXZWJLaXRXZWJWaWV3IiwgInRscy1lcnJvcnMtcG9saWN5IiwgdGVzdFRM U0Vycm9yc1BvbGljeSk7CiAgICAgVExTRXJyb3JzVGVzdDo6YWRkKCJXZWJLaXRXZWJWaWV3Iiwg ImxvYWQtZmFpbGVkLXdpdGgtdGxzLWVycm9ycyIsIHRlc3RMb2FkRmFpbGVkV2l0aFRMU0Vycm9y cyk7CisgICAgVExTRXJyb3JzVGVzdDo6YWRkKCJXZWJLaXRXZWJWaWV3IiwgInRscy1yZWRpcmVj dGlvbi10by1odHRwIiwgdGVzdFRMU1JlZGlyZWN0aW9uSFRUUFNUb0hUVFApOwogfQogCiB2b2lk IGFmdGVyQWxsKCkK