132369 2014-04-29 17:32:20 -0700 Removing unused argument in InlineFlowBox::placeBoxesInInlineDirection() 2014-04-29 17:37:18 -0700 1 1 1 Unclassified WebKit New Bugs 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 1 mmaxfield mmaxfield commit-queue esprehn+autocc glenn kondapallykalyan oldest_to_newest 1005228 0 mmaxfield 2014-04-29 17:32:20 -0700 Removing unused argument in InlineFlowBox::placeBoxesInInlineDirection() 1005229 1 230444 mmaxfield 2014-04-29 17:33:26 -0700 Created attachment 230444 Patch 1005230 2 mmaxfield 2014-04-29 17:35:08 -0700 Wow, you are fast, Darin! 1005232 3 mmaxfield 2014-04-29 17:37:18 -0700 http://trac.webkit.org/changeset/167973 230444 2014-04-29 17:33:26 -0700 2014-04-29 17:34:07 -0700 Patch bug-132369-20140429173304.patch text/plain 6135 mmaxfield U3VidmVyc2lvbiBSZXZpc2lvbjogMTY3OTY0CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggNTljN2YyMzk4YmUzZWI1 Mzk2MzJmMjY5MTFmMmI1NDMwOTg1YWVjYy4uZDU3MmQ5YzI0Y2Y1NTZmNTk3Yjk0NmVmMDA5Zjcx MDUwM2RhYTk1OCAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDIyIEBACisyMDE0LTA0LTI5ICBNeWxl cyBDLiBNYXhmaWVsZCAgPG1tYXhmaWVsZEBhcHBsZS5jb20+CisKKyAgICAgICAgUmVtb3Zpbmcg dW51c2VkIGFyZ3VtZW50IGluIElubGluZUZsb3dCb3g6OnBsYWNlQm94ZXNJbklubGluZURpcmVj dGlvbigpCisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0x MzIzNjkKKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICBU aGlzIHdhcyBub3QgY2F1Z2h0IGJ5IG91ciBjb21waWxlciBiZWNhdXNlIHBsYWNlQm94ZXNJbklu bGluZURpcmVjdGlvbigpCisgICAgICAgIGlzIG11dHVhbGx5LXJlY3Vyc2l2ZSB3aXRoIHBsYWNl Qm94UmFuZ2VJbklubGluZURpcmVjdGlvbigpLgorCisgICAgICAgIE5vIG5ldyB0ZXN0cyBhcmUg bmVjZXNzYXJ5IGJlY2F1c2UgdGhlcmUgc2hvdWxkIGJlIG5vIGJlaGF2aW9yIGNoYW5nZS4KKwor ICAgICAgICAqIHJlbmRlcmluZy9JbmxpbmVGbG93Qm94LmNwcDoKKyAgICAgICAgKFdlYkNvcmU6 OklubGluZUZsb3dCb3g6OnBsYWNlQm94ZXNJbklubGluZURpcmVjdGlvbik6CisgICAgICAgIChX ZWJDb3JlOjpJbmxpbmVGbG93Qm94OjpwbGFjZUJveFJhbmdlSW5JbmxpbmVEaXJlY3Rpb24pOgor ICAgICAgICAqIHJlbmRlcmluZy9JbmxpbmVGbG93Qm94Lmg6CisgICAgICAgICogcmVuZGVyaW5n L1JlbmRlckJsb2NrTGluZUxheW91dC5jcHA6CisgICAgICAgIChXZWJDb3JlOjpSZW5kZXJCbG9j a0Zsb3c6OmNvbXB1dGVJbmxpbmVEaXJlY3Rpb25Qb3NpdGlvbnNGb3JMaW5lKToKKwogMjAxNC0w NC0yOSAgTWFyayBIYWhuZW5iZXJnICA8bWhhaG5lbmJlcmdAYXBwbGUuY29tPgogCiAgICAgICAg IEpTUHJveGllcyBzaG91bGQgYmUgY2FjaGVhYmxlCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29y ZS9yZW5kZXJpbmcvSW5saW5lRmxvd0JveC5jcHAgYi9Tb3VyY2UvV2ViQ29yZS9yZW5kZXJpbmcv SW5saW5lRmxvd0JveC5jcHAKaW5kZXggY2M0NjMwZDAxN2QzYjBhZmI2ZmQyZTcwOTdhNjVlMDM4 MWIzYWU3Zi4uZmZiMDdmM2Y2ODcwOTIyYTU4NTk1NjY5ODc0MTExMTkzOGU1MGI5ZiAxMDA2NDQK LS0tIGEvU291cmNlL1dlYkNvcmUvcmVuZGVyaW5nL0lubGluZUZsb3dCb3guY3BwCisrKyBiL1Nv dXJjZS9XZWJDb3JlL3JlbmRlcmluZy9JbmxpbmVGbG93Qm94LmNwcApAQCAtMzY3LDcgKzM2Nyw3 IEBAIHZvaWQgSW5saW5lRmxvd0JveDo6ZGV0ZXJtaW5lU3BhY2luZ0ZvckZsb3dCb3hlcyhib29s IGxhc3RMaW5lLCBib29sIGlzTG9naWNhbGx5CiAgICAgfQogfQogCi1mbG9hdCBJbmxpbmVGbG93 Qm94OjpwbGFjZUJveGVzSW5JbmxpbmVEaXJlY3Rpb24oZmxvYXQgbG9naWNhbExlZnQsIGJvb2wm IG5lZWRzV29yZFNwYWNpbmcsIEdseXBoT3ZlcmZsb3dBbmRGYWxsYmFja0ZvbnRzTWFwJiB0ZXh0 Qm94RGF0YU1hcCkKK2Zsb2F0IElubGluZUZsb3dCb3g6OnBsYWNlQm94ZXNJbklubGluZURpcmVj dGlvbihmbG9hdCBsb2dpY2FsTGVmdCwgYm9vbCYgbmVlZHNXb3JkU3BhY2luZykKIHsKICAgICAv LyBTZXQgb3VyIHggcG9zaXRpb24uCiAgICAgYmVnaW5QbGFjaW5nQm94UmFuZ2VzSW5JbmxpbmVE aXJlY3Rpb24obG9naWNhbExlZnQpOwpAQCAtMzc4LDE0ICszNzgsMTQgQEAgZmxvYXQgSW5saW5l Rmxvd0JveDo6cGxhY2VCb3hlc0luSW5saW5lRGlyZWN0aW9uKGZsb2F0IGxvZ2ljYWxMZWZ0LCBi b29sJiBuZWVkc1cKICAgICBmbG9hdCBtaW5Mb2dpY2FsTGVmdCA9IHN0YXJ0TG9naWNhbExlZnQ7 CiAgICAgZmxvYXQgbWF4TG9naWNhbFJpZ2h0ID0gbG9naWNhbExlZnQ7CiAKLSAgICBwbGFjZUJv eFJhbmdlSW5JbmxpbmVEaXJlY3Rpb24oZmlyc3RDaGlsZCgpLCAwLCBsb2dpY2FsTGVmdCwgbWlu TG9naWNhbExlZnQsIG1heExvZ2ljYWxSaWdodCwgbmVlZHNXb3JkU3BhY2luZywgdGV4dEJveERh dGFNYXApOworICAgIHBsYWNlQm94UmFuZ2VJbklubGluZURpcmVjdGlvbihmaXJzdENoaWxkKCks IDAsIGxvZ2ljYWxMZWZ0LCBtaW5Mb2dpY2FsTGVmdCwgbWF4TG9naWNhbFJpZ2h0LCBuZWVkc1dv cmRTcGFjaW5nKTsKIAogICAgIGxvZ2ljYWxMZWZ0ICs9IGJvcmRlckxvZ2ljYWxSaWdodCgpICsg cGFkZGluZ0xvZ2ljYWxSaWdodCgpOwogICAgIGVuZFBsYWNpbmdCb3hSYW5nZXNJbklubGluZURp cmVjdGlvbihzdGFydExvZ2ljYWxMZWZ0LCBsb2dpY2FsTGVmdCwgbWluTG9naWNhbExlZnQsIG1h eExvZ2ljYWxSaWdodCk7CiAgICAgcmV0dXJuIGxvZ2ljYWxMZWZ0OwogfQogCi1mbG9hdCBJbmxp bmVGbG93Qm94OjpwbGFjZUJveFJhbmdlSW5JbmxpbmVEaXJlY3Rpb24oSW5saW5lQm94KiBmaXJz dENoaWxkLCBJbmxpbmVCb3gqIGxhc3RDaGlsZCwgZmxvYXQmIGxvZ2ljYWxMZWZ0LCBmbG9hdCYg bWluTG9naWNhbExlZnQsIGZsb2F0JiBtYXhMb2dpY2FsUmlnaHQsIGJvb2wmIG5lZWRzV29yZFNw YWNpbmcsIEdseXBoT3ZlcmZsb3dBbmRGYWxsYmFja0ZvbnRzTWFwJiB0ZXh0Qm94RGF0YU1hcCkK K2Zsb2F0IElubGluZUZsb3dCb3g6OnBsYWNlQm94UmFuZ2VJbklubGluZURpcmVjdGlvbihJbmxp bmVCb3gqIGZpcnN0Q2hpbGQsIElubGluZUJveCogbGFzdENoaWxkLCBmbG9hdCYgbG9naWNhbExl ZnQsIGZsb2F0JiBtaW5Mb2dpY2FsTGVmdCwgZmxvYXQmIG1heExvZ2ljYWxSaWdodCwgYm9vbCYg bmVlZHNXb3JkU3BhY2luZykKIHsKICAgICBmb3IgKElubGluZUJveCogY3VyciA9IGZpcnN0Q2hp bGQ7IGN1cnIgJiYgY3VyciAhPSBsYXN0Q2hpbGQ7IGN1cnIgPSBjdXJyLT5uZXh0T25MaW5lKCkp IHsKICAgICAgICAgaWYgKGN1cnItPnJlbmRlcmVyKCkuaXNUZXh0KCkpIHsKQEAgLTQxOCw3ICs0 MTgsNyBAQCBmbG9hdCBJbmxpbmVGbG93Qm94OjpwbGFjZUJveFJhbmdlSW5JbmxpbmVEaXJlY3Rp b24oSW5saW5lQm94KiBmaXJzdENoaWxkLCBJbmxpbgogICAgICAgICAgICAgICAgIGxvZ2ljYWxM ZWZ0ICs9IGZsb3ctPm1hcmdpbkxvZ2ljYWxMZWZ0KCk7CiAgICAgICAgICAgICAgICAgaWYgKGtu b3duVG9IYXZlTm9PdmVyZmxvdygpKQogICAgICAgICAgICAgICAgICAgICBtaW5Mb2dpY2FsTGVm dCA9IHN0ZDo6bWluKGxvZ2ljYWxMZWZ0LCBtaW5Mb2dpY2FsTGVmdCk7Ci0gICAgICAgICAgICAg ICAgbG9naWNhbExlZnQgPSBmbG93LT5wbGFjZUJveGVzSW5JbmxpbmVEaXJlY3Rpb24obG9naWNh bExlZnQsIG5lZWRzV29yZFNwYWNpbmcsIHRleHRCb3hEYXRhTWFwKTsKKyAgICAgICAgICAgICAg ICBsb2dpY2FsTGVmdCA9IGZsb3ctPnBsYWNlQm94ZXNJbklubGluZURpcmVjdGlvbihsb2dpY2Fs TGVmdCwgbmVlZHNXb3JkU3BhY2luZyk7CiAgICAgICAgICAgICAgICAgaWYgKGtub3duVG9IYXZl Tm9PdmVyZmxvdygpKQogICAgICAgICAgICAgICAgICAgICBtYXhMb2dpY2FsUmlnaHQgPSBzdGQ6 Om1heChsb2dpY2FsTGVmdCwgbWF4TG9naWNhbFJpZ2h0KTsKICAgICAgICAgICAgICAgICBsb2dp Y2FsTGVmdCArPSBmbG93LT5tYXJnaW5Mb2dpY2FsUmlnaHQoKTsKZGlmZiAtLWdpdCBhL1NvdXJj ZS9XZWJDb3JlL3JlbmRlcmluZy9JbmxpbmVGbG93Qm94LmggYi9Tb3VyY2UvV2ViQ29yZS9yZW5k ZXJpbmcvSW5saW5lRmxvd0JveC5oCmluZGV4IGM4YmFhM2U5ODAzMjc5YWNlOWIyMmYxYWUxYzMw NGQ4YjM0ZmY3ZjYuLmRlMDE1MjAxMmRiOTEwNzI0MTEwMzljMDljMzE1NGYwZDNkYzk5MDggMTAw NjQ0Ci0tLSBhL1NvdXJjZS9XZWJDb3JlL3JlbmRlcmluZy9JbmxpbmVGbG93Qm94LmgKKysrIGIv U291cmNlL1dlYkNvcmUvcmVuZGVyaW5nL0lubGluZUZsb3dCb3guaApAQCAtMTc2LDggKzE3Niw4 IEBAIHB1YmxpYzoKICAgICAvLyBIZWxwZXIgZnVuY3Rpb25zIHVzZWQgZHVyaW5nIGxpbmUgY29u c3RydWN0aW9uIGFuZCBwbGFjZW1lbnQuCiAgICAgdm9pZCBkZXRlcm1pbmVTcGFjaW5nRm9yRmxv d0JveGVzKGJvb2wgbGFzdExpbmUsIGJvb2wgaXNMb2dpY2FsbHlMYXN0UnVuV3JhcHBlZCwgUmVu ZGVyT2JqZWN0KiBsb2dpY2FsbHlMYXN0UnVuUmVuZGVyZXIpOwogICAgIExheW91dFVuaXQgZ2V0 Rmxvd1NwYWNpbmdMb2dpY2FsV2lkdGgoKTsKLSAgICBmbG9hdCBwbGFjZUJveGVzSW5JbmxpbmVE aXJlY3Rpb24oZmxvYXQgbG9naWNhbExlZnQsIGJvb2wmIG5lZWRzV29yZFNwYWNpbmcsIEdseXBo T3ZlcmZsb3dBbmRGYWxsYmFja0ZvbnRzTWFwJik7Ci0gICAgZmxvYXQgcGxhY2VCb3hSYW5nZUlu SW5saW5lRGlyZWN0aW9uKElubGluZUJveCogZmlyc3RDaGlsZCwgSW5saW5lQm94KiBsYXN0Q2hp bGQsIGZsb2F0JiBsb2dpY2FsTGVmdCwgZmxvYXQmIG1pbkxvZ2ljYWxMZWZ0LCBmbG9hdCYgbWF4 TG9naWNhbFJpZ2h0LCBib29sJiBuZWVkc1dvcmRTcGFjaW5nLCBHbHlwaE92ZXJmbG93QW5kRmFs bGJhY2tGb250c01hcCYpOworICAgIGZsb2F0IHBsYWNlQm94ZXNJbklubGluZURpcmVjdGlvbihm bG9hdCBsb2dpY2FsTGVmdCwgYm9vbCYgbmVlZHNXb3JkU3BhY2luZyk7CisgICAgZmxvYXQgcGxh Y2VCb3hSYW5nZUluSW5saW5lRGlyZWN0aW9uKElubGluZUJveCogZmlyc3RDaGlsZCwgSW5saW5l Qm94KiBsYXN0Q2hpbGQsIGZsb2F0JiBsb2dpY2FsTGVmdCwgZmxvYXQmIG1pbkxvZ2ljYWxMZWZ0 LCBmbG9hdCYgbWF4TG9naWNhbFJpZ2h0LCBib29sJiBuZWVkc1dvcmRTcGFjaW5nKTsKICAgICB2 b2lkIGJlZ2luUGxhY2luZ0JveFJhbmdlc0luSW5saW5lRGlyZWN0aW9uKGZsb2F0IGxvZ2ljYWxM ZWZ0KSB7IHNldExvZ2ljYWxMZWZ0KGxvZ2ljYWxMZWZ0KTsgfQogICAgIHZvaWQgZW5kUGxhY2lu Z0JveFJhbmdlc0luSW5saW5lRGlyZWN0aW9uKGZsb2F0IGxvZ2ljYWxMZWZ0LCBmbG9hdCBsb2dp Y2FsUmlnaHQsIGZsb2F0IG1pbkxvZ2ljYWxMZWZ0LCBmbG9hdCBtYXhMb2dpY2FsUmlnaHQpCiAg ICAgewpkaWZmIC0tZ2l0IGEvU291cmNlL1dlYkNvcmUvcmVuZGVyaW5nL1JlbmRlckJsb2NrTGlu ZUxheW91dC5jcHAgYi9Tb3VyY2UvV2ViQ29yZS9yZW5kZXJpbmcvUmVuZGVyQmxvY2tMaW5lTGF5 b3V0LmNwcAppbmRleCAxMWViOTI5MTJjYTFiMzVlODc2ODViNjI0OGM1Yzg1OWM0ZDkwOGM0Li5j MmRjZWRkYWUzNzM2NzQ1N2QzMTRiMWQzYjQxZGE4NTRiNzViNDA3IDEwMDY0NAotLS0gYS9Tb3Vy Y2UvV2ViQ29yZS9yZW5kZXJpbmcvUmVuZGVyQmxvY2tMaW5lTGF5b3V0LmNwcAorKysgYi9Tb3Vy Y2UvV2ViQ29yZS9yZW5kZXJpbmcvUmVuZGVyQmxvY2tMaW5lTGF5b3V0LmNwcApAQCAtNjQ1LDcg KzY0NSw3IEBAIHZvaWQgUmVuZGVyQmxvY2tGbG93Ojpjb21wdXRlSW5saW5lRGlyZWN0aW9uUG9z aXRpb25zRm9yTGluZShSb290SW5saW5lQm94KiBsaW5lCiAgICAgLy8gVGhlIHdpZHRocyBvZiBh bGwgcnVucyBhcmUgbm93IGtub3duLiBXZSBjYW4gbm93IHBsYWNlIGV2ZXJ5IGlubGluZSBib3gg KGFuZAogICAgIC8vIGNvbXB1dGUgYWNjdXJhdGUgd2lkdGhzIGZvciB0aGUgaW5saW5lIGZsb3cg Ym94ZXMpLgogICAgIG5lZWRzV29yZFNwYWNpbmcgPSBmYWxzZTsKLSAgICBsaW5lQm94LT5wbGFj ZUJveGVzSW5JbmxpbmVEaXJlY3Rpb24obGluZUxvZ2ljYWxMZWZ0LCBuZWVkc1dvcmRTcGFjaW5n LCB0ZXh0Qm94RGF0YU1hcCk7CisgICAgbGluZUJveC0+cGxhY2VCb3hlc0luSW5saW5lRGlyZWN0 aW9uKGxpbmVMb2dpY2FsTGVmdCwgbmVlZHNXb3JkU3BhY2luZyk7CiB9CiAKIEJpZGlSdW4qIFJl bmRlckJsb2NrRmxvdzo6Y29tcHV0ZUlubGluZURpcmVjdGlvblBvc2l0aW9uc0ZvclNlZ21lbnQo Um9vdElubGluZUJveCogbGluZUJveCwgY29uc3QgTGluZUluZm8mIGxpbmVJbmZvLCBFVGV4dEFs aWduIHRleHRBbGlnbiwgZmxvYXQmIGxvZ2ljYWxMZWZ0LCAK