132368 2014-04-29 16:48:47 -0700 [iOS][WK2] When pageScaleFactor * deviceScaleFactor = 1, the tile grid is completely messed up 2014-04-29 21:04:56 -0700 1 1 1 Unclassified WebKit New Bugs 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 1 benjamin benjamin commit-queue simon.fraser oldest_to_newest 1005209 0 benjamin 2014-04-29 16:48:47 -0700 [iOS][WK2] When pageScaleFactor * deviceScaleFactor = 1, the tile grid is completely messed up 1005211 1 230439 benjamin 2014-04-29 16:54:29 -0700 Created attachment 230439 Patch 1005217 2 230439 simon.fraser 2014-04-29 16:59:08 -0700 Comment on attachment 230439 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=230439&action=review > Source/WebCore/ChangeLog:11 > + contentsScale() on retina device until the next successful scale update. devices > Source/WebKit2/ChangeLog:15 > + When the page initialize, GraphicsLayerCA::updateContentsScale(0.5) computes a contentsScale of 1. There is an early is initialized 1005273 3 benjamin 2014-04-29 21:04:56 -0700 Committed r167980: <http://trac.webkit.org/changeset/167980> 230439 2014-04-29 16:54:29 -0700 2014-04-29 16:59:08 -0700 Patch bug-132368-20140429165405.patch text/plain 4035 benjamin U3VidmVyc2lvbiBSZXZpc2lvbjogMTY3OTUwCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggZDRkOGJmMzhlMGVlNmEy MzY3MjRhZTk1YmE4NjJiNWZjZDJlNjZkNi4uNDI3N2Q0ZjFhMDkzYzRkOTU1ZWNhZjlhM2ExODFk Mzk0OTY0YTY3NiAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDE1IEBACisyMDE0LTA0LTI5ICBCZW5q YW1pbiBQb3VsYWluICA8YnBvdWxhaW5AYXBwbGUuY29tPgorCisgICAgICAgIFtpT1NdW1dLMl0g V2hlbiBwYWdlU2NhbGVGYWN0b3IgKiBkZXZpY2VTY2FsZUZhY3RvciA9IDEsIHRoZSB0aWxlIGdy aWQgaXMgY29tcGxldGVseSBtZXNzZWQgdXAKKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5v cmcvc2hvd19idWcuY2dpP2lkPTEzMjM2OAorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAo T09QUyEpLgorCisgICAgICAgICogcGxhdGZvcm0vZ3JhcGhpY3MvY2EvbWFjL1RpbGVDb250cm9s bGVyLm1tOgorICAgICAgICAoV2ViQ29yZTo6VGlsZUNvbnRyb2xsZXI6OlRpbGVDb250cm9sbGVy KToKKyAgICAgICAgVGhlIGluaXRpYWwgZGV2aWNlIHNjYWxlIGZhY3RvciB3YXMgaW5pdGlhbGl6 ZWQgdG8gMS4gV2Ugd2VyZSByZXR1cm5pbmcgdGhlIHdyb25nIHpvb21lZE91dENvbnRlbnRzU2Nh bGUoKSBhbmQKKyAgICAgICAgY29udGVudHNTY2FsZSgpIG9uIHJldGluYSBkZXZpY2UgdW50aWwg dGhlIG5leHQgc3VjY2Vzc2Z1bCBzY2FsZSB1cGRhdGUuCisKIDIwMTQtMDQtMjkgIEplciBOb2Js ZSAgPGplci5ub2JsZUBhcHBsZS5jb20+CiAKICAgICAgICAgW2lPU10gUmVtb3ZlIHdvcmthcm91 bmQgZm9yIDxyZGFyOi8vcHJvYmxlbS8xNjU3ODcyNz4uCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2Vi S2l0Mi9DaGFuZ2VMb2cgYi9Tb3VyY2UvV2ViS2l0Mi9DaGFuZ2VMb2cKaW5kZXggNzI3ZGUwMThh ZmFjMTExZDMxZDNkMmRkOGYzOTY2ODk3MTA1NDdjNy4uMDFkNTFjYzRhZGJlZWVmNmZhODgyZTBj NjhlZWM0NGZiZmMyMWRlYiAxMDA2NDQKLS0tIGEvU291cmNlL1dlYktpdDIvQ2hhbmdlTG9nCisr KyBiL1NvdXJjZS9XZWJLaXQyL0NoYW5nZUxvZwpAQCAtMSwzICsxLDI0IEBACisyMDE0LTA0LTI5 ICBCZW5qYW1pbiBQb3VsYWluICA8YnBvdWxhaW5AYXBwbGUuY29tPgorCisgICAgICAgIFtpT1Nd W1dLMl0gV2hlbiBwYWdlU2NhbGVGYWN0b3IgKiBkZXZpY2VTY2FsZUZhY3RvciA9IDEsIHRoZSB0 aWxlIGdyaWQgaXMgY29tcGxldGVseSBtZXNzZWQgdXAKKyAgICAgICAgaHR0cHM6Ly9idWdzLndl YmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTEzMjM2OAorCisgICAgICAgIFJldmlld2VkIGJ5IE5P Qk9EWSAoT09QUyEpLgorCisgICAgICAgICogV2ViUHJvY2Vzcy9XZWJQYWdlL21hYy9QbGF0Zm9y bUNBTGF5ZXJSZW1vdGUuY3BwOgorICAgICAgICAoV2ViS2l0OjpQbGF0Zm9ybUNBTGF5ZXJSZW1v dGU6OlBsYXRmb3JtQ0FMYXllclJlbW90ZSk6CisgICAgICAgIFBsYXRmb3JtQ0FMYXllclJlbW90 ZSBhbHdheXMgaW5pdGlhbGl6ZWQgdGhlIGNvbnRlbnQgc2NhbGUgdG8gMS4gU2luY2UgY29udGVu dHNTY2FsZSBpcyBzdXBwb3NlZCB0byByZWZsZWN0CisgICAgICAgIHpvb21TY2FsZSAqIGRldmlj ZVNjYWxlRmFjdG9yLCB0aGUgdmFsdWUgc2hvdWxkIGJlIDIuCisKKyAgICAgICAgVGhpcyB3YXMg Y2F1c2luZyBidWdzIHdoZW5ldmVyIHRoZSBwYWdlIHNjYWxlIGZhY3RvciB3YXMgMS8yIG9uIHJl dGluYSBkZXZpY2UgKGRldmljZSBzY2FsZSBmYWN0b3IgPSAyKS4KKworICAgICAgICBXaGVuIHRo ZSBwYWdlIGluaXRpYWxpemUsIEdyYXBoaWNzTGF5ZXJDQTo6dXBkYXRlQ29udGVudHNTY2FsZSgw LjUpIGNvbXB1dGVzIGEgY29udGVudHNTY2FsZSBvZiAxLiBUaGVyZSBpcyBhbiBlYXJseQorICAg ICAgICByZXR1cm4gb24gaWYgKGNvbnRlbnRzU2NhbGUgPT0gbV9sYXllci0+Y29udGVudHNTY2Fs ZSgpKS4gU2luY2UgUGxhdGZvcm1DQUxheWVyUmVtb3RlLT5jb250ZW50c1NjYWxlKCkgd2FzIGlu Y29ycmVjbHR5CisgICAgICAgIHJldHVybmluZyBvbmUsIHdlIHdlcmUgbGVhdmluZyB0aGUgdGls ZSBiYWNraW5nIHVubW9kaWZpZWQuCisKKyAgICAgICAgTGF0ZXIsIHdoZW4gdGhlIHRyYW5zYWN0 aW9uIGlzIGNvbW1pdGVkLCB0aGUgdGlsZSBiYWNraW5nIHdvdWxkIHN0aWxsIGJlIGRlZmF1bHQg aW5pdGlhbGl6ZWQgYW5kIHdvdWxkIHJlbmRlciBldmVyeXRoaW5nCisgICAgICAgIGF0IHRoZSB3 cm9uZyBzY2FsZS4KKwogMjAxNC0wNC0yOSAgVGltIEhvcnRvbiAgPHRpbW90aHlfaG9ydG9uQGFw cGxlLmNvbT4KIAogICAgICAgICBCdWlsZCBmaXguCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29y ZS9wbGF0Zm9ybS9ncmFwaGljcy9jYS9tYWMvVGlsZUNvbnRyb2xsZXIubW0gYi9Tb3VyY2UvV2Vi Q29yZS9wbGF0Zm9ybS9ncmFwaGljcy9jYS9tYWMvVGlsZUNvbnRyb2xsZXIubW0KaW5kZXggZjQw MjIxNjBjZTJmODliYzg1YzU3MzhmNjViZmU0ZWE2MDk5ODYzZC4uODM0NTk1ZjY4MDk1OGEwMzk2 ZGRkZDFjNjBhMzNkM2RmMjFlYjNjYiAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvcGxhdGZv cm0vZ3JhcGhpY3MvY2EvbWFjL1RpbGVDb250cm9sbGVyLm1tCisrKyBiL1NvdXJjZS9XZWJDb3Jl L3BsYXRmb3JtL2dyYXBoaWNzL2NhL21hYy9UaWxlQ29udHJvbGxlci5tbQpAQCAtNTUsNyArNTUs NyBAQCBUaWxlQ29udHJvbGxlcjo6VGlsZUNvbnRyb2xsZXIoUGxhdGZvcm1DQUxheWVyKiByb290 UGxhdGZvcm1MYXllcikKICAgICAsIG1fdGlsZVNpemUoZGVmYXVsdFRpbGVXaWR0aCwgZGVmYXVs dFRpbGVIZWlnaHQpCiAgICAgLCBtX3RpbGVSZXZhbGlkYXRpb25UaW1lcih0aGlzLCAmVGlsZUNv bnRyb2xsZXI6OnRpbGVSZXZhbGlkYXRpb25UaW1lckZpcmVkKQogICAgICwgbV96b29tZWRPdXRD b250ZW50c1NjYWxlKDApCi0gICAgLCBtX2RldmljZVNjYWxlRmFjdG9yKDEpCisgICAgLCBtX2Rl dmljZVNjYWxlRmFjdG9yKG93bmluZ0dyYXBoaWNzTGF5ZXIoKS0+cGxhdGZvcm1DQUxheWVyRGV2 aWNlU2NhbGVGYWN0b3IoKSkKICAgICAsIG1fdGlsZUNvdmVyYWdlKENvdmVyYWdlRm9yVmlzaWJs ZUFyZWEpCiAgICAgLCBtX21hcmdpblRvcCgwKQogICAgICwgbV9tYXJnaW5Cb3R0b20oMCkKZGlm ZiAtLWdpdCBhL1NvdXJjZS9XZWJLaXQyL1dlYlByb2Nlc3MvV2ViUGFnZS9tYWMvUGxhdGZvcm1D QUxheWVyUmVtb3RlLmNwcCBiL1NvdXJjZS9XZWJLaXQyL1dlYlByb2Nlc3MvV2ViUGFnZS9tYWMv UGxhdGZvcm1DQUxheWVyUmVtb3RlLmNwcAppbmRleCA3YjkwODExZWY4YWY4MGY4ZTdhYThhZDFi YWZmMTlhODMzMjQ1MjUzLi44OWIxZTYyNWQ4NmMyZmQ2YmU4NDMzMzBhZTA1YWVhYTEzMjM4NGRj IDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViS2l0Mi9XZWJQcm9jZXNzL1dlYlBhZ2UvbWFjL1BsYXRm b3JtQ0FMYXllclJlbW90ZS5jcHAKKysrIGIvU291cmNlL1dlYktpdDIvV2ViUHJvY2Vzcy9XZWJQ YWdlL21hYy9QbGF0Zm9ybUNBTGF5ZXJSZW1vdGUuY3BwCkBAIC04NCw2ICs4NCw4IEBAIFBsYXRm b3JtQ0FMYXllclJlbW90ZTo6UGxhdGZvcm1DQUxheWVyUmVtb3RlKExheWVyVHlwZSBsYXllclR5 cGUsIFBsYXRmb3JtQ0FMYXllCiAgICAgLCBtX2FjY2VsZXJhdGVzRHJhd2luZyhmYWxzZSkKICAg ICAsIG1fY29udGV4dChjb250ZXh0KQogeworICAgIGlmIChvd25lcikKKyAgICAgICAgbV9wcm9w ZXJ0aWVzLmNvbnRlbnRzU2NhbGUgPSBvd25lci0+cGxhdGZvcm1DQUxheWVyRGV2aWNlU2NhbGVG YWN0b3IoKTsKIH0KIAogUGxhdGZvcm1DQUxheWVyUmVtb3RlOjpQbGF0Zm9ybUNBTGF5ZXJSZW1v dGUoY29uc3QgUGxhdGZvcm1DQUxheWVyUmVtb3RlJiBvdGhlciwgUGxhdGZvcm1DQUxheWVyQ2xp ZW50KiBvd25lciwgUmVtb3RlTGF5ZXJUcmVlQ29udGV4dCogY29udGV4dCkK