132344 2014-04-29 11:02:58 -0700 Zombifying sweep should ignore retired blocks 2014-04-29 11:30:35 -0700 1 1 1 Unclassified WebKit JavaScriptCore 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 1 mark.lam mark.lam fpizlo ggaren mhahnenberg mmirman msaboff oliver oldest_to_newest 1005027 0 mark.lam 2014-04-29 11:02:58 -0700 By definition, retired blocks do not have "dead" objects, or at least none that we know of yet until the next marking phase has been run over it. So, we should not be sweeping them (even for zombie mode). 1005029 1 230391 mark.lam 2014-04-29 11:16:43 -0700 Created attachment 230391 the patch. 1005030 2 230391 mhahnenberg 2014-04-29 11:17:22 -0700 Comment on attachment 230391 the patch. r=me 1005033 3 mark.lam 2014-04-29 11:21:15 -0700 Thanks. Landed in r167948: <http://trac.webkit.org/r167948>. 1005038 4 ggaren 2014-04-29 11:25:17 -0700 Why did you do this? Does this fix a bug in zombie mode? Improve performance? 1005039 5 mark.lam 2014-04-29 11:30:35 -0700 (In reply to comment #4) > Why did you do this? > > Does this fix a bug in zombie mode? Improve performance? This fixes a bug when running with zombie mode. This is needed because unlike the default sweeper that only sweeps after a full collection (which ensures there are no retired blocks during a sweep), the zombie sweep can happen with just an eden collection (and hence, retired blocks can exists, and we'll fail an assertion if we don't ignore them). 230391 2014-04-29 11:16:43 -0700 2014-04-29 11:17:22 -0700 the patch. bug-132344.patch text/plain 3093 mark.lam SW5kZXg6IFNvdXJjZS9KYXZhU2NyaXB0Q29yZS9DaGFuZ2VMb2cKPT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PQotLS0gU291 cmNlL0phdmFTY3JpcHRDb3JlL0NoYW5nZUxvZwkocmV2aXNpb24gMTY3OTQ3KQorKysgU291cmNl L0phdmFTY3JpcHRDb3JlL0NoYW5nZUxvZwkod29ya2luZyBjb3B5KQpAQCAtMSwzICsxLDIxIEBA CisyMDE0LTA0LTI5ICBNYXJrIExhbSAgPG1hcmsubGFtQGFwcGxlLmNvbT4KKworICAgICAgICBa b21iaWZ5aW5nIHN3ZWVwIHNob3VsZCBpZ25vcmUgcmV0aXJlZCBibG9ja3MuCisgICAgICAgIDxo dHRwczovL3dlYmtpdC5vcmcvYi8xMzIzNDQ+CisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZ IChPT1BTISkuCisKKyAgICAgICAgQnkgZGVmaW5pdGlvbiwgcmV0aXJlZCBibG9ja3MgZG8gbm90 IGhhdmUgImRlYWQiIG9iamVjdHMsIG9yIGF0IGxlYXN0CisgICAgICAgIG5vbmUgdGhhdCB3ZSBr bm93IG9mIHlldCB1bnRpbCB0aGUgbmV4dCBtYXJraW5nIHBoYXNlIGhhcyBiZWVuIHJ1bgorICAg ICAgICBvdmVyIGl0LiAgU28sIHdlIHNob3VsZCBub3QgYmUgc3dlZXBpbmcgdGhlbSAoZXZlbiBm b3Igem9tYmllIG1vZGUpLgorCisgICAgICAgICogaGVhcC9IZWFwLmNwcDoKKyAgICAgICAgKEpT Qzo6SGVhcDo6em9tYmlmeURlYWRPYmplY3RzKToKKyAgICAgICAgKiBoZWFwL01hcmtlZFNwYWNl LmNwcDoKKyAgICAgICAgKEpTQzo6TWFya2VkU3BhY2U6OnpvbWJpZnlTd2VlcCk6CisgICAgICAg ICogaGVhcC9NYXJrZWRTcGFjZS5oOgorICAgICAgICAoSlNDOjpab21iaWZ5U3dlZXA6Om9wZXJh dG9yKCkpOgorCiAyMDE0LTA0LTI5ICBNYXJrIExhbSAgPG1hcmsubGFtQGFwcGxlLmNvbT4KIAog ICAgICAgICBGaXggYml0IHJvdCBpbiB6b21iaWUgbW9kZSBoZWFwIGNvZGUuCkluZGV4OiBTb3Vy Y2UvSmF2YVNjcmlwdENvcmUvaGVhcC9IZWFwLmNwcAo9PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBTb3VyY2UvSmF2 YVNjcmlwdENvcmUvaGVhcC9IZWFwLmNwcAkocmV2aXNpb24gMTY3OTQ1KQorKysgU291cmNlL0ph dmFTY3JpcHRDb3JlL2hlYXAvSGVhcC5jcHAJKHdvcmtpbmcgY29weSkKQEAgLTEzNDMsNyArMTM0 Myw3IEBAIHZvaWQgSGVhcDo6em9tYmlmeURlYWRPYmplY3RzKCkKICAgICB7CiAgICAgICAgIFNh bXBsaW5nUmVnaW9uIHNhbXBsaW5nUmVnaW9uKCJHYXJiYWdlIENvbGxlY3Rpb246IFN3ZWVwaW5n Iik7CiAgICAgICAgIERlbGF5ZWRSZWxlYXNlU2NvcGUgZGVsYXllZFJlbGVhc2VTY29wZShtX29i amVjdFNwYWNlKTsKLSAgICAgICAgbV9vYmplY3RTcGFjZS5zd2VlcCgpOworICAgICAgICBtX29i amVjdFNwYWNlLnpvbWJpZnlTd2VlcCgpOwogICAgIH0KICAgICBIZWFwSXRlcmF0aW9uU2NvcGUg aXRlcmF0aW9uU2NvcGUoKnRoaXMpOwogICAgIG1fb2JqZWN0U3BhY2UuZm9yRWFjaERlYWRDZWxs PFpvbWJpZnk+KGl0ZXJhdGlvblNjb3BlKTsKSW5kZXg6IFNvdXJjZS9KYXZhU2NyaXB0Q29yZS9o ZWFwL01hcmtlZFNwYWNlLmNwcAo9PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBTb3VyY2UvSmF2YVNjcmlwdENvcmUv aGVhcC9NYXJrZWRTcGFjZS5jcHAJKHJldmlzaW9uIDE2Nzk0NSkKKysrIFNvdXJjZS9KYXZhU2Ny aXB0Q29yZS9oZWFwL01hcmtlZFNwYWNlLmNwcAkod29ya2luZyBjb3B5KQpAQCAtMTI3LDYgKzEy NywxNCBAQCB2b2lkIE1hcmtlZFNwYWNlOjpzd2VlcCgpCiAgICAgZm9yRWFjaEJsb2NrPFN3ZWVw PigpOwogfQogCit2b2lkIE1hcmtlZFNwYWNlOjp6b21iaWZ5U3dlZXAoKQoreworICAgIGlmIChP cHRpb25zOjpsb2dHQygpKQorICAgICAgICBkYXRhTG9nKCJab21iaWZ5aW5nIHN3ZWVwLi4uIik7 CisgICAgbV9oZWFwLT5zd2VlcGVyKCktPndpbGxGaW5pc2hTd2VlcGluZygpOworICAgIGZvckVh Y2hCbG9jazxab21iaWZ5U3dlZXA+KCk7Cit9CisKIHZvaWQgTWFya2VkU3BhY2U6OnJlc2V0QWxs b2NhdG9ycygpCiB7CiAgICAgZm9yIChzaXplX3QgY2VsbFNpemUgPSBwcmVjaXNlU3RlcDsgY2Vs bFNpemUgPD0gcHJlY2lzZUN1dG9mZjsgY2VsbFNpemUgKz0gcHJlY2lzZVN0ZXApIHsKSW5kZXg6 IFNvdXJjZS9KYXZhU2NyaXB0Q29yZS9oZWFwL01hcmtlZFNwYWNlLmgKPT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PQotLS0g U291cmNlL0phdmFTY3JpcHRDb3JlL2hlYXAvTWFya2VkU3BhY2UuaAkocmV2aXNpb24gMTY3OTQ1 KQorKysgU291cmNlL0phdmFTY3JpcHRDb3JlL2hlYXAvTWFya2VkU3BhY2UuaAkod29ya2luZyBj b3B5KQpAQCAtNjMsNiArNjMsMTQgQEAgc3RydWN0IFN3ZWVwIDogTWFya2VkQmxvY2s6OlZvaWRG dW5jdG9yIAogICAgIHZvaWQgb3BlcmF0b3IoKShNYXJrZWRCbG9jayogYmxvY2spIHsgYmxvY2st PnN3ZWVwKCk7IH0KIH07CiAKK3N0cnVjdCBab21iaWZ5U3dlZXAgOiBNYXJrZWRCbG9jazo6Vm9p ZEZ1bmN0b3IgeworICAgIHZvaWQgb3BlcmF0b3IoKShNYXJrZWRCbG9jayogYmxvY2spCisgICAg eworICAgICAgICBpZiAoYmxvY2stPm5lZWRzU3dlZXBpbmcoKSkKKyAgICAgICAgICAgIGJsb2Nr LT5zd2VlcCgpOworICAgIH0KK307CisKIHN0cnVjdCBNYXJrQ291bnQgOiBNYXJrZWRCbG9jazo6 Q291bnRGdW5jdG9yIHsKICAgICB2b2lkIG9wZXJhdG9yKCkoTWFya2VkQmxvY2sqIGJsb2NrKSB7 IGNvdW50KGJsb2NrLT5tYXJrQ291bnQoKSk7IH0KIH07CkBAIC0xMjEsNiArMTI5LDcgQEAgcHVi bGljOgogICAgIHZvaWQgY2xlYXJSZW1lbWJlcmVkU2V0KCk7CiAgICAgdm9pZCBjbGVhck5ld2x5 QWxsb2NhdGVkKCk7CiAgICAgdm9pZCBzd2VlcCgpOworICAgIHZvaWQgem9tYmlmeVN3ZWVwKCk7 CiAgICAgc2l6ZV90IG9iamVjdENvdW50KCk7CiAgICAgc2l6ZV90IHNpemUoKTsKICAgICBzaXpl X3QgY2FwYWNpdHkoKTsK