132334 2014-04-29 05:48:33 -0700 Merge same ifdef blocks into each other 2014-04-30 02:33:21 -0700 1 1 1 Unclassified WebKit WebCore Misc. 528+ (Nightly build) Unspecified Unspecified RESOLVED INVALID P2 Normal --- 1 zsborbely.u-szeged webkit-unassigned oldest_to_newest 1004913 0 zsborbely.u-szeged 2014-04-29 05:48:33 -0700 Merge same ifdef blocks into each other. 1004914 1 230368 zsborbely.u-szeged 2014-04-29 05:51:27 -0700 Created attachment 230368 Proposed patch 1004973 2 230368 darin 2014-04-29 09:16:45 -0700 Comment on attachment 230368 Proposed patch I don’t think this is a good idea. It’s better to have a separate #if for the includes and for things inside this file. 230368 2014-04-29 05:51:27 -0700 2014-04-29 09:16:44 -0700 Proposed patch ifdef.patch text/plain 2506 zsborbely.u-szeged ZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJDb3JlL0NoYW5nZUxvZyBiL1NvdXJjZS9XZWJDb3JlL0No YW5nZUxvZwppbmRleCBlMDViMmUwLi5hZTUyMjg0IDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViQ29y ZS9DaGFuZ2VMb2cKKysrIGIvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMTQg QEAKKzIwMTQtMDQtMjkgIFpzb2x0IEJvcmJlbHkgIDx6c2JvcmJlbHkudS1zemVnZWRAcGFydG5l ci5zYW1zdW5nLmNvbT4KKworICAgICAgICBNZXJnZSBzYW1lIGlmZGVmIGJsb2NrcyBpbnRvIGVh Y2ggb3RoZXIKKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lk PTEzMjMzNAorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAg ICogeG1sL1hTTFN0eWxlU2hlZXRMaWJ4c2x0LmNwcDoKKyAgICAgICAgKiB4bWwvWFNMVEV4dGVu c2lvbnMuY3BwOgorICAgICAgICAqIHhtbC9YU0xUVW5pY29kZVNvcnQuY3BwOgorCiAyMDE0LTA0 LTI4ICBCZW5qYW1pbiBQb3VsYWluICA8YmVuamFtaW5Ad2Via2l0Lm9yZz4KIAogICAgICAgICBT ZWxlY3RvckNvZGVHZW5lcmF0b3I6OmdlbmVyYXRlRWxlbWVudElzTnRoQ2hpbGQoKSBsZWFrcyB0 aGUgcGFyZW50IHJlZ2lzdGVyIDpudGgtY2hpbGQoKSBpcyBub24tZmlsdGVyaW5nCmRpZmYgLS1n aXQgYS9Tb3VyY2UvV2ViQ29yZS94bWwvWFNMU3R5bGVTaGVldExpYnhzbHQuY3BwIGIvU291cmNl L1dlYkNvcmUveG1sL1hTTFN0eWxlU2hlZXRMaWJ4c2x0LmNwcAppbmRleCA3YTE3ZmJkLi45NDFh ZTdkIDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViQ29yZS94bWwvWFNMU3R5bGVTaGVldExpYnhzbHQu Y3BwCisrKyBiL1NvdXJjZS9XZWJDb3JlL3htbC9YU0xTdHlsZVNoZWV0TGlieHNsdC5jcHAKQEAg LTM4LDkgKzM4LDcgQEAKIAogI2lmIE9TKERBUldJTikgJiYgIVBMQVRGT1JNKEVGTCkgJiYgIVBM QVRGT1JNKEdUSykKICNpbmNsdWRlICJTb2Z0TGlua2luZy5oIgotI2VuZGlmCiAKLSNpZiBPUyhE QVJXSU4pICYmICFQTEFURk9STShFRkwpICYmICFQTEFURk9STShHVEspCiBTT0ZUX0xJTktfTElC UkFSWShsaWJ4c2x0KQogU09GVF9MSU5LKGxpYnhzbHQsIHhzbHRJc0JsYW5rLCBpbnQsICh4bWxD aGFyICpzdHIpLCAoc3RyKSkKIFNPRlRfTElOSyhsaWJ4c2x0LCB4c2x0R2V0TnNQcm9wLCB4bWxD aGFyICosICh4bWxOb2RlUHRyIG5vZGUsIGNvbnN0IHhtbENoYXIgKm5hbWUsIGNvbnN0IHhtbENo YXIgKm5hbWVTcGFjZSksIChub2RlLCBuYW1lLCBuYW1lU3BhY2UpKQpkaWZmIC0tZ2l0IGEvU291 cmNlL1dlYkNvcmUveG1sL1hTTFRFeHRlbnNpb25zLmNwcCBiL1NvdXJjZS9XZWJDb3JlL3htbC9Y U0xURXh0ZW5zaW9ucy5jcHAKaW5kZXggNzE5Yjk1OS4uOThkZDBjYiAxMDA2NDQKLS0tIGEvU291 cmNlL1dlYkNvcmUveG1sL1hTTFRFeHRlbnNpb25zLmNwcAorKysgYi9Tb3VyY2UvV2ViQ29yZS94 bWwvWFNMVEV4dGVuc2lvbnMuY3BwCkBAIC0zNyw5ICszNyw3IEBACiAKICNpZiBPUyhEQVJXSU4p ICYmICFQTEFURk9STShFRkwpICYmICFQTEFURk9STShHVEspCiAjaW5jbHVkZSAiU29mdExpbmtp bmcuaCIKLSNlbmRpZgogCi0jaWYgT1MoREFSV0lOKSAmJiAhUExBVEZPUk0oRUZMKSAmJiAhUExB VEZPUk0oR1RLKQogU09GVF9MSU5LX0xJQlJBUlkobGlieHNsdCkKIFNPRlRfTElOSyhsaWJ4c2x0 LCB4c2x0UmVnaXN0ZXJFeHRGdW5jdGlvbiwgaW50LCAoeHNsdFRyYW5zZm9ybUNvbnRleHRQdHIg Y3R4dCwgY29uc3QgeG1sQ2hhciAqbmFtZSwgY29uc3QgeG1sQ2hhciAqVVJJLCB4bWxYUGF0aEZ1 bmN0aW9uIGZ1bmN0aW9uKSwgKGN0eHQsIG5hbWUsIFVSSSwgZnVuY3Rpb24pKQogU09GVF9MSU5L KGxpYnhzbHQsIHhzbHRGdW5jdGlvbk5vZGVTZXQsIHZvaWQsICh4bWxYUGF0aFBhcnNlckNvbnRl eHRQdHIgY3R4dCwgaW50IG5hcmdzKSwgKGN0eHQsIG5hcmdzKSkKZGlmZiAtLWdpdCBhL1NvdXJj ZS9XZWJDb3JlL3htbC9YU0xUVW5pY29kZVNvcnQuY3BwIGIvU291cmNlL1dlYkNvcmUveG1sL1hT TFRVbmljb2RlU29ydC5jcHAKaW5kZXggZDZmMTYzZC4uMTY3ZjY0NiAxMDA2NDQKLS0tIGEvU291 cmNlL1dlYkNvcmUveG1sL1hTTFRVbmljb2RlU29ydC5jcHAKKysrIGIvU291cmNlL1dlYkNvcmUv eG1sL1hTTFRVbmljb2RlU29ydC5jcHAKQEAgLTM3LDkgKzM3LDYgQEAKIAogI2lmIE9TKERBUldJ TikgJiYgIVBMQVRGT1JNKEVGTCkgJiYgIVBMQVRGT1JNKEdUSykKICNpbmNsdWRlICJTb2Z0TGlu a2luZy5oIgotI2VuZGlmCi0KLSNpZiBPUyhEQVJXSU4pICYmICFQTEFURk9STShFRkwpICYmICFQ TEFURk9STShHVEspCiAKIFNPRlRfTElOS19MSUJSQVJZKGxpYnhzbHQpCiBTT0ZUX0xJTksobGli eHNsdCwgeHNsdENvbXB1dGVTb3J0UmVzdWx0LCB4bWxYUGF0aE9iamVjdFB0ciosICh4c2x0VHJh bnNmb3JtQ29udGV4dFB0ciBjdHh0LCB4bWxOb2RlUHRyIHNvcnQpLCAoY3R4dCwgc29ydCkpCg==