132331 2014-04-29 04:32:44 -0700 Build warning in source/JavaScriptCore/dfg/DFGFixupPhase.cpp 2014-05-09 11:21:11 -0700 1 1 1 Unclassified WebKit JavaScriptCore 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 1 tanay.c webkit-unassigned commit-queue fpizlo ggaren tanay.c oldest_to_newest 1004902 0 tanay.c 2014-04-29 04:32:44 -0700 In file included from /home/tanay.c/webkit/Source/JavaScriptCore/dfg/DFGAdjacencyList.h:32:0, from /home/tanay.c/webkit/Source/JavaScriptCore/dfg/DFGNode.h:33, from /home/tanay.c/webkit/Source/JavaScriptCore/dfg/DFGBasicBlock.h:35, from /home/tanay.c/webkit/Source/JavaScriptCore/dfg/DFGGraph.h:34, from /home/tanay.c/webkit/Source/JavaScriptCore/dfg/DFGFixupPhase.cpp:31: /home/tanay.c/webkit/Source/JavaScriptCore/dfg/DFGEdge.h: In member function ‘void JSC::DFG::FixupPhase::injectTypeConversionsForEdge(JSC::DFG::Node*, JSC::DFG::Edge&)’: /home/tanay.c/webkit/Source/JavaScriptCore/dfg/DFGEdge.h:64:22: warning: ‘result’ may be used uninitialized in this function [-Wmaybe-uninitialized] /home/tanay.c/webkit/Source/JavaScriptCore/dfg/DFGFixupPhase.cpp:1898:19: note: ‘result’ was declared here In file included from /home/tanay.c/webkit/Source/JavaScriptCore/dfg/DFGAdjacencyList.h:32:0, from /home/tanay.c/webkit/Source/JavaScriptCore/dfg/DFGNode.h:33, from /home/tanay.c/webkit/Source/JavaScriptCore/dfg/DFGBasicBlock.h:35, from /home/tanay.c/webkit/Source/JavaScriptCore/dfg/DFGGraph.h:34, from /home/tanay.c/webkit/Source/JavaScriptCore/dfg/DFGFixupPhase.cpp:31: /home/tanay.c/webkit/Source/JavaScriptCore/dfg/DFGEdge.h: In member function ‘void JSC::DFG::FixupPhase::injectTypeConversionsInBlock(JSC::DFG::BasicBlock*)’: /home/tanay.c/webkit/Source/JavaScriptCore/dfg/DFGEdge.h:64:22: warning: ‘result’ may be used uninitialized in this function [-Wmaybe-uninitialized] /home/tanay.c/webkit/Source/JavaScriptCore/dfg/DFGFixupPhase.cpp:1898:19: note: ‘result’ was declared here In file included from /home/tanay.c/webkit/Source/JavaScriptCore/dfg/DFGAdjacencyList.h:32:0, from /home/tanay.c/webkit/Source/JavaScriptCore/dfg/DFGNode.h:33, from /home/tanay.c/webkit/Source/JavaScriptCore/dfg/DFGBasicBlock.h:35, from /home/tanay.c/webkit/Source/JavaScriptCore/dfg/DFGGraph.h:34, from /home/tanay.c/webkit/Source/JavaScriptCore/dfg/DFGFixupPhase.cpp:31: /home/tanay.c/webkit/Source/JavaScriptCore/dfg/DFGEdge.h:64:22: warning: ‘result’ may be used uninitialized in this function [-Wmaybe-uninitialized] 1006870 1 230889 tanay.c 2014-05-05 23:02:01 -0700 Created attachment 230889 Patch for build warning fix Patch to Fix build warning and coding style warning in DFGFixupPhase.cpp 1006879 2 230889 fpizlo 2014-05-05 23:21:45 -0700 Comment on attachment 230889 Patch for build warning fix Looks like you need to rebase. 1006915 3 tanay.c 2014-05-06 04:50:56 -0700 (In reply to comment #2) > (From update of attachment 230889 [details]) > Looks like you need to rebase. Rebased to r168352. Can still see the warning. Could you please let me know if I am missing some information? 1006943 4 fpizlo 2014-05-06 06:54:01 -0700 (In reply to comment #3) > (In reply to comment #2) > > (From update of attachment 230889 [details] [details]) > > Looks like you need to rebase. > > Rebased to r168352. Can still see the warning. Could you please let me know if I am missing some information? What I mean is, can you upload a debased patch? 1007300 5 230990 tanay.c 2014-05-07 05:06:17 -0700 Created attachment 230990 Patch 1007322 6 230990 fpizlo 2014-05-07 07:33:27 -0700 Comment on attachment 230990 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=230990&action=review > Source/JavaScriptCore/ChangeLog:93 > +>>>>>>> .r168416 You should remove the conflict markets. 1007528 7 231046 tanay.c 2014-05-07 22:06:45 -0700 Created attachment 231046 Patch 1007721 8 231046 darin 2014-05-08 12:33:07 -0700 Comment on attachment 231046 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=231046&action=review > Source/JavaScriptCore/dfg/DFGFixupPhase.cpp:1868 > + Node* result = 0; Please use nullptr instead of 0. 1007892 9 231130 tanay.c 2014-05-08 22:24:10 -0700 Created attachment 231130 Patch 1008039 10 231130 commit-queue 2014-05-09 11:21:08 -0700 Comment on attachment 231130 Patch Clearing flags on attachment: 231130 Committed r168540: <http://trac.webkit.org/changeset/168540> 1008040 11 commit-queue 2014-05-09 11:21:11 -0700 All reviewed patches have been landed. Closing bug. 230889 2014-05-05 23:02:01 -0700 2014-05-07 05:06:05 -0700 Patch for build warning fix patch.txt text/plain 1989 tanay.c SW5kZXg6IENoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBDaGFuZ2VMb2cJKHJldmlzaW9uIDE2ODM0 OCkKKysrIENoYW5nZUxvZwkod29ya2luZyBjb3B5KQpAQCAtMSwzICsxLDEzIEBACisyMDE0LTA1 LTA1ICBUYW5heSBDICA8dGFuYXkuY0BzYW1zdW5nLmNvbT4KKworICAgICAgICBGaXggYnVpbGQg d2FybmluZyAodW5pbml0aWFsaXplZCB2YXJpYWJsZSBhbmQgZXh0cmEgbGluZSBhdCBFT0YpIGlu IERGR0ZpeHVwUGhhc2UuY3BwIAorICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93 X2J1Zy5jZ2k/aWQ9MTMyMzMxCisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISku CisKKyAgICAgICAgKiBkZmcvREZHRml4dXBQaGFzZS5jcHA6CisgICAgICAgIChKU0M6OkRGRzo6 Rml4dXBQaGFzZTo6aW5qZWN0VHlwZUNvbnZlcnNpb25zRm9yRWRnZSk6CisKIDIwMTQtMDUtMDUg IEFuZHJlYXMgS2xpbmcgIDxha2xpbmdAYXBwbGUuY29tPgogCiAgICAgICAgIEZpeCBkZWJ1ZyBi dWlsZC4KSW5kZXg6IGRmZy9ERkdGaXh1cFBoYXNlLmNwcAo9PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBkZmcvREZH Rml4dXBQaGFzZS5jcHAJKHJldmlzaW9uIDE2NzU4NykKKysrIGRmZy9ERkdGaXh1cFBoYXNlLmNw cAkod29ya2luZyBjb3B5KQpAQCAtMTg2NSw3ICsxODY1LDcgQEAKICAgICB2b2lkIGluamVjdFR5 cGVDb252ZXJzaW9uc0ZvckVkZ2UoTm9kZSogbm9kZSwgRWRnZSYgZWRnZSkKICAgICB7CiAgICAg ICAgIEFTU0VSVChub2RlID09IG1fY3VycmVudE5vZGUpOwotICAgICAgICAKKyAgICAgICAgTm9k ZSogcmVzdWx0ID0gMDsKICAgICAgICAgc3dpdGNoIChlZGdlLnVzZUtpbmQoKSkgewogICAgICAg ICBjYXNlIERvdWJsZVJlcFVzZToKICAgICAgICAgY2FzZSBEb3VibGVSZXBSZWFsVXNlOiB7CkBA IC0xODc0LDcgKzE4NzQsNiBAQAogICAgICAgICAgICAgCiAgICAgICAgICAgICBhZGRSZXF1aXJl ZFBoYW50b20oZWRnZS5ub2RlKCkpOwogCi0gICAgICAgICAgICBOb2RlKiByZXN1bHQ7CiAgICAg ICAgICAgICBpZiAoZWRnZS0+aGFzSW50NTJSZXN1bHQoKSkgewogICAgICAgICAgICAgICAgIHJl c3VsdCA9IG1faW5zZXJ0aW9uU2V0Lmluc2VydE5vZGUoCiAgICAgICAgICAgICAgICAgICAgIG1f aW5kZXhJbkJsb2NrLCBTcGVjSW50NTJBc0RvdWJsZSwgRG91YmxlUmVwLCBub2RlLT5vcmlnaW4s CkBAIC0xODk1LDcgKzE4OTQsNiBAQAogICAgICAgICAgICAgCiAgICAgICAgICAgICBhZGRSZXF1 aXJlZFBoYW50b20oZWRnZS5ub2RlKCkpOwogCi0gICAgICAgICAgICBOb2RlKiByZXN1bHQ7CiAg ICAgICAgICAgICBpZiAoZWRnZS0+aGFzRG91YmxlUmVzdWx0KCkpIHsKICAgICAgICAgICAgICAg ICAvLyBUaGlzIHdpbGwgbmV2ZXIgaGFwcGVuLgogICAgICAgICAgICAgICAgIGRhdGFMb2coIkZv dW5kIGFuIEludDUyUmVwVXNlIHRvIGEgZG91YmxlIHJlc3VsdDogIiwgbm9kZSwgIiAtPiAiLCBl ZGdlLCAiXG4iKTsKQEAgLTE5MjcsNyArMTkyNSw2IEBACiAgICAgICAgICAgICAKICAgICAgICAg ICAgIGFkZFJlcXVpcmVkUGhhbnRvbShlZGdlLm5vZGUoKSk7CiAgICAgICAgICAgICAKLSAgICAg ICAgICAgIE5vZGUqIHJlc3VsdDsKICAgICAgICAgICAgIGlmIChlZGdlLT5oYXNEb3VibGVSZXN1 bHQoKSkgewogICAgICAgICAgICAgICAgIHJlc3VsdCA9IG1faW5zZXJ0aW9uU2V0Lmluc2VydE5v ZGUoCiAgICAgICAgICAgICAgICAgICAgIG1faW5kZXhJbkJsb2NrLCBTcGVjQnl0ZWNvZGVEb3Vi bGUsIFZhbHVlUmVwLCBub2RlLT5vcmlnaW4sCkBAIC0xOTk1LDQgKzE5OTIsMyBAQAogfSB9IC8v IG5hbWVzcGFjZSBKU0M6OkRGRwogCiAjZW5kaWYgLy8gRU5BQkxFKERGR19KSVQpCi0K 230990 2014-05-07 05:06:17 -0700 2014-05-07 22:06:36 -0700 Patch bug-132331-20140507173653.patch text/plain 2260 tanay.c SW5kZXg6IFNvdXJjZS9KYXZhU2NyaXB0Q29yZS9DaGFuZ2VMb2cKPT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PQotLS0gU291 cmNlL0phdmFTY3JpcHRDb3JlL0NoYW5nZUxvZwkocmV2aXNpb24gMTY4NDIzKQorKysgU291cmNl L0phdmFTY3JpcHRDb3JlL0NoYW5nZUxvZwkod29ya2luZyBjb3B5KQpAQCAtMSwzICsxLDEzIEBA CisyMDE0LTA1LTA3ICBUYW5heSBDICA8dGFuYXkuY0BzYW1zdW5nLmNvbT4KKworICAgICAgICBG aXggYnVpbGQgd2FybmluZyAodW5pbml0aWFsaXplZCB2YXJpYWJsZSBhbmQgZXh0cmEgbGluZSBh dCBFT0YpIGluIERGR0ZpeHVwUGhhc2UuY3BwIAorICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0 Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MTMyMzMxCisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZ IChPT1BTISkuCisKKyAgICAgICAgKiBkZmcvREZHRml4dXBQaGFzZS5jcHA6CisgICAgICAgIChK U0M6OkRGRzo6Rml4dXBQaGFzZTo6aW5qZWN0VHlwZUNvbnZlcnNpb25zRm9yRWRnZSk6CisKIDIw MTQtMDUtMDYgIE1pY2hhZWwgU2Fib2ZmICA8bXNhYm9mZkBhcHBsZS5jb20+CiAKICAgICAgICAg VW5yZXZpZXdkIGJ1aWxkIGZpeCBmb3IgQy1MT09QIGFmdGVyIHIxNjgzOTYuCkBAIC04MCw2ICs5 MCw3IEBACiAgICAgICAgICogdGVzdHMvc3RyZXNzL2Zvci1pbi1hZnRlci1kZWxldGUuanM6CiAg ICAgICAgIChmb28pOiBEZWxldGVkLgogCis+Pj4+Pj4+IC5yMTY4NDE2CiAyMDE0LTA1LTA1ICBB bmRyZWFzIEtsaW5nICA8YWtsaW5nQGFwcGxlLmNvbT4KIAogICAgICAgICBGaXggZGVidWcgYnVp bGQuCkluZGV4OiBTb3VyY2UvSmF2YVNjcmlwdENvcmUvZGZnL0RGR0ZpeHVwUGhhc2UuY3BwCj09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT0KLS0tIFNvdXJjZS9KYXZhU2NyaXB0Q29yZS9kZmcvREZHRml4dXBQaGFzZS5jcHAJ KHJldmlzaW9uIDE2ODQyMykKKysrIFNvdXJjZS9KYXZhU2NyaXB0Q29yZS9kZmcvREZHRml4dXBQ aGFzZS5jcHAJKHdvcmtpbmcgY29weSkKQEAgLTE4NjUsNiArMTg2NSw3IEBAIHByaXZhdGU6CiAg ICAgdm9pZCBpbmplY3RUeXBlQ29udmVyc2lvbnNGb3JFZGdlKE5vZGUqIG5vZGUsIEVkZ2UmIGVk Z2UpCiAgICAgewogICAgICAgICBBU1NFUlQobm9kZSA9PSBtX2N1cnJlbnROb2RlKTsKKyAgICAg ICAgTm9kZSogcmVzdWx0ID0gMDsKICAgICAgICAgCiAgICAgICAgIHN3aXRjaCAoZWRnZS51c2VL aW5kKCkpIHsKICAgICAgICAgY2FzZSBEb3VibGVSZXBVc2U6CkBAIC0xODc0LDcgKzE4NzUsNiBA QCBwcml2YXRlOgogICAgICAgICAgICAgCiAgICAgICAgICAgICBhZGRSZXF1aXJlZFBoYW50b20o ZWRnZS5ub2RlKCkpOwogCi0gICAgICAgICAgICBOb2RlKiByZXN1bHQ7CiAgICAgICAgICAgICBp ZiAoZWRnZS0+aGFzSW50NTJSZXN1bHQoKSkgewogICAgICAgICAgICAgICAgIHJlc3VsdCA9IG1f aW5zZXJ0aW9uU2V0Lmluc2VydE5vZGUoCiAgICAgICAgICAgICAgICAgICAgIG1faW5kZXhJbkJs b2NrLCBTcGVjSW50NTJBc0RvdWJsZSwgRG91YmxlUmVwLCBub2RlLT5vcmlnaW4sCkBAIC0xODk1 LDcgKzE4OTUsNiBAQCBwcml2YXRlOgogICAgICAgICAgICAgCiAgICAgICAgICAgICBhZGRSZXF1 aXJlZFBoYW50b20oZWRnZS5ub2RlKCkpOwogCi0gICAgICAgICAgICBOb2RlKiByZXN1bHQ7CiAg ICAgICAgICAgICBpZiAoZWRnZS0+aGFzRG91YmxlUmVzdWx0KCkpIHsKICAgICAgICAgICAgICAg ICAvLyBUaGlzIHdpbGwgbmV2ZXIgaGFwcGVuLgogICAgICAgICAgICAgICAgIGRhdGFMb2coIkZv dW5kIGFuIEludDUyUmVwVXNlIHRvIGEgZG91YmxlIHJlc3VsdDogIiwgbm9kZSwgIiAtPiAiLCBl ZGdlLCAiXG4iKTsKQEAgLTE5MjcsNyArMTkyNiw2IEBAIHByaXZhdGU6CiAgICAgICAgICAgICAK ICAgICAgICAgICAgIGFkZFJlcXVpcmVkUGhhbnRvbShlZGdlLm5vZGUoKSk7CiAgICAgICAgICAg ICAKLSAgICAgICAgICAgIE5vZGUqIHJlc3VsdDsKICAgICAgICAgICAgIGlmIChlZGdlLT5oYXNE b3VibGVSZXN1bHQoKSkgewogICAgICAgICAgICAgICAgIHJlc3VsdCA9IG1faW5zZXJ0aW9uU2V0 Lmluc2VydE5vZGUoCiAgICAgICAgICAgICAgICAgICAgIG1faW5kZXhJbkJsb2NrLCBTcGVjQnl0 ZWNvZGVEb3VibGUsIFZhbHVlUmVwLCBub2RlLT5vcmlnaW4sCg== 231046 2014-05-07 22:06:45 -0700 2014-05-08 22:24:00 -0700 Patch bug-132331-20140508103722.patch text/plain 2074 tanay.c SW5kZXg6IFNvdXJjZS9KYXZhU2NyaXB0Q29yZS9DaGFuZ2VMb2cKPT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PQotLS0gU291 cmNlL0phdmFTY3JpcHRDb3JlL0NoYW5nZUxvZwkocmV2aXNpb24gMTY4NDIzKQorKysgU291cmNl L0phdmFTY3JpcHRDb3JlL0NoYW5nZUxvZwkod29ya2luZyBjb3B5KQpAQCAtMSwzICsxLDEzIEBA CisyMDE0LTA1LTA3ICBUYW5heSBDICA8dGFuYXkuY0BzYW1zdW5nLmNvbT4KKworICAgICAgICBG aXggYnVpbGQgd2FybmluZyAodW5pbml0aWFsaXplZCB2YXJpYWJsZSBhbmQgZXh0cmEgbGluZSBh dCBFT0YpIGluIERGR0ZpeHVwUGhhc2UuY3BwIAorICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0 Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MTMyMzMxCisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZ IChPT1BTISkuCisKKyAgICAgICAgKiBkZmcvREZHRml4dXBQaGFzZS5jcHA6CisgICAgICAgIChK U0M6OkRGRzo6Rml4dXBQaGFzZTo6aW5qZWN0VHlwZUNvbnZlcnNpb25zRm9yRWRnZSk6CisKIDIw MTQtMDUtMDYgIE1pY2hhZWwgU2Fib2ZmICA8bXNhYm9mZkBhcHBsZS5jb20+CiAKICAgICAgICAg VW5yZXZpZXdkIGJ1aWxkIGZpeCBmb3IgQy1MT09QIGFmdGVyIHIxNjgzOTYuCkluZGV4OiBTb3Vy Y2UvSmF2YVNjcmlwdENvcmUvZGZnL0RGR0ZpeHVwUGhhc2UuY3BwCj09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIFNv dXJjZS9KYXZhU2NyaXB0Q29yZS9kZmcvREZHRml4dXBQaGFzZS5jcHAJKHJldmlzaW9uIDE2ODQy MykKKysrIFNvdXJjZS9KYXZhU2NyaXB0Q29yZS9kZmcvREZHRml4dXBQaGFzZS5jcHAJKHdvcmtp bmcgY29weSkKQEAgLTE4NjUsNiArMTg2NSw3IEBAIHByaXZhdGU6CiAgICAgdm9pZCBpbmplY3RU eXBlQ29udmVyc2lvbnNGb3JFZGdlKE5vZGUqIG5vZGUsIEVkZ2UmIGVkZ2UpCiAgICAgewogICAg ICAgICBBU1NFUlQobm9kZSA9PSBtX2N1cnJlbnROb2RlKTsKKyAgICAgICAgTm9kZSogcmVzdWx0 ID0gMDsKICAgICAgICAgCiAgICAgICAgIHN3aXRjaCAoZWRnZS51c2VLaW5kKCkpIHsKICAgICAg ICAgY2FzZSBEb3VibGVSZXBVc2U6CkBAIC0xODc0LDcgKzE4NzUsNiBAQCBwcml2YXRlOgogICAg ICAgICAgICAgCiAgICAgICAgICAgICBhZGRSZXF1aXJlZFBoYW50b20oZWRnZS5ub2RlKCkpOwog Ci0gICAgICAgICAgICBOb2RlKiByZXN1bHQ7CiAgICAgICAgICAgICBpZiAoZWRnZS0+aGFzSW50 NTJSZXN1bHQoKSkgewogICAgICAgICAgICAgICAgIHJlc3VsdCA9IG1faW5zZXJ0aW9uU2V0Lmlu c2VydE5vZGUoCiAgICAgICAgICAgICAgICAgICAgIG1faW5kZXhJbkJsb2NrLCBTcGVjSW50NTJB c0RvdWJsZSwgRG91YmxlUmVwLCBub2RlLT5vcmlnaW4sCkBAIC0xODk1LDcgKzE4OTUsNiBAQCBw cml2YXRlOgogICAgICAgICAgICAgCiAgICAgICAgICAgICBhZGRSZXF1aXJlZFBoYW50b20oZWRn ZS5ub2RlKCkpOwogCi0gICAgICAgICAgICBOb2RlKiByZXN1bHQ7CiAgICAgICAgICAgICBpZiAo ZWRnZS0+aGFzRG91YmxlUmVzdWx0KCkpIHsKICAgICAgICAgICAgICAgICAvLyBUaGlzIHdpbGwg bmV2ZXIgaGFwcGVuLgogICAgICAgICAgICAgICAgIGRhdGFMb2coIkZvdW5kIGFuIEludDUyUmVw VXNlIHRvIGEgZG91YmxlIHJlc3VsdDogIiwgbm9kZSwgIiAtPiAiLCBlZGdlLCAiXG4iKTsKQEAg LTE5MjcsNyArMTkyNiw2IEBAIHByaXZhdGU6CiAgICAgICAgICAgICAKICAgICAgICAgICAgIGFk ZFJlcXVpcmVkUGhhbnRvbShlZGdlLm5vZGUoKSk7CiAgICAgICAgICAgICAKLSAgICAgICAgICAg IE5vZGUqIHJlc3VsdDsKICAgICAgICAgICAgIGlmIChlZGdlLT5oYXNEb3VibGVSZXN1bHQoKSkg ewogICAgICAgICAgICAgICAgIHJlc3VsdCA9IG1faW5zZXJ0aW9uU2V0Lmluc2VydE5vZGUoCiAg ICAgICAgICAgICAgICAgICAgIG1faW5kZXhJbkJsb2NrLCBTcGVjQnl0ZWNvZGVEb3VibGUsIFZh bHVlUmVwLCBub2RlLT5vcmlnaW4sCg== 231130 2014-05-08 22:24:10 -0700 2014-05-09 11:21:07 -0700 Patch bug-132331-20140509105446.patch text/plain 2058 tanay.c SW5kZXg6IFNvdXJjZS9KYXZhU2NyaXB0Q29yZS9DaGFuZ2VMb2cKPT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PQotLS0gU291 cmNlL0phdmFTY3JpcHRDb3JlL0NoYW5nZUxvZwkocmV2aXNpb24gMTY4NDIzKQorKysgU291cmNl L0phdmFTY3JpcHRDb3JlL0NoYW5nZUxvZwkod29ya2luZyBjb3B5KQpAQCAtMSwzICsxLDEzIEBA CisyMDE0LTA1LTA3ICBUYW5heSBDICA8dGFuYXkuY0BzYW1zdW5nLmNvbT4KKworICAgICAgICBG aXggYnVpbGQgd2FybmluZyAodW5pbml0aWFsaXplZCB2YXJpYWJsZSkgaW4gREZHRml4dXBQaGFz ZS5jcHAgCisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0x MzIzMzEKKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICAq IGRmZy9ERkdGaXh1cFBoYXNlLmNwcDoKKyAgICAgICAgKEpTQzo6REZHOjpGaXh1cFBoYXNlOjpp bmplY3RUeXBlQ29udmVyc2lvbnNGb3JFZGdlKToKKwogMjAxNC0wNS0wNiAgTWljaGFlbCBTYWJv ZmYgIDxtc2Fib2ZmQGFwcGxlLmNvbT4KIAogICAgICAgICBVbnJldmlld2QgYnVpbGQgZml4IGZv ciBDLUxPT1AgYWZ0ZXIgcjE2ODM5Ni4KSW5kZXg6IFNvdXJjZS9KYXZhU2NyaXB0Q29yZS9kZmcv REZHRml4dXBQaGFzZS5jcHAKPT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PQotLS0gU291cmNlL0phdmFTY3JpcHRDb3JlL2Rm Zy9ERkdGaXh1cFBoYXNlLmNwcAkocmV2aXNpb24gMTY4NDIzKQorKysgU291cmNlL0phdmFTY3Jp cHRDb3JlL2RmZy9ERkdGaXh1cFBoYXNlLmNwcAkod29ya2luZyBjb3B5KQpAQCAtMTg2NSw2ICsx ODY1LDcgQEAgcHJpdmF0ZToKICAgICB2b2lkIGluamVjdFR5cGVDb252ZXJzaW9uc0ZvckVkZ2Uo Tm9kZSogbm9kZSwgRWRnZSYgZWRnZSkKICAgICB7CiAgICAgICAgIEFTU0VSVChub2RlID09IG1f Y3VycmVudE5vZGUpOworICAgICAgICBOb2RlKiByZXN1bHQgPSBudWxscHRyOwogICAgICAgICAK ICAgICAgICAgc3dpdGNoIChlZGdlLnVzZUtpbmQoKSkgewogICAgICAgICBjYXNlIERvdWJsZVJl cFVzZToKQEAgLTE4NzQsNyArMTg3NSw2IEBAIHByaXZhdGU6CiAgICAgICAgICAgICAKICAgICAg ICAgICAgIGFkZFJlcXVpcmVkUGhhbnRvbShlZGdlLm5vZGUoKSk7CiAKLSAgICAgICAgICAgIE5v ZGUqIHJlc3VsdDsKICAgICAgICAgICAgIGlmIChlZGdlLT5oYXNJbnQ1MlJlc3VsdCgpKSB7CiAg ICAgICAgICAgICAgICAgcmVzdWx0ID0gbV9pbnNlcnRpb25TZXQuaW5zZXJ0Tm9kZSgKICAgICAg ICAgICAgICAgICAgICAgbV9pbmRleEluQmxvY2ssIFNwZWNJbnQ1MkFzRG91YmxlLCBEb3VibGVS ZXAsIG5vZGUtPm9yaWdpbiwKQEAgLTE4OTUsNyArMTg5NSw2IEBAIHByaXZhdGU6CiAgICAgICAg ICAgICAKICAgICAgICAgICAgIGFkZFJlcXVpcmVkUGhhbnRvbShlZGdlLm5vZGUoKSk7CiAKLSAg ICAgICAgICAgIE5vZGUqIHJlc3VsdDsKICAgICAgICAgICAgIGlmIChlZGdlLT5oYXNEb3VibGVS ZXN1bHQoKSkgewogICAgICAgICAgICAgICAgIC8vIFRoaXMgd2lsbCBuZXZlciBoYXBwZW4uCiAg ICAgICAgICAgICAgICAgZGF0YUxvZygiRm91bmQgYW4gSW50NTJSZXBVc2UgdG8gYSBkb3VibGUg cmVzdWx0OiAiLCBub2RlLCAiIC0+ICIsIGVkZ2UsICJcbiIpOwpAQCAtMTkyNyw3ICsxOTI2LDYg QEAgcHJpdmF0ZToKICAgICAgICAgICAgIAogICAgICAgICAgICAgYWRkUmVxdWlyZWRQaGFudG9t KGVkZ2Uubm9kZSgpKTsKICAgICAgICAgICAgIAotICAgICAgICAgICAgTm9kZSogcmVzdWx0Owog ICAgICAgICAgICAgaWYgKGVkZ2UtPmhhc0RvdWJsZVJlc3VsdCgpKSB7CiAgICAgICAgICAgICAg ICAgcmVzdWx0ID0gbV9pbnNlcnRpb25TZXQuaW5zZXJ0Tm9kZSgKICAgICAgICAgICAgICAgICAg ICAgbV9pbmRleEluQmxvY2ssIFNwZWNCeXRlY29kZURvdWJsZSwgVmFsdWVSZXAsIG5vZGUtPm9y aWdpbiwK