132330 2014-04-29 04:30:02 -0700 LLINT loadisFromInstruction doesn't need special case for big endians 2014-04-29 07:06:40 -0700 1 1 1 Unclassified WebKit JavaScriptCore 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 128743 132333 1 tpopela webkit-unassigned commit-queue mark.lam oldest_to_newest 1004901 0 tpopela 2014-04-29 04:30:02 -0700 The change introduced in r167076 was wrong. We cannot apply the offset adjustment on every loadisFromInstruction usage as the instruction (UnlinkedInstruction) is declared as an union (i.e. with the int32_t operand variable). The offset of the union members will be the same as the offset of the first one, that is 0. The behavior here is the same on little and big endian architectures us we don't need special case for big endians. 1004903 1 230365 tpopela 2014-04-29 04:33:42 -0700 Created attachment 230365 Proposed patch 1004921 2 230365 mark.lam 2014-04-29 06:10:08 -0700 Comment on attachment 230365 Proposed patch View in context: https://bugs.webkit.org/attachment.cgi?id=230365&action=review Thanks for fixing this. If you update the ChangeLog comment, we should be good to go. > Source/JavaScriptCore/ChangeLog:9 > + The change introduced in r167076 was wrong. We cannot apply the offset > + adjustment on every loadisFromInstruction usage as the instruction Please change “cannot” to “should not” and remove “every”. As it read previously, it implied that there are some cases where the offset should be applied, which is not true. It is always wrong to applied that offset. > Source/JavaScriptCore/ChangeLog:11 > + operand variable). The offset of the union members will be the Please change “union” to “other union”. > Source/JavaScriptCore/ChangeLog:13 > + same on little and big endian architectures thus we don't need Missing period between “architectures. Thus”. 1004926 3 230373 tpopela 2014-04-29 06:28:43 -0700 Created attachment 230373 Proposed patch v2 Fixes after Mark's review 1004927 4 230373 mark.lam 2014-04-29 06:29:53 -0700 Comment on attachment 230373 Proposed patch v2 r=me 1004928 5 230373 commit-queue 2014-04-29 07:06:37 -0700 Comment on attachment 230373 Proposed patch v2 Clearing flags on attachment: 230373 Committed r167929: <http://trac.webkit.org/changeset/167929> 1004929 6 commit-queue 2014-04-29 07:06:40 -0700 All reviewed patches have been landed. Closing bug. 230365 2014-04-29 04:33:42 -0700 2014-04-29 06:28:43 -0700 Proposed patch webkit-132330.patch text/plain 2734 tpopela RnJvbSA5ZTgzNjczOGQ3NGRmNDYzMTEwODg1ODMyOGE5MzJjMTcyMDgwN2EwIE1vbiBTZXAgMTcg MDA6MDA6MDAgMjAwMQpGcm9tOiBUb21hcyBQb3BlbGEgPHRwb3BlbGFAcmVkaGF0LmNvbT4KRGF0 ZTogVHVlLCAyOSBBcHIgMjAxNCAxMzozMTozMSArMDIwMApTdWJqZWN0OiBbUEFUQ0hdIDIwMTQt MDQtMjkgIFRvbWFzIFBvcGVsYSAgPHRwb3BlbGFAcmVkaGF0LmNvbT4KCiAgICAgICAgTExJTlQg bG9hZGlzRnJvbUluc3RydWN0aW9uIGRvZXNuJ3QgbmVlZCBzcGVjaWFsIGNhc2UgZm9yIGJpZyBl bmRpYW5zCiAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTEz MjMzMAoKICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KCiAgICAgICAgVGhlIGNo YW5nZSBpbnRyb2R1Y2VkIGluIHIxNjcwNzYgd2FzIHdyb25nLiBXZSBjYW5ub3QgYXBwbHkgdGhl IG9mZnNldAogICAgICAgIGFkanVzdG1lbnQgb24gZXZlcnkgbG9hZGlzRnJvbUluc3RydWN0aW9u IHVzYWdlIGFzIHRoZSBpbnN0cnVjdGlvbgogICAgICAgIChVbmxpbmtlZEluc3RydWN0aW9uKSBp cyBkZWNsYXJlZCBhcyBhbiB1bmlvbiAoaS5lLiB3aXRoIHRoZSBpbnQzMl90CiAgICAgICAgb3Bl cmFuZCB2YXJpYWJsZSkuIFRoZSBvZmZzZXQgb2YgdGhlIHVuaW9uIG1lbWJlcnMgd2lsbCBiZSB0 aGUKICAgICAgICBzYW1lIGFzIHRoZSBvZmZzZXQgb2YgdGhlIGZpcnN0IG9uZSwgdGhhdCBpcyAw LiBUaGUgYmVoYXZpb3IgaGVyZSBpcyB0aGUKICAgICAgICBzYW1lIG9uIGxpdHRsZSBhbmQgYmln IGVuZGlhbiBhcmNoaXRlY3R1cmVzIHRodXMgd2UgZG9uJ3QgbmVlZAogICAgICAgIHNwZWNpYWwg Y2FzZSBmb3IgYmlnIGVuZGlhbnMuCgogICAgICAgICogbGxpbnQvTG93TGV2ZWxJbnRlcnByZXRl ci5hc206Ci0tLQogU291cmNlL0phdmFTY3JpcHRDb3JlL0NoYW5nZUxvZyAgICAgICAgICAgICAg ICAgICAgIHwgMTcgKysrKysrKysrKysrKysrKysKIFNvdXJjZS9KYXZhU2NyaXB0Q29yZS9sbGlu dC9Mb3dMZXZlbEludGVycHJldGVyLmFzbSB8ICA0IC0tLS0KIDIgZmlsZXMgY2hhbmdlZCwgMTcg aW5zZXJ0aW9ucygrKSwgNCBkZWxldGlvbnMoLSkKCmRpZmYgLS1naXQgYS9Tb3VyY2UvSmF2YVNj cmlwdENvcmUvQ2hhbmdlTG9nIGIvU291cmNlL0phdmFTY3JpcHRDb3JlL0NoYW5nZUxvZwppbmRl eCBjYTg2N2ExLi5jOGUwMjM1IDEwMDY0NAotLS0gYS9Tb3VyY2UvSmF2YVNjcmlwdENvcmUvQ2hh bmdlTG9nCisrKyBiL1NvdXJjZS9KYXZhU2NyaXB0Q29yZS9DaGFuZ2VMb2cKQEAgLTEsMyArMSwy MCBAQAorMjAxNC0wNC0yOSAgVG9tYXMgUG9wZWxhICA8dHBvcGVsYUByZWRoYXQuY29tPgorCisg ICAgICAgIExMSU5UIGxvYWRpc0Zyb21JbnN0cnVjdGlvbiBkb2Vzbid0IG5lZWQgc3BlY2lhbCBj YXNlIGZvciBiaWcgZW5kaWFucworICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93 X2J1Zy5jZ2k/aWQ9MTMyMzMwCisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISku CisKKyAgICAgICAgVGhlIGNoYW5nZSBpbnRyb2R1Y2VkIGluIHIxNjcwNzYgd2FzIHdyb25nLiBX ZSBjYW5ub3QgYXBwbHkgdGhlIG9mZnNldAorICAgICAgICBhZGp1c3RtZW50IG9uIGV2ZXJ5IGxv YWRpc0Zyb21JbnN0cnVjdGlvbiB1c2FnZSBhcyB0aGUgaW5zdHJ1Y3Rpb24KKyAgICAgICAgKFVu bGlua2VkSW5zdHJ1Y3Rpb24pIGlzIGRlY2xhcmVkIGFzIGFuIHVuaW9uIChpLmUuIHdpdGggdGhl IGludDMyX3QKKyAgICAgICAgb3BlcmFuZCB2YXJpYWJsZSkuIFRoZSBvZmZzZXQgb2YgdGhlIHVu aW9uIG1lbWJlcnMgd2lsbCBiZSB0aGUKKyAgICAgICAgc2FtZSBhcyB0aGUgb2Zmc2V0IG9mIHRo ZSBmaXJzdCBvbmUsIHRoYXQgaXMgMC4gVGhlIGJlaGF2aW9yIGhlcmUgaXMgdGhlCisgICAgICAg IHNhbWUgb24gbGl0dGxlIGFuZCBiaWcgZW5kaWFuIGFyY2hpdGVjdHVyZXMgdGh1cyB3ZSBkb24n dCBuZWVkCisgICAgICAgIHNwZWNpYWwgY2FzZSBmb3IgYmlnIGVuZGlhbnMuCisKKyAgICAgICAg KiBsbGludC9Mb3dMZXZlbEludGVycHJldGVyLmFzbToKKwogMjAxNC0wNC0yOCAgTWFyayBIYWhu ZW5iZXJnICA8bWhhaG5lbmJlcmdAYXBwbGUuY29tPgogCiAgICAgICAgIFNpbXBsaWZ5IHRyeUNh Y2hlR2V0QnlJZApkaWZmIC0tZ2l0IGEvU291cmNlL0phdmFTY3JpcHRDb3JlL2xsaW50L0xvd0xl dmVsSW50ZXJwcmV0ZXIuYXNtIGIvU291cmNlL0phdmFTY3JpcHRDb3JlL2xsaW50L0xvd0xldmVs SW50ZXJwcmV0ZXIuYXNtCmluZGV4IGQ4Y2I5ZWYuLjY1NTQ5OTYgMTAwNjQ0Ci0tLSBhL1NvdXJj ZS9KYXZhU2NyaXB0Q29yZS9sbGludC9Mb3dMZXZlbEludGVycHJldGVyLmFzbQorKysgYi9Tb3Vy Y2UvSmF2YVNjcmlwdENvcmUvbGxpbnQvTG93TGV2ZWxJbnRlcnByZXRlci5hc20KQEAgLTEwNiwx MSArMTA2LDcgQEAgaWYgSlNWQUxVRTY0CiAgICAgY29uc3QgdGFnTWFzayA9IGNzcjIKICAgICAK ICAgICBtYWNybyBsb2FkaXNGcm9tSW5zdHJ1Y3Rpb24ob2Zmc2V0LCBkZXN0KQotaWYgQklHX0VO RElBTgotICAgICAgICBsb2FkaXMgNCArIG9mZnNldCAqIDhbUEIsIFBDLCA4XSwgZGVzdAotZWxz ZQogICAgICAgICBsb2FkaXMgb2Zmc2V0ICogOFtQQiwgUEMsIDhdLCBkZXN0Ci1lbmQKICAgICBl bmQKICAgICAKICAgICBtYWNybyBsb2FkcEZyb21JbnN0cnVjdGlvbihvZmZzZXQsIGRlc3QpCg== 230373 2014-04-29 06:28:43 -0700 2014-04-29 07:06:36 -0700 Proposed patch v2 webkit-132330v2.patch text/plain 2744 tpopela RnJvbSA5ZTgzNjczOGQ3NGRmNDYzMTEwODg1ODMyOGE5MzJjMTcyMDgwN2EwIE1vbiBTZXAgMTcg MDA6MDA6MDAgMjAwMQpGcm9tOiBUb21hcyBQb3BlbGEgPHRwb3BlbGFAcmVkaGF0LmNvbT4KRGF0 ZTogVHVlLCAyOSBBcHIgMjAxNCAxMzozMTozMSArMDIwMApTdWJqZWN0OiBbUEFUQ0hdIDIwMTQt MDQtMjkgIFRvbWFzIFBvcGVsYSAgPHRwb3BlbGFAcmVkaGF0LmNvbT4KCiAgICAgICAgTExJTlQg bG9hZGlzRnJvbUluc3RydWN0aW9uIGRvZXNuJ3QgbmVlZCBzcGVjaWFsIGNhc2UgZm9yIGJpZyBl bmRpYW5zCiAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTEz MjMzMAoKICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KCiAgICAgICAgVGhlIGNo YW5nZSBpbnRyb2R1Y2VkIGluIHIxNjcwNzYgd2FzIHdyb25nLiBXZSBzaG91bGQgbm90IGFwcGx5 IHRoZSBvZmZzZXQKICAgICAgICBhZGp1c3RtZW50IG9uIGxvYWRpc0Zyb21JbnN0cnVjdGlvbiB1 c2FnZSBhcyB0aGUgaW5zdHJ1Y3Rpb24KICAgICAgICAoVW5saW5rZWRJbnN0cnVjdGlvbikgaXMg ZGVjbGFyZWQgYXMgYW4gdW5pb24gKGkuZS4gd2l0aCB0aGUgaW50MzJfdAogICAgICAgIG9wZXJh bmQgdmFyaWFibGUpLiBUaGUgb2Zmc2V0IG9mIHRoZSBvdGhlciB1bmlvbiBtZW1iZXJzIHdpbGwg YmUgdGhlCiAgICAgICAgc2FtZSBhcyB0aGUgb2Zmc2V0IG9mIHRoZSBmaXJzdCBvbmUsIHRoYXQg aXMgMC4gVGhlIGJlaGF2aW9yIGhlcmUgaXMgdGhlCiAgICAgICAgc2FtZSBvbiBsaXR0bGUgYW5k IGJpZyBlbmRpYW4gYXJjaGl0ZWN0dXJlcy4gVGh1cyB3ZSBkb24ndCBuZWVkCiAgICAgICAgc3Bl Y2lhbCBjYXNlIGZvciBiaWcgZW5kaWFucy4KCiAgICAgICAgKiBsbGludC9Mb3dMZXZlbEludGVy cHJldGVyLmFzbToKLS0tCiBTb3VyY2UvSmF2YVNjcmlwdENvcmUvQ2hhbmdlTG9nICAgICAgICAg ICAgICAgICAgICAgfCAxNyArKysrKysrKysrKysrKysrKwogU291cmNlL0phdmFTY3JpcHRDb3Jl L2xsaW50L0xvd0xldmVsSW50ZXJwcmV0ZXIuYXNtIHwgIDQgLS0tLQogMiBmaWxlcyBjaGFuZ2Vk LCAxNyBpbnNlcnRpb25zKCspLCA0IGRlbGV0aW9ucygtKQoKZGlmZiAtLWdpdCBhL1NvdXJjZS9K YXZhU2NyaXB0Q29yZS9DaGFuZ2VMb2cgYi9Tb3VyY2UvSmF2YVNjcmlwdENvcmUvQ2hhbmdlTG9n CmluZGV4IGNhODY3YTEuLmM4ZTAyMzUgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9KYXZhU2NyaXB0Q29y ZS9DaGFuZ2VMb2cKKysrIGIvU291cmNlL0phdmFTY3JpcHRDb3JlL0NoYW5nZUxvZwpAQCAtMSwz ICsxLDIwIEBACisyMDE0LTA0LTI5ICBUb21hcyBQb3BlbGEgIDx0cG9wZWxhQHJlZGhhdC5jb20+ CisKKyAgICAgICAgTExJTlQgbG9hZGlzRnJvbUluc3RydWN0aW9uIGRvZXNuJ3QgbmVlZCBzcGVj aWFsIGNhc2UgZm9yIGJpZyBlbmRpYW5zCisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3Jn L3Nob3dfYnVnLmNnaT9pZD0xMzIzMzAKKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9P UFMhKS4KKworICAgICAgICBUaGUgY2hhbmdlIGludHJvZHVjZWQgaW4gcjE2NzA3NiB3YXMgd3Jv bmcuIFdlIHNob3VsZCBub3QgYXBwbHkgdGhlIG9mZnNldAorICAgICAgICBhZGp1c3RtZW50IG9u IGxvYWRpc0Zyb21JbnN0cnVjdGlvbiB1c2FnZSBhcyB0aGUgaW5zdHJ1Y3Rpb24KKyAgICAgICAg KFVubGlua2VkSW5zdHJ1Y3Rpb24pIGlzIGRlY2xhcmVkIGFzIGFuIHVuaW9uIChpLmUuIHdpdGgg dGhlIGludDMyX3QKKyAgICAgICAgb3BlcmFuZCB2YXJpYWJsZSkuIFRoZSBvZmZzZXQgb2YgdGhl IG90aGVyIHVuaW9uIG1lbWJlcnMgd2lsbCBiZSB0aGUKKyAgICAgICAgc2FtZSBhcyB0aGUgb2Zm c2V0IG9mIHRoZSBmaXJzdCBvbmUsIHRoYXQgaXMgMC4gVGhlIGJlaGF2aW9yIGhlcmUgaXMgdGhl CisgICAgICAgIHNhbWUgb24gbGl0dGxlIGFuZCBiaWcgZW5kaWFuIGFyY2hpdGVjdHVyZXMuIFRo dXMgd2UgZG9uJ3QgbmVlZAorICAgICAgICBzcGVjaWFsIGNhc2UgZm9yIGJpZyBlbmRpYW5zLgor CisgICAgICAgICogbGxpbnQvTG93TGV2ZWxJbnRlcnByZXRlci5hc206CisKIDIwMTQtMDQtMjgg IE1hcmsgSGFobmVuYmVyZyAgPG1oYWhuZW5iZXJnQGFwcGxlLmNvbT4KIAogICAgICAgICBTaW1w bGlmeSB0cnlDYWNoZUdldEJ5SWQKZGlmZiAtLWdpdCBhL1NvdXJjZS9KYXZhU2NyaXB0Q29yZS9s bGludC9Mb3dMZXZlbEludGVycHJldGVyLmFzbSBiL1NvdXJjZS9KYXZhU2NyaXB0Q29yZS9sbGlu dC9Mb3dMZXZlbEludGVycHJldGVyLmFzbQppbmRleCBkOGNiOWVmLi42NTU0OTk2IDEwMDY0NAot LS0gYS9Tb3VyY2UvSmF2YVNjcmlwdENvcmUvbGxpbnQvTG93TGV2ZWxJbnRlcnByZXRlci5hc20K KysrIGIvU291cmNlL0phdmFTY3JpcHRDb3JlL2xsaW50L0xvd0xldmVsSW50ZXJwcmV0ZXIuYXNt CkBAIC0xMDYsMTEgKzEwNiw3IEBAIGlmIEpTVkFMVUU2NAogICAgIGNvbnN0IHRhZ01hc2sgPSBj c3IyCiAgICAgCiAgICAgbWFjcm8gbG9hZGlzRnJvbUluc3RydWN0aW9uKG9mZnNldCwgZGVzdCkK LWlmIEJJR19FTkRJQU4KLSAgICAgICAgbG9hZGlzIDQgKyBvZmZzZXQgKiA4W1BCLCBQQywgOF0s IGRlc3QKLWVsc2UKICAgICAgICAgbG9hZGlzIG9mZnNldCAqIDhbUEIsIFBDLCA4XSwgZGVzdAot ZW5kCiAgICAgZW5kCiAgICAgCiAgICAgbWFjcm8gbG9hZHBGcm9tSW5zdHJ1Y3Rpb24ob2Zmc2V0 LCBkZXN0KQo=