132326 2014-04-29 02:21:05 -0700 [GTK] Simplify Vector handling in WorkQueue::registerSocketEventHandler() 2014-05-29 05:01:33 -0700 1 1 1 Unclassified WebKit New Bugs 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 130081 1 zan zan cgarcia oldest_to_newest 1004889 0 zan 2014-04-29 02:21:05 -0700 [GTK] Simplify Vector handling in WorkQueue::registerSocketEventHandler() 1004893 1 230364 zan 2014-04-29 02:26:17 -0700 Created attachment 230364 Patch 1004900 2 230364 cgarcia 2014-04-29 03:37:19 -0700 Comment on attachment 230364 Patch This code should die once bug #130081 is fixed. It's not really possible to register a socket event handler for more than one descriptor. 1005025 3 zan 2014-04-29 11:01:02 -0700 (In reply to comment #2) > (From update of attachment 230364 [details]) > This code should die once bug #130081 is fixed. It's not really possible to register a socket event handler for more than one descriptor. I'll mark this bug as dependent on bug #130081 so I get notified when this patch might become obsolete. 1005026 4 230364 zan 2014-04-29 11:02:34 -0700 Comment on attachment 230364 Patch Removing the review flag until then. 1012399 5 zan 2014-05-29 05:01:33 -0700 (In reply to comment #3) > (In reply to comment #2) > > (From update of attachment 230364 [details] [details]) > > This code should die once bug #130081 is fixed. It's not really possible to register a socket event handler for more than one descriptor. > > I'll mark this bug as dependent on bug #130081 so I get notified when this patch might become obsolete. Bug #130081 landed, making this patch invalid/unnecessary. Closing. 230364 2014-04-29 02:26:17 -0700 2014-04-29 11:02:33 -0700 Patch bug-132326-20140429022554.patch text/plain 2737 zan U3VidmVyc2lvbiBSZXZpc2lvbjogMTY3OTIzCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViS2l0Mi9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViS2l0Mi9DaGFuZ2VMb2cKaW5kZXggNzVkYmNhMmM0ZjA0ZjBl NTU3ZjgxMWNjZTA5Yjg3OGNhNzA1YzA4Yi4uOTFmNTIxNWE1M2NjNjM5ZmI2NTQzYTZhMDc5MDA3 NGJjMzExZTdkNyAxMDA2NDQKLS0tIGEvU291cmNlL1dlYktpdDIvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJLaXQyL0NoYW5nZUxvZwpAQCAtMSwzICsxLDE3IEBACisyMDE0LTA0LTI5ICBaYW4g RG9iZXJzZWsgIDx6ZG9iZXJzZWtAaWdhbGlhLmNvbT4KKworICAgICAgICBbR1RLXSBTaW1wbGlm eSBWZWN0b3IgaGFuZGxpbmcgaW4gV29ya1F1ZXVlOjpyZWdpc3RlclNvY2tldEV2ZW50SGFuZGxl cigpCisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0xMzIz MjYKKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICAqIFBs YXRmb3JtL2d0ay9Xb3JrUXVldWVHdGsuY3BwOgorICAgICAgICAoV29ya1F1ZXVlOjpyZWdpc3Rl clNvY2tldEV2ZW50SGFuZGxlcik6IFNpbXBsaWZ5IFZlY3RvciBoYW5kbGluZyBieSBjYWxsaW5n IEhhc2hNYXA8Pjo6YWRkKCksIHRha2luZyB0aGUgcmVmZXJlbmNlCisgICAgICAgIHRvIHRoZSBW ZWN0b3Igb2JqZWN0IHRoYXQgd2FzIGVpdGhlciBqdXN0IGFkZGVkIHRvIHRoZSBIYXNoTWFwIG9y IHdhcyBhbHJlYWR5IGluIGl0LCBhbmQgYXBwZW5kIHRoZSBTb2NrZXRFdmVudFNvdXJjZQorICAg ICAgICBwb2ludGVyIHRvIHRoYXQgcmVmZXJlbmNlLiBUaGlzIGxvb2tzIGFuZCBwZXJmb3JtcyBt dWNoIGJldHRlciB0aGFuIGZpbmRpbmcgdGhlIGV4aXN0aW5nIFZlY3RvciBvYmplY3QsIGFwcGVu ZGluZyB0aGUKKyAgICAgICAgZXZlbnQgc291cmNlIHRvIGl0LCBhbmQgdGhlbiBjb3B5aW5nIGl0 IGJhY2sgaW50byB0aGUgSGFzaE1hcC4KKyAgICAgICAgKFdvcmtRdWV1ZTo6dW5yZWdpc3RlclNv Y2tldEV2ZW50SGFuZGxlcik6IERlcGxveSBhIHJhbmdlLWJhc2VkIGZvci1sb29wIHRvIGl0ZXJh dGUgb3ZlciB0aGUgZXZlbiBzb3VyY2VzIFZlY3Rvci4KKwogMjAxNC0wNC0yOCAgRGFuIEJlcm5z dGVpbiAgPG1pdHpAYXBwbGUuY29tPgogCiAgICAgICAgIDxyZGFyOi8vcHJvYmxlbS8xNjc1MDcw OD4gUkVHUkVTU0lPTiAocjE1OTM1OCk6IENyYXNoIGluIEluamVjdGVkQnVuZGxlSGl0VGVzdFJl c3VsdDo6ZnJhbWUKZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJLaXQyL1BsYXRmb3JtL2d0ay9Xb3Jr UXVldWVHdGsuY3BwIGIvU291cmNlL1dlYktpdDIvUGxhdGZvcm0vZ3RrL1dvcmtRdWV1ZUd0ay5j cHAKaW5kZXggYWUwM2M0N2RkYjhhMGEzZWQ0NTk4YjAyZTlhNzRmZDA0ZGYzODRlOS4uN2E2ZGFh ZjM2OTQxNjkxZThlYjBhN2ZjNjI5M2Y5ZDk5N2FmYTE0YSAxMDA2NDQKLS0tIGEvU291cmNlL1dl YktpdDIvUGxhdGZvcm0vZ3RrL1dvcmtRdWV1ZUd0ay5jcHAKKysrIGIvU291cmNlL1dlYktpdDIv UGxhdGZvcm0vZ3RrL1dvcmtRdWV1ZUd0ay5jcHAKQEAgLTE4NSwxMyArMTg1LDggQEAgdm9pZCBX b3JrUXVldWU6OnJlZ2lzdGVyU29ja2V0RXZlbnRIYW5kbGVyKGludCBmaWxlRGVzY3JpcHRvciwg c3RkOjpmdW5jdGlvbjx2b2kKICAgICAvLyBTZXQgdXAgdGhlIGV2ZW50IHNvdXJjZXMgdW5kZXIg dGhlIG11dGV4IHNpbmNlIHRoaXMgaXMgc2hhcmVkIGFjcm9zcyBtdWx0aXBsZSB0aHJlYWRzLgog ICAgIHsKICAgICAgICAgTXV0ZXhMb2NrZXIgbG9ja2VyKG1fZXZlbnRTb3VyY2VzTG9jayk7Ci0g ICAgICAgIFZlY3RvcjxTb2NrZXRFdmVudFNvdXJjZSo+IHNvdXJjZXM7Ci0gICAgICAgIGF1dG8g aXQgPSBtX2V2ZW50U291cmNlcy5maW5kKGZpbGVEZXNjcmlwdG9yKTsKLSAgICAgICAgaWYgKGl0 ICE9IG1fZXZlbnRTb3VyY2VzLmVuZCgpKQotICAgICAgICAgICAgc291cmNlcyA9IGl0LT52YWx1 ZTsKLQorICAgICAgICBWZWN0b3I8U29ja2V0RXZlbnRTb3VyY2UqPiYgc291cmNlcyA9IG1fZXZl bnRTb3VyY2VzLmFkZChmaWxlRGVzY3JpcHRvciwgVmVjdG9yPFNvY2tldEV2ZW50U291cmNlKj4o KSkuaXRlcmF0b3ItPnZhbHVlOwogICAgICAgICBzb3VyY2VzLmFwcGVuZChldmVudFNvdXJjZSk7 Ci0gICAgICAgIG1fZXZlbnRTb3VyY2VzLnNldChmaWxlRGVzY3JpcHRvciwgc291cmNlcyk7CiAg ICAgfQogCiAgICAgZ19zb3VyY2VfYXR0YWNoKGRpc3BhdGNoU291cmNlLmdldCgpLCBtX2V2ZW50 Q29udGV4dC5nZXQoKSk7CkBAIC0yMDcsOSArMjAyLDggQEAgdm9pZCBXb3JrUXVldWU6OnVucmVn aXN0ZXJTb2NrZXRFdmVudEhhbmRsZXIoaW50IGZpbGVEZXNjcmlwdG9yKQogICAgIGF1dG8gaXQg PSBtX2V2ZW50U291cmNlcy5maW5kKGZpbGVEZXNjcmlwdG9yKTsKIAogICAgIGlmIChpdCAhPSBt X2V2ZW50U291cmNlcy5lbmQoKSkgewotICAgICAgICBWZWN0b3I8U29ja2V0RXZlbnRTb3VyY2Uq PiBzb3VyY2VzID0gaXQtPnZhbHVlOwotICAgICAgICBmb3IgKHVuc2lnbmVkIGkgPSAwOyBpIDwg c291cmNlcy5zaXplKCk7IGkrKykKLSAgICAgICAgICAgIHNvdXJjZXNbaV0tPmNhbmNlbCgpOwor ICAgICAgICBmb3IgKGF1dG8mIHNvdXJjZSA6IGl0LT52YWx1ZSkKKyAgICAgICAgICAgIHNvdXJj ZS0+Y2FuY2VsKCk7CiAKICAgICAgICAgbV9ldmVudFNvdXJjZXMucmVtb3ZlKGl0KTsKICAgICB9 Cg==