132323 2014-04-29 00:40:53 -0700 [GTK][WK2] Avoid Vector copies in WebViewBaseInputMethodFilter::setPreedit() 2014-04-29 08:13:40 -0700 1 1 1 Unclassified WebKit New Bugs 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 1 zan zan berto cgarcia commit-queue gustavo mrobinson oldest_to_newest 1004864 0 zan 2014-04-29 00:40:53 -0700 [GTK][WK2] Avoid Vector copies in WebViewBaseInputMethodFilter::setPreedit(), WebTouchEvent 1004866 1 230360 zan 2014-04-29 00:48:43 -0700 Created attachment 230360 Patch 1004867 2 commit-queue 2014-04-29 00:49:51 -0700 Thanks for the patch. If this patch contains new public API please make sure it follows the guidelines for new WebKit2 GTK+ API. See http://trac.webkit.org/wiki/WebKitGTK/AddingNewWebKit2API 1004868 3 commit-queue 2014-04-29 00:50:00 -0700 Attachment 230360 did not pass style-queue: ERROR: Source/WebKit2/UIProcess/API/gtk/WebViewBaseInputMethodFilter.cpp:91: Missing space before { [whitespace/braces] [5] Total errors found: 1 in 4 files If any of these errors are false positives, please file a bug against check-webkit-style. 1004873 4 230362 zan 2014-04-29 01:26:59 -0700 Created attachment 230362 Patch 1004874 5 commit-queue 2014-04-29 01:27:57 -0700 Attachment 230362 did not pass style-queue: ERROR: Source/WebKit2/UIProcess/API/gtk/WebViewBaseInputMethodFilter.cpp:91: Missing space before { [whitespace/braces] [5] Total errors found: 1 in 2 files If any of these errors are false positives, please file a bug against check-webkit-style. 1004878 6 230362 zan 2014-04-29 01:44:40 -0700 Comment on attachment 230362 Patch Clearing flags on attachment: 230362 Committed r167924: <http://trac.webkit.org/changeset/167924> 1004879 7 zan 2014-04-29 01:44:48 -0700 All reviewed patches have been landed. Closing bug. 1004938 8 230360 mrobinson 2014-04-29 07:31:55 -0700 Comment on attachment 230360 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=230360&action=review > Source/WebKit2/UIProcess/API/gtk/WebViewBaseInputMethodFilter.cpp:92 > + m_webPageProxy->setComposition(newPreedit, Vector<CompositionUnderline>{ CompositionUnderline(0, newPreedit.length(), Color(1, 1, 1), false) }, > + m_cursorOffset, m_cursorOffset, 0 /* replacement start */, 0 /* replacement end */); When the TODO is fixed the vector constructor has to be moved out-of-line anyway. Perhaps it's best just to leave this? It's not called frequently enough for performance to matter. 1004941 9 mrobinson 2014-04-29 07:34:53 -0700 (In reply to comment #8) > When the TODO is fixed the vector constructor has to be moved out-of-line anyway. Perhaps it's best just to leave this? It's not called frequently enough for performance to matter. Oops. I see now that the patch has landed already. 1004948 10 230360 zan 2014-04-29 08:13:40 -0700 Comment on attachment 230360 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=230360&action=review >> Source/WebKit2/UIProcess/API/gtk/WebViewBaseInputMethodFilter.cpp:92 >> + m_cursorOffset, m_cursorOffset, 0 /* replacement start */, 0 /* replacement end */); > > When the TODO is fixed the vector constructor has to be moved out-of-line anyway. Perhaps it's best just to leave this? It's not called frequently enough for performance to matter. I went with inlining to keep the code compact, but std::move() could be used instead (and should be used when someone addresses the TODO and has to un-inline the constructor). I know this Vector copy (and many others) wasn't anywhere near being a performance bottleneck, but it's still more correct to have the Vector moved than to have it unnecessarily copied. This is actually the case with most of such changes I've been landing recently. 230360 2014-04-29 00:48:43 -0700 2014-04-29 08:13:40 -0700 Patch bug-132323-20140429004819.patch text/plain 4716 zan U3VidmVyc2lvbiBSZXZpc2lvbjogMTY3OTIzCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViS2l0Mi9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViS2l0Mi9DaGFuZ2VMb2cKaW5kZXggNzVkYmNhMmM0ZjA0ZjBl NTU3ZjgxMWNjZTA5Yjg3OGNhNzA1YzA4Yi4uM2RkZWY4OWE4ZjA2N2NiNDI3N2ZiNDk4MDEzNDMy ZGVmNmFiYWUzYiAxMDA2NDQKLS0tIGEvU291cmNlL1dlYktpdDIvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJLaXQyL0NoYW5nZUxvZwpAQCAtMSwzICsxLDIwIEBACisyMDE0LTA0LTI5ICBaYW4g RG9iZXJzZWsgIDx6ZG9iZXJzZWtAaWdhbGlhLmNvbT4KKworICAgICAgICBbR1RLXVtXSzJdIEF2 b2lkIFZlY3RvciBjb3BpZXMgaW4gV2ViVmlld0Jhc2VJbnB1dE1ldGhvZEZpbHRlcjo6c2V0UHJl ZWRpdCgpLCBXZWJUb3VjaEV2ZW50CisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3No b3dfYnVnLmNnaT9pZD0xMzIzMjMKKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMh KS4KKworICAgICAgICAqIFNoYXJlZC9XZWJFdmVudC5oOiBSZW1vdmUgYSBjb21tZW50IGFib3V0 IFZlY3RvciBjb3BpZXMuIFRob3NlIGFyZSBhbGwgZ29uZSBub3cuCisgICAgICAgICogU2hhcmVk L1dlYlRvdWNoRXZlbnQuY3BwOgorICAgICAgICAoV2ViS2l0OjpXZWJUb3VjaEV2ZW50OjpXZWJU b3VjaEV2ZW50KTogTW92ZSB0aGUgdG91Y2ggcG9pbnRzIFZlY3RvciBpbnRvIHRoZSBtZW1iZXIg dmFyaWFibGUuCisgICAgICAgICogU2hhcmVkL2d0ay9XZWJFdmVudEZhY3RvcnkuY3BwOgorICAg ICAgICAoV2ViS2l0OjpXZWJFdmVudEZhY3Rvcnk6OmNyZWF0ZVdlYlRvdWNoRXZlbnQpOiBNb3Zl IHRoZSB0b3VjaCBwb2ludHMgVmVjdG9yIGludG8gdGhlCisgICAgICAgIFdlYlRvdWNoRXZlbnQg Y29uc3RydWN0b3IuCisgICAgICAgICogVUlQcm9jZXNzL0FQSS9ndGsvV2ViVmlld0Jhc2VJbnB1 dE1ldGhvZEZpbHRlci5jcHA6CisgICAgICAgIChXZWJLaXQ6OldlYlZpZXdCYXNlSW5wdXRNZXRo b2RGaWx0ZXI6OnNldFByZWVkaXQpOiBJbmxpbmUgdGhlIFZlY3RvciBvYmplY3QgY29uc3RydWN0 aW9uIGludG8KKyAgICAgICAgdGhlIFdlYlBhZ2VQcm94eTo6c2V0Q29tcG9zaXRpb24oKSBjYWxs IHRvIGF2b2lkIGV4dHJhIFZlY3RvciBjb3BpZXMgYW5kIG1vdmVzLgorCiAyMDE0LTA0LTI4ICBE YW4gQmVybnN0ZWluICA8bWl0ekBhcHBsZS5jb20+CiAKICAgICAgICAgPHJkYXI6Ly9wcm9ibGVt LzE2NzUwNzA4PiBSRUdSRVNTSU9OIChyMTU5MzU4KTogQ3Jhc2ggaW4gSW5qZWN0ZWRCdW5kbGVI aXRUZXN0UmVzdWx0OjpmcmFtZQpkaWZmIC0tZ2l0IGEvU291cmNlL1dlYktpdDIvU2hhcmVkL1dl YkV2ZW50LmggYi9Tb3VyY2UvV2ViS2l0Mi9TaGFyZWQvV2ViRXZlbnQuaAppbmRleCBiZmJjMWEz OTQ1NTIzMWFlNmM2Nzg2ZWIyZmQ5MjBlYzc4OTk1NDdlLi4wZWQyOTk4ZWUyN2VkMDZmOTI3NTUz MDcxOWFmYWE2MWJlZmM3YWJmIDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViS2l0Mi9TaGFyZWQvV2Vi RXZlbnQuaAorKysgYi9Tb3VyY2UvV2ViS2l0Mi9TaGFyZWQvV2ViRXZlbnQuaApAQCAtMzcyLDgg KzM3Miw2IEBAIHByaXZhdGU6CiBjbGFzcyBXZWJUb3VjaEV2ZW50IDogcHVibGljIFdlYkV2ZW50 IHsKIHB1YmxpYzoKICAgICBXZWJUb3VjaEV2ZW50KCkgeyB9Ci0gCi0gICAgLy8gRklYTUU6IEl0 IHdvdWxkIGJlIG5pY2Ugbm90IHRvIGhhdmUgdG8gY29weSB0aGUgVmVjdG9yIGhlcmUuCiAgICAg V2ViVG91Y2hFdmVudChUeXBlLCBWZWN0b3I8V2ViUGxhdGZvcm1Ub3VjaFBvaW50PiwgTW9kaWZp ZXJzLCBkb3VibGUgdGltZXN0YW1wKTsKIAogICAgIGNvbnN0IFZlY3RvcjxXZWJQbGF0Zm9ybVRv dWNoUG9pbnQ+JiB0b3VjaFBvaW50cygpIGNvbnN0IHsgcmV0dXJuIG1fdG91Y2hQb2ludHM7IH0K ZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJLaXQyL1NoYXJlZC9XZWJUb3VjaEV2ZW50LmNwcCBiL1Nv dXJjZS9XZWJLaXQyL1NoYXJlZC9XZWJUb3VjaEV2ZW50LmNwcAppbmRleCAyNzhiNmJhZTA3MzJk NTYyM2FlMGEzZmViMDQ3Y2JkZjY2MTU0M2NkLi4zNmQ4MDkwNjkwNWNjMTFjM2I4Y2FmODg0YzUz ZDNhM2QzMGQ2M2IyIDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViS2l0Mi9TaGFyZWQvV2ViVG91Y2hF dmVudC5jcHAKKysrIGIvU291cmNlL1dlYktpdDIvU2hhcmVkL1dlYlRvdWNoRXZlbnQuY3BwCkBA IC0zNSw3ICszNSw3IEBAIG5hbWVzcGFjZSBXZWJLaXQgewogCiBXZWJUb3VjaEV2ZW50OjpXZWJU b3VjaEV2ZW50KFdlYkV2ZW50OjpUeXBlIHR5cGUsIFZlY3RvcjxXZWJQbGF0Zm9ybVRvdWNoUG9p bnQ+IHRvdWNoUG9pbnRzLCBNb2RpZmllcnMgbW9kaWZpZXJzLCBkb3VibGUgdGltZXN0YW1wKQog ICAgIDogV2ViRXZlbnQodHlwZSwgbW9kaWZpZXJzLCB0aW1lc3RhbXApCi0gICAgLCBtX3RvdWNo UG9pbnRzKHRvdWNoUG9pbnRzKQorICAgICwgbV90b3VjaFBvaW50cyhzdGQ6Om1vdmUodG91Y2hQ b2ludHMpKQogewogICAgIEFTU0VSVChpc1RvdWNoRXZlbnRUeXBlKHR5cGUpKTsKIH0KZGlmZiAt LWdpdCBhL1NvdXJjZS9XZWJLaXQyL1NoYXJlZC9ndGsvV2ViRXZlbnRGYWN0b3J5LmNwcCBiL1Nv dXJjZS9XZWJLaXQyL1NoYXJlZC9ndGsvV2ViRXZlbnRGYWN0b3J5LmNwcAppbmRleCA0NjJiMTFi ODk1MTczNzE2MmRmYTYyZDczZjY5NGUxZGEyOTkyNTAyLi5jMmRhZTdkMGNiNDg0ZjE3ODgyNjk0 YjU0YjE0YmNhZGRmZDg5OTMwIDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViS2l0Mi9TaGFyZWQvZ3Rr L1dlYkV2ZW50RmFjdG9yeS5jcHAKKysrIGIvU291cmNlL1dlYktpdDIvU2hhcmVkL2d0ay9XZWJF dmVudEZhY3RvcnkuY3BwCkBAIC0yNjksNyArMjY5LDcgQEAgV2ViVG91Y2hFdmVudCBXZWJFdmVu dEZhY3Rvcnk6OmNyZWF0ZVdlYlRvdWNoRXZlbnQoY29uc3QgR2RrRXZlbnQqIGV2ZW50LCBjb25z dAogICAgIGlmIChldmVudC0+dHlwZSA9PSBHREtfVE9VQ0hfRU5EKQogICAgICAgICBhcHBlbmRU b3VjaEV2ZW50KHRvdWNoUG9pbnRMaXN0LCBldmVudCwgV2ViUGxhdGZvcm1Ub3VjaFBvaW50OjpU b3VjaFJlbGVhc2VkKTsKIAotICAgIHJldHVybiBXZWJUb3VjaEV2ZW50KHR5cGUsIHRvdWNoUG9p bnRMaXN0LCBtb2RpZmllcnNGb3JFdmVudChldmVudCksIGdka19ldmVudF9nZXRfdGltZShldmVu dCkpOworICAgIHJldHVybiBXZWJUb3VjaEV2ZW50KHR5cGUsIHN0ZDo6bW92ZSh0b3VjaFBvaW50 TGlzdCksIG1vZGlmaWVyc0ZvckV2ZW50KGV2ZW50KSwgZ2RrX2V2ZW50X2dldF90aW1lKGV2ZW50 KSk7CiAjZWxzZQogICAgIHJldHVybiBXZWJUb3VjaEV2ZW50KCk7CiAjZW5kaWYgLy8gR1RLX0FQ SV9WRVJTSU9OXzIKZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJLaXQyL1VJUHJvY2Vzcy9BUEkvZ3Rr L1dlYlZpZXdCYXNlSW5wdXRNZXRob2RGaWx0ZXIuY3BwIGIvU291cmNlL1dlYktpdDIvVUlQcm9j ZXNzL0FQSS9ndGsvV2ViVmlld0Jhc2VJbnB1dE1ldGhvZEZpbHRlci5jcHAKaW5kZXggNjk1YWU1 NmI4YjkzZWQ4ZDAxMzkzOGE1YjZmM2IyNDllMzcwMDZiYi4uZTA5OTgyZTUwNzIzZjQzYTJkOTQx NzM4Y2Q5OTQwZTVhZDkzMDZiMiAxMDA2NDQKLS0tIGEvU291cmNlL1dlYktpdDIvVUlQcm9jZXNz L0FQSS9ndGsvV2ViVmlld0Jhc2VJbnB1dE1ldGhvZEZpbHRlci5jcHAKKysrIGIvU291cmNlL1dl YktpdDIvVUlQcm9jZXNzL0FQSS9ndGsvV2ViVmlld0Jhc2VJbnB1dE1ldGhvZEZpbHRlci5jcHAK QEAgLTg3LDE0ICs4Nyw5IEBAIHZvaWQgV2ViVmlld0Jhc2VJbnB1dE1ldGhvZEZpbHRlcjo6Y2Fu Y2VsQ3VycmVudENvbXBvc2l0aW9uKCkKIHZvaWQgV2ViVmlld0Jhc2VJbnB1dE1ldGhvZEZpbHRl cjo6c2V0UHJlZWRpdChTdHJpbmcgbmV3UHJlZWRpdCwgaW50IC8qIGN1cnNvck9mZnNldCAqLykK IHsKICAgICAvLyBUT0RPOiBXZSBzaG91bGQgcGFyc2UgdGhlIFBhbmdvQXR0ckxpc3QgdGhhdCB3 ZSBnZXQgZnJvbSB0aGUgSU0gY29udGV4dCBoZXJlLgotICAgIFZlY3RvcjxDb21wb3NpdGlvblVu ZGVybGluZT4gdW5kZXJsaW5lczsKLSAgICB1bmRlcmxpbmVzLmFwcGVuZChDb21wb3NpdGlvblVu ZGVybGluZSgwLCBuZXdQcmVlZGl0Lmxlbmd0aCgpLCBDb2xvcigxLCAxLCAxKSwgZmFsc2UpKTsK LQogICAgIEFTU0VSVChtX3dlYlBhZ2VQcm94eSk7Ci0gICAgbV93ZWJQYWdlUHJveHktPnNldENv bXBvc2l0aW9uKG5ld1ByZWVkaXQsIHVuZGVybGluZXMsCi0gICAgICAgICAgICAgICAgICAgICAg ICAgICAgICAgICAgIG1fY3Vyc29yT2Zmc2V0LCBtX2N1cnNvck9mZnNldCwKLSAgICAgICAgICAg ICAgICAgICAgICAgICAgICAgICAgICAgMCAvKiByZXBsYWNlbWVudCBzdGFydCAqLywKLSAgICAg ICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgMCAvKiByZXBsYWNlbWVudCBlbmQgKi8pOwor ICAgIG1fd2ViUGFnZVByb3h5LT5zZXRDb21wb3NpdGlvbihuZXdQcmVlZGl0LCBWZWN0b3I8Q29t cG9zaXRpb25VbmRlcmxpbmU+eyBDb21wb3NpdGlvblVuZGVybGluZSgwLCBuZXdQcmVlZGl0Lmxl bmd0aCgpLCBDb2xvcigxLCAxLCAxKSwgZmFsc2UpIH0sCisgICAgICAgIG1fY3Vyc29yT2Zmc2V0 LCBtX2N1cnNvck9mZnNldCwgMCAvKiByZXBsYWNlbWVudCBzdGFydCAqLywgMCAvKiByZXBsYWNl bWVudCBlbmQgKi8pOwogfQogCiB9IC8vIG5hbWVzcGFjZSBXZWJLaXQK 230362 2014-04-29 01:26:59 -0700 2014-04-29 01:44:40 -0700 Patch bug-132323-20140429012636.patch text/plain 2096 zan SW5kZXg6IFNvdXJjZS9XZWJLaXQyL0NoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBTb3VyY2UvV2Vi S2l0Mi9DaGFuZ2VMb2cJKHJldmlzaW9uIDE2NzkyMykKKysrIFNvdXJjZS9XZWJLaXQyL0NoYW5n ZUxvZwkod29ya2luZyBjb3B5KQpAQCAtMSwzICsxLDE0IEBACisyMDE0LTA0LTI5ICBaYW4gRG9i ZXJzZWsgIDx6ZG9iZXJzZWtAaWdhbGlhLmNvbT4KKworICAgICAgICBbR1RLXVtXSzJdIEF2b2lk IFZlY3RvciBjb3BpZXMgaW4gV2ViVmlld0Jhc2VJbnB1dE1ldGhvZEZpbHRlcjo6c2V0UHJlZWRp dCgpCisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0xMzIz MjMKKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICAqIFVJ UHJvY2Vzcy9BUEkvZ3RrL1dlYlZpZXdCYXNlSW5wdXRNZXRob2RGaWx0ZXIuY3BwOgorICAgICAg ICAoV2ViS2l0OjpXZWJWaWV3QmFzZUlucHV0TWV0aG9kRmlsdGVyOjpzZXRQcmVlZGl0KTogSW5s aW5lIHRoZSBWZWN0b3Igb2JqZWN0IGNvbnN0cnVjdGlvbiBpbnRvCisgICAgICAgIHRoZSBXZWJQ YWdlUHJveHk6OnNldENvbXBvc2l0aW9uKCkgY2FsbCB0byBhdm9pZCBleHRyYSBWZWN0b3IgY29w aWVzIGFuZCBtb3Zlcy4KKwogMjAxNC0wNC0yOCAgRGFuIEJlcm5zdGVpbiAgPG1pdHpAYXBwbGUu Y29tPgogCiAgICAgICAgIDxyZGFyOi8vcHJvYmxlbS8xNjc1MDcwOD4gUkVHUkVTU0lPTiAocjE1 OTM1OCk6IENyYXNoIGluIEluamVjdGVkQnVuZGxlSGl0VGVzdFJlc3VsdDo6ZnJhbWUKSW5kZXg6 IFNvdXJjZS9XZWJLaXQyL1VJUHJvY2Vzcy9BUEkvZ3RrL1dlYlZpZXdCYXNlSW5wdXRNZXRob2RG aWx0ZXIuY3BwCj09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT0KLS0tIFNvdXJjZS9XZWJLaXQyL1VJUHJvY2Vzcy9BUEkvZ3Rr L1dlYlZpZXdCYXNlSW5wdXRNZXRob2RGaWx0ZXIuY3BwCShyZXZpc2lvbiAxNjc5MjMpCisrKyBT b3VyY2UvV2ViS2l0Mi9VSVByb2Nlc3MvQVBJL2d0ay9XZWJWaWV3QmFzZUlucHV0TWV0aG9kRmls dGVyLmNwcAkod29ya2luZyBjb3B5KQpAQCAtODcsMTQgKzg3LDkgQEAgdm9pZCBXZWJWaWV3QmFz ZUlucHV0TWV0aG9kRmlsdGVyOjpjYW5jZQogdm9pZCBXZWJWaWV3QmFzZUlucHV0TWV0aG9kRmls dGVyOjpzZXRQcmVlZGl0KFN0cmluZyBuZXdQcmVlZGl0LCBpbnQgLyogY3Vyc29yT2Zmc2V0ICov KQogewogICAgIC8vIFRPRE86IFdlIHNob3VsZCBwYXJzZSB0aGUgUGFuZ29BdHRyTGlzdCB0aGF0 IHdlIGdldCBmcm9tIHRoZSBJTSBjb250ZXh0IGhlcmUuCi0gICAgVmVjdG9yPENvbXBvc2l0aW9u VW5kZXJsaW5lPiB1bmRlcmxpbmVzOwotICAgIHVuZGVybGluZXMuYXBwZW5kKENvbXBvc2l0aW9u VW5kZXJsaW5lKDAsIG5ld1ByZWVkaXQubGVuZ3RoKCksIENvbG9yKDEsIDEsIDEpLCBmYWxzZSkp OwotCiAgICAgQVNTRVJUKG1fd2ViUGFnZVByb3h5KTsKLSAgICBtX3dlYlBhZ2VQcm94eS0+c2V0 Q29tcG9zaXRpb24obmV3UHJlZWRpdCwgdW5kZXJsaW5lcywKLSAgICAgICAgICAgICAgICAgICAg ICAgICAgICAgICAgICAgbV9jdXJzb3JPZmZzZXQsIG1fY3Vyc29yT2Zmc2V0LAotICAgICAgICAg ICAgICAgICAgICAgICAgICAgICAgICAgICAwIC8qIHJlcGxhY2VtZW50IHN0YXJ0ICovLAotICAg ICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAwIC8qIHJlcGxhY2VtZW50IGVuZCAqLyk7 CisgICAgbV93ZWJQYWdlUHJveHktPnNldENvbXBvc2l0aW9uKG5ld1ByZWVkaXQsIFZlY3RvcjxD b21wb3NpdGlvblVuZGVybGluZT57IENvbXBvc2l0aW9uVW5kZXJsaW5lKDAsIG5ld1ByZWVkaXQu bGVuZ3RoKCksIENvbG9yKDEsIDEsIDEpLCBmYWxzZSkgfSwKKyAgICAgICAgbV9jdXJzb3JPZmZz ZXQsIG1fY3Vyc29yT2Zmc2V0LCAwIC8qIHJlcGxhY2VtZW50IHN0YXJ0ICovLCAwIC8qIHJlcGxh Y2VtZW50IGVuZCAqLyk7CiB9CiAKIH0gLy8gbmFtZXNwYWNlIFdlYktpdAo=