132321 2014-04-29 00:14:48 -0700 AX: SpeechSynthesisUtterance cannot addEventListener 2014-04-29 09:05:44 -0700 1 1 1 Unclassified WebKit Accessibility 528+ (Nightly build) All All RESOLVED FIXED InRadar P2 Normal --- 1 cfleizach cfleizach cdumez commit-queue esprehn+autocc kondapallykalyan mario webkit-bug-importer oldest_to_newest 1004860 0 cfleizach 2014-04-29 00:14:48 -0700 According to the Web Speech API spec, the SpeechSynthesisUtterance is a subclass of EventTarget. Therefore it has event handler attributes like `onend` and `onresume`. However it did not implement the `addEventListener` method, so you cannot hook event handlers to an utterance instance via the more common way. Steps to Reproduce: 1. var u = new SpeechSynthesisUtterance("Test speech"); 2. u.addEventListener('end', function(e) { console.log(e); }); <rdar://problem/14887812> 1004862 1 230358 cfleizach 2014-04-29 00:16:37 -0700 Created attachment 230358 patch 1004896 2 230358 mario 2014-04-29 02:29:43 -0700 Comment on attachment 230358 patch View in context: https://bugs.webkit.org/attachment.cgi?id=230358&action=review It looks good to me, but please take into consideration my comments below (should they make sense to you too). Thanks! > Source/WebCore/Modules/speech/SpeechSynthesisUtterance.idl:40 > + void addEventListener(DOMString type, EventListener listener, optional boolean useCapture); > + void removeEventListener(DOMString type, EventListener listener, optional boolean useCapture); I know you probably don't need it for this specific case, but wouldn't it be a good idea to add EventTarget's dispatchEvent() here too, so the implementation of that interface is complete insite SpeechSynthesisUtterance? Also, for consistency with other IDLs (e.g. html/MediaController.idl, html/track/TextTrack.idl...), I guess I would add these methods to the end with a comment "// EventTarget interface" on top for clarity. 1004965 3 cfleizach 2014-04-29 09:05:44 -0700 http://trac.webkit.org/changeset/167933 Thanks Mario! 230358 2014-04-29 00:16:37 -0700 2014-04-29 02:29:43 -0700 patch patch text/plain 2838 cfleizach SW5kZXg6IFNvdXJjZS9XZWJDb3JlL0NoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBTb3VyY2UvV2Vi Q29yZS9DaGFuZ2VMb2cJKHJldmlzaW9uIDE2NzkyMykKKysrIFNvdXJjZS9XZWJDb3JlL0NoYW5n ZUxvZwkod29ya2luZyBjb3B5KQpAQCAtMSwzICsxLDE0IEBACisyMDE0LTA0LTI5ICBDaHJpcyBG bGVpemFjaCAgPGNmbGVpemFjaEBhcHBsZS5jb20+CisKKyAgICAgICAgQVg6IFNwZWVjaFN5bnRo ZXNpc1V0dGVyYW5jZSBjYW5ub3QgYWRkRXZlbnRMaXN0ZW5lcgorICAgICAgICBodHRwczovL2J1 Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MTMyMzIxCisKKyAgICAgICAgUmV2aWV3ZWQg YnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgTW9kaWZpZWQgYW4gZXhpc3RpbmcgdGVzdCAo c3BlZWNoLXN5bnRoZXNpcy1zcGVhay5odG1sKSB0byB1c2UgYWRkRXZlbnRUYXJnZXQuCisKKyAg ICAgICAgKiBNb2R1bGVzL3NwZWVjaC9TcGVlY2hTeW50aGVzaXNVdHRlcmFuY2UuaWRsOgorCiAy MDE0LTA0LTI4ICBCZW5qYW1pbiBQb3VsYWluICA8YmVuamFtaW5Ad2Via2l0Lm9yZz4KIAogICAg ICAgICBTZWxlY3RvckNvZGVHZW5lcmF0b3I6OmdlbmVyYXRlRWxlbWVudElzTnRoQ2hpbGQoKSBs ZWFrcyB0aGUgcGFyZW50IHJlZ2lzdGVyIDpudGgtY2hpbGQoKSBpcyBub24tZmlsdGVyaW5nCklu ZGV4OiBTb3VyY2UvV2ViQ29yZS9Nb2R1bGVzL3NwZWVjaC9TcGVlY2hTeW50aGVzaXNVdHRlcmFu Y2UuaWRsCj09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT0KLS0tIFNvdXJjZS9XZWJDb3JlL01vZHVsZXMvc3BlZWNoL1NwZWVj aFN5bnRoZXNpc1V0dGVyYW5jZS5pZGwJKHJldmlzaW9uIDE2Nzg4NykKKysrIFNvdXJjZS9XZWJD b3JlL01vZHVsZXMvc3BlZWNoL1NwZWVjaFN5bnRoZXNpc1V0dGVyYW5jZS5pZGwJKHdvcmtpbmcg Y29weSkKQEAgLTM2LDYgKzM2LDkgQEAKICAgICBhdHRyaWJ1dGUgZmxvYXQgcmF0ZTsKICAgICBh dHRyaWJ1dGUgZmxvYXQgcGl0Y2g7CiAKKyAgICB2b2lkIGFkZEV2ZW50TGlzdGVuZXIoRE9NU3Ry aW5nIHR5cGUsIEV2ZW50TGlzdGVuZXIgbGlzdGVuZXIsIG9wdGlvbmFsIGJvb2xlYW4gdXNlQ2Fw dHVyZSk7CisgICAgdm9pZCByZW1vdmVFdmVudExpc3RlbmVyKERPTVN0cmluZyB0eXBlLCBFdmVu dExpc3RlbmVyIGxpc3RlbmVyLCBvcHRpb25hbCBib29sZWFuIHVzZUNhcHR1cmUpOworCiAgICAg YXR0cmlidXRlIEV2ZW50TGlzdGVuZXIgb25zdGFydDsKICAgICBhdHRyaWJ1dGUgRXZlbnRMaXN0 ZW5lciBvbmVuZDsKICAgICBhdHRyaWJ1dGUgRXZlbnRMaXN0ZW5lciBvbmVycm9yOwpJbmRleDog TGF5b3V0VGVzdHMvQ2hhbmdlTG9nCj09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIExheW91dFRlc3RzL0NoYW5nZUxv ZwkocmV2aXNpb24gMTY3OTIzKQorKysgTGF5b3V0VGVzdHMvQ2hhbmdlTG9nCSh3b3JraW5nIGNv cHkpCkBAIC0xLDMgKzEsMTIgQEAKKzIwMTQtMDQtMjkgIENocmlzIEZsZWl6YWNoICA8Y2ZsZWl6 YWNoQGFwcGxlLmNvbT4KKworICAgICAgICBBWDogU3BlZWNoU3ludGhlc2lzVXR0ZXJhbmNlIGNh bm5vdCBhZGRFdmVudExpc3RlbmVyCisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3No b3dfYnVnLmNnaT9pZD0xMzIzMjEKKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMh KS4KKworICAgICAgICAqIHBsYXRmb3JtL21hYy9mYXN0L3NwZWVjaHN5bnRoZXNpcy9zcGVlY2gt c3ludGhlc2lzLXNwZWFrLmh0bWw6CisKIDIwMTQtMDQtMjggIEJlbmphbWluIFBvdWxhaW4gIDxi ZW5qYW1pbkB3ZWJraXQub3JnPgogCiAgICAgICAgIFNlbGVjdG9yQ29kZUdlbmVyYXRvcjo6Z2Vu ZXJhdGVFbGVtZW50SXNOdGhDaGlsZCgpIGxlYWtzIHRoZSBwYXJlbnQgcmVnaXN0ZXIgOm50aC1j aGlsZCgpIGlzIG5vbi1maWx0ZXJpbmcKSW5kZXg6IExheW91dFRlc3RzL3BsYXRmb3JtL21hYy9m YXN0L3NwZWVjaHN5bnRoZXNpcy9zcGVlY2gtc3ludGhlc2lzLXNwZWFrLmh0bWwKPT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PQotLS0gTGF5b3V0VGVzdHMvcGxhdGZvcm0vbWFjL2Zhc3Qvc3BlZWNoc3ludGhlc2lzL3NwZWVj aC1zeW50aGVzaXMtc3BlYWsuaHRtbAkocmV2aXNpb24gMTY3ODg3KQorKysgTGF5b3V0VGVzdHMv cGxhdGZvcm0vbWFjL2Zhc3Qvc3BlZWNoc3ludGhlc2lzL3NwZWVjaC1zeW50aGVzaXMtc3BlYWsu aHRtbAkod29ya2luZyBjb3B5KQpAQCAtMjYsMTEgKzI2LDEyIEBACiAgICAgICAgc2hvdWxkQmVU cnVlKCJldmVudC5lbGFwc2VkVGltZSA+IDAiKTsKICAgICAgICBzaG91bGRCZVRydWUoInNwZWVj aFN5bnRoZXNpcy5zcGVha2luZyIpOwogICAgIH0KLSAgICB1Lm9uZW5kID0gZnVuY3Rpb24oZXZl bnQpIHsKKworICAgIHUuYWRkRXZlbnRMaXN0ZW5lcignZW5kJywgZnVuY3Rpb24oZSkgeyAKICAg ICAgICBzaG91bGRCZVRydWUoImV2ZW50LmVsYXBzZWRUaW1lID4gMCIpOwogICAgICAgIHNob3Vs ZEJlRmFsc2UoInNwZWVjaFN5bnRoZXNpcy5zcGVha2luZyIpOwogICAgICAgIGZpbmlzaEpTVGVz dCgpOwotICAgIH0KKyAgICB9KTsKIAogICAgIHNob3VsZEJlRmFsc2UoInNwZWVjaFN5bnRoZXNp cy5zcGVha2luZyIpOwogICAgIHNwZWVjaFN5bnRoZXNpcy5zcGVhayh1KTsK