132318 2014-04-28 20:58:02 -0700 REGRESSION (r159358): Crash in InjectedBundleHitTestResult::frame 2014-04-28 21:21:34 -0700 1 1 1 Unclassified WebKit WebKit2 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED https://smilesoftware.com/TextExpander/download_thanks.html?url=http://cdn.smilesoftware.com/TextExpander_4.2.1.zip InRadar, Regression P1 Normal --- 1 mitz mitz aestes oldest_to_newest 1004845 0 mitz 2014-04-28 20:58:02 -0700 <rdar://problem/16750708> To reproduce this crash, navigate to the URL. 1004846 1 230352 mitz 2014-04-28 21:01:56 -0700 Created attachment 230352 Get the frame from the event target, not from its hit-test result 1004848 2 230352 aestes 2014-04-28 21:19:13 -0700 Comment on attachment 230352 Get the frame from the event target, not from its hit-test result View in context: https://bugs.webkit.org/attachment.cgi?id=230352&action=review > Source/WebKit2/ChangeLog:14 > + frame for the action not from a hit test results, because some link activation actions are "a hit test results" 1004849 3 mitz 2014-04-28 21:21:34 -0700 (In reply to comment #2) > (From update of attachment 230352 [details]) > View in context: https://bugs.webkit.org/attachment.cgi?id=230352&action=review > > > Source/WebKit2/ChangeLog:14 > > + frame for the action not from a hit test results, because some link activation actions are > > "a hit test results" Fixed. Thanks for the review! Committed <http://trac.webkit.org/r167923>. 230352 2014-04-28 21:01:56 -0700 2014-04-28 21:19:13 -0700 Get the frame from the event target, not from its hit-test result bug-132318-20140428210134.patch text/plain 2880 mitz SW5kZXg6IFNvdXJjZS9XZWJLaXQyL0NoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBTb3VyY2UvV2Vi S2l0Mi9DaGFuZ2VMb2cJKHJldmlzaW9uIDE2NzkyMikKKysrIFNvdXJjZS9XZWJLaXQyL0NoYW5n ZUxvZwkod29ya2luZyBjb3B5KQpAQCAtMSwzICsxLDE5IEBACisyMDE0LTA0LTI4ICBEYW4gQmVy bnN0ZWluICA8bWl0ekBhcHBsZS5jb20+CisKKyAgICAgICAgPHJkYXI6Ly9wcm9ibGVtLzE2NzUw NzA4PiBSRUdSRVNTSU9OIChyMTU5MzU4KTogQ3Jhc2ggaW4gSW5qZWN0ZWRCdW5kbGVIaXRUZXN0 UmVzdWx0OjpmcmFtZQorICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5j Z2k/aWQ9MTMyMzE4CisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAg ICAgICAgKiBVSVByb2Nlc3MvQ29jb2EvTmF2aWdhdGlvblN0YXRlLm1tOgorICAgICAgICAoV2Vi S2l0OjpOYXZpZ2F0aW9uU3RhdGU6OlBvbGljeUNsaWVudDo6ZGVjaWRlUG9saWN5Rm9yTmF2aWdh dGlvbkFjdGlvbik6IEZpeGVkIGEgdHlwbzogc2V0CisgICAgICAgIHRoZSBzb3VyY2UgZnJhbWUs IG5vdCB0aGUgZGVzdGluYXRpb24gZnJhbWUuCisKKyAgICAgICAgKiBXZWJQcm9jZXNzL1dlYkNv cmVTdXBwb3J0L1dlYkZyYW1lTG9hZGVyQ2xpZW50LmNwcDoKKyAgICAgICAgKFdlYktpdDo6V2Vi RnJhbWVMb2FkZXJDbGllbnQ6OmRpc3BhdGNoRGVjaWRlUG9saWN5Rm9yTmF2aWdhdGlvbkFjdGlv bik6IENoYW5nZWQgdG8gZ2V0IHRoZQorICAgICAgICBmcmFtZSBmb3IgdGhlIGFjdGlvbiBub3Qg ZnJvbSBhIGhpdCB0ZXN0IHJlc3VsdHMsIGJlY2F1c2Ugc29tZSBsaW5rIGFjdGl2YXRpb24gYWN0 aW9ucyBhcmUKKyAgICAgICAgbm90IG1vdXNlIGV2ZW50cywgYnV0IHJhdGhlciBmcm9tIHRoZSBl dmVudOKAmXMgdGFyZ2V0LgorCiAyMDE0LTA0LTI4ICBCZW5qYW1pbiBQb3VsYWluICA8YnBvdWxh aW5AYXBwbGUuY29tPgogCiAgICAgICAgIFtpT1NdW1dLMl0gUmVzdG9yZSB0aGUgc2Nyb2xsIHBv c2l0aW9uIGFuZCBzY2FsZSBmcm9tIHRoZSBIaXN0b3J5SXRlbSAobW9zdGx5KQpJbmRleDogU291 cmNlL1dlYktpdDIvVUlQcm9jZXNzL0NvY29hL05hdmlnYXRpb25TdGF0ZS5tbQo9PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 Ci0tLSBTb3VyY2UvV2ViS2l0Mi9VSVByb2Nlc3MvQ29jb2EvTmF2aWdhdGlvblN0YXRlLm1tCShy ZXZpc2lvbiAxNjc5MjEpCisrKyBTb3VyY2UvV2ViS2l0Mi9VSVByb2Nlc3MvQ29jb2EvTmF2aWdh dGlvblN0YXRlLm1tCSh3b3JraW5nIGNvcHkpCkBAIC0yNTYsNyArMjU2LDcgQEAgdm9pZCBOYXZp Z2F0aW9uU3RhdGU6OlBvbGljeUNsaWVudDo6ZGVjaQogICAgICAgICBpZiAoc291cmNlRnJhbWUg PT0gZGVzdGluYXRpb25GcmFtZSkKICAgICAgICAgICAgIFtuYXZpZ2F0aW9uQWN0aW9uIHNldFNv dXJjZUZyYW1lOltuYXZpZ2F0aW9uQWN0aW9uIHRhcmdldEZyYW1lXV07CiAgICAgICAgIGVsc2UK LSAgICAgICAgICAgIFtuYXZpZ2F0aW9uQWN0aW9uIHNldFRhcmdldEZyYW1lOmFkb3B0TlMoW1tX S0ZyYW1lSW5mbyBhbGxvY10gaW5pdFdpdGhXZWJGcmFtZVByb3h5Oipzb3VyY2VGcmFtZV0pLmdl dCgpXTsKKyAgICAgICAgICAgIFtuYXZpZ2F0aW9uQWN0aW9uIHNldFNvdXJjZUZyYW1lOmFkb3B0 TlMoW1tXS0ZyYW1lSW5mbyBhbGxvY10gaW5pdFdpdGhXZWJGcmFtZVByb3h5Oipzb3VyY2VGcmFt ZV0pLmdldCgpXTsKICAgICB9CiAKICAgICBbbmF2aWdhdGlvbkFjdGlvbiBzZXROYXZpZ2F0aW9u VHlwZTp0b1dLTmF2aWdhdGlvblR5cGUobmF2aWdhdGlvbkFjdGlvbkRhdGEubmF2aWdhdGlvblR5 cGUpXTsKSW5kZXg6IFNvdXJjZS9XZWJLaXQyL1dlYlByb2Nlc3MvV2ViQ29yZVN1cHBvcnQvV2Vi RnJhbWVMb2FkZXJDbGllbnQuY3BwCj09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIFNvdXJjZS9XZWJLaXQyL1dlYlBy b2Nlc3MvV2ViQ29yZVN1cHBvcnQvV2ViRnJhbWVMb2FkZXJDbGllbnQuY3BwCShyZXZpc2lvbiAx Njc5MjEpCisrKyBTb3VyY2UvV2ViS2l0Mi9XZWJQcm9jZXNzL1dlYkNvcmVTdXBwb3J0L1dlYkZy YW1lTG9hZGVyQ2xpZW50LmNwcAkod29ya2luZyBjb3B5KQpAQCAtNzMzLDcgKzczMywxMiBAQCB2 b2lkIFdlYkZyYW1lTG9hZGVyQ2xpZW50OjpkaXNwYXRjaERlY2lkCiAgICAgUmVmUHRyPFdlYkZy YW1lPiBvcmlnaW5hdGluZ0ZyYW1lOwogICAgIHN3aXRjaCAoYWN0aW9uLT5uYXZpZ2F0aW9uVHlw ZSgpKSB7CiAgICAgY2FzZSBOYXZpZ2F0aW9uVHlwZUxpbmtDbGlja2VkOgotICAgICAgICBvcmln aW5hdGluZ0ZyYW1lID0gYWN0aW9uLT5oaXRUZXN0UmVzdWx0KCktPmZyYW1lKCk7CisgICAgICAg IGlmIChFdmVudFRhcmdldCogdGFyZ2V0ID0gbmF2aWdhdGlvbkFjdGlvbi5ldmVudCgpLT50YXJn ZXQoKSkgeworICAgICAgICAgICAgaWYgKE5vZGUqIG5vZGUgPSB0YXJnZXQtPnRvTm9kZSgpKSB7 CisgICAgICAgICAgICAgICAgaWYgKEZyYW1lKiBmcmFtZSA9IG5vZGUtPmRvY3VtZW50KCkuZnJh bWUoKSkKKyAgICAgICAgICAgICAgICAgICAgb3JpZ2luYXRpbmdGcmFtZSA9IFdlYkZyYW1lOjpm cm9tQ29yZUZyYW1lKCpmcmFtZSk7CisgICAgICAgICAgICB9CisgICAgICAgIH0KICAgICAgICAg YnJlYWs7CiAgICAgY2FzZSBOYXZpZ2F0aW9uVHlwZUZvcm1TdWJtaXR0ZWQ6CiAgICAgY2FzZSBO YXZpZ2F0aW9uVHlwZUZvcm1SZXN1Ym1pdHRlZDoK