132313 2014-04-28 17:34:17 -0700 [CSS Shapes] complex calc values for shape-margin return null for computed style 2014-04-29 09:16:43 -0700 1 1 1 Unclassified WebKit CSS 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 98664 1 rhauck zoltan commit-queue esprehn+autocc glenn gyuyoung.kim macpherson menard zoltan oldest_to_newest 1004797 0 rhauck 2014-04-28 17:34:17 -0700 The attached test has this: -webkit-shape-margin: calc(25%*3 - 10in); getPropertyValue() on the computedStyle returns null. Simpler calc values are fine - for this one, remove the "- 10in" and the test passes. 1004798 1 230340 rhauck 2014-04-28 17:35:16 -0700 Created attachment 230340 test case for the bug 1004863 2 230359 zoltan 2014-04-29 00:23:54 -0700 Created attachment 230359 Patch 1004959 3 230359 bjonesbe 2014-04-29 08:45:45 -0700 Comment on attachment 230359 Patch r=me 1004971 4 230359 commit-queue 2014-04-29 09:16:39 -0700 Comment on attachment 230359 Patch Clearing flags on attachment: 230359 Committed r167935: <http://trac.webkit.org/changeset/167935> 1004972 5 commit-queue 2014-04-29 09:16:43 -0700 All reviewed patches have been landed. Closing bug. 230340 2014-04-28 17:35:16 -0700 2014-04-28 17:35:16 -0700 test case for the bug shape-margin-complex-calc-args.html text/html 995 rhauck PCFET0NUWVBFIGh0bWw+CjxodG1sPgogICAgPGhlYWQ+CiAgICAgICAgPHNjcmlwdCBzcmM9Ii9y ZXNvdXJjZXMvdGVzdGhhcm5lc3MuanMiPjwvc2NyaXB0PgogICAgICAgIDxzY3JpcHQgc3JjPSIv cmVzb3VyY2VzL3Rlc3RoYXJuZXNzcmVwb3J0LmpzIj48L3NjcmlwdD4KICAgIDwvaGVhZD4KICAg IDxib2R5PgogICAgICAgIDxkaXYgaWQ9ImxvZyI+PC9kaXY+CiAgICAgICAgPHNjcmlwdCB0eXBl PSJ0ZXh0L2phdmFzY3JpcHQiPgogICAgICAgICAgICB0ZXN0KGZ1bmN0aW9uKCkgewogICAgICAg ICAgICAgICAgdmFyIHRlc3RDYWxjVmFsdWUgPSAiY2FsYygyNSUqMyAtIDEwaW4pIjsKICAgICAg ICAgICAgICAgIHZhciBleHBlY3RlZCA9ICJjYWxjKDc1JSAtIDk2MHB4KSI7CiAgICAgICAgICAg ICAgICAKICAgICAgICAgICAgICAgIHZhciBkaXYgPSBkb2N1bWVudC5jcmVhdGVFbGVtZW50KCdk aXYnKTsKICAgICAgICAgICAgICAgIGRpdi5zdHlsZS5zZXRQcm9wZXJ0eSgnLXdlYmtpdC1zaGFw ZS1vdXRzaWRlJywgImJvcmRlci1ib3ggaW5zZXQoMTBweCkiKTsKICAgICAgICAgICAgICAgIGRp di5zdHlsZS5zZXRQcm9wZXJ0eSgnLXdlYmtpdC1zaGFwZS1tYXJnaW4nLCB0ZXN0Q2FsY1ZhbHVl KTsKICAgICAgICAgICAgICAgIGRvY3VtZW50LmJvZHkuYXBwZW5kQ2hpbGQoZGl2KTsKCiAgICAg ICAgICAgICAgICB2YXIgc3R5bGUgPSBnZXRDb21wdXRlZFN0eWxlKGRpdik7CiAgICAgICAgICAg ICAgICB2YXIgYWN0dWFsID0gc3R5bGUuZ2V0UHJvcGVydHlWYWx1ZSgnLXdlYmtpdC1zaGFwZS1t YXJnaW4nKTsKICAgICAgICAgICAgICAgIGRvY3VtZW50LmJvZHkucmVtb3ZlQ2hpbGQoZGl2KTsK CiAgICAgICAgICAgICAgICBhc3NlcnRfZXF1YWxzKGFjdHVhbCwgZXhwZWN0ZWQpOwogICAgICAg ICAgICB9LCAic2hhcGUtbWFyZ2luOiBjYWxjKDI1JSozIC0gMTBpbikiKTsKICAgICAgICA8L3Nj cmlwdD4KICAgIDwvYm9keT4KPC9odG1sPgo= 230359 2014-04-29 00:23:54 -0700 2014-04-29 09:16:39 -0700 Patch shapemarginfix.patch text/plain 3798 zoltan ZGlmZiAtLWdpdCBhL0xheW91dFRlc3RzL0NoYW5nZUxvZyBiL0xheW91dFRlc3RzL0NoYW5nZUxv ZwppbmRleCAxN2NmOWViLi4zM2Q0ZTliIDEwMDY0NAotLS0gYS9MYXlvdXRUZXN0cy9DaGFuZ2VM b2cKKysrIGIvTGF5b3V0VGVzdHMvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMTIgQEAKKzIwMTQtMDQt MjkgIFpvbHRhbiBIb3J2YXRoICA8em9sdGFuQHdlYmtpdC5vcmc+CisKKyAgICAgICAgW0NTUyBT aGFwZXNdIGNvbXBsZXggY2FsYyB2YWx1ZXMgZm9yIHNoYXBlLW1hcmdpbiByZXR1cm4gbnVsbCBm b3IgY29tcHV0ZWQgc3R5bGUKKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19i dWcuY2dpP2lkPTEzMjMxMworCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgor CisgICAgICAgICogZmFzdC9zaGFwZXMvcGFyc2luZy9wYXJzaW5nLXNoYXBlLW1hcmdpbi5odG1s OgorCiAyMDE0LTA0LTI4ICBDb21taXQgUXVldWUgIDxjb21taXQtcXVldWVAd2Via2l0Lm9yZz4K IAogICAgICAgICBVbnJldmlld2VkLCByb2xsaW5nIG91dCByMTY3ODcxLgpkaWZmIC0tZ2l0IGEv TGF5b3V0VGVzdHMvZmFzdC9zaGFwZXMvcGFyc2luZy9wYXJzaW5nLXNoYXBlLW1hcmdpbi1leHBl Y3RlZC50eHQgYi9MYXlvdXRUZXN0cy9mYXN0L3NoYXBlcy9wYXJzaW5nL3BhcnNpbmctc2hhcGUt bWFyZ2luLWV4cGVjdGVkLnR4dAppbmRleCAyNmU4NzI4Li42OTcwNTQ3IDEwMDY0NAotLS0gYS9M YXlvdXRUZXN0cy9mYXN0L3NoYXBlcy9wYXJzaW5nL3BhcnNpbmctc2hhcGUtbWFyZ2luLWV4cGVj dGVkLnR4dAorKysgYi9MYXlvdXRUZXN0cy9mYXN0L3NoYXBlcy9wYXJzaW5nL3BhcnNpbmctc2hh cGUtbWFyZ2luLWV4cGVjdGVkLnR4dApAQCAtMjEsNiArMjEsNyBAQCBQQVNTIGdldENvbXB1dGVk U3R5bGVWYWx1ZSgiLXdlYmtpdC1zaGFwZS1tYXJnaW4iLCAiMXB4IikgaXMgIjFweCIKIFBBU1Mg Z2V0Q29tcHV0ZWRTdHlsZVZhbHVlKCItd2Via2l0LXNoYXBlLW1hcmdpbiIsICItNWVtIikgaXMg IjBweCIKIFBBU1MgZ2V0Q29tcHV0ZWRTdHlsZVZhbHVlKCItd2Via2l0LXNoYXBlLW1hcmdpbiIs ICJpZGVudGlmaWVyIikgaXMgIjBweCIKIFBBU1MgZ2V0Q29tcHV0ZWRTdHlsZVZhbHVlKCItd2Vi a2l0LXNoYXBlLW1hcmdpbiIsICInc3RyaW5nJyIpIGlzICIwcHgiCitQQVNTIGdldENvbXB1dGVk U3R5bGVWYWx1ZSgiLXdlYmtpdC1zaGFwZS1tYXJnaW4iLCAiY2FsYygyNSUqMyAtIDEwaW4pIikg aXMgImNhbGMoNzUlIC0gOTYwcHgpIgogUEFTUyBnZXRDaGlsZENvbXB1dGVkU3R5bGUoIi13ZWJr aXQtc2hhcGUtbWFyZ2luIiwgIjAiLCAiMCIpIGlzICIwcHgiCiBQQVNTIGdldENoaWxkQ29tcHV0 ZWRTdHlsZSgiLXdlYmtpdC1zaGFwZS1tYXJnaW4iLCAiMCIsICIxcHgiKSBpcyAiMXB4IgogUEFT UyBnZXRDaGlsZENvbXB1dGVkU3R5bGUoIi13ZWJraXQtc2hhcGUtbWFyZ2luIiwgIjFweCIsICIt MWVtIikgaXMgIjBweCIKZGlmZiAtLWdpdCBhL0xheW91dFRlc3RzL2Zhc3Qvc2hhcGVzL3BhcnNp bmcvcGFyc2luZy1zaGFwZS1tYXJnaW4uaHRtbCBiL0xheW91dFRlc3RzL2Zhc3Qvc2hhcGVzL3Bh cnNpbmcvcGFyc2luZy1zaGFwZS1tYXJnaW4uaHRtbAppbmRleCA2MWY2MTRjLi4zZTJhN2NkIDEw MDY0NAotLS0gYS9MYXlvdXRUZXN0cy9mYXN0L3NoYXBlcy9wYXJzaW5nL3BhcnNpbmctc2hhcGUt bWFyZ2luLmh0bWwKKysrIGIvTGF5b3V0VGVzdHMvZmFzdC9zaGFwZXMvcGFyc2luZy9wYXJzaW5n LXNoYXBlLW1hcmdpbi5odG1sCkBAIC0yNyw3ICsyNyw4IEBAIGFwcGx5VG9FYWNoQXJnbGlzdCgK ICAgICAgWyItd2Via2l0LXNoYXBlLW1hcmdpbiIsICIxcHgiLCAiMXB4Il0sCiAgICAgIFsiLXdl YmtpdC1zaGFwZS1tYXJnaW4iLCAiLTVlbSIsICIwcHgiXSwKICAgICAgWyItd2Via2l0LXNoYXBl LW1hcmdpbiIsICJpZGVudGlmaWVyIiwgIjBweCJdLAotICAgICBbIi13ZWJraXQtc2hhcGUtbWFy Z2luIiwgIlwnc3RyaW5nXCciLCAiMHB4Il1dCisgICAgIFsiLXdlYmtpdC1zaGFwZS1tYXJnaW4i LCAiXCdzdHJpbmdcJyIsICIwcHgiXSwKKyAgICAgWyItd2Via2l0LXNoYXBlLW1hcmdpbiIsICJj YWxjKDI1JSozIC0gMTBpbikiLCAiY2FsYyg3NSUgLSA5NjBweCkiXV0KICk7CiAKIGFwcGx5VG9F YWNoQXJnbGlzdCgKZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJDb3JlL0NoYW5nZUxvZyBiL1NvdXJj ZS9XZWJDb3JlL0NoYW5nZUxvZwppbmRleCA2ZjAwZjMxLi43NDI1MDJhIDEwMDY0NAotLS0gYS9T b3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKKysrIGIvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCkBA IC0xLDMgKzEsMTggQEAKKzIwMTQtMDQtMjkgIFpvbHRhbiBIb3J2YXRoICA8em9sdGFuQHdlYmtp dC5vcmc+CisKKyAgICAgICAgW0NTUyBTaGFwZXNdIGNvbXBsZXggY2FsYyB2YWx1ZXMgZm9yIHNo YXBlLW1hcmdpbiByZXR1cm4gbnVsbCBmb3IgY29tcHV0ZWQgc3R5bGUKKyAgICAgICAgaHR0cHM6 Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTEzMjMxMworCisgICAgICAgIFJldmll d2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgIFdlIG5lZWQgdG8gcGFzcyBSZW5kZXJT dHlsZSogdG8gdGhlIGNzc1ZhbHVlUG9vbCB3aGVuIHBhcnNpbmcKKyAgICAgICAgc2hhcGUtbWFy Z2luIGluIG9yZGVyIHRvIHVzZSBjYWxjKCkgYXMgYSBwYXJhbWV0ZXIuCisKKyAgICAgICAgSSd2 ZSBhZGRlZCB0aGUgbmV3IHRlc3QgY2FzZSB0byBwYXJzaW5nLXNoYXBlLW1hcmdpbi5odG1sCisK KyAgICAgICAgKiBjc3MvQ1NTQ29tcHV0ZWRTdHlsZURlY2xhcmF0aW9uLmNwcDoKKyAgICAgICAg KFdlYkNvcmU6OkNvbXB1dGVkU3R5bGVFeHRyYWN0b3I6OnByb3BlcnR5VmFsdWUpOgorCiAyMDE0 LTA0LTI4ICBDb21taXQgUXVldWUgIDxjb21taXQtcXVldWVAd2Via2l0Lm9yZz4KIAogICAgICAg ICBVbnJldmlld2VkLCByb2xsaW5nIG91dCByMTY3ODcxLgpkaWZmIC0tZ2l0IGEvU291cmNlL1dl YkNvcmUvY3NzL0NTU0NvbXB1dGVkU3R5bGVEZWNsYXJhdGlvbi5jcHAgYi9Tb3VyY2UvV2ViQ29y ZS9jc3MvQ1NTQ29tcHV0ZWRTdHlsZURlY2xhcmF0aW9uLmNwcAppbmRleCAzYWI3NzE4Li4zYTcy YzBhIDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViQ29yZS9jc3MvQ1NTQ29tcHV0ZWRTdHlsZURlY2xh cmF0aW9uLmNwcAorKysgYi9Tb3VyY2UvV2ViQ29yZS9jc3MvQ1NTQ29tcHV0ZWRTdHlsZURlY2xh cmF0aW9uLmNwcApAQCAtMjgwNiw3ICsyODA2LDcgQEAgUGFzc1JlZlB0cjxDU1NWYWx1ZT4gQ29t cHV0ZWRTdHlsZUV4dHJhY3Rvcjo6cHJvcGVydHlWYWx1ZShDU1NQcm9wZXJ0eUlEIHByb3BlcnQK ICNlbmRpZgogI2lmIEVOQUJMRShDU1NfU0hBUEVTKQogICAgICAgICBjYXNlIENTU1Byb3BlcnR5 V2Via2l0U2hhcGVNYXJnaW46Ci0gICAgICAgICAgICByZXR1cm4gY3NzVmFsdWVQb29sKCkuY3Jl YXRlVmFsdWUoc3R5bGUtPnNoYXBlTWFyZ2luKCkpOworICAgICAgICAgICAgcmV0dXJuIGNzc1Zh bHVlUG9vbCgpLmNyZWF0ZVZhbHVlKHN0eWxlLT5zaGFwZU1hcmdpbigpLCBzdHlsZS5nZXQoKSk7 CiAgICAgICAgIGNhc2UgQ1NTUHJvcGVydHlXZWJraXRTaGFwZUltYWdlVGhyZXNob2xkOgogICAg ICAgICAgICAgcmV0dXJuIGNzc1ZhbHVlUG9vbCgpLmNyZWF0ZVZhbHVlKHN0eWxlLT5zaGFwZUlt YWdlVGhyZXNob2xkKCksIENTU1ByaW1pdGl2ZVZhbHVlOjpDU1NfTlVNQkVSKTsKICAgICAgICAg Y2FzZSBDU1NQcm9wZXJ0eVdlYmtpdFNoYXBlT3V0c2lkZToK