132309 2014-04-28 16:03:00 -0700 Scrollbars do not update properly when topContentInset changes dynamically 2014-04-28 21:10:12 -0700 1 1 1 Unclassified WebKit Layout and Rendering 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED InRadar P2 Normal --- 1 bdakin bdakin barraclough bdakin rniwa sam simon.fraser thorton oldest_to_newest 1004762 0 bdakin 2014-04-28 16:03:00 -0700 Scrollbars do not update properly when topContentInset changes dynamically. <rdar://problem/16642232> 1004763 1 230331 bdakin 2014-04-28 16:07:39 -0700 Created attachment 230331 Patch 1004766 2 230331 thorton 2014-04-28 16:10:04 -0700 Comment on attachment 230331 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=230331&action=review > Source/WebCore/page/FrameView.cpp:962 > + // To fully update scrollbars, we need to call both updateScrolbars() and frameViewDidChangeSize() which will > + // will update all of the scrolling-related layers. I don't think the comment is necessary. > Source/WebCore/page/FrameView.cpp:964 > + if (RenderView* renderView = this->renderView()) { We already have a local and already early returned for RenderView. 1004768 3 bdakin 2014-04-28 16:19:47 -0700 Thank you! http://trac.webkit.org/changeset/167911 1004818 4 rniwa 2014-04-28 18:23:46 -0700 Looks like this regressed PLT by ~2% 1004844 5 bdakin 2014-04-28 20:24:21 -0700 (In reply to comment #4) > Looks like this regressed PLT by ~2% This seems very unlikely… 1004847 6 rniwa 2014-04-28 21:10:12 -0700 (In reply to comment #5) > (In reply to comment #4) > > Looks like this regressed PLT by ~2% > > This seems very unlikely… Yeah, looks like it was a temporary fluke. The numbers look better now. 230331 2014-04-28 16:07:39 -0700 2014-04-28 16:10:04 -0700 Patch for-review.txt text/plain 1911 bdakin SW5kZXg6IFNvdXJjZS9XZWJDb3JlL0NoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBTb3VyY2UvV2Vi Q29yZS9DaGFuZ2VMb2cJKHJldmlzaW9uIDE2NzkxMCkKKysrIFNvdXJjZS9XZWJDb3JlL0NoYW5n ZUxvZwkod29ya2luZyBjb3B5KQpAQCAtMSwzICsxLDE4IEBACisyMDE0LTA0LTI4ICBCZXRoIERh a2luICA8YmRha2luQGFwcGxlLmNvbT4KKworICAgICAgICBTY3JvbGxiYXJzIGRvIG5vdCB1cGRh dGUgcHJvcGVybHkgd2hlbiB0b3BDb250ZW50SW5zZXQgY2hhbmdlcyBkeW5hbWljYWxseQorICAg ICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MTMyMzA5CisgICAg ICAgIC1hbmQgY29ycmVzcG9uZGluZy0KKyAgICAgICAgPHJkYXI6Ly9wcm9ibGVtLzE2NjQyMjMy PgorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgIEl0IGlz IG5vdCBzdWZmaWNpZW50IHRvIGRvIGEgbGF5b3V0IGFuZCBjYWxsIHVwZGF0ZVNjcm9sbGJhcnMo KS4gV2UgbXVzdCBhbHNvIGNhbGwgCisgICAgICAgIFJlbmRlckxheWVyQ29tcG9zaXRvcjo6ZnJh bWVWaWV3RGlkQ2hhbmdlU2l6ZSgpIGluIG9yZGVyIHRvIHByb3Blcmx5IGFkanVzdCB0aGUgCisg ICAgICAgIHNpemUgYW5kIHBvc2l0aW9uIG9mIGFsbCBvZiB0aGUgc2Nyb2xsaW5nLXJlbGF0ZWQg bGF5ZXJzLgorICAgICAgICAqIHBhZ2UvRnJhbWVWaWV3LmNwcDoKKyAgICAgICAgKFdlYkNvcmU6 OkZyYW1lVmlldzo6dG9wQ29udGVudEluc2V0RGlkQ2hhbmdlKToKKwogMjAxNC0wNC0yOCAgRGF2 aWQgSHlhdHQgIDxoeWF0dEBhcHBsZS5jb20+CiAKICAgICAgICAgW05ldyBNdWx0aWNvbHVtbl0g ZXZlbnQub2Zmc2V0WC9vZmZzZXRZIGRvbid0IHdvcmsgY29ycmVjdGx5CkluZGV4OiBTb3VyY2Uv V2ViQ29yZS9wYWdlL0ZyYW1lVmlldy5jcHAKPT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PQotLS0gU291cmNlL1dlYkNvcmUv cGFnZS9GcmFtZVZpZXcuY3BwCShyZXZpc2lvbiAxNjc5MDQpCisrKyBTb3VyY2UvV2ViQ29yZS9w YWdlL0ZyYW1lVmlldy5jcHAJKHdvcmtpbmcgY29weSkKQEAgLTk1NiwxMCArOTU2LDE1IEBAIHZv aWQgRnJhbWVWaWV3Ojp0b3BDb250ZW50SW5zZXREaWRDaGFuZ2UKICAgICBpZiAoIXJlbmRlclZp ZXcpCiAgICAgICAgIHJldHVybjsKICAgICAKLSAgICAvLyBGSVhNRTogPHJkYXI6Ly9wcm9ibGVt LzE2NjQyMjMyPiBUaGlzIGNhbGwgdG8gdXBkYXRlU2Nyb2xsYmFycygpIGlzIG5vdCBhY3R1YWxs eSBzdWZmaWNpZW50IHRvIGZpeAotICAgIC8vIHRoZSBzY3JvbGxiYXJzIGlmIHRoZSBjb250ZW50 SW5zZXQgY2hhbmdlcyBkeW5hbWljYWxseS4gCiAgICAgbGF5b3V0KCk7CisgICAgCisgICAgLy8g VG8gZnVsbHkgdXBkYXRlIHNjcm9sbGJhcnMsIHdlIG5lZWQgdG8gY2FsbCBib3RoIHVwZGF0ZVNj cm9sYmFycygpIGFuZCBmcmFtZVZpZXdEaWRDaGFuZ2VTaXplKCkgd2hpY2ggd2lsbAorICAgIC8v IHdpbGwgdXBkYXRlIGFsbCBvZiB0aGUgc2Nyb2xsaW5nLXJlbGF0ZWQgbGF5ZXJzLgogICAgIHVw ZGF0ZVNjcm9sbGJhcnMoc2Nyb2xsT2Zmc2V0KCkpOworICAgIGlmIChSZW5kZXJWaWV3KiByZW5k ZXJWaWV3ID0gdGhpcy0+cmVuZGVyVmlldygpKSB7CisgICAgICAgIGlmIChyZW5kZXJWaWV3LT51 c2VzQ29tcG9zaXRpbmcoKSkKKyAgICAgICAgICAgIHJlbmRlclZpZXctPmNvbXBvc2l0b3IoKS5m cmFtZVZpZXdEaWRDaGFuZ2VTaXplKCk7CisgICAgfQogfQogICAgIAogYm9vbCBGcmFtZVZpZXc6 Omhhc0NvbXBvc2l0ZWRDb250ZW50KCkgY29uc3QK