132304 2014-04-28 14:47:35 -0700 [WK2 iOS] Need to show title in the action sheet for images not inside an anchor element. 2014-04-28 15:01:06 -0700 1 1 1 Unclassified WebKit WebKit2 528+ (Nightly build) iPhone / iPad Unspecified NEW InRadar P2 Normal --- 1 enrica webkit-unassigned oldest_to_newest 1004738 0 enrica 2014-04-28 14:47:35 -0700 We need to implement the same logic we had in WebKit1. If the image is not inside an anchor tag, we must show the content of the title attribute as action sheet title. <rdar://problem/16535227> 1004739 1 230324 enrica 2014-04-28 14:49:33 -0700 Created attachment 230324 Patch 1004743 2 230324 benjamin 2014-04-28 14:53:04 -0700 Comment on attachment 230324 Patch +1, I like that feature :) 1004747 3 enrica 2014-04-28 15:01:06 -0700 Committed revision 167909. 230324 2014-04-28 14:49:33 -0700 2014-04-28 14:53:03 -0700 Patch imagetitle.txt text/plain 1591 enrica SW5kZXg6IFNvdXJjZS9XZWJLaXQyL0NoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBTb3VyY2UvV2Vi S2l0Mi9DaGFuZ2VMb2cJKHJldmlzaW9uIDE2NzkwNykKKysrIFNvdXJjZS9XZWJLaXQyL0NoYW5n ZUxvZwkod29ya2luZyBjb3B5KQpAQCAtMSwzICsxLDE3IEBACisyMDE0LTA0LTI4ICBFbnJpY2Eg Q2FzdWNjaSAgPGVucmljYUBhcHBsZS5jb20+CisKKyAgICAgICAgW1dLMiBpT1NdIE5lZWQgdG8g c2hvdyB0aXRsZSBpbiB0aGUgYWN0aW9uIHNoZWV0IGZvciBpbWFnZXMgbm90IGluc2lkZSBhbiBh bmNob3IgZWxlbWVudC4KKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcu Y2dpP2lkPTEzMjMwNAorICAgICAgICA8cmRhcjovL3Byb2JsZW0vMTY1MzUyMjc+CisKKyAgICAg ICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgSWYgdGhlIGltYWdlIGlu IG5vdCBpbnNpZGUgYW4gYW5jaG9yIHRhZywgd2UgbXVzdCB1c2UgdGhlIHRpdGxlIGF0dHJpYnV0 ZSBhcworICAgICAgICB0aXRsZSBmb3IgdGhlIGFjdGlvbiBzaGVldC4KKworICAgICAgICAqIFVJ UHJvY2Vzcy9pb3MvV0tBY3Rpb25TaGVldEFzc2lzdGFudC5tbToKKyAgICAgICAgKC1bV0tBY3Rp b25TaGVldEFzc2lzdGFudCBfY3JlYXRlU2hlZXRXaXRoRWxlbWVudEFjdGlvbnM6c2hvd0xpbmtU aXRsZTpdKToKKwogMjAxNC0wNC0yOCAgVGltIEhvcnRvbiAgPHRpbW90aHlfaG9ydG9uQGFwcGxl LmNvbT4KIAogICAgICAgICBXZWJLaXQyIFZpZXcgR2VzdHVyZXMgKFN3aXBlKTogRGlzY2FyZCBz bmFwc2hvdHMgbWFkZSB3aXRoIGEgZGlmZmVyZW50IHZpZXcgc2l6ZS9waXhlbCBkZW5zaXR5Cklu ZGV4OiBTb3VyY2UvV2ViS2l0Mi9VSVByb2Nlc3MvaW9zL1dLQWN0aW9uU2hlZXRBc3Npc3RhbnQu bW0KPT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PQotLS0gU291cmNlL1dlYktpdDIvVUlQcm9jZXNzL2lvcy9XS0FjdGlvblNo ZWV0QXNzaXN0YW50Lm1tCShyZXZpc2lvbiAxNjc5MDMpCisrKyBTb3VyY2UvV2ViS2l0Mi9VSVBy b2Nlc3MvaW9zL1dLQWN0aW9uU2hlZXRBc3Npc3RhbnQubW0JKHdvcmtpbmcgY29weSkKQEAgLTE5 Miw3ICsxOTIsNyBAQCAtICh2b2lkKV9jcmVhdGVTaGVldFdpdGhFbGVtZW50QWN0aW9uczooCiAK ICAgICBOU1N0cmluZyAqdGl0bGVTdHJpbmcgPSBuaWw7CiAgICAgQk9PTCB0aXRsZUlzVVJMID0g Tk87Ci0gICAgaWYgKHNob3dMaW5rVGl0bGUpIHsKKyAgICBpZiAoc2hvd0xpbmtUaXRsZSAmJiBb W3RhcmdldFVSTCBhYnNvbHV0ZVN0cmluZ10gbGVuZ3RoXSkgewogICAgICAgICBpZiAoaXNKYXZh U2NyaXB0VVJMKQogICAgICAgICAgICAgdGl0bGVTdHJpbmcgPSBXRUJfVUlfU1RSSU5HX0tFWSgi SmF2YVNjcmlwdCIsICJKYXZhU2NyaXB0IEFjdGlvbiBTaGVldCBUaXRsZSIsICJUaXRsZSBmb3Ig YWN0aW9uIHNoZWV0IGZvciBKYXZhU2NyaXB0IGxpbmsiKTsKICAgICAgICAgZWxzZSB7Cg==