132303 2014-04-28 14:33:59 -0700 Fix a failure with python3 2014-04-28 14:51:13 -0700 1 1 1 Unclassified WebKit JavaScriptCore 528+ (Nightly build) Unspecified Unspecified NEW P2 Normal --- 1 jerome webkit-unassigned commit-queue oldest_to_newest 1004734 0 230323 jerome 2014-04-28 14:33:59 -0700 Created attachment 230323 Patch Same logic as with bug 106645. Please forgive the non-svn diff, I'm on a terrible connection at the moment and unable to download the full webkit sources. Fixes the following failure: File ".../JavaScriptCore/disassembler/udis86/itab.py", line 347, in genItab self.genItabH() File ".../JavaScriptCore/disassembler/udis86/itab.py", line 318, in genItabH operands.sort() AttributeError: 'dict_keys' object has no attribute 'sort' Makefile.JavaScriptCore.DerivedSources:730: recipe for target 'generated/udis86_itab.c' failed make[2]: *** [generated/udis86_itab.c] Error 1 1004737 1 jerome 2014-04-28 14:44:24 -0700 This could actually just be updated against upstream, by the way. https://github.com/vmt/udis86/blob/master/scripts/ud_itab.py 1004742 2 commit-queue 2014-04-28 14:51:13 -0700 Attachment 230323 did not pass style-queue: Total errors found: 0 in 0 files If any of these errors are false positives, please file a bug against check-webkit-style. 230323 2014-04-28 14:33:59 -0700 2014-04-28 14:33:59 -0700 Patch webkit-jsc-python3-fix.patch text/plain 527 jerome LS0tIGl0YWIucHkub2xkIDIwMTQtMDQtMjggMjI6Mjg6NDMuMjI0NDIxNTQwICswMTAwCisrKyBp dGFiLnB5ICAgICAyMDE0LTA0LTI4IDIyOjMwOjMzLjMyNzA1Mjc2MCArMDEwMApAQCAtMzE0LDgg KzMxNCw3IEBACiAgICAgICAgIHNlbGYuSXRhYkgud3JpdGUoICJcbiIgKQogCiAgICAgICAgIHNl bGYuSXRhYkgud3JpdGUoIlxuLyogaXRhYiBlbnRyeSBvcGVyYW5kIGRlZmluaXRpb25zICovXG4i KTsKLSAgICAgICAgb3BlcmFuZHMgPSBzZWxmLk9wZXJhbmREaWN0LmtleXMoKQotICAgICAgICBv cGVyYW5kcy5zb3J0KCkKKyAgICAgICAgb3BlcmFuZHMgPSBzb3J0ZWQoc2VsZi5PcGVyYW5kRGlj dC5rZXlzKCkpCiAgICAgICAgIGZvciBvIGluIG9wZXJhbmRzOgogICAgICAgICAgICAgc2VsZi5J dGFiSC53cml0ZSgiI2RlZmluZSBPXyUtN3MgeyAlLTEycyAlLThzIH1cbiIgJQogICAgICAgICAg ICAgICAgICAgICAobywgc2VsZi5PcGVyYW5kRGljdFtvXVswXSArICIsIiwgc2VsZi5PcGVyYW5k RGljdFtvXVsxXSkpOwo=