132300 2014-04-28 13:32:56 -0700 REGRESSION (r167751): svn-create-patch is very slow 2014-04-29 09:51:27 -0700 1 1 1 Unclassified WebKit Tools / Tests 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 131115 1 ap sam commit-queue dbates jcraig sam oldest_to_newest 1004715 0 ap 2014-04-28 13:32:56 -0700 svn-create-patch has become very slow, now that it runs check-webkit-style. This is very annoying, especially because I frequently apply and unapply WIP patches locally. 1004719 1 jcraig 2014-04-28 13:40:34 -0700 Weren't you one of the people who suggested running check-webkit-style should be the default? I don't think this bug is actionable unless you're requesting we change that. There is a --no-style flag that you can call or add as a default parameter to your bash profile. 1004720 2 jcraig 2014-04-28 13:42:29 -0700 IOW, this is not any slower than running svn-create-patch + check-webkit-style. If your issue is that check-webkit-style is too slow, that seems like another matter. Which are you requesting? 1004744 3 ap 2014-04-28 14:53:08 -0700 > Weren't you one of the people who suggested running check-webkit-style should be the default? If I was, this demonstrates that this was not such a good idea. I didn't know that check-webkit-style was so slow and buggy. Another use case where this is very annoying is running svn-create-patch to simply see what the current state of the tree is (what did I do?) > Which are you requesting? Given the current state of check-webkit-style, seems like it should not be invoked by svn-create-patch by default. Changing bash profile on every machine just to make svn-create-patch not slow doesn't seem like the right workaround. 1004757 4 230329 sam 2014-04-28 15:42:43 -0700 Created attachment 230329 Patch 1004758 5 sam 2014-04-28 15:44:10 -0700 (In reply to comment #2) > IOW, this is not any slower than running svn-create-patch + check-webkit-style. If your issue is that check-webkit-style is too slow, that seems like another matter. Which are you requesting? The real issue here is that svn-create-patch + check-webkit-style is not everyone's workflow. I use svn-create-patch to stash files away all the time, and don't need a style check run. 1004759 6 230329 jcraig 2014-04-28 15:54:27 -0700 Comment on attachment 230329 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=230329&action=review > Tools/Scripts/svn-create-patch:80 > +my $checkWebKitStyle = 0; This is used as a boolean, so you can just remove " = 1" instead of setting it to 0. 1004992 7 sam 2014-04-29 09:50:51 -0700 Committed r167939: <http://trac.webkit.org/changeset/167939> 1004994 8 sam 2014-04-29 09:51:27 -0700 (In reply to comment #6) > (From update of attachment 230329 [details]) > View in context: https://bugs.webkit.org/attachment.cgi?id=230329&action=review > > > Tools/Scripts/svn-create-patch:80 > > +my $checkWebKitStyle = 0; > > This is used as a boolean, so you can just remove " = 1" instead of setting it to 0. I prefer it to be more explicit. 230329 2014-04-28 15:42:43 -0700 2014-04-28 15:54:27 -0700 Patch bug-132300-20140428154221.patch text/plain 1167 sam SW5kZXg6IFRvb2xzL0NoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBUb29scy9DaGFuZ2VMb2cJKHJl dmlzaW9uIDE2NzkxMCkKKysrIFRvb2xzL0NoYW5nZUxvZwkod29ya2luZyBjb3B5KQpAQCAtMSwz ICsxLDE0IEBACisyMDE0LTA0LTI4ICBTYW0gV2VpbmlnICA8c2FtQHdlYmtpdC5vcmc+CisKKyAg ICAgICAgUkVHUkVTU0lPTiAocjE2Nzc1MSk6IHN2bi1jcmVhdGUtcGF0Y2ggaXMgdmVyeSBzbG93 CisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0xMzIzMDAK KworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICAqIFNjcmlw dHMvc3ZuLWNyZWF0ZS1wYXRjaDoKKyAgICAgICAgQ2hhbmdlIGRlZmF1bHQgYmVoYXZpb3Igb2Yg c3ZuLWNyZWF0ZS1wYXRjaCB0byBubyBsb25nZXIgcnVuIHRoZSBzdHlsZSBjaGVja2VyLiBJdCBj YW4gc3RpbGwgYmUgcnVuCisgICAgICAgIGJ5IGNhbGxpbmcgYHN2bi1jcmVhdGUtcGF0Y2ggLS1z dHlsZWAuCisKIDIwMTQtMDQtMjggIEZpbGlwIFBpemxvICA8ZnBpemxvQGFwcGxlLmNvbT4KIAog ICAgICAgICBNYWtlIHN1cmUgdGhhdCB0aGUgY292ZXJhZ2Ugb2Ygb3VyIHRlc3RzIGRvZXNuJ3Qg Y2hhbmdlIG11Y2ggaWYgd2UgY2hhbmdlIHRoZSB0aHJlc2hvbGRzIG5vdyBhbmQgaW4gdGhlIGZ1 dHVyZSwgYnV0IG1ha2luZwpJbmRleDogVG9vbHMvU2NyaXB0cy9zdm4tY3JlYXRlLXBhdGNoCj09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT0KLS0tIFRvb2xzL1NjcmlwdHMvc3ZuLWNyZWF0ZS1wYXRjaAkocmV2aXNpb24gMTY3 ODQ1KQorKysgVG9vbHMvU2NyaXB0cy9zdm4tY3JlYXRlLXBhdGNoCSh3b3JraW5nIGNvcHkpCkBA IC03Nyw3ICs3Nyw3IEBAIHN1YiB0ZXN0ZmlsZWNtcCgkJCk7CiAkRU5WeydMQ19BTEwnfSA9ICdD JzsKIAogbXkgJHNob3dIZWxwOwotbXkgJGNoZWNrV2ViS2l0U3R5bGUgPSAxOworbXkgJGNoZWNr V2ViS2l0U3R5bGUgPSAwOwogbXkgJGlnbm9yZUNoYW5nZWxvZ3MgPSAwOwogbXkgJGRldk51bGwg PSBGaWxlOjpTcGVjLT5kZXZudWxsKCk7CiAK