132296 2014-04-28 12:29:17 -0700 WK2 iOS: crash when handling a synthetic keyboard event 2014-04-28 15:02:58 -0700 1 1 1 Unclassified WebKit WebKit2 528+ (Nightly build) iPhone / iPad Unspecified RESOLVED FIXED InRadar P2 Normal --- 1 enrica enrica oldest_to_newest 1004692 0 enrica 2014-04-28 12:29:17 -0700 A synthetic keyboard event does not contain a valid platform keyboard event. We should null check keyEvent() before dereferencing, like we already do on Mac. <rdar://problem/16469726> 1004694 1 230317 enrica 2014-04-28 12:33:11 -0700 Created attachment 230317 Patch 1004748 2 enrica 2014-04-28 15:02:58 -0700 Committed revision 167903 230317 2014-04-28 12:33:11 -0700 2014-04-28 12:42:48 -0700 Patch synthetickbevent-crash.txt text/plain 2090 enrica SW5kZXg6IFNvdXJjZS9XZWJLaXQyL0NoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBTb3VyY2UvV2Vi S2l0Mi9DaGFuZ2VMb2cJKHJldmlzaW9uIDE2Nzg5NykKKysrIFNvdXJjZS9XZWJLaXQyL0NoYW5n ZUxvZwkod29ya2luZyBjb3B5KQpAQCAtMSwzICsxLDE3IEBACisyMDE0LTA0LTI4ICBFbnJpY2Eg Q2FzdWNjaSAgPGVucmljYUBhcHBsZS5jb20+CisKKyAgICAgICAgV0syIGlPUzogY3Jhc2ggd2hl biBoYW5kbGluZyBhIHN5bnRoZXRpYyBrZXlib2FyZCBldmVudC4KKyAgICAgICAgaHR0cHM6Ly9i dWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTEzMjI5NgorICAgICAgICA8cmRhcjovL3By b2JsZW0vMTY0Njk3MjY+CisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisK KyAgICAgICAgQWRkaW5nIGEgbnVsbCBjaGVjaywgc2luY2Ugc3ludGhldGljIGtleWJvYXJkIGV2 ZW50cyBkbyBub3QKKyAgICAgICAgaGF2ZSBhIGNvcnJlc3BvbmRpbmcgcGxhdGZvcm0gZXZlbnQu IFdlIGFscmVhZHkgZG8gdGhpcyBvbiBPUyBYLgorCisgICAgICAgICogV2ViUHJvY2Vzcy9XZWJQ YWdlL2lvcy9XZWJQYWdlSU9TLm1tOgorICAgICAgICAoV2ViS2l0OjpXZWJQYWdlOjpoYW5kbGVF ZGl0aW5nS2V5Ym9hcmRFdmVudCk6CisKIDIwMTQtMDQtMjggIEJyYWR5IEVpZHNvbiAgPGJlaWRz b25AYXBwbGUuY29tPgogCiAgICAgICAgIEhpZGUgc2VydmljZSBjb250cm9scyBmb3Igc2VsZWN0 aW9uIGJlaGluZCBhIHJ1bnRpbWUgc3dpdGNoCkluZGV4OiBTb3VyY2UvV2ViS2l0Mi9XZWJQcm9j ZXNzL1dlYlBhZ2UvaW9zL1dlYlBhZ2VJT1MubW0KPT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PQotLS0gU291cmNlL1dlYktp dDIvV2ViUHJvY2Vzcy9XZWJQYWdlL2lvcy9XZWJQYWdlSU9TLm1tCShyZXZpc2lvbiAxNjc4MzUp CisrKyBTb3VyY2UvV2ViS2l0Mi9XZWJQcm9jZXNzL1dlYlBhZ2UvaW9zL1dlYlBhZ2VJT1MubW0J KHdvcmtpbmcgY29weSkKQEAgLTE1NCw5ICsxNTQsMTMgQEAgYm9vbCBXZWJQYWdlOjphbGxvd3NV c2VyU2NhbGluZygpIGNvbnN0CiAKIGJvb2wgV2ViUGFnZTo6aGFuZGxlRWRpdGluZ0tleWJvYXJk RXZlbnQoS2V5Ym9hcmRFdmVudCogZXZlbnQpCiB7CisgICAgY29uc3QgUGxhdGZvcm1LZXlib2Fy ZEV2ZW50KiBwbGF0Zm9ybUV2ZW50ID0gZXZlbnQtPmtleUV2ZW50KCk7CisgICAgaWYgKCFwbGF0 Zm9ybUV2ZW50KQorICAgICAgICByZXR1cm4gZmFsc2U7CisKICAgICAvLyBGSVhNRTogSW50ZXJw cmV0IHRoZSBldmVudCBpbW1lZGlhdGVseSB1cG9uIHJlY2VpdmluZyBpdCBpbiBVSSBwcm9jZXNz LCB3aXRob3V0IHNlbmRpbmcgdG8gV2ViUHJvY2VzcyBmaXJzdC4KICAgICBib29sIGV2ZW50V2Fz SGFuZGxlZCA9IGZhbHNlOwotICAgIGJvb2wgc2VuZFJlc3VsdCA9IFdlYlByb2Nlc3M6OnNoYXJl ZCgpLnBhcmVudFByb2Nlc3NDb25uZWN0aW9uKCktPnNlbmRTeW5jKE1lc3NhZ2VzOjpXZWJQYWdl UHJveHk6OkludGVycHJldEtleUV2ZW50KGVkaXRvclN0YXRlKCksIGV2ZW50LT5rZXlFdmVudCgp LT50eXBlKCkgPT0gUGxhdGZvcm1LZXlib2FyZEV2ZW50OjpDaGFyKSwKKyAgICBib29sIHNlbmRS ZXN1bHQgPSBXZWJQcm9jZXNzOjpzaGFyZWQoKS5wYXJlbnRQcm9jZXNzQ29ubmVjdGlvbigpLT5z ZW5kU3luYyhNZXNzYWdlczo6V2ViUGFnZVByb3h5OjpJbnRlcnByZXRLZXlFdmVudChlZGl0b3JT dGF0ZSgpLCBwbGF0Zm9ybUV2ZW50LT50eXBlKCkgPT0gUGxhdGZvcm1LZXlib2FyZEV2ZW50OjpD aGFyKSwKICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAg ICAgICAgICAgICAgICAgICAgICAgICAgICAgICBNZXNzYWdlczo6V2ViUGFnZVByb3h5OjpJbnRl cnByZXRLZXlFdmVudDo6UmVwbHkoZXZlbnRXYXNIYW5kbGVkKSwgbV9wYWdlSUQpOwogICAgIGlm ICghc2VuZFJlc3VsdCkKICAgICAgICAgcmV0dXJuIGZhbHNlOwo=