132294 2014-04-28 12:07:21 -0700 Don't immediately snapshot plugin to allow for proper dominant plugin detection. 2014-04-29 15:15:36 -0700 1 1 1 Unclassified WebKit Plug-ins 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED InRadar P2 Normal --- 131871 1 roger_fong webkit-unassigned dino roger_fong webkit-bug-importer oldest_to_newest 1004684 0 roger_fong 2014-04-28 12:07:21 -0700 Currently we immediately set the display state to displaying snapshot if the max number of snapshot retries is 0. However, this causes timing problems. Namely, it causes hit testing to fail because the hit test needs to happen with the original plugin element. If we instead call beginSnapshottingRunningPlugin, we allow the page some time to perform the hit test with the plugin element before snapshotting. I've only seen this affect layout tests, where we explicitly set the max number of snapshot retries to 0. This fix will allow us to enable snapshotting tests. 1004685 1 webkit-bug-importer 2014-04-28 12:07:58 -0700 <rdar://problem/16745679> 1004690 2 230316 roger_fong 2014-04-28 12:21:09 -0700 Created attachment 230316 patch 1005158 3 roger_fong 2014-04-29 15:15:36 -0700 http://trac.webkit.org/changeset/167961 230316 2014-04-28 12:21:09 -0700 2014-04-29 05:18:03 -0700 patch patch.patch text/plain 1570 roger_fong SW5kZXg6IFNvdXJjZS9XZWJLaXQyL0NoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBTb3VyY2UvV2Vi S2l0Mi9DaGFuZ2VMb2cJKHJldmlzaW9uIDE2Nzg2OCkKKysrIFNvdXJjZS9XZWJLaXQyL0NoYW5n ZUxvZwkod29ya2luZyBjb3B5KQpAQCAtMSwzICsxLDE2IEBACisyMDE0LTA0LTI3ICBSb2dlciBG b25nICA8cm9nZXJfZm9uZ0BhcHBsZS5jb20+CisKKyAgICAgICAgRG9uJ3QgaW1tZWRpYXRlbHkg c25hcHNob3QgcGx1Z2luIHRvIGFsbG93IGZvciBwcm9wZXIgZG9taW5hbnQgcGx1Z2luIGRldGVj dGlvbi4KKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTEz MjI5NC4KKyAgICAgICAgPHJkYXI6Ly9wcm9ibGVtLzE2NzQ1Njc5PgorCisgICAgICAgIFJldmll d2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgICogV2ViUHJvY2Vzcy9QbHVnaW5zL1Bs dWdpblZpZXcuY3BwOgorICAgICAgICAoV2ViS2l0OjpQbHVnaW5WaWV3OjpkaWRJbml0aWFsaXpl UGx1Z2luKToKKyAgICAgICAgSW5zdGVhZCBvZiBpbW1lZGlhdGVseSBzZXR0aW5nIHRoZSBkaXNw bGF5IHN0YXRlIHRvIERpc3BsYXlTbmFwc2hvdCwKKyAgICAgICAgcHV0IGl0IG9uIGEgdGltZXIg dG8gbGV0IHRoZSBwYWdlIGZ1bGx5IGxheW91dCBhbmQgZ2V0IGhpdCB0ZXN0IHByb3Blcmx5Lgor CiAyMDE0LTA0LTI3ICBFdW5taSBMZWUgIDxldW5taTE1LmxlZUBzYW1zdW5nLmNvbT4KIAogICAg ICAgICBUb3VjaEV2ZW50IGlzIG5vdCBoYW5kbGVkIGFmdGVyIHJlbGVhc2luZyBhbnkgcG9pbnQg YW1vbmcgdG91Y2hlZCBwb2ludHMuCkluZGV4OiBTb3VyY2UvV2ViS2l0Mi9XZWJQcm9jZXNzL1Bs dWdpbnMvUGx1Z2luVmlldy5jcHAKPT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PQotLS0gU291cmNlL1dlYktpdDIvV2ViUHJv Y2Vzcy9QbHVnaW5zL1BsdWdpblZpZXcuY3BwCShyZXZpc2lvbiAxNjc4NjgpCisrKyBTb3VyY2Uv V2ViS2l0Mi9XZWJQcm9jZXNzL1BsdWdpbnMvUGx1Z2luVmlldy5jcHAJKHdvcmtpbmcgY29weSkK QEAgLTYyMiw3ICs2MjIsNyBAQCB2b2lkIFBsdWdpblZpZXc6OmRpZEluaXRpYWxpemVQbHVnaW4o KQogICAgICAgICAgICAgbV9wbHVnaW5FbGVtZW50LT5zZXROZWVkc1N0eWxlUmVjYWxjKFN5bnRo ZXRpY1N0eWxlQ2hhbmdlKTsKICAgICAgICAgfQogICAgICAgICBpZiAoZnJhbWUoKSAmJiAhZnJh bWUoKS0+c2V0dGluZ3MoKS5tYXhpbXVtUGx1Z0luU25hcHNob3RBdHRlbXB0cygpKSB7Ci0gICAg ICAgICAgICBtX3BsdWdpbkVsZW1lbnQtPnNldERpc3BsYXlTdGF0ZShIVE1MUGx1Z0luRWxlbWVu dDo6RGlzcGxheWluZ1NuYXBzaG90KTsKKyAgICAgICAgICAgIGJlZ2luU25hcHNob3R0aW5nUnVu bmluZ1BsdWdpbigpOwogICAgICAgICAgICAgcmV0dXJuOwogICAgICAgICB9CiAgICAgICAgIG1f cGx1Z2luU25hcHNob3RUaW1lci5yZXN0YXJ0KCk7Cg==