132291 2014-04-28 11:07:11 -0700 Hide service controls for selection behind a runtime switch 2014-04-28 11:46:14 -0700 1 1 1 Unclassified WebKit WebKit2 528+ (Nightly build) Mac All RESOLVED FIXED InRadar P2 Normal --- 1 beidson beidson commit-queue oldest_to_newest 1004666 0 beidson 2014-04-28 11:07:11 -0700 Hide service controls for selection behind a runtime switch This is to allow disabling the UI by default during development. <rdar://problem/16736616> 1004668 1 230312 beidson 2014-04-28 11:10:25 -0700 Created attachment 230312 Patch v1 1004681 2 230312 commit-queue 2014-04-28 11:46:12 -0700 Comment on attachment 230312 Patch v1 Clearing flags on attachment: 230312 Committed r167896: <http://trac.webkit.org/changeset/167896> 1004682 3 commit-queue 2014-04-28 11:46:14 -0700 All reviewed patches have been landed. Closing bug. 230312 2014-04-28 11:10:25 -0700 2014-04-28 11:46:12 -0700 Patch v1 patch text/plain 4537 beidson ZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJLaXQyL0NoYW5nZUxvZyBiL1NvdXJjZS9XZWJLaXQyL0No YW5nZUxvZwppbmRleCBjMGNhMzE0Li4yM2EzY2Q4IDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViS2l0 Mi9DaGFuZ2VMb2cKKysrIGIvU291cmNlL1dlYktpdDIvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMjIg QEAKKzIwMTQtMDQtMjggIEJyYWR5IEVpZHNvbiAgPGJlaWRzb25AYXBwbGUuY29tPgorCisgICAg ICAgIEhpZGUgc2VydmljZSBjb250cm9scyBmb3Igc2VsZWN0aW9uIGJlaGluZCBhIHJ1bnRpbWUg c3dpdGNoCisgICAgICAgIDxyZGFyOi8vcHJvYmxlbS8xNjczNjYxNj4gYW5kIGh0dHBzOi8vYnVn cy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0xMzIyOTEKKworICAgICAgICBSZXZpZXdlZCBi eSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICAqIFNoYXJlZC9XZWJQcmVmZXJlbmNlc1N0b3Jl Lmg6CisKKyAgICAgICAgKiBXZWJQcm9jZXNzL1dlYkNvcmVTdXBwb3J0L1dlYkVkaXRvckNsaWVu dC5jcHA6CisgICAgICAgIChXZWJLaXQ6OldlYkVkaXRvckNsaWVudDo6c2VsZWN0aW9uUmVjdHNE aWRDaGFuZ2UpOiBEbyBub3RoaW5nIGlmIHRoZSBVSSBpcyBkaXNhYmxlZC4KKworICAgICAgICAq IFdlYlByb2Nlc3MvV2ViUGFnZS9XZWJQYWdlLmNwcDoKKyAgICAgICAgKFdlYktpdDo6V2ViUGFn ZTo6V2ViUGFnZSk6CisgICAgICAgIChXZWJLaXQ6OldlYlBhZ2U6OnVwZGF0ZVByZWZlcmVuY2Vz KToKKworICAgICAgICAqIFdlYlByb2Nlc3MvV2ViUGFnZS9XZWJQYWdlLmg6CisgICAgICAgIChX ZWJLaXQ6OldlYlBhZ2U6OnNlcnZpY2VDb250cm9sc0VuYWJsZWQpOgorCiAyMDE0LTA0LTI4ICBa YW4gRG9iZXJzZWsgIDx6ZG9iZXJzZWtAaWdhbGlhLmNvbT4KIAogICAgICAgICBbV0syXVtYMTFd IE5ldHNjYXBlUGx1Z2luTW9kdWxlOjpzY2FuUGx1Z2luKCkgc2hvdWxkIHdyaXRlIFVURi04IHN0 cmluZ3MgdG8gc3Rkb3V0CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViS2l0Mi9TaGFyZWQvV2ViUHJl ZmVyZW5jZXNTdG9yZS5oIGIvU291cmNlL1dlYktpdDIvU2hhcmVkL1dlYlByZWZlcmVuY2VzU3Rv cmUuaAppbmRleCA3NzRjNTI3Li5iOWUxNWRlIDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViS2l0Mi9T aGFyZWQvV2ViUHJlZmVyZW5jZXNTdG9yZS5oCisrKyBiL1NvdXJjZS9XZWJLaXQyL1NoYXJlZC9X ZWJQcmVmZXJlbmNlc1N0b3JlLmgKQEAgLTIyNSw2ICsyMjUsNyBAQCBuYW1lc3BhY2UgV2ViS2l0 IHsKICAgICBtYWNybyhQYXNzd29yZEVjaG9FbmFibGVkLCBwYXNzd29yZEVjaG9FbmFibGVkLCBC b29sLCBib29sLCBERUZBVUxUX1BBU1NXT1JEX0VDSE9fRU5BQkxFRCkgXAogICAgIG1hY3JvKElt YWdlQ29udHJvbHNFbmFibGVkLCBpbWFnZUNvbnRyb2xzRW5hYmxlZCwgQm9vbCwgYm9vbCwgZmFs c2UpIFwKICAgICBtYWNybyhFbmFibGVJbmhlcml0VVJJUXVlcnlDb21wb25lbnQsIGVuYWJsZUlu aGVyaXRVUklRdWVyeUNvbXBvbmVudCwgQm9vbCwgYm9vbCwgZmFsc2UpIFwKKyAgICBtYWNybyhT ZXJ2aWNlQ29udHJvbHNFbmFibGVkLCBzZXJ2aWNlQ29udHJvbHNFbmFibGVkLCBCb29sLCBib29s LCBmYWxzZSkgXAogCiAjZGVmaW5lIEZPUl9FQUNIX1dFQktJVF9ET1VCTEVfUFJFRkVSRU5DRSht YWNybykgXAogICAgIG1hY3JvKFBERlNjYWxlRmFjdG9yLCBwZGZTY2FsZUZhY3RvciwgRG91Ymxl LCBkb3VibGUsIDApIFwKZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJLaXQyL1dlYlByb2Nlc3MvV2Vi Q29yZVN1cHBvcnQvV2ViRWRpdG9yQ2xpZW50LmNwcCBiL1NvdXJjZS9XZWJLaXQyL1dlYlByb2Nl c3MvV2ViQ29yZVN1cHBvcnQvV2ViRWRpdG9yQ2xpZW50LmNwcAppbmRleCA3ZGFkN2M0Li45ZGY1 OTI1IDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViS2l0Mi9XZWJQcm9jZXNzL1dlYkNvcmVTdXBwb3J0 L1dlYkVkaXRvckNsaWVudC5jcHAKKysrIGIvU291cmNlL1dlYktpdDIvV2ViUHJvY2Vzcy9XZWJD b3JlU3VwcG9ydC9XZWJFZGl0b3JDbGllbnQuY3BwCkBAIC01MzUsNyArNTM1LDggQEAgdm9pZCBX ZWJFZGl0b3JDbGllbnQ6OnNlbGVjdGVkVGVsZXBob25lTnVtYmVyUmFuZ2VzQ2hhbmdlZChjb25z dCBWZWN0b3I8UmVmUHRyPFIKICNpZiBFTkFCTEUoU0VSVklDRV9DT05UUk9MUykKIHZvaWQgV2Vi RWRpdG9yQ2xpZW50OjpzZWxlY3Rpb25SZWN0c0RpZENoYW5nZShjb25zdCBWZWN0b3I8TGF5b3V0 UmVjdD4mIHJlY3RzKQogewotICAgIG1fcGFnZS0+c2VsZWN0aW9uT3ZlcmxheUNvbnRyb2xsZXIo KS5zZWxlY3Rpb25SZWN0c0RpZENoYW5nZShyZWN0cyk7CisgICAgaWYgKG1fcGFnZS0+c2Vydmlj ZUNvbnRyb2xzRW5hYmxlZCgpKQorICAgICAgICBtX3BhZ2UtPnNlbGVjdGlvbk92ZXJsYXlDb250 cm9sbGVyKCkuc2VsZWN0aW9uUmVjdHNEaWRDaGFuZ2UocmVjdHMpOwogfQogI2VuZGlmIC8vIEVO QUJMRShTRVJWSUNFX0NPTlRST0xTKQogCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViS2l0Mi9XZWJQ cm9jZXNzL1dlYlBhZ2UvV2ViUGFnZS5jcHAgYi9Tb3VyY2UvV2ViS2l0Mi9XZWJQcm9jZXNzL1dl YlBhZ2UvV2ViUGFnZS5jcHAKaW5kZXggZjkwNmU5Zi4uMTU4OGVjMCAxMDA2NDQKLS0tIGEvU291 cmNlL1dlYktpdDIvV2ViUHJvY2Vzcy9XZWJQYWdlL1dlYlBhZ2UuY3BwCisrKyBiL1NvdXJjZS9X ZWJLaXQyL1dlYlByb2Nlc3MvV2ViUGFnZS9XZWJQYWdlLmNwcApAQCAtMjQ5LDYgKzI0OSw5IEBA IFdlYlBhZ2U6OldlYlBhZ2UodWludDY0X3QgcGFnZUlELCBjb25zdCBXZWJQYWdlQ3JlYXRpb25Q YXJhbWV0ZXJzJiBwYXJhbWV0ZXJzKQogICAgICwgbV9udW1iZXJPZlByaW1hcnlTbmFwc2hvdERl dGVjdGlvbkF0dGVtcHRzKDApCiAgICAgLCBtX2RldGVybWluZVByaW1hcnlTbmFwc2hvdHRlZFBs dWdJblRpbWVyKFJ1bkxvb3A6Om1haW4oKSwgdGhpcywgJldlYlBhZ2U6OmRldGVybWluZVByaW1h cnlTbmFwc2hvdHRlZFBsdWdJblRpbWVyRmlyZWQpCiAjZW5kaWYKKyNpZiBFTkFCTEUoU0VSVklD RV9DT05UUk9MUykKKyAgICAsIG1fc2VydmljZUNvbnRyb2xzRW5hYmxlZChmYWxzZSkKKyNlbmRp ZgogICAgICwgbV9sYXllckhvc3RpbmdNb2RlKHBhcmFtZXRlcnMubGF5ZXJIb3N0aW5nTW9kZSkK ICNpZiBQTEFURk9STShDT0NPQSkKICAgICAsIG1fcGRmUGx1Z2luRW5hYmxlZChmYWxzZSkKQEAg LTI0OTcsNiArMjUwMCwxMCBAQCB2b2lkIFdlYlBhZ2U6OnVwZGF0ZVByZWZlcmVuY2VzKGNvbnN0 IFdlYlByZWZlcmVuY2VzU3RvcmUmIHN0b3JlKQogICAgIG1fcGRmUGx1Z2luRW5hYmxlZCA9IHN0 b3JlLmdldEJvb2xWYWx1ZUZvcktleShXZWJQcmVmZXJlbmNlc0tleTo6cGRmUGx1Z2luRW5hYmxl ZEtleSgpKTsKICNlbmRpZgogCisjaWYgRU5BQkxFKFNFUlZJQ0VfQ09OVFJPTFMpCisgICAgbV9z ZXJ2aWNlQ29udHJvbHNFbmFibGVkID0gc3RvcmUuZ2V0Qm9vbFZhbHVlRm9yS2V5KFdlYlByZWZl cmVuY2VzS2V5OjpzZXJ2aWNlQ29udHJvbHNFbmFibGVkS2V5KCkpOworI2VuZGlmCisKICAgICAv LyBGSVhNRTogVGhpcyBzaG91bGQgYmUgZ2VuZXJhdGVkIGZyb20gbWFjcm8gZXhwYW5zaW9uIGZv ciBhbGwgcHJlZmVyZW5jZXMsCiAgICAgLy8gYnV0IHdlIGN1cnJlbnRseSBkb24ndCBtYXRjaCB0 aGUgbmFtaW5nIG9mIFdlYkNvcmUgZXhhY3RseSBzbyB3ZSBhcmUKICAgICAvLyBoYW5kcm9sbGlu ZyB0aGUgYm9vbGVhbiBhbmQgaW50ZWdlciBwcmVmZXJlbmNlcyB1bnRpbCB0aGF0IGlzIGZpeGVk LgpkaWZmIC0tZ2l0IGEvU291cmNlL1dlYktpdDIvV2ViUHJvY2Vzcy9XZWJQYWdlL1dlYlBhZ2Uu aCBiL1NvdXJjZS9XZWJLaXQyL1dlYlByb2Nlc3MvV2ViUGFnZS9XZWJQYWdlLmgKaW5kZXggYzQ2 YTYxZC4uOTU3MzcxMSAxMDA2NDQKLS0tIGEvU291cmNlL1dlYktpdDIvV2ViUHJvY2Vzcy9XZWJQ YWdlL1dlYlBhZ2UuaAorKysgYi9Tb3VyY2UvV2ViS2l0Mi9XZWJQcm9jZXNzL1dlYlBhZ2UvV2Vi UGFnZS5oCkBAIC03ODgsNiArNzg4LDcgQEAgcHVibGljOgogI2VuZGlmCiAjaWYgRU5BQkxFKFNF UlZJQ0VfQ09OVFJPTFMpCiAgICAgU2VsZWN0aW9uT3ZlcmxheUNvbnRyb2xsZXImIHNlbGVjdGlv bk92ZXJsYXlDb250cm9sbGVyKCk7CisgICAgYm9vbCBzZXJ2aWNlQ29udHJvbHNFbmFibGVkKCkg Y29uc3QgeyByZXR1cm4gbV9zZXJ2aWNlQ29udHJvbHNFbmFibGVkOyB9CiAjZW5kaWYKIAogICAg IHZvaWQgZGlkQ2hhbmdlU2Nyb2xsT2Zmc2V0Rm9yRnJhbWUoV2ViQ29yZTo6RnJhbWUqKTsKQEAg LTEwNDEsNiArMTA0MiwxMCBAQCBwcml2YXRlOgogICAgIFJ1bkxvb3A6OlRpbWVyPFdlYlBhZ2U+ IG1fZGV0ZXJtaW5lUHJpbWFyeVNuYXBzaG90dGVkUGx1Z0luVGltZXI7CiAjZW5kaWYKIAorI2lm IEVOQUJMRShTRVJWSUNFX0NPTlRST0xTKQorICAgIGJvb2wgbV9zZXJ2aWNlQ29udHJvbHNFbmFi bGVkOworI2VuZGlmCisKICAgICAvLyBUaGUgbGF5ZXIgaG9zdGluZyBtb2RlLgogICAgIExheWVy SG9zdGluZ01vZGUgbV9sYXllckhvc3RpbmdNb2RlOwogCg==