132286 2014-04-28 10:34:12 -0700 run-jsc-stress-tests: Silence warning about kernel interface hw.activecpu not available on Linux 2014-05-03 20:19:00 -0700 1 1 1 Unclassified WebKit Tools / Tests 528+ (Nightly build) Other Linux RESOLVED FIXED P2 Normal --- 1 clopez webkit-unassigned commit-queue darin fpizlo ggaren oliver oldest_to_newest 1004640 0 clopez 2014-04-28 10:34:12 -0700 When running the run-jsc-stress-tests script, on Linux systems the following warning shows: sysctl: cannot stat /proc/sys/hw/activecpu: No such file or directory That kernel interface (hw.activecpu) is not available on Linux. The script gets right the number of CPUs because it fallbacks later to the nproc utility. However the warning about hw.activecpu should be hidden. 1004642 1 230306 clopez 2014-04-28 10:39:08 -0700 Created attachment 230306 Patch 1005233 2 230306 darin 2014-04-29 17:37:38 -0700 Comment on attachment 230306 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=230306&action=review > Tools/Scripts/run-jsc-stress-tests:77 > + $numProcessors = `sysctl -n hw.activecpu 2>/dev/null`.to_i I suggest this instead: $numProcessors = `sysctl -i -n hw.activecpu`.to_i That’s much better than hiding all possible errors by routing them to /dev/null. 1005640 3 clopez 2014-04-30 20:16:41 -0700 (In reply to comment #2) > I suggest this instead: > > $numProcessors = `sysctl -i -n hw.activecpu`.to_i > > That’s much better than hiding all possible errors by routing them to /dev/null. The idea of the patch was precisely to hide the stderr output. IMHO there is no point on printing any error that sysctl can give, because in that case, then the current codebase already does another try that uses the system utility nproc. (which is how it gets the number of CPUs on Linux) Also, your suggestion of passing "-i" don't works on Linux.... If you pass the flag "-i" to sysctl on Linux you will get this: $ sysctl -i -n hw.activecpu sysctl: invalid option -- 'i' Usage: sysctl [options] [variable[=value] ...] Options: -a, --all display all variables -A alias of -a -X alias of -a --deprecated include deprecated parameters to listing -b, --binary print value without new line -e, --ignore ignore unknown variables errors -N, --names print variable names without values -n, --values print only values of a variables -p, --load[=<file>] read values from file -f alias of -p --system read values from all system directories -r, --pattern <expression> select setting that match expression -q, --quiet do not echo variable set -w, --write enable writing a value to variable -o does nothing -x does nothing -d alias of -h -h, --help display this help and exit -V, --version output version information and exit For more details see sysctl(8). .... which makes the noise even worse 1005647 4 230306 fpizlo 2014-04-30 20:49:23 -0700 Comment on attachment 230306 Patch I think this is fine. 1005648 5 230306 commit-queue 2014-04-30 21:20:44 -0700 Comment on attachment 230306 Patch Clearing flags on attachment: 230306 Committed r168083: <http://trac.webkit.org/changeset/168083> 1005649 6 commit-queue 2014-04-30 21:20:48 -0700 All reviewed patches have been landed. Closing bug. 1006454 7 darin 2014-05-03 20:19:00 -0700 I’m fine with the patch we landed, but I don’t agree that we want to hide all error output. Ideally, we’d want to hide the “I never heard of hw.activecpu before” error, but if there are other types of errors we’d like to see them. Anyway, not a big deal and OK like this. 230306 2014-04-28 10:39:08 -0700 2014-04-30 21:20:44 -0700 Patch bug-132286-20140428193845.patch text/plain 1172 clopez U3VidmVyc2lvbiBSZXZpc2lvbjogMTY3ODg4CmRpZmYgLS1naXQgYS9Ub29scy9DaGFuZ2VMb2cg Yi9Ub29scy9DaGFuZ2VMb2cKaW5kZXggMjY5ZDMxZjVjNzgyYWE3NWJjYzYxZTM3MzY2MGM2MDkz ZmJiZWYyNS4uYjY5ODkwZTg0Njg3NThkZmQ2MjliMGYxMmFjMWFjNTcwMmE4M2VlYSAxMDA2NDQK LS0tIGEvVG9vbHMvQ2hhbmdlTG9nCisrKyBiL1Rvb2xzL0NoYW5nZUxvZwpAQCAtMSwzICsxLDEz IEBACisyMDE0LTA0LTI4ICBDYXJsb3MgQWxiZXJ0byBMb3BleiBQZXJleiAgPGNsb3BlekBpZ2Fs aWEuY29tPgorCisgICAgICAgIEtlcm5lbCBzeXNjdGwgaW50ZXJmYWNlIGh3LmFjdGl2ZWNwdSBk b24ndCBleGlzdHMgb24gTGludXguCisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3No b3dfYnVnLmNnaT9pZD0xMzIyODYKKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMh KS4KKworICAgICAgICAqIFNjcmlwdHMvcnVuLWpzYy1zdHJlc3MtdGVzdHM6IFJlZGlyZWN0IHN0 ZGVyciB0byBudWxsIHdoZW4KKyAgICAgICAgY2FsbGluZyBzeXNjdGwgb3ZlciBody5hY3RpdmVj cHUKKwogMjAxNC0wNC0yNyAgSm9vbmdodW4gUGFyayAgPGpoNzE4LnBhcmtAc2Ftc3VuZy5jb20+ CiAKICAgICAgICAgW0VGTF0gUmVtb3ZlIGluZGV4ZWREQidzIGRlcGVuZGVuY3kgb24gbGV2ZWxk YiBhbmQgZGlzYWJsZSBpbmRleGVkREIKZGlmZiAtLWdpdCBhL1Rvb2xzL1NjcmlwdHMvcnVuLWpz Yy1zdHJlc3MtdGVzdHMgYi9Ub29scy9TY3JpcHRzL3J1bi1qc2Mtc3RyZXNzLXRlc3RzCmluZGV4 IGM0NmZmOTA4Njk5NjA2NzRlMDUzZDI4OWY3MjNmNTkxYjQ2MjgyYTguLjk3OWE0YTgzZjU4OTVh NmU1YmRlYzM0OGRmNjgzOThlYjIzYjU5MjIgMTAwNzU1Ci0tLSBhL1Rvb2xzL1NjcmlwdHMvcnVu LWpzYy1zdHJlc3MtdGVzdHMKKysrIGIvVG9vbHMvU2NyaXB0cy9ydW4tanNjLXN0cmVzcy10ZXN0 cwpAQCAtNzQsNyArNzQsNyBAQCBkZWYgbXlzeXMoKmNtZCkKIGVuZAogCiBiZWdpbgotICAgICRu dW1Qcm9jZXNzb3JzID0gYHN5c2N0bCAtbiBody5hY3RpdmVjcHVgLnRvX2kKKyAgICAkbnVtUHJv Y2Vzc29ycyA9IGBzeXNjdGwgLW4gaHcuYWN0aXZlY3B1IDI+L2Rldi9udWxsYC50b19pCiByZXNj dWUKICAgICAkbnVtUHJvY2Vzc29ycyA9IDAKIGVuZAo=