132285 2014-04-28 09:52:09 -0700 [New Multicolumn] Multiple tests assert in RenderGeometryMap 2014-04-29 22:16:04 -0700 1 1 1 Unclassified WebKit Layout and Rendering 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 1 hyatt hyatt commit-queue esprehn+autocc glenn kondapallykalyan WebkitBugTracker oldest_to_newest 1004620 0 hyatt 2014-04-28 09:52:09 -0700 The assert: 0 com.apple.JavaScriptCore 0x000000010e73047a WTFCrash + 42 (Assertions.cpp:333) 1 com.apple.WebCore 0x000000011101db92 WebCore::RenderGeometryMap::mapToContainer(WebCore::FloatRect const&, WebCore::RenderLayerModelObject const*) const + 850 (RenderGeometryMap.cpp:143) 2 com.apple.WebCore 0x000000011104c5c9 WebCore::RenderGeometryMap::absoluteRect(WebCore::FloatRect const&) const + 57 (RenderGeometryMap.h:90) 3 com.apple.WebCore 0x000000011109e6a3 WebCore::RenderLayerCompositor::computeCompositingRequirements(WebCore::RenderLayer*, WebCore::RenderLayer&, WebCore::RenderLayerCompositor::OverlapMap*, WebCore::CompositingState&, bool&, bool&) + 467 (RenderLayerCompositor.cpp:1139) 4 com.apple.WebCore 0x000000011109ebc9 WebCore::RenderLayerCompositor::computeCompositingRequirements(WebCore::RenderLayer*, WebCore::RenderLayer&, WebCore::RenderLayerCompositor::OverlapMap*, WebCore::CompositingState&, bool&, bool&) + 1785 (RenderLayerCompositor.cpp:1230) 5 com.apple.WebCore 0x000000011109ebc9 WebCore::RenderLayerCompositor::computeCompositingRequirements(WebCore::RenderLayer*, WebCore::RenderLayer&, WebCore::RenderLayerCompositor::OverlapMap*, WebCore::CompositingState&, bool&, bool&) + 1785 (RenderLayerCompositor.cpp:1230) 6 com.apple.WebCore 0x000000011109df7a WebCore::RenderLayerCompositor::updateCompositingLayers(WebCore::CompositingUpdateType, WebCore::RenderLayer*) + 906 (RenderLayerCompositor.cpp:702) 7 com.apple.WebCore 0x00000001100d8efd WebCore::FrameView::updateCompositingLayersAfterLayout() + 93 (FrameView.cpp:729) 8 com.apple.WebCore 0x00000001100dabca WebCore::FrameView::layout(bool) + 3882 (FrameView.cpp:1330) 9 com.apple.WebCore 0x000000010fd5f76d WebCore::Document::updateLayout() + 349 (Document.cpp:1846) 10 com.apple.WebCore 0x000000010fd62d4f WebCore::Document::updateLayoutIgnorePendingStylesheets() + 207 (Document.cpp:1880) 11 com.apple.WebCore 0x000000010fee84fe WebCore::Element::getBoundingClientRect() + 62 (Element.cpp:888) The results are also wrong. This obviously blocks turning on new columns. 1004622 1 hyatt 2014-04-28 09:54:08 -0700 fast/events/offsetX-offsetY.html also fails with the same characteristics, so lumping it in here. 1004623 2 hyatt 2014-04-28 09:55:48 -0700 compositing/columns/composited-columns.html also hits this assert. 1004624 3 hyatt 2014-04-28 09:56:27 -0700 Ditto for compositing/columns/composited-nested-columns.html 1005275 4 230456 hyatt 2014-04-29 22:07:47 -0700 Created attachment 230456 Patch 1005276 5 230456 simon.fraser 2014-04-29 22:09:55 -0700 Comment on attachment 230456 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=230456&action=review > Source/WebCore/rendering/RenderMultiColumnFlowThread.h:112 > + virtual LayoutSize offsetFromContainer(RenderObject*, const LayoutPoint&, bool* offsetDependsOnPoint = 0) const override; = nullptr 1005277 6 hyatt 2014-04-29 22:16:04 -0700 Fixed in r167982. 230456 2014-04-29 22:07:47 -0700 2014-04-29 22:09:54 -0700 Patch patch.txt text/plain 3289 hyatt SW5kZXg6IFNvdXJjZS9XZWJDb3JlL0NoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBTb3VyY2UvV2Vi Q29yZS9DaGFuZ2VMb2cJKHJldmlzaW9uIDE2Nzk4MSkKKysrIFNvdXJjZS9XZWJDb3JlL0NoYW5n ZUxvZwkod29ya2luZyBjb3B5KQpAQCAtMSwzICsxLDE5IEBACisyMDE0LTA0LTI5ICBEYXZpZCBI eWF0dCAgPGh5YXR0QGFwcGxlLmNvbT4KKworICAgICAgICBbTmV3IE11bHRpY29sdW1uXSBNdWx0 aXBsZSB0ZXN0cyBhc3NlcnQgaW4gUmVuZGVyR2VvbWV0cnlNYXAKKyAgICAgICAgaHR0cHM6Ly9i dWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTEzMjI4NQorCisgICAgICAgIFJldmlld2Vk IGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgIEltcGxlbWVudCBvZmZzZXRGcm9tQ29udGFp bmVyIGZvciBSZW5kZXJNdWx0aUNvbHVtbkZsb3dUaHJlYWQgc28gdGhhdCB0aGUKKyAgICAgICAg Z2VvbWV0cnkgbWFwIGdldHMgdGhlIHJpZ2h0IG9mZnNldHMuIFRoaXMgaXMgcmVhbGx5IG9ubHkg cmVsZXZhbnQgZm9yIHRoZSAKKyAgICAgICAgZ2VvbWV0cnkgbWFwLCBzaW5jZSBJIGFscmVhZHkg b3ZlcnJvZGUgbWFwQWJzb2x1dGVUb0xvY2FsUG9pbnQgYW5kIG11bHRpY29sdW1uCisgICAgICAg IGZsb3cgdGhyZWFkcyBhcmUgcmVwYWludCBjb250YWluZXJzIChzbyBtYXBMb2NhbFRvQWJzb2x1 dGUgbmV2ZXIgbmVlZHMgb2Zmc2V0RnJvbUNvbnRhaW5lcikuCisKKyAgICAgICAgKiByZW5kZXJp bmcvUmVuZGVyTXVsdGlDb2x1bW5GbG93VGhyZWFkLmNwcDoKKyAgICAgICAgKFdlYkNvcmU6OlJl bmRlck11bHRpQ29sdW1uRmxvd1RocmVhZDo6b2Zmc2V0RnJvbUNvbnRhaW5lcik6CisgICAgICAg ICogcmVuZGVyaW5nL1JlbmRlck11bHRpQ29sdW1uRmxvd1RocmVhZC5oOgorCiAyMDE0LTA0LTI5 ICBCZW5qYW1pbiBQb3VsYWluICA8YnBvdWxhaW5AYXBwbGUuY29tPgogCiAgICAgICAgIFtpT1Nd W1dLMl0gV2hlbiBwYWdlU2NhbGVGYWN0b3IgKiBkZXZpY2VTY2FsZUZhY3RvciA9IDEsIHRoZSB0 aWxlIGdyaWQgaXMgY29tcGxldGVseSBtZXNzZWQgdXAKSW5kZXg6IFNvdXJjZS9XZWJDb3JlL3Jl bmRlcmluZy9SZW5kZXJNdWx0aUNvbHVtbkZsb3dUaHJlYWQuY3BwCj09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIFNv dXJjZS9XZWJDb3JlL3JlbmRlcmluZy9SZW5kZXJNdWx0aUNvbHVtbkZsb3dUaHJlYWQuY3BwCShy ZXZpc2lvbiAxNjc5NjUpCisrKyBTb3VyY2UvV2ViQ29yZS9yZW5kZXJpbmcvUmVuZGVyTXVsdGlD b2x1bW5GbG93VGhyZWFkLmNwcAkod29ya2luZyBjb3B5KQpAQCAtNTgzLDYgKzU4MywyNiBAQCB2 b2lkIFJlbmRlck11bHRpQ29sdW1uRmxvd1RocmVhZDo6Y29tcHV0CiAgICAgfQogfQogCitMYXlv dXRTaXplIFJlbmRlck11bHRpQ29sdW1uRmxvd1RocmVhZDo6b2Zmc2V0RnJvbUNvbnRhaW5lcihS ZW5kZXJPYmplY3QqIGVuY2xvc2luZ0NvbnRhaW5lciwgY29uc3QgTGF5b3V0UG9pbnQmIHBoeXNp Y2FsUG9pbnQsIGJvb2wqIG9mZnNldERlcGVuZHNPblBvaW50KSBjb25zdAoreworICAgIEFTU0VS VChlbmNsb3NpbmdDb250YWluZXIgPT0gY29udGFpbmVyKCkpOworCisgICAgaWYgKG9mZnNldERl cGVuZHNPblBvaW50KQorICAgICAgICAqb2Zmc2V0RGVwZW5kc09uUG9pbnQgPSB0cnVlOworICAg IAorICAgIExheW91dFBvaW50IHRyYW5zbGF0ZWRQaHlzaWNhbFBvaW50KHBoeXNpY2FsUG9pbnQp OworICAgIFJlbmRlclJlZ2lvbiogcmVnaW9uID0gcGh5c2ljYWxUcmFuc2xhdGlvbkZyb21GbG93 VG9SZWdpb24odHJhbnNsYXRlZFBoeXNpY2FsUG9pbnQpOworICAgIGlmICghcmVnaW9uKQorICAg ICAgICByZXR1cm4gdG9wTGVmdExvY2F0aW9uT2Zmc2V0KCk7CisgICAgCisgICAgdHJhbnNsYXRl ZFBoeXNpY2FsUG9pbnQubW92ZUJ5KHJlZ2lvbi0+dG9wTGVmdExvY2F0aW9uKCkpOworICAgIAor ICAgIExheW91dFNpemUgb2Zmc2V0KHRyYW5zbGF0ZWRQaHlzaWNhbFBvaW50LngoKSwgdHJhbnNs YXRlZFBoeXNpY2FsUG9pbnQueSgpKTsKKyAgICBpZiAoZW5jbG9zaW5nQ29udGFpbmVyLT5pc0Jv eCgpKQorICAgICAgICBvZmZzZXQgLT0gdG9SZW5kZXJCb3goZW5jbG9zaW5nQ29udGFpbmVyKS0+ c2Nyb2xsZWRDb250ZW50T2Zmc2V0KCk7CisgICAgcmV0dXJuIG9mZnNldDsKK30KKyAgICAKIHZv aWQgUmVuZGVyTXVsdGlDb2x1bW5GbG93VGhyZWFkOjptYXBBYnNvbHV0ZVRvTG9jYWxQb2ludChN YXBDb29yZGluYXRlc0ZsYWdzIG1vZGUsIFRyYW5zZm9ybVN0YXRlJiB0cmFuc2Zvcm1TdGF0ZSkg Y29uc3QKIHsKICAgICAvLyBGaXJzdCBnZXQgdGhlIHRyYW5zZm9ybSBzdGF0ZSdzIHBvaW50IGlu dG8gdGhlIGJsb2NrIGZsb3cgdGhyZWFkJ3MgcGh5c2ljYWwgY29vcmRpbmF0ZSBzcGFjZS4KSW5k ZXg6IFNvdXJjZS9XZWJDb3JlL3JlbmRlcmluZy9SZW5kZXJNdWx0aUNvbHVtbkZsb3dUaHJlYWQu aAo9PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09Ci0tLSBTb3VyY2UvV2ViQ29yZS9yZW5kZXJpbmcvUmVuZGVyTXVsdGlDb2x1 bW5GbG93VGhyZWFkLmgJKHJldmlzaW9uIDE2Nzk2NCkKKysrIFNvdXJjZS9XZWJDb3JlL3JlbmRl cmluZy9SZW5kZXJNdWx0aUNvbHVtbkZsb3dUaHJlYWQuaAkod29ya2luZyBjb3B5KQpAQCAtMTA5 LDYgKzEwOSw3IEBAIHB1YmxpYzoKICAgICB2aXJ0dWFsIGJvb2wgbm9kZUF0UG9pbnQoY29uc3Qg SGl0VGVzdFJlcXVlc3QmLCBIaXRUZXN0UmVzdWx0JiwgY29uc3QgSGl0VGVzdExvY2F0aW9uJiBs b2NhdGlvbkluQ29udGFpbmVyLCBjb25zdCBMYXlvdXRQb2ludCYgYWNjdW11bGF0ZWRPZmZzZXQs IEhpdFRlc3RBY3Rpb24pIG92ZXJyaWRlOwogICAgIAogICAgIHZpcnR1YWwgdm9pZCBtYXBBYnNv bHV0ZVRvTG9jYWxQb2ludChNYXBDb29yZGluYXRlc0ZsYWdzLCBUcmFuc2Zvcm1TdGF0ZSYpIGNv bnN0IG92ZXJyaWRlOworICAgIHZpcnR1YWwgTGF5b3V0U2l6ZSBvZmZzZXRGcm9tQ29udGFpbmVy KFJlbmRlck9iamVjdCosIGNvbnN0IExheW91dFBvaW50JiwgYm9vbCogb2Zmc2V0RGVwZW5kc09u UG9pbnQgPSAwKSBjb25zdCBvdmVycmlkZTsKICAgICAKIHByaXZhdGU6CiAgICAgdmlydHVhbCBj b25zdCBjaGFyKiByZW5kZXJOYW1lKCkgY29uc3Qgb3ZlcnJpZGU7Cg==