132252 2014-04-28 03:37:20 -0700 [GTK] Crash in debug build with removing windowed plugin child widgets from the view 2014-04-28 04:11:06 -0700 1 1 1 Unclassified WebKit WebKit2 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED Gtk P2 Normal --- 1 cgarcia webkit-unassigned berto commit-queue gustavo mrobinson pnormand zan oldest_to_newest 1004523 0 cgarcia 2014-04-28 03:37:20 -0700 It crashes due to an assert in HashTable that checks the iterators validity. The problem is that we are iterating the children map and the callback called on every iterator might modify the map, making the iterators invalid. This happens when the web view is destroyed, GtkContainer calls gtk_container_foreach() with gtk_widget_destroy as callback. When a widget inside a container is destroyed, it's removed from the container, and in our case, the child widget is removed from the map. This is causing several crashes when running layout tests in debug bot. 1004525 1 230289 cgarcia 2014-04-28 03:40:59 -0700 Created attachment 230289 Patch 1004526 2 commit-queue 2014-04-28 03:43:00 -0700 Thanks for the patch. If this patch contains new public API please make sure it follows the guidelines for new WebKit2 GTK+ API. See http://trac.webkit.org/wiki/WebKitGTK/AddingNewWebKit2API 1004527 3 commit-queue 2014-04-28 03:43:11 -0700 Attachment 230289 did not pass style-queue: ERROR: Source/WebKit2/UIProcess/API/gtk/WebKitWebViewBase.cpp:368: Multi line control clauses should use braces. [whitespace/braces] [4] Total errors found: 1 in 2 files If any of these errors are false positives, please file a bug against check-webkit-style. 1004528 4 230290 cgarcia 2014-04-28 03:46:35 -0700 Created attachment 230290 Fix coding style 1004533 5 cgarcia 2014-04-28 04:11:06 -0700 Committed r167883: <http://trac.webkit.org/changeset/167883> 230289 2014-04-28 03:40:59 -0700 2014-04-28 03:46:35 -0700 Patch wk2-plugin-crashes.diff text/plain 2510 cgarcia ZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJLaXQyL0NoYW5nZUxvZyBiL1NvdXJjZS9XZWJLaXQyL0No YW5nZUxvZwppbmRleCBhYzhkYjcyLi42OTI0ZjkxIDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViS2l0 Mi9DaGFuZ2VMb2cKKysrIGIvU291cmNlL1dlYktpdDIvQ2hhbmdlTG9nCkBAIC0xLDUgKzEsMjgg QEAKIDIwMTQtMDQtMjggIENhcmxvcyBHYXJjaWEgQ2FtcG9zICA8Y2dhcmNpYUBpZ2FsaWEuY29t PgogCisgICAgICAgIFtHVEtdIENyYXNoIGluIGRlYnVnIGJ1aWxkIHdpdGggcmVtb3Zpbmcgd2lu ZG93ZWQgcGx1Z2luIGNoaWxkIHdpZGdldHMgZnJvbSB0aGUgdmlldworICAgICAgICBodHRwczov L2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MTMyMjUyCisKKyAgICAgICAgUmV2aWV3 ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgSXQgY3Jhc2hlcyBkdWUgdG8gYW4gYXNz ZXJ0IGluIEhhc2hUYWJsZSB0aGF0IGNoZWNrcyB0aGUgaXRlcmF0b3JzCisgICAgICAgIHZhbGlk aXR5LiBUaGUgcHJvYmxlbSBpcyB0aGF0IHdlIGFyZSBpdGVyYXRpbmcgdGhlIGNoaWxkcmVuIG1h cAorICAgICAgICBhbmQgdGhlIGNhbGxiYWNrIGNhbGxlZCBvbiBldmVyeSBpdGVyYXRpb24gbWln aHQgbW9kaWZ5IHRoZSBtYXAsCisgICAgICAgIG1ha2luZyB0aGUgaXRlcmF0b3JzIGludmFsaWQu IFRoaXMgaGFwcGVucyB3aGVuIHRoZSBXZWJWaWV3IGlzCisgICAgICAgIGRlc3Ryb3llZCwgR3Rr Q29udGFpbmVyIGNhbGxzIGd0a19jb250YWluZXJfZm9yZWFjaCgpIHdpdGgKKyAgICAgICAgZ3Rr X3dpZGdldF9kZXN0cm95IGFzIGNhbGxiYWNrLiBXaGVuIGEgd2lkZ2V0IGluc2lkZSBhIGNvbnRh aW5lcgorICAgICAgICBpcyBkZXN0cm95ZWQsIGl0J3MgcmVtb3ZlZCBmcm9tIHRoZSBjb250YWlu ZXIsIGFuZCBpbiBvdXIgY2FzZSwKKyAgICAgICAgdGhlIGNoaWxkIHdpZGdldCBpcyByZW1vdmVk IGZyb20gdGhlIG1hcC4gVGhpcyBmaXhlcyBzZXZlcmFsCisgICAgICAgIGNyYXNoZXMgd2hlbiBy dW5uaW5nIGxheW91dCB0ZXN0cyBpbiBkZWJ1ZyBib3QuCisKKyAgICAgICAgKiBVSVByb2Nlc3Mv QVBJL2d0ay9XZWJLaXRXZWJWaWV3QmFzZS5jcHA6CisgICAgICAgICh3ZWJraXRXZWJWaWV3QmFz ZUNvbnRhaW5lckZvcmFsbCk6IFVzZSBjb3B5S2V5c1RvVmVjdG9yKCkgaW5zdGVhZAorICAgICAg ICBvZiB1c2luZyBhIHJhbmdlIGl0ZXJhdG9yIGZvciB0aGUgbWFwIGtleXMgYW5kIGNoZWNrIGlu IGV2ZXJ5CisgICAgICAgIGl0ZXJhdGlvbiB0aGF0IHRoZSBjaGlsZCB3aWRnZXQgZnJvbSB0aGUg a2V5cyB2ZWN0b3IgaXMgc3RpbGwKKyAgICAgICAgcHJlc2VudCBpbiB0aGUgbWFwIGJlZm9yZSBj YWxsaW5nIHRoZSBjYWxsYmFjay4KKworMjAxNC0wNC0yOCAgQ2FybG9zIEdhcmNpYSBDYW1wb3Mg IDxjZ2FyY2lhQGlnYWxpYS5jb20+CisKICAgICAgICAgW0dUS10gR09iamVjdCBpbnRyb3NwZWN0 aW9uIGxpbmtzIHRvIGluc3RhbGxlZCBsaWJzIHdoZW4gdXNpbmcgamhidWlsZAogICAgICAgICBo dHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MTMyMjIwCiAKZGlmZiAtLWdp dCBhL1NvdXJjZS9XZWJLaXQyL1VJUHJvY2Vzcy9BUEkvZ3RrL1dlYktpdFdlYlZpZXdCYXNlLmNw cCBiL1NvdXJjZS9XZWJLaXQyL1VJUHJvY2Vzcy9BUEkvZ3RrL1dlYktpdFdlYlZpZXdCYXNlLmNw cAppbmRleCBiZWI1OGNmLi5lMzA0ZDVkIDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViS2l0Mi9VSVBy b2Nlc3MvQVBJL2d0ay9XZWJLaXRXZWJWaWV3QmFzZS5jcHAKKysrIGIvU291cmNlL1dlYktpdDIv VUlQcm9jZXNzL0FQSS9ndGsvV2ViS2l0V2ViVmlld0Jhc2UuY3BwCkBAIC0zNjMsOCArMzYzLDEx IEBAIHN0YXRpYyB2b2lkIHdlYmtpdFdlYlZpZXdCYXNlQ29udGFpbmVyRm9yYWxsKEd0a0NvbnRh aW5lciogY29udGFpbmVyLCBnYm9vbGVhbiBpCiAgICAgV2ViS2l0V2ViVmlld0Jhc2UqIHdlYlZp ZXcgPSBXRUJLSVRfV0VCX1ZJRVdfQkFTRShjb250YWluZXIpOwogICAgIFdlYktpdFdlYlZpZXdC YXNlUHJpdmF0ZSogcHJpdiA9IHdlYlZpZXctPnByaXY7CiAKLSAgICBmb3IgKGNvbnN0IGF1dG8m IHdpZGdldCA6IHByaXYtPmNoaWxkcmVuLmtleXMoKSkKLSAgICAgICAgKCpjYWxsYmFjaykod2lk Z2V0LCBjYWxsYmFja0RhdGEpOworICAgIFZlY3RvcjxHdGtXaWRnZXQqPiBjaGlsZHJlbjsKKyAg ICBjb3B5S2V5c1RvVmVjdG9yKHByaXYtPmNoaWxkcmVuLCBjaGlsZHJlbik7CisgICAgZm9yIChj b25zdCBhdXRvJiBjaGlsZCA6IGNoaWxkcmVuKQorICAgICAgICBpZiAocHJpdi0+Y2hpbGRyZW4u Y29udGFpbnMoY2hpbGQpKQorICAgICAgICAgICAgKCpjYWxsYmFjaykoY2hpbGQsIGNhbGxiYWNr RGF0YSk7CiAKICAgICBpZiAoaW5jbHVkZUludGVybmFscyAmJiBwcml2LT5pbnNwZWN0b3JWaWV3 KQogICAgICAgICAoKmNhbGxiYWNrKShwcml2LT5pbnNwZWN0b3JWaWV3LCBjYWxsYmFja0RhdGEp Owo= 230290 2014-04-28 03:46:35 -0700 2014-04-28 04:05:10 -0700 Fix coding style wk2-plugin-crashes.diff text/plain 2519 cgarcia ZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJLaXQyL0NoYW5nZUxvZyBiL1NvdXJjZS9XZWJLaXQyL0No YW5nZUxvZwppbmRleCBhYzhkYjcyLi42OTI0ZjkxIDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViS2l0 Mi9DaGFuZ2VMb2cKKysrIGIvU291cmNlL1dlYktpdDIvQ2hhbmdlTG9nCkBAIC0xLDUgKzEsMjgg QEAKIDIwMTQtMDQtMjggIENhcmxvcyBHYXJjaWEgQ2FtcG9zICA8Y2dhcmNpYUBpZ2FsaWEuY29t PgogCisgICAgICAgIFtHVEtdIENyYXNoIGluIGRlYnVnIGJ1aWxkIHdpdGggcmVtb3Zpbmcgd2lu ZG93ZWQgcGx1Z2luIGNoaWxkIHdpZGdldHMgZnJvbSB0aGUgdmlldworICAgICAgICBodHRwczov L2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MTMyMjUyCisKKyAgICAgICAgUmV2aWV3 ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgSXQgY3Jhc2hlcyBkdWUgdG8gYW4gYXNz ZXJ0IGluIEhhc2hUYWJsZSB0aGF0IGNoZWNrcyB0aGUgaXRlcmF0b3JzCisgICAgICAgIHZhbGlk aXR5LiBUaGUgcHJvYmxlbSBpcyB0aGF0IHdlIGFyZSBpdGVyYXRpbmcgdGhlIGNoaWxkcmVuIG1h cAorICAgICAgICBhbmQgdGhlIGNhbGxiYWNrIGNhbGxlZCBvbiBldmVyeSBpdGVyYXRpb24gbWln aHQgbW9kaWZ5IHRoZSBtYXAsCisgICAgICAgIG1ha2luZyB0aGUgaXRlcmF0b3JzIGludmFsaWQu IFRoaXMgaGFwcGVucyB3aGVuIHRoZSBXZWJWaWV3IGlzCisgICAgICAgIGRlc3Ryb3llZCwgR3Rr Q29udGFpbmVyIGNhbGxzIGd0a19jb250YWluZXJfZm9yZWFjaCgpIHdpdGgKKyAgICAgICAgZ3Rr X3dpZGdldF9kZXN0cm95IGFzIGNhbGxiYWNrLiBXaGVuIGEgd2lkZ2V0IGluc2lkZSBhIGNvbnRh aW5lcgorICAgICAgICBpcyBkZXN0cm95ZWQsIGl0J3MgcmVtb3ZlZCBmcm9tIHRoZSBjb250YWlu ZXIsIGFuZCBpbiBvdXIgY2FzZSwKKyAgICAgICAgdGhlIGNoaWxkIHdpZGdldCBpcyByZW1vdmVk IGZyb20gdGhlIG1hcC4gVGhpcyBmaXhlcyBzZXZlcmFsCisgICAgICAgIGNyYXNoZXMgd2hlbiBy dW5uaW5nIGxheW91dCB0ZXN0cyBpbiBkZWJ1ZyBib3QuCisKKyAgICAgICAgKiBVSVByb2Nlc3Mv QVBJL2d0ay9XZWJLaXRXZWJWaWV3QmFzZS5jcHA6CisgICAgICAgICh3ZWJraXRXZWJWaWV3QmFz ZUNvbnRhaW5lckZvcmFsbCk6IFVzZSBjb3B5S2V5c1RvVmVjdG9yKCkgaW5zdGVhZAorICAgICAg ICBvZiB1c2luZyBhIHJhbmdlIGl0ZXJhdG9yIGZvciB0aGUgbWFwIGtleXMgYW5kIGNoZWNrIGlu IGV2ZXJ5CisgICAgICAgIGl0ZXJhdGlvbiB0aGF0IHRoZSBjaGlsZCB3aWRnZXQgZnJvbSB0aGUg a2V5cyB2ZWN0b3IgaXMgc3RpbGwKKyAgICAgICAgcHJlc2VudCBpbiB0aGUgbWFwIGJlZm9yZSBj YWxsaW5nIHRoZSBjYWxsYmFjay4KKworMjAxNC0wNC0yOCAgQ2FybG9zIEdhcmNpYSBDYW1wb3Mg IDxjZ2FyY2lhQGlnYWxpYS5jb20+CisKICAgICAgICAgW0dUS10gR09iamVjdCBpbnRyb3NwZWN0 aW9uIGxpbmtzIHRvIGluc3RhbGxlZCBsaWJzIHdoZW4gdXNpbmcgamhidWlsZAogICAgICAgICBo dHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MTMyMjIwCiAKZGlmZiAtLWdp dCBhL1NvdXJjZS9XZWJLaXQyL1VJUHJvY2Vzcy9BUEkvZ3RrL1dlYktpdFdlYlZpZXdCYXNlLmNw cCBiL1NvdXJjZS9XZWJLaXQyL1VJUHJvY2Vzcy9BUEkvZ3RrL1dlYktpdFdlYlZpZXdCYXNlLmNw cAppbmRleCBiZWI1OGNmLi45NDZmYjU0IDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViS2l0Mi9VSVBy b2Nlc3MvQVBJL2d0ay9XZWJLaXRXZWJWaWV3QmFzZS5jcHAKKysrIGIvU291cmNlL1dlYktpdDIv VUlQcm9jZXNzL0FQSS9ndGsvV2ViS2l0V2ViVmlld0Jhc2UuY3BwCkBAIC0zNjMsOCArMzYzLDEy IEBAIHN0YXRpYyB2b2lkIHdlYmtpdFdlYlZpZXdCYXNlQ29udGFpbmVyRm9yYWxsKEd0a0NvbnRh aW5lciogY29udGFpbmVyLCBnYm9vbGVhbiBpCiAgICAgV2ViS2l0V2ViVmlld0Jhc2UqIHdlYlZp ZXcgPSBXRUJLSVRfV0VCX1ZJRVdfQkFTRShjb250YWluZXIpOwogICAgIFdlYktpdFdlYlZpZXdC YXNlUHJpdmF0ZSogcHJpdiA9IHdlYlZpZXctPnByaXY7CiAKLSAgICBmb3IgKGNvbnN0IGF1dG8m IHdpZGdldCA6IHByaXYtPmNoaWxkcmVuLmtleXMoKSkKLSAgICAgICAgKCpjYWxsYmFjaykod2lk Z2V0LCBjYWxsYmFja0RhdGEpOworICAgIFZlY3RvcjxHdGtXaWRnZXQqPiBjaGlsZHJlbjsKKyAg ICBjb3B5S2V5c1RvVmVjdG9yKHByaXYtPmNoaWxkcmVuLCBjaGlsZHJlbik7CisgICAgZm9yIChj b25zdCBhdXRvJiBjaGlsZCA6IGNoaWxkcmVuKSB7CisgICAgICAgIGlmIChwcml2LT5jaGlsZHJl bi5jb250YWlucyhjaGlsZCkpCisgICAgICAgICAgICAoKmNhbGxiYWNrKShjaGlsZCwgY2FsbGJh Y2tEYXRhKTsKKyAgICB9CiAKICAgICBpZiAoaW5jbHVkZUludGVybmFscyAmJiBwcml2LT5pbnNw ZWN0b3JWaWV3KQogICAgICAgICAoKmNhbGxiYWNrKShwcml2LT5pbnNwZWN0b3JWaWV3LCBjYWxs YmFja0RhdGEpOwo=