132223 2014-04-26 18:53:28 -0700 [Cocoa] -[WKWebProcessPlugInController parameters] returns nil if no parameters have been set yet 2014-04-27 16:13:50 -0700 1 1 1 Unclassified WebKit WebKit2 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 1 mitz mitz oldest_to_newest 1004364 0 mitz 2014-04-26 18:53:28 -0700 [Cocoa] -[WKWebProcessPlugInController parameters] returns nil if no parameters have been set yet 1004365 1 230249 mitz 2014-04-26 18:54:57 -0700 Created attachment 230249 Create m_bundleParameters if needed 1004446 2 230249 sam 2014-04-27 15:45:48 -0700 Comment on attachment 230249 Create m_bundleParameters if needed View in context: https://bugs.webkit.org/attachment.cgi?id=230249&action=review > Source/WebKit2/WebProcess/InjectedBundle/mac/InjectedBundleMac.mm:137 > + m_bundleParameters = adoptNS([[WKWebProcessBundleParameters alloc] initWithDictionary:[NSDictionary dictionary]]); Maybe @{ } instead of [NSDictionary dictionary]? 1004448 3 mitz 2014-04-27 16:13:50 -0700 (In reply to comment #2) > (From update of attachment 230249 [details]) > View in context: https://bugs.webkit.org/attachment.cgi?id=230249&action=review > > > Source/WebKit2/WebProcess/InjectedBundle/mac/InjectedBundleMac.mm:137 > > + m_bundleParameters = adoptNS([[WKWebProcessBundleParameters alloc] initWithDictionary:[NSDictionary dictionary]]); > > Maybe @{ } instead of [NSDictionary dictionary]? Done. Fixed in <http://trac.webkit.org/r167865>. 230249 2014-04-26 18:54:57 -0700 2014-04-27 15:45:48 -0700 Create m_bundleParameters if needed bug-132223-20140426185435.patch text/plain 1554 mitz SW5kZXg6IFNvdXJjZS9XZWJLaXQyL0NoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBTb3VyY2UvV2Vi S2l0Mi9DaGFuZ2VMb2cJKHJldmlzaW9uIDE2Nzg0OCkKKysrIFNvdXJjZS9XZWJLaXQyL0NoYW5n ZUxvZwkod29ya2luZyBjb3B5KQpAQCAtMSwzICsxLDE0IEBACisyMDE0LTA0LTI2ICBEYW4gQmVy bnN0ZWluICA8bWl0ekBhcHBsZS5jb20+CisKKyAgICAgICAgW0NvY29hXSAtW1dLV2ViUHJvY2Vz c1BsdWdJbkNvbnRyb2xsZXIgcGFyYW1ldGVyc10gcmV0dXJucyBuaWwgaWYgbm8gcGFyYW1ldGVy cyBoYXZlIGJlZW4gc2V0IHlldAorICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93 X2J1Zy5jZ2k/aWQ9MTMyMjIzCisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISku CisKKyAgICAgICAgKiBXZWJQcm9jZXNzL0luamVjdGVkQnVuZGxlL21hYy9JbmplY3RlZEJ1bmRs ZU1hYy5tbToKKyAgICAgICAgKFdlYktpdDo6SW5qZWN0ZWRCdW5kbGU6OmJ1bmRsZVBhcmFtZXRl cnMpOiBDcmVhdGUgdGhlIFdLV2ViUHJvY2Vzc0J1bmRsZVBhcmFtZXRlcnMgaWYKKyAgICAgICAg bmVlZGVkLgorCiAyMDE0LTA0LTI2ICBEYW4gQmVybnN0ZWluICA8bWl0ekBhcHBsZS5jb20+CiAK ICAgICAgICAgW0NvY29hXSBSZW5hbWUgYSBidW5kbGUgZm9ybSBkZWxlZ2F0ZSBtZXRob2QKSW5k ZXg6IFNvdXJjZS9XZWJLaXQyL1dlYlByb2Nlc3MvSW5qZWN0ZWRCdW5kbGUvbWFjL0luamVjdGVk QnVuZGxlTWFjLm1tCj09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIFNvdXJjZS9XZWJLaXQyL1dlYlByb2Nlc3MvSW5q ZWN0ZWRCdW5kbGUvbWFjL0luamVjdGVkQnVuZGxlTWFjLm1tCShyZXZpc2lvbiAxNjc4MTIpCisr KyBTb3VyY2UvV2ViS2l0Mi9XZWJQcm9jZXNzL0luamVjdGVkQnVuZGxlL21hYy9JbmplY3RlZEJ1 bmRsZU1hYy5tbQkod29ya2luZyBjb3B5KQpAQCAtMTMxLDcgKzEzMSwxMCBAQCB2b2lkIEluamVj dGVkQnVuZGxlOjphY3RpdmF0ZU1hY0ZvbnRBc2NlCiAjaWYgV0tfQVBJX0VOQUJMRUQKIFdLV2Vi UHJvY2Vzc0J1bmRsZVBhcmFtZXRlcnMgKkluamVjdGVkQnVuZGxlOjpidW5kbGVQYXJhbWV0ZXJz KCkKIHsKLSAgICBBU1NFUlQobV9idW5kbGVQYXJhbWV0ZXJzKTsKKyAgICAvLyBXZSBtdXN0IG5v dCByZXR1cm4gbmlsIGV2ZW4gaWYgbm8gcGFyYW1ldGVycyBhcmUgY3VycmVudGx5IHNldCwgaW4g b3JkZXIgdG8gYWxsb3cgdGhlIGNsaWVudAorICAgIC8vIHRvIHVzZSBLVk8uCisgICAgaWYgKCFt X2J1bmRsZVBhcmFtZXRlcnMpCisgICAgICAgIG1fYnVuZGxlUGFyYW1ldGVycyA9IGFkb3B0TlMo W1tXS1dlYlByb2Nlc3NCdW5kbGVQYXJhbWV0ZXJzIGFsbG9jXSBpbml0V2l0aERpY3Rpb25hcnk6 W05TRGljdGlvbmFyeSBkaWN0aW9uYXJ5XV0pOwogCiAgICAgcmV0dXJuIG1fYnVuZGxlUGFyYW1l dGVycy5nZXQoKTsKIH0K