132220 2014-04-26 03:16:00 -0700 [GTK] GObject introspection links to installed libs when using jhbuild 2014-08-06 11:25:57 -0700 1 1 1 Unclassified WebKit WebKitGTK 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED Gtk, Regression P2 Normal --- 132226 1 cgarcia webkit-unassigned bunhere cdumez commit-queue gyuyoung.kim lantw44 rakuco sergio oldest_to_newest 1004332 0 cgarcia 2014-04-26 03:16:00 -0700 See: /home/cgarcia/src/git/gnome/WebKit/WebKitBuild/Release/Source/WebKit2/tmp-introspecttMzAlB/WebKit2WebExtension-3.0.o:(.data+0x4b8): referencia a `webkit_dom_vtt_cue_get_type' sin definir (this is undefined reference in English) collect2: error: ld returned 1 exit status linking of temporary binary failed: Command '['/home/cgarcia/src/git/icecream/bin/cc', '-o', '/home/cgarcia/src/git/gnome/WebKit/WebKitBuild/Release/Source/WebKit2/tmp-introspecttMzAlB/WebKit2WebExtension-3.0', '-Wno-deprecated-declarations', '-L/home/cgarcia/gnome/lib64', '/home/cgarcia/src/git/gnome/WebKit/WebKitBuild/Release/Source/WebKit2/tmp-introspecttMzAlB/WebKit2WebExtension-3.0.o', '-L.', '-Wl,-rpath=.', '-Wl,--no-as-needed', '-lwebkit2gtk-3.0', '-ljavascriptcoregtk-3.0', '-L/home/cgarcia/src/git/gnome/WebKit/WebKitBuild/Release/lib', '-Wl,-rpath=/home/cgarcia/src/git/gnome/WebKit/WebKitBuild/Release/lib', '-Wl,--export-dynamic', '-pthread', '-L/home/cgarcia/gnome/lib64', '-lgmodule-2.0', '-lgtk-3', '-lgdk-3', '-latk-1.0', '-lpangocairo-1.0', '-lgdk_pixbuf-2.0', '-lcairo-gobject', '-lpango-1.0', '-lcairo', '-lsoup-2.4', '-lgio-2.0', '-lgobject-2.0', '-lglib-2.0']' returned non-zero exit status 1 As you can see there's two -L/home/cgarcia/gnome/lib64, and the first one is very early an takes precedence. That first one comes from the LDFLAGS env varaibles that jhbuild sets. The other one, which is correctly set after the builddir paths, is deduced by g-ir-scanner from the lib arguments passed using ldd. This didn't happen with autotools because g-ir-scanner used libtool. This is not a problem when using the internal jhbuild because we never run make install for webkit, only for the dependencies, so the linker never finds a installed webkit in jhbuild env. Since we are already overriding the CFLAGS env var we can simply override LDFLAGS as well to unset it, since g-ir-scanner will do the right thing deducing all library paths using ldd. 1004333 1 230240 cgarcia 2014-04-26 03:22:03 -0700 Created attachment 230240 Patch 1004343 2 230240 mrobinson 2014-04-26 08:27:01 -0700 Comment on attachment 230240 Patch Seems reasonable, though I wonder if some flags should be passed through. What is the value of LDFLAGS that is causing the incorrect link. 1004346 3 cgarcia 2014-04-26 12:03:20 -0700 (In reply to comment #2) > (From update of attachment 230240 [details]) > Seems reasonable, though I wonder if some flags should be passed through. What is the value of LDFLAGS that is causing the incorrect link. $ jhbuild run env | grep LDFLAGS LDFLAGS=-L/home/cgarcia/gnome/lib64 That's added later guessed from the deps. We are already overriding the CFLAGS as well. jhbuild sets the LDFLAGS env var to make sure the programs compiled during configure build against the jhbuild environment. Note that this only affects the temporary files compiled by gobject-introspection to generate the gir files, so I'm pretty sure it's safe to override the LDFLAGS. 1004498 4 cgarcia 2014-04-28 00:52:17 -0700 Committed r167873: <http://trac.webkit.org/changeset/167873> 1027236 5 lantw44 2014-08-06 11:25:57 -0700 Ignoring LDFLAGS causes build failure on FreeBSD because it cannot find libintl via LDFLAGS. 230240 2014-04-26 03:22:03 -0700 2014-04-27 04:03:29 -0700 Patch wk-g-i-link.diff text/plain 2093 cgarcia ZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJLaXQyL0NoYW5nZUxvZyBiL1NvdXJjZS9XZWJLaXQyL0No YW5nZUxvZwppbmRleCA5MTk3NTE1Li43MGRlYzJiIDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViS2l0 Mi9DaGFuZ2VMb2cKKysrIGIvU291cmNlL1dlYktpdDIvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMjAg QEAKKzIwMTQtMDQtMjYgIENhcmxvcyBHYXJjaWEgQ2FtcG9zICA8Y2dhcmNpYUBpZ2FsaWEuY29t PgorCisgICAgICAgIFtHVEtdIEdPYmplY3QgaW50cm9zcGVjdGlvbiBsaW5rcyB0byBpbnN0YWxs ZWQgbGlicyB3aGVuIHVzaW5nIGpoYnVpbGQKKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5v cmcvc2hvd19idWcuY2dpP2lkPTEzMjIyMAorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAo T09QUyEpLgorCisgICAgICAgIFRoZSBwcm9ibGVtIGlzIHRoYXQgZ29iamVjdC1pbnRyb3NwZWN0 aW9uIGlzIGxpbmtpbmcgdGhlIHRlbXBvcmFyeQorICAgICAgICBiaW5hcmllcyBhZGRpbmcgdGhl IGxpYnJhcnkgcGF0aHMgcHJlc2VudCBMREZMQUdTIGVudmlyb25tZW50CisgICAgICAgIHZhcmlh YmxlIGZpcnN0LCB0YWtpbmcgcHJlY2VkZW5jZSBvdmVyIHRoZSBsaWJyYXJpZXMgaW4gdGhlIGJ1 aWxkCisgICAgICAgIGRpci4gU2luY2UgdGhlIGxpYnJhcmllcyBwYXRocyBvZiB0aGUgZGVwZW5k ZW5jaWVzIGFyZSBhbHJlYWR5CisgICAgICAgIGNvcnJlY3RseSBkZWR1Y2VkIGJ5IGdvYmplY3Qt aW50cm9zcGVjdGlvbiB1c2luZyBsZGQsIHdlIGNhbgorICAgICAgICBqdXN0IHVuc2V0IHRoZSBM REZMQUdTIHZhcmlhYmxlIGJlZm9yZSBjYWxsaW5nIGctaXItc2Nhbm5lciB0bworICAgICAgICBt YWtlIHN1cmUgdGhlIGxpYnJhcmllcyBpbiB0aGUgYnVpbGQgZGlyIHRha2UgcHJlZGVuY2UuCisK KyAgICAgICAgKiBQbGF0Zm9ybUdUSy5jbWFrZToKKwogMjAxNC0wNC0yNSAgQ2FybG9zIEdhcmNp YSBDYW1wb3MgIDxjZ2FyY2lhQGlnYWxpYS5jb20+CiAKICAgICAgICAgW0dUS10gUGx1Z2luIHBy b2Nlc3MgY3Jhc2hlcyB3aXRoIEdUSzIgd2luZG93ZWQgcGx1Z2lucwpkaWZmIC0tZ2l0IGEvU291 cmNlL1dlYktpdDIvUGxhdGZvcm1HVEsuY21ha2UgYi9Tb3VyY2UvV2ViS2l0Mi9QbGF0Zm9ybUdU Sy5jbWFrZQppbmRleCA5MGMyY2Q2Li5iZWExZTRkIDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViS2l0 Mi9QbGF0Zm9ybUdUSy5jbWFrZQorKysgYi9Tb3VyY2UvV2ViS2l0Mi9QbGF0Zm9ybUdUSy5jbWFr ZQpAQCAtNjg0LDcgKzY4NCw3IEBAIGFkZF9jdXN0b21fY29tbWFuZCgKICAgICBPVVRQVVQgJHtD TUFLRV9CSU5BUllfRElSfS9XZWJLaXQyLSR7V0VCS0lUR1RLX0FQSV9WRVJTSU9OfS5naXIKICAg ICBERVBFTkRTIFdlYktpdDIKICAgICBERVBFTkRTIEphdmFTY3JpcHRDb3JlLTMtZ2lyCi0gICAg Q09NTUFORCBDQz0ke0NNQUtFX0NfQ09NUElMRVJ9IENGTEFHUz0tV25vLWRlcHJlY2F0ZWQtZGVj bGFyYXRpb25zCisgICAgQ09NTUFORCBDQz0ke0NNQUtFX0NfQ09NUElMRVJ9IENGTEFHUz0tV25v LWRlcHJlY2F0ZWQtZGVjbGFyYXRpb25zIExERkxBR1M9CiAgICAgICAgICR7SU5UUk9TUEVDVElP Tl9TQ0FOTkVSfQogICAgICAgICAtLXF1aWV0CiAgICAgICAgIC0td2Fybi1hbGwKQEAgLTcyMiw3 ICs3MjIsNyBAQCBhZGRfY3VzdG9tX2NvbW1hbmQoCiAgICAgT1VUUFVUICR7Q01BS0VfQklOQVJZ X0RJUn0vV2ViS2l0MldlYkV4dGVuc2lvbi0ke1dFQktJVEdUS19BUElfVkVSU0lPTn0uZ2lyCiAg ICAgREVQRU5EUyBKYXZhU2NyaXB0Q29yZS0zLWdpcgogICAgIERFUEVORFMgJHtDTUFLRV9CSU5B UllfRElSfS9XZWJLaXQyLSR7V0VCS0lUR1RLX0FQSV9WRVJTSU9OfS5naXIKLSAgICBDT01NQU5E IENDPSR7Q01BS0VfQ19DT01QSUxFUn0gQ0ZMQUdTPS1Xbm8tZGVwcmVjYXRlZC1kZWNsYXJhdGlv bnMKKyAgICBDT01NQU5EIENDPSR7Q01BS0VfQ19DT01QSUxFUn0gQ0ZMQUdTPS1Xbm8tZGVwcmVj YXRlZC1kZWNsYXJhdGlvbnMgTERGTEFHUz0KICAgICAgICAgJHtJTlRST1NQRUNUSU9OX1NDQU5O RVJ9CiAgICAgICAgIC0tcXVpZXQKICAgICAgICAgLS13YXJuLWFsbAo=