132209 2014-04-25 15:11:59 -0700 Set prepare-Changelog flag so that it no longer runs check-webkit-style by default 2014-04-25 16:48:43 -0700 1 1 1 Unclassified WebKit Tools / Tests 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 131115 1 jcraig jcraig commit-queue jcraig oldest_to_newest 1004235 0 jcraig 2014-04-25 15:11:59 -0700 Set prepare-Changelog flag so that it no longer runs check-webkit-style by default Alexey and others object the unrelated false positives in check-webkit-style, so set the default value back to false like the original patch for bug 131115. 1004242 1 230213 jcraig 2014-04-25 15:23:45 -0700 Created attachment 230213 patch 1004256 2 230213 dbates 2014-04-25 15:49:41 -0700 Comment on attachment 230213 patch OK. 1004284 3 230213 commit-queue 2014-04-25 16:48:41 -0700 Comment on attachment 230213 patch Clearing flags on attachment: 230213 Committed r167834: <http://trac.webkit.org/changeset/167834> 1004286 4 commit-queue 2014-04-25 16:48:43 -0700 All reviewed patches have been landed. Closing bug. 230213 2014-04-25 15:23:45 -0700 2014-04-25 16:48:41 -0700 patch webkit132209.diff text/plain 2008 jcraig SW5kZXg6IFRvb2xzL0NoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBUb29scy9DaGFuZ2VMb2cJKHJl dmlzaW9uIDE2NzgyNykKKysrIFRvb2xzL0NoYW5nZUxvZwkod29ya2luZyBjb3B5KQpAQCAtMSwz ICsxLDE2IEBACisyMDE0LTA0LTI1ICBKYW1lcyBDcmFpZyAgPGpjcmFpZ0BhcHBsZS5jb20+CisK KyAgICAgICAgU2V0IHByZXBhcmUtQ2hhbmdlbG9nIGZsYWcgc28gdGhhdCBpdCBubyBsb25nZXIg cnVucyBjaGVjay13ZWJraXQtc3R5bGUgYnkgZGVmYXVsdAorICAgICAgICBodHRwczovL2J1Z3Mu d2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MTMyMjA5CisKKyAgICAgICAgUmV2aWV3ZWQgYnkg Tk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgU2V0IGRlZmF1bHQgdG8gLS1uby1zdHlsZSB0byBh dm9pZCBhZGRpdGlvbmFsIHNwZXcgZnJvbSBmYWxzZSBwb3NpdGl2ZXMgaW4gY2hlY2std2Via2l0 LXN0eWxlLgorICAgICAgICBSdW4gY2hlY2std2Via2l0LXN0eWxlIGJlZm9yZSBnZW5lcmF0aW5n IGNoYW5nZWxvZ3MgdG8gYXZvaWQgYWRkaXRpb25hbCBzcHVyaW91cyBlcnJvcnMuCisKKyAgICAg ICAgKiBTY3JpcHRzL3ByZXBhcmUtQ2hhbmdlTG9nOgorICAgICAgICAobWFpbik6IAorCiAyMDE0 LTA0LTI1ICBNaWNoYWVsIFNhYm9mZiAgPG1zYWJvZmZAYXBwbGUuY29tPgogCiAgICAgICAgIENy YXNoIGluIHBsYXRmb3JtL21hYy9hY2Nlc3NpYmlsaXR5L3RhYmxlLXZpc2libGUtcm93cy5odG1s CkluZGV4OiBUb29scy9TY3JpcHRzL3ByZXBhcmUtQ2hhbmdlTG9nCj09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIFRv b2xzL1NjcmlwdHMvcHJlcGFyZS1DaGFuZ2VMb2cJKHJldmlzaW9uIDE2NzgyMykKKysrIFRvb2xz L1NjcmlwdHMvcHJlcGFyZS1DaGFuZ2VMb2cJKHdvcmtpbmcgY29weSkKQEAgLTEyOCw3ICsxMjgs NyBAQCBzdWIgbWFpbigpCiAgICAgbXkgJGdpdENvbW1pdCA9IDA7CiAgICAgbXkgJGdpdEluZGV4 ID0gIiI7CiAgICAgbXkgJGdpdFJldmlld2VyID0gIiI7Ci0gICAgbXkgJGNoZWNrV2ViS2l0U3R5 bGUgPSAxOworICAgIG15ICRjaGVja1dlYktpdFN0eWxlOwogICAgIG15ICRvcGVuQ2hhbmdlTG9n cyA9IDA7CiAgICAgbXkgJHdyaXRlQ2hhbmdlTG9ncyA9IDE7CiAgICAgbXkgJHNob3dIZWxwID0g MDsKQEAgLTE2OCw2ICsxNjgsMTEgQEAgc3ViIG1haW4oKQogICAgICAgICByZXR1cm4gMTsKICAg ICB9CiAKKyAgICBpZiAoJGNoZWNrV2ViS2l0U3R5bGUpIHsKKyAgICAgICAgcHJpbnQgU1RERVJS ICIgIFJ1bm5pbmcgY2hlY2std2Via2l0LXN0eWxlLlxuICAiOworICAgICAgICBzeXN0ZW0gIiRG aW5kQmluOjpCaW4vY2hlY2std2Via2l0LXN0eWxlIjsKKyAgICB9CisKICAgICBkaWUgIi0tZ2l0 LWNvbW1pdCBhbmQgLS1naXQtaW5kZXggYXJlIGluY29tcGF0aWJsZS4iIGlmICgkZ2l0SW5kZXgg JiYgJGdpdENvbW1pdCk7CiAKICAgICBpc1NWTigpIHx8IGlzR2l0KCkgfHwgZGllICJDb3VsZG4n dCBkZXRlcm1pbmUgeW91ciB2ZXJzaW9uIGNvbnRyb2wgc3lzdGVtLiI7CkBAIC0yMjgsMTEgKzIz Myw2IEBAIHN1YiBtYWluKCkKICAgICAgICAgcHJpbnREaWZmKCRjaGFuZ2VkRmlsZXMsICRnaXRD b21taXQsICRnaXRJbmRleCwgJG1lcmdlQmFzZSk7CiAgICAgfQogCi0gICAgaWYgKCRjaGVja1dl YktpdFN0eWxlKSB7Ci0gICAgICAgIHByaW50IFNUREVSUiAiICBSdW5uaW5nIGNoZWNrLXdlYmtp dC1zdHlsZS5cbiAgIjsKLSAgICAgICAgc3lzdGVtICIkRmluZEJpbjo6QmluL2NoZWNrLXdlYmtp dC1zdHlsZSI7Ci0gICAgfSAgCi0KICAgICAjIE9wZW4gQ2hhbmdlTG9ncy4KICAgICBpZiAoJG9w ZW5DaGFuZ2VMb2dzICYmIEAkY2hhbmdlTG9ncykgewogICAgICAgICBvcGVuQ2hhbmdlTG9ncygk Y2hhbmdlTG9ncyk7Cg==