132194 2014-04-25 07:04:21 -0700 REGRESSION(r167799): ASSERTION in parseGridTemplateShorthand in fast/css-grid-layout/grid-template-shorthand-get-set.html 2014-04-25 14:18:19 -0700 1 1 1 Unclassified WebKit Layout and Rendering 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 1 jfernandez webkit-unassigned allan.jensen ap commit-queue esprehn+autocc glenn gyuyoung.kim jfernandez macpherson menard msaboff stavila thorton oldest_to_newest 1004084 0 jfernandez 2014-04-25 07:04:21 -0700 The change introduced in r167799 broke the Debug build because of an incorrect assertion. Im already working on a fix. 1004090 1 230179 jfernandez 2014-04-25 07:37:33 -0700 Created attachment 230179 Patch 1004092 2 230179 abucur 2014-04-25 07:39:05 -0700 Comment on attachment 230179 Patch r=me 1004096 3 230179 commit-queue 2014-04-25 08:16:24 -0700 Comment on attachment 230179 Patch Clearing flags on attachment: 230179 Committed r167806: <http://trac.webkit.org/changeset/167806> 1004097 4 commit-queue 2014-04-25 08:16:27 -0700 All reviewed patches have been landed. Closing bug. 1004123 5 thorton 2014-04-25 10:01:39 -0700 This is still failing in 167807: http://build.webkit.org/results/Apple%20Mavericks%20Debug%20WK1%20(Tests)/r167807%20(4934)/results.html 1004125 6 thorton 2014-04-25 10:04:18 -0700 Reopening. 1004126 7 jfernandez 2014-04-25 10:09:25 -0700 (In reply to comment #6) > Reopening. I filed bug #132197 but I can provide the patch here, no problem. I'm already working on it 1004128 8 thorton 2014-04-25 10:12:07 -0700 (In reply to comment #7) > (In reply to comment #6) > > Reopening. > > I filed bug #132197 but I can provide the patch here, no problem. > I'm already working on it Putting a little bit more information than "breaks debug tests" in the title might make them easier to find :D Thanks for fixing! 1004134 9 ap 2014-04-25 10:28:10 -0700 *** Bug 132197 has been marked as a duplicate of this bug. *** 1004151 10 thorton 2014-04-25 11:23:35 -0700 Skipped on debug in http://trac.webkit.org/changeset/167812 1004182 11 230195 jfernandez 2014-04-25 13:29:27 -0700 Created attachment 230195 Patch Fix for the Debug layout tests. 1004201 12 230195 commit-queue 2014-04-25 14:18:13 -0700 Comment on attachment 230195 Patch Clearing flags on attachment: 230195 Committed r167821: <http://trac.webkit.org/changeset/167821> 1004202 13 commit-queue 2014-04-25 14:18:19 -0700 All reviewed patches have been landed. Closing bug. 230179 2014-04-25 07:37:33 -0700 2014-04-25 13:29:18 -0700 Patch bug-132194-20140425163710.patch text/plain 1640 jfernandez U3VidmVyc2lvbiBSZXZpc2lvbjogMTY3Nzk5CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggNmNlMWEyODVkYjU1OTc2 YTM4MjhiZjBiMGRiZjU1OWU5OTE4ZDdkMy4uNDg1NjAxZGVlNjYxZWJiYWVhYjgwMDliMTdmNTlh ZWRkZTI4YTJiMyAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSw1ICsxLDE5IEBACiAyMDE0LTA0LTI1ICBKYXZp ZXIgRmVybmFuZGV6ICA8amZlcm5hbmRlekBpZ2FsaWEuY29tPgogCisgICAgICAgIFJFR1JFU1NJ T04ocjE2Nzc5OSk6IEJyZWFrcyBkZWJ1ZyBidWlsZAorICAgICAgICBodHRwczovL2J1Z3Mud2Vi a2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MTMyMTk0CisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9C T0RZIChPT1BTISkuCisKKyAgICAgICAgRml4IHRoZSBkZWJ1ZyBib3RzIGFmdGVyIHIxNjc3OTkK KworICAgICAgICBObyBuZXcgdGVzdHMsIG5vIG5ldyBmdW5jdGlvbmFsaXR5LgorCisgICAgICAg ICogY3NzL0NTU1BhcnNlci5jcHA6CisgICAgICAgIChXZWJDb3JlOjpDU1NQYXJzZXI6OnBhcnNl R3JpZFRlbXBsYXRlU2hvcnRoYW5kKToKKworMjAxNC0wNC0yNSAgSmF2aWVyIEZlcm5hbmRleiAg PGpmZXJuYW5kZXpAaWdhbGlhLmNvbT4KKwogICAgICAgICBbQ1NTIEdyaWQgTGF5b3V0XSBJbXBs ZW1lbnRhdGlvbiBvZiB0aGUgZ3JpZC10ZW1wbGF0ZSBzaG9ydGhhbmQuCiAgICAgICAgIGh0dHBz Oi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0xMjg5ODAKIApkaWZmIC0tZ2l0IGEv U291cmNlL1dlYkNvcmUvY3NzL0NTU1BhcnNlci5jcHAgYi9Tb3VyY2UvV2ViQ29yZS9jc3MvQ1NT UGFyc2VyLmNwcAppbmRleCAyNDAyMjEwNWE1MTdjODNhNzVkMTc4NDA5MGQ2OGEzNDI1YjM5NGY3 Li5kMGIwNjhhZmY2Y2E0MzAwMGU0N2YxNjM2ZjlmNjhkMWI0OTk1ZDA5IDEwMDY0NAotLS0gYS9T b3VyY2UvV2ViQ29yZS9jc3MvQ1NTUGFyc2VyLmNwcAorKysgYi9Tb3VyY2UvV2ViQ29yZS9jc3Mv Q1NTUGFyc2VyLmNwcApAQCAtNDg2MSwxMCArNDg2MSwxMCBAQCBib29sIENTU1BhcnNlcjo6cGFy c2VHcmlkVGVtcGxhdGVSb3dzQW5kQXJlYXMoUGFzc1JlZlB0cjxDU1NWYWx1ZT4gdGVtcGxhdGVD b2x1bQogCiBib29sIENTU1BhcnNlcjo6cGFyc2VHcmlkVGVtcGxhdGVTaG9ydGhhbmQoYm9vbCBp bXBvcnRhbnQpCiB7Ci0gICAgQVNTRVJUKFJ1bnRpbWVFbmFibGVkRmVhdHVyZXM6OmNzc0dyaWRM YXlvdXRFbmFibGVkKCkpOworICAgIEFTU0VSVChjc3NHcmlkTGF5b3V0RW5hYmxlZCgpKTsKIAog ICAgIFNob3J0aGFuZFNjb3BlIHNjb3BlKHRoaXMsIENTU1Byb3BlcnR5V2Via2l0R3JpZFRlbXBs YXRlKTsKLSAgICBBU1NFUlQoZ3JpZFRlbXBsYXRlU2hvcnRoYW5kKCkubGVuZ3RoKCkgPT0gMyk7 CisgICAgQVNTRVJUKHNob3J0aGFuZEZvclByb3BlcnR5KENTU1Byb3BlcnR5V2Via2l0R3JpZFRl bXBsYXRlKS5sZW5ndGgoKSA9PSAzKTsKIAogICAgIC8vIEF0IGxlYXN0ICJub25lIiBtdXN0IGJl IGRlZmluZWQuCiAgICAgaWYgKCFtX3ZhbHVlTGlzdC0+Y3VycmVudCgpKQo= 230195 2014-04-25 13:29:27 -0700 2014-04-25 14:18:12 -0700 Patch bug-132194-20140425222905.patch text/plain 5139 jfernandez U3VidmVyc2lvbiBSZXZpc2lvbjogMTY3ODEzCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggNGExYmNmNWQ3MDExZmZl MzlmYjE5MDk0NDRhYmM1MTVjMTE1OWRjOS4uNWI3ZTc3YmFmM2ExN2Y4MGVmNWFhNmYwZWM4NTQ0 OWY0ZjFlMDEyMCAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDIzIEBACisyMDE0LTA0LTI1ICBKYXZp ZXIgRmVybmFuZGV6ICA8amZlcm5hbmRlekBpZ2FsaWEuY29tPgorCisgICAgICAgIFJFR1JFU1NJ T04ocjE2Nzc5OSk6IEFTU0VSVElPTiBpbiBwYXJzZUdyaWRUZW1wbGF0ZVNob3J0aGFuZCBpbiBm YXN0L2Nzcy1ncmlkLWxheW91dC9ncmlkLXRlbXBsYXRlLXNob3J0aGFuZC1nZXQtc2V0Lmh0bWwK KyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTEzMjE5NAor CisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgIFByb3Blcmx5 IHJlc29sdmluZyB0aGUgZ3JpZC10ZW1wbGF0ZSBzaG9ydGhhbmQgZm9yIHRoZSBjb3JyZXNwb25k aW5nIGxvbmdoYW5kCisgICAgICAgIHByb3BlcnRpZXMuCisKKyAgICAgICAgTm8gbmV3IHRlc3Rz LCBncmlkLXRlbXBsYXRlLXNob3J0aGFuZC1nZXQtc2V0Lmh0bWwgYWxyZWFkeSBjb3ZlcnMgdGhp cyBjYXNlLgorCisgICAgICAgICogY3NzL1N0eWxlUHJvcGVydGllcy5jcHA6CisgICAgICAgIChX ZWJDb3JlOjpTdHlsZVByb3BlcnRpZXM6OmdldFByb3BlcnR5VmFsdWUpOgorICAgICAgICAqIGNz cy9TdHlsZVByb3BlcnR5U2hvcnRoYW5kLmNwcDoKKyAgICAgICAgKFdlYkNvcmU6OnNob3J0aGFu ZEZvclByb3BlcnR5KToKKyAgICAgICAgKFdlYkNvcmU6Om1hdGNoaW5nU2hvcnRoYW5kc0Zvckxv bmdoYW5kKToKKyAgICAgICAgKiBjc3MvU3R5bGVSZXNvbHZlci5jcHA6CisgICAgICAgIChXZWJD b3JlOjpTdHlsZVJlc29sdmVyOjphcHBseVByb3BlcnR5KToKKwogMjAxNC0wNC0yNSAgQW5kcmVh cyBLbGluZyAgPGFrbGluZ0BhcHBsZS5jb20+CiAKICAgICAgICAgTWFyayBzb21lIHRoaW5ncyB3 aXRoIFdURl9NQUtFX0ZBU1RfQUxMT0NBVEVELgpkaWZmIC0tZ2l0IGEvU291cmNlL1dlYkNvcmUv Y3NzL1N0eWxlUHJvcGVydGllcy5jcHAgYi9Tb3VyY2UvV2ViQ29yZS9jc3MvU3R5bGVQcm9wZXJ0 aWVzLmNwcAppbmRleCA4NDBmMDkwMzk3YjA1NmRmNTg3Y2IzZDYxNWU3ODEwZGFjYzkwYmYzLi4x YzdjMjY0N2NjODYxMWI5M2IxMmNkOTEwY2YyMDkyMjk2MGQ2NjY5IDEwMDY0NAotLS0gYS9Tb3Vy Y2UvV2ViQ29yZS9jc3MvU3R5bGVQcm9wZXJ0aWVzLmNwcAorKysgYi9Tb3VyY2UvV2ViQ29yZS9j c3MvU3R5bGVQcm9wZXJ0aWVzLmNwcApAQCAtMTYwLDYgKzE2MCw4IEBAIFN0cmluZyBTdHlsZVBy b3BlcnRpZXM6OmdldFByb3BlcnR5VmFsdWUoQ1NTUHJvcGVydHlJRCBwcm9wZXJ0eUlEKSBjb25z dAogI2lmIEVOQUJMRShDU1NfR1JJRF9MQVlPVVQpCiAgICAgY2FzZSBDU1NQcm9wZXJ0eVdlYmtp dEdyaWRBcmVhOgogICAgICAgICByZXR1cm4gZ2V0U2hvcnRoYW5kVmFsdWUod2Via2l0R3JpZEFy ZWFTaG9ydGhhbmQoKSk7CisgICAgY2FzZSBDU1NQcm9wZXJ0eVdlYmtpdEdyaWRUZW1wbGF0ZToK KyAgICAgICAgcmV0dXJuIGdldFNob3J0aGFuZFZhbHVlKHdlYmtpdEdyaWRUZW1wbGF0ZVNob3J0 aGFuZCgpKTsKICAgICBjYXNlIENTU1Byb3BlcnR5V2Via2l0R3JpZENvbHVtbjoKICAgICAgICAg cmV0dXJuIGdldFNob3J0aGFuZFZhbHVlKHdlYmtpdEdyaWRDb2x1bW5TaG9ydGhhbmQoKSk7CiAg ICAgY2FzZSBDU1NQcm9wZXJ0eVdlYmtpdEdyaWRSb3c6CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2Vi Q29yZS9jc3MvU3R5bGVQcm9wZXJ0eVNob3J0aGFuZC5jcHAgYi9Tb3VyY2UvV2ViQ29yZS9jc3Mv U3R5bGVQcm9wZXJ0eVNob3J0aGFuZC5jcHAKaW5kZXggMWY4MjI4Y2U4ZmFhMDY1OTg3YTg5ZmMw Y2E5MjZhMDQyMzEwNTI1NS4uMzhkNGRmYWJmYzQ1NDVjMGFlNmM2OWQ4NDVhNjM1YjViOWI4ZTNi OCAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvY3NzL1N0eWxlUHJvcGVydHlTaG9ydGhhbmQu Y3BwCisrKyBiL1NvdXJjZS9XZWJDb3JlL2Nzcy9TdHlsZVByb3BlcnR5U2hvcnRoYW5kLmNwcApA QCAtNTY3LDYgKzU2Nyw4IEBAIFN0eWxlUHJvcGVydHlTaG9ydGhhbmQgc2hvcnRoYW5kRm9yUHJv cGVydHkoQ1NTUHJvcGVydHlJRCBwcm9wZXJ0eUlEKQogI2lmIEVOQUJMRShDU1NfR1JJRF9MQVlP VVQpCiAgICAgY2FzZSBDU1NQcm9wZXJ0eVdlYmtpdEdyaWRBcmVhOgogICAgICAgICByZXR1cm4g d2Via2l0R3JpZEFyZWFTaG9ydGhhbmQoKTsKKyAgICBjYXNlIENTU1Byb3BlcnR5V2Via2l0R3Jp ZFRlbXBsYXRlOgorICAgICAgICByZXR1cm4gd2Via2l0R3JpZFRlbXBsYXRlU2hvcnRoYW5kKCk7 CiAgICAgY2FzZSBDU1NQcm9wZXJ0eVdlYmtpdEdyaWRDb2x1bW46CiAgICAgICAgIHJldHVybiB3 ZWJraXRHcmlkQ29sdW1uU2hvcnRoYW5kKCk7CiAgICAgY2FzZSBDU1NQcm9wZXJ0eVdlYmtpdEdy aWRSb3c6CkBAIC03NjcsNiArNzY5LDEwIEBAIFZlY3RvcjxTdHlsZVByb3BlcnR5U2hvcnRoYW5k PiBtYXRjaGluZ1Nob3J0aGFuZHNGb3JMb25naGFuZChDU1NQcm9wZXJ0eUlEIHByb3BlCiAgICAg Y2FzZSBDU1NQcm9wZXJ0eVdlYmtpdEdyaWRSb3dTdGFydDoKICAgICBjYXNlIENTU1Byb3BlcnR5 V2Via2l0R3JpZFJvd0VuZDoKICAgICAgICAgcmV0dXJuIG1ha2VWZWN0b3Iod2Via2l0R3JpZFJv d1Nob3J0aGFuZCgpKTsKKyAgICBjYXNlIENTU1Byb3BlcnR5V2Via2l0R3JpZFRlbXBsYXRlQ29s dW1uczoKKyAgICBjYXNlIENTU1Byb3BlcnR5V2Via2l0R3JpZFRlbXBsYXRlUm93czoKKyAgICBj YXNlIENTU1Byb3BlcnR5V2Via2l0R3JpZFRlbXBsYXRlQXJlYXM6CisgICAgICAgIHJldHVybiBt YWtlVmVjdG9yKHdlYmtpdEdyaWRUZW1wbGF0ZVNob3J0aGFuZCgpKTsKICNlbmRpZgogICAgIGNh c2UgQ1NTUHJvcGVydHlXZWJraXRNYXJnaW5CZWZvcmVDb2xsYXBzZToKICAgICBjYXNlIENTU1By b3BlcnR5V2Via2l0TWFyZ2luQWZ0ZXJDb2xsYXBzZToKZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJD b3JlL2Nzcy9TdHlsZVJlc29sdmVyLmNwcCBiL1NvdXJjZS9XZWJDb3JlL2Nzcy9TdHlsZVJlc29s dmVyLmNwcAppbmRleCA2NTNiNGNiNzMxNTI3NzZmMTFlOTNmNmZkNzZlZjM2YzA2OTVlMDRiLi44 OTEyMWUzYWMxMTI1OGI3MzM1NTVjMTFlNjVkNjM0Nzg5MWUwOWJjIDEwMDY0NAotLS0gYS9Tb3Vy Y2UvV2ViQ29yZS9jc3MvU3R5bGVSZXNvbHZlci5jcHAKKysrIGIvU291cmNlL1dlYkNvcmUvY3Nz L1N0eWxlUmVzb2x2ZXIuY3BwCkBAIC0yMjYzLDYgKzIyNjMsNyBAQCB2b2lkIFN0eWxlUmVzb2x2 ZXI6OmFwcGx5UHJvcGVydHkoQ1NTUHJvcGVydHlJRCBpZCwgQ1NTVmFsdWUqIHZhbHVlKQogICAg IGNhc2UgQ1NTUHJvcGVydHlXZWJraXRGbGV4OgogICAgIGNhc2UgQ1NTUHJvcGVydHlXZWJraXRG bGV4RmxvdzoKICNpZiBFTkFCTEUoQ1NTX0dSSURfTEFZT1VUKQorICAgIGNhc2UgQ1NTUHJvcGVy dHlXZWJraXRHcmlkVGVtcGxhdGU6CiAgICAgY2FzZSBDU1NQcm9wZXJ0eVdlYmtpdEdyaWRBcmVh OgogICAgIGNhc2UgQ1NTUHJvcGVydHlXZWJraXRHcmlkQ29sdW1uOgogICAgIGNhc2UgQ1NTUHJv cGVydHlXZWJraXRHcmlkUm93OgpkaWZmIC0tZ2l0IGEvTGF5b3V0VGVzdHMvQ2hhbmdlTG9nIGIv TGF5b3V0VGVzdHMvQ2hhbmdlTG9nCmluZGV4IGNmMjkwMTI0MzhiYmY4NmQyMzE2M2ZkODAxM2Vm NTMwZTEwMmI3OTcuLjc5NTg1M2NlYmE0MDFmODA4NDgzNjU1NGU3Yjk5NWFlNmU2NzU2NzQgMTAw NjQ0Ci0tLSBhL0xheW91dFRlc3RzL0NoYW5nZUxvZworKysgYi9MYXlvdXRUZXN0cy9DaGFuZ2VM b2cKQEAgLTEsMyArMSwxMiBAQAorMjAxNC0wNC0yNSAgSmF2aWVyIEZlcm5hbmRleiAgPGpmZXJu YW5kZXpAaWdhbGlhLmNvbT4KKworICAgICAgICBSRUdSRVNTSU9OKHIxNjc3OTkpOiBBU1NFUlRJ T04gaW4gcGFyc2VHcmlkVGVtcGxhdGVTaG9ydGhhbmQgaW4gZmFzdC9jc3MtZ3JpZC1sYXlvdXQv Z3JpZC10ZW1wbGF0ZS1zaG9ydGhhbmQtZ2V0LXNldC5odG1sCisgICAgICAgIGh0dHBzOi8vYnVn cy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0xMzIxOTQKKworICAgICAgICBSZXZpZXdlZCBi eSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICAqIFRlc3RFeHBlY3RhdGlvbnM6IFVuc2tpcCBm YXN0L2Nzcy1ncmlkLWxheW91dC9ncmlkLXRlbXBsYXRlLXNob3J0aGFuZC1nZXQtc2V0Lmh0bWwu CisKIDIwMTQtMDQtMjUgIFRpbSBIb3J0b24gIDx0aW1vdGh5X2hvcnRvbkBhcHBsZS5jb20+CiAK ICAgICAgICAgUkVHUkVTU0lPTihyMTY3Nzk5KTogQVNTRVJUSU9OIGluIHBhcnNlR3JpZFRlbXBs YXRlU2hvcnRoYW5kIGluIGZhc3QvY3NzLWdyaWQtbGF5b3V0L2dyaWQtdGVtcGxhdGUtc2hvcnRo YW5kLWdldC1zZXQuaHRtbApkaWZmIC0tZ2l0IGEvTGF5b3V0VGVzdHMvVGVzdEV4cGVjdGF0aW9u cyBiL0xheW91dFRlc3RzL1Rlc3RFeHBlY3RhdGlvbnMKaW5kZXggMzM3OWE5ZjhkMzViYmVjYjFm OGMwMGI0ODhmNGU4YTNjMTY0YzVlYy4uZGNkOTVmYzk2MjVkNmMwNDEwYTY4ODFhMDZiZDNjOWQ2 YjExOTBmNyAxMDA2NDQKLS0tIGEvTGF5b3V0VGVzdHMvVGVzdEV4cGVjdGF0aW9ucworKysgYi9M YXlvdXRUZXN0cy9UZXN0RXhwZWN0YXRpb25zCkBAIC0xMDYsNSArMTA2LDMgQEAgd2Via2l0Lm9y Zy9iLzEzMTMxOCBodHRwL3Rlc3RzL2luc3BlY3Rvci9yZXBsYXkvZG9jdW1lbnQtbGFzdC1tb2Rp ZmllZC1mYWxsYmFjay0KIAogIyBFeHBhbmRvIHByb3BlcnRpZXMgb24gYXR0cmlidXRlIG5vZGVz IGRpc2FwcGVhcgogd2Via2l0Lm9yZy9iLzg4MDQ1IGZhc3QvZG9tL2djLWF0dHJpYnV0ZS1ub2Rl Lmh0bWwgWyBGYWlsdXJlIFBhc3MgXQotCi13ZWJraXQub3JnL2IvMTMyMTk0IFsgRGVidWcgXSBm YXN0L2Nzcy1ncmlkLWxheW91dC9ncmlkLXRlbXBsYXRlLXNob3J0aGFuZC1nZXQtc2V0Lmh0bWwg WyBTa2lwIF0K