132190 2014-04-25 04:51:50 -0700 [GTK] Generate Eclipse project + ninja build for GTK+ if Eclipse in available in the PATH 2014-08-26 11:12:52 -0700 1 1 1 Unclassified WebKit Tools / Tests 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Enhancement --- 1 eocanha webkit-unassigned b.long commit-queue dbates mrobinson oldest_to_newest 1004052 0 eocanha 2014-04-25 04:51:50 -0700 Now that cmake is being used, it should be trivial to use the 'Eclipse CDT4 - Ninja' generator, which does the same as the 'Ninja' generator currently in use, but also creates .project and .cproject files suitable for Eclipse. This would be much better than the approach used in Autotools+Makefile times, where the source code import had some troubles. 1004053 1 230167 eocanha 2014-04-25 04:59:19 -0700 Created attachment 230167 Patch 1004056 2 eocanha 2014-04-25 05:06:35 -0700 Just for the record, I've been used this patch successfully in my box for some time. The only thing needed is to create two symbolic links: .project -> WebKitBuild/Release/.project .cproject -> WebKitBuild/Release/.cproject This is because the project file must be in the root directory of the project (WebKit). After that, just create the project in Eclipse via File, Import, General, Existing projects into workspace. Select the WebKit root dir and perform the import. Enjoy! 1004062 3 230167 gustavo 2014-04-25 05:25:51 -0700 Comment on attachment 230167 Patch Looks OK to me. 1004093 4 mrobinson 2014-04-25 07:39:49 -0700 This seems risky. There are probably people who have eclipse in their path who don't want to use Eclipse to build. 1004094 5 eocanha 2014-04-25 08:10:18 -0700 The eclipse target is a superset of the ninja target. It also generates ninja files, so you can build it "the ninja way". That's how I build it. Assuming that you want to use eclipse if you have it in your path is as risky as assuming that you want to use ninja if you have it in your path (the current approach). 1004095 6 mrobinson 2014-04-25 08:11:12 -0700 Are the ninja files generated for the eclipse target the same as for the ninja target? 1004137 7 eocanha 2014-04-25 10:44:10 -0700 The rules.ninja files are equal. In the build.ninja files, some rules are in different places in the file (some are before, some are after, but I think that's irrelevant for ninja). I know it's not orthodox, but I've "sort"ed both versions of build.ninja and "diff"ed them after that to bypass the place shifting differences. The resulting diff showed 3393 different lines out of 31633. Examining them closely, the main part of them just differ in the position of lib/libANGLESupport.a in the argument list (it's even missing in some of the blocks generated by the Eclipse Ninja target). Apart from that, the "build build.ninja" line is different, as it calls different cmake system files, some only related to Eclipse. 1004140 8 mrobinson 2014-04-25 10:51:39 -0700 Okay. Sound safe, but we should be ready to only do this when requested if it causes issues. 1004949 9 230167 commit-queue 2014-04-29 08:17:37 -0700 Comment on attachment 230167 Patch Clearing flags on attachment: 230167 Committed r167932: <http://trac.webkit.org/changeset/167932> 1004950 10 commit-queue 2014-04-29 08:17:40 -0700 All reviewed patches have been landed. Closing bug. 1031421 11 b.long 2014-08-26 11:12:52 -0700 *** Bug 132062 has been marked as a duplicate of this bug. *** 230167 2014-04-25 04:59:19 -0700 2014-04-29 08:17:37 -0700 Patch bug-132190-20140425115856.patch text/plain 1716 eocanha U3VidmVyc2lvbiBSZXZpc2lvbjogMTY3Nzk4CmRpZmYgLS1naXQgYS9Ub29scy9DaGFuZ2VMb2cg Yi9Ub29scy9DaGFuZ2VMb2cKaW5kZXggMjBlMmM1YTY5OWEyMzVkMjdlZjc2N2Y2N2Q0MTI5NjVm ZjE2NmU5My4uMmRhMTcxM2NmZjYyY2E3OWVjNGU3NGEyNThkZjcwNGNmZGZkNmRhNiAxMDA2NDQK LS0tIGEvVG9vbHMvQ2hhbmdlTG9nCisrKyBiL1Rvb2xzL0NoYW5nZUxvZwpAQCAtMSwzICsxLDE2 IEBACisyMDE0LTA0LTI1ICBFbnJpcXVlIE9jYcOxYSBHb256w6FsZXogIDxlb2NhbmhhQGlnYWxp YS5jb20+CisKKyAgICAgICAgR2VuZXJhdGUgRWNsaXBzZSBwcm9qZWN0ICsgbmluamEgYnVpbGQg Zm9yIEdUSysgaWYgRWNsaXBzZSBpbiBhdmFpbGFibGUgaW4gdGhlIFBBVEgKKyAgICAgICAgaHR0 cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTEzMjE5MAorCisgICAgICAgIFJl dmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgICogU2NyaXB0cy93ZWJraXRkaXJz LnBtOgorICAgICAgICAoY2FuVXNlRWNsaXBzZSk6IFRlc3QgaWYgRWNsaXBzZSBpcyBpbiB0aGUg cGF0aC4gVGhpcyBpcyB0aGUgc2FtZSBtZXRob2QgdXNlZCB0byB0ZXN0CisgICAgICAgICAgICBp ZiBuaW5qYSBpcyBpbiB0aGUgcGF0aC4KKyAgICAgICAgKGdlbmVyYXRlQnVpbGRTeXN0ZW1Gcm9t Q01ha2VQcm9qZWN0KTogVXNlIHRoZSBlY2xpcHNlIGdlbmVyYXRvciBpZiBwb3NzaWJsZSwgZmFs bGJhY2sKKyAgICAgICAgICAgIHRvIHRoZSBwcmV2aW91cyBuaW5qYSBnZW5lcmF0b3IgaWYgbm90 LgorCiAyMDE0LTA0LTI0ICBFZHVhcmRvIExpbWEgTWl0ZXYgIDxlbGltYUBpZ2FsaWEuY29tPgog CiAgICAgICAgIFVucmV2aWV3ZWQgR1RLIGdhcmRlbmluZwpkaWZmIC0tZ2l0IGEvVG9vbHMvU2Ny aXB0cy93ZWJraXRkaXJzLnBtIGIvVG9vbHMvU2NyaXB0cy93ZWJraXRkaXJzLnBtCmluZGV4IDc2 MDMyOGEzYmNiM2M4NDJhYjY3YjE2MzgxY2RkYTNhOTEwN2ZiODQuLjdhYmVjNDJkMzUwZmEyMzBl NGE0NGVkZjA3MTdmZTc2YzMxN2NhNTIgMTAwNzU1Ci0tLSBhL1Rvb2xzL1NjcmlwdHMvd2Via2l0 ZGlycy5wbQorKysgYi9Ub29scy9TY3JpcHRzL3dlYmtpdGRpcnMucG0KQEAgLTE3ODEsNiArMTc4 MSwxMiBAQCBzdWIgY2FuVXNlTmluamEoQCkKICAgICByZXR1cm4gJD8gPT0gMDsKIH0KIAorc3Vi IGNhblVzZUVjbGlwc2UoQCkKK3sKKyAgICBzeXN0ZW0oJ3doaWNoIGVjbGlwc2UgPiAvZGV2L251 bGwnKTsKKyAgICByZXR1cm4gJD8gPT0gMDsKK30KKwogc3ViIGNtYWtlR2VuZXJhdGVkQnVpbGRm aWxlKEApCiB7CiAgICAgbXkgKCR3aWxsVXNlTmluamEpID0gQF87CkBAIC0xODE5LDcgKzE4MjUs MTEgQEAgc3ViIGdlbmVyYXRlQnVpbGRTeXN0ZW1Gcm9tQ01ha2VQcm9qZWN0CiAKICAgICBpZiAo JHdpbGxVc2VOaW5qYSkgewogICAgICAgICBwdXNoIEBhcmdzLCAiLUciOwotICAgICAgICBwdXNo IEBhcmdzLCAiTmluamEiOworICAgICAgICBpZiAoY2FuVXNlRWNsaXBzZSgpKSB7CisgICAgICAg ICAgICBwdXNoIEBhcmdzLCAiJ0VjbGlwc2UgQ0RUNCAtIE5pbmphJyI7CisgICAgICAgIH0gZWxz ZSB7CisgICAgICAgICAgICBwdXNoIEBhcmdzLCAiTmluamEiOworICAgICAgICB9CiAgICAgfQog CiAgICAgIyBEb24ndCB3YXJuIHZhcmlhYmxlcyB3aGljaCBhcmVuJ3QgdXNlZCBieSBjbWFrZSBw b3J0cy4K