132153 2014-04-24 15:59:29 -0700 [iOS] Add some missing overrides and remove unnecessary virtuals 2014-04-24 19:10:29 -0700 1 1 1 Unclassified WebKit WebKit2 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 1 joepeck webkit-unassigned commit-queue eric.carlson glenn jeremyj-wk jer.noble joepeck jonlee philipj sergio oldest_to_newest 1003823 0 joepeck 2014-04-24 15:59:29 -0700 Some iOS header file cleanup noticed while working in related files. 1003824 1 230115 joepeck 2014-04-24 16:00:29 -0700 Created attachment 230115 [PATCH] Proposed Fix 1003900 2 230115 commit-queue 2014-04-24 17:17:35 -0700 Comment on attachment 230115 [PATCH] Proposed Fix Clearing flags on attachment: 230115 Committed r167783: <http://trac.webkit.org/changeset/167783> 1003901 3 commit-queue 2014-04-24 17:17:39 -0700 All reviewed patches have been landed. Closing bug. 230115 2014-04-24 16:00:29 -0700 2014-04-24 17:17:35 -0700 [PATCH] Proposed Fix cleanup.patch text/plain 2721 joepeck ZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJLaXQyL0NoYW5nZUxvZyBiL1NvdXJjZS9XZWJLaXQyL0No YW5nZUxvZwppbmRleCAzZTNjMGI1Li40OTJhYjI4IDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViS2l0 Mi9DaGFuZ2VMb2cKKysrIGIvU291cmNlL1dlYktpdDIvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMTMg QEAKKzIwMTQtMDQtMjQgIEpvc2VwaCBQZWNvcmFybyAgPHBlY29yYXJvQGFwcGxlLmNvbT4KKwor ICAgICAgICBbaU9TXSBBZGQgc29tZSBtaXNzaW5nIG92ZXJyaWRlcyBhbmQgcmVtb3ZlIHVubmVj ZXNzYXJ5IHZpcnR1YWxzCisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVn LmNnaT9pZD0xMzIxNTMKKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKwor ICAgICAgICAqIFVJUHJvY2Vzcy9pb3MvUGFnZUNsaWVudEltcGxJT1MuaDoKKyAgICAgICAgKiBV SVByb2Nlc3MvaW9zL1dlYlZpZGVvRnVsbHNjcmVlbk1hbmFnZXJQcm94eS5oOgorCiAyMDE0LTA0 LTI0ICBNeWxlcyBDLiBNYXhmaWVsZCAgPG1tYXhmaWVsZEBhcHBsZS5jb20+CiAKICAgICAgICAg Rm9udENhY2hlOjpmb250Q2FjaGUoKSBuZXZlciByZXR1cm5zIG51bGxwdHIgc28gaXQgY2FuIGJl IG1hZGUgdG8gcmV0dXJuIGEgcmVmZXJlbmNlIGluc3RlYWQKZGlmZiAtLWdpdCBhL1NvdXJjZS9X ZWJLaXQyL1VJUHJvY2Vzcy9pb3MvUGFnZUNsaWVudEltcGxJT1MuaCBiL1NvdXJjZS9XZWJLaXQy L1VJUHJvY2Vzcy9pb3MvUGFnZUNsaWVudEltcGxJT1MuaAppbmRleCBkYjYwNjkyLi42MjQzZjM0 IDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViS2l0Mi9VSVByb2Nlc3MvaW9zL1BhZ2VDbGllbnRJbXBs SU9TLmgKKysrIGIvU291cmNlL1dlYktpdDIvVUlQcm9jZXNzL2lvcy9QYWdlQ2xpZW50SW1wbElP Uy5oCkBAIC0xMTMsOSArMTEzLDkgQEAgcHJpdmF0ZToKICAgICB2aXJ0dWFsIHZvaWQgc3RvcEFz c2lzdGluZ05vZGUoKSBvdmVycmlkZTsKICAgICB2aXJ0dWFsIHZvaWQgc2VsZWN0aW9uRGlkQ2hh bmdlKCkgb3ZlcnJpZGU7CiAgICAgdmlydHVhbCBib29sIGludGVycHJldEtleUV2ZW50KGNvbnN0 IE5hdGl2ZVdlYktleWJvYXJkRXZlbnQmLCBib29sIGlzQ2hhckV2ZW50KSBvdmVycmlkZTsKLSAg ICB2aXJ0dWFsIHZvaWQgcG9zaXRpb25JbmZvcm1hdGlvbkRpZENoYW5nZShjb25zdCBJbnRlcmFj dGlvbkluZm9ybWF0aW9uQXRQb3NpdGlvbiYpOwotICAgIHZpcnR1YWwgdm9pZCBzYXZlSW1hZ2VU b0xpYnJhcnkoUGFzc1JlZlB0cjxXZWJDb3JlOjpTaGFyZWRCdWZmZXI+KTsKLSAgICB2aXJ0dWFs IHZvaWQgZGlkVXBkYXRlQmxvY2tTZWxlY3Rpb25XaXRoVG91Y2godWludDMyX3QgdG91Y2gsIHVp bnQzMl90IGZsYWdzLCBmbG9hdCBncm93VGhyZXNob2xkLCBmbG9hdCBzaHJpbmtUaHJlc2hvbGQp OworICAgIHZpcnR1YWwgdm9pZCBwb3NpdGlvbkluZm9ybWF0aW9uRGlkQ2hhbmdlKGNvbnN0IElu dGVyYWN0aW9uSW5mb3JtYXRpb25BdFBvc2l0aW9uJikgb3ZlcnJpZGU7CisgICAgdmlydHVhbCB2 b2lkIHNhdmVJbWFnZVRvTGlicmFyeShQYXNzUmVmUHRyPFdlYkNvcmU6OlNoYXJlZEJ1ZmZlcj4p IG92ZXJyaWRlOworICAgIHZpcnR1YWwgdm9pZCBkaWRVcGRhdGVCbG9ja1NlbGVjdGlvbldpdGhU b3VjaCh1aW50MzJfdCB0b3VjaCwgdWludDMyX3QgZmxhZ3MsIGZsb2F0IGdyb3dUaHJlc2hvbGQs IGZsb2F0IHNocmlua1RocmVzaG9sZCkgb3ZlcnJpZGU7CiAgICAgdmlydHVhbCB2b2lkIHNob3dQ bGF5YmFja1RhcmdldFBpY2tlcihib29sIGhhc1ZpZGVvLCBjb25zdCBXZWJDb3JlOjpJbnRSZWN0 JiBlbGVtZW50UmVjdCkgb3ZlcnJpZGU7CiAKICNpZiBFTkFCTEUoSU5TUEVDVE9SKQpkaWZmIC0t Z2l0IGEvU291cmNlL1dlYktpdDIvVUlQcm9jZXNzL2lvcy9XZWJWaWRlb0Z1bGxzY3JlZW5NYW5h Z2VyUHJveHkuaCBiL1NvdXJjZS9XZWJLaXQyL1VJUHJvY2Vzcy9pb3MvV2ViVmlkZW9GdWxsc2Ny ZWVuTWFuYWdlclByb3h5LmgKaW5kZXggMTVkZDY4My4uZjVmNWUzZSAxMDA2NDQKLS0tIGEvU291 cmNlL1dlYktpdDIvVUlQcm9jZXNzL2lvcy9XZWJWaWRlb0Z1bGxzY3JlZW5NYW5hZ2VyUHJveHku aAorKysgYi9Tb3VyY2UvV2ViS2l0Mi9VSVByb2Nlc3MvaW9zL1dlYlZpZGVvRnVsbHNjcmVlbk1h bmFnZXJQcm94eS5oCkBAIC01Miw4ICs1Miw4IEBAIHByaXZhdGU6CiAgICAgdmlydHVhbCB2b2lk IGRpZFJlY2VpdmVNZXNzYWdlKElQQzo6Q29ubmVjdGlvbiosIElQQzo6TWVzc2FnZURlY29kZXIm KSBvdmVycmlkZTsKIAogICAgIC8vIFRyYW5zbGF0ZSB0byBGdWxsc2NyZWVuSW50ZXJmYWNlCi0g ICAgdmlydHVhbCB2b2lkIGVudGVyRnVsbHNjcmVlbldpdGhJRCh1aW50MzJfdCwgV2ViQ29yZTo6 SW50UmVjdCBpbml0aWFsUmVjdCk7Ci0gICAgdmlydHVhbCB2b2lkIHNldFNlZWthYmxlUmFuZ2Vz VmVjdG9yKFZlY3RvcjxzdGQ6OnBhaXI8ZG91YmxlLCBkb3VibGU+PiYpOworICAgIHZvaWQgZW50 ZXJGdWxsc2NyZWVuV2l0aElEKHVpbnQzMl90LCBXZWJDb3JlOjpJbnRSZWN0IGluaXRpYWxSZWN0 KTsKKyAgICB2b2lkIHNldFNlZWthYmxlUmFuZ2VzVmVjdG9yKFZlY3RvcjxzdGQ6OnBhaXI8ZG91 YmxlLCBkb3VibGU+PiYpOwogCiAgICAgLy8gRnVsbHNjcmVlbiBPYnNlcnZlcgogICAgIHZpcnR1 YWwgdm9pZCByZXF1ZXN0RXhpdEZ1bGxzY3JlZW4oKSBvdmVycmlkZTsK