132151 2014-04-24 15:35:05 -0700 Mark Supplement instead of RefCountedSupplement in NavigatorContentUtils 2014-04-24 21:00:19 -0700 1 1 1 Unclassified WebKit New Bugs 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 1 gyuyoung.kim gyuyoung.kim commit-queue oldest_to_newest 1003809 0 gyuyoung.kim 2014-04-24 15:35:05 -0700 Though NavigatorContentUtils didn't have any scenario which can be shared across navigator instances, it has used RefCountedSupplement. So, we need to use Supplement<Page> instead of RefCountedSupplement<>. 1003814 1 gyuyoung.kim 2014-04-24 15:39:23 -0700 (In reply to comment #0) > Though NavigatorContentUtils didn't have any scenario which can be shared across navigator instances, it has used RefCountedSupplement. So, we need to use Supplement<Page> instead of RefCountedSupplement<>. s/across navigator instances/across page instances/g It was considered to make the NavigatorContentUtils shareable across navigator instances. However, it has used RefCountedSupplement<Page> instead of RefCountedSupplement<Navigator>. 1003820 2 230114 gyuyoung.kim 2014-04-24 15:47:22 -0700 Created attachment 230114 Patch 1003897 3 230114 darin 2014-04-24 17:14:21 -0700 Comment on attachment 230114 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=230114&action=review > Source/WebCore/Modules/navigatorcontentutils/NavigatorContentUtils.h:58 > + static PassOwnPtr<NavigatorContentUtils> create(std::unique_ptr<NavigatorContentUtilsClient>); Should use std::unique_ptr, not PassOwnPtr, in new code. But I guess we need to fix all Supplement implementers at once. 1003949 4 gyuyoung.kim 2014-04-24 20:31:57 -0700 (In reply to comment #3) > (From update of attachment 230114 [details]) > View in context: https://bugs.webkit.org/attachment.cgi?id=230114&action=review > > > Source/WebCore/Modules/navigatorcontentutils/NavigatorContentUtils.h:58 > > + static PassOwnPtr<NavigatorContentUtils> create(std::unique_ptr<NavigatorContentUtilsClient>); > > Should use std::unique_ptr, not PassOwnPtr, in new code. But I guess we need to fix all Supplement implementers at once. Yes, I also wanna to it at once. I'm gonna file a bug for it. 1003953 5 230114 commit-queue 2014-04-24 21:00:14 -0700 Comment on attachment 230114 Patch Clearing flags on attachment: 230114 Committed r167789: <http://trac.webkit.org/changeset/167789> 1003954 6 commit-queue 2014-04-24 21:00:19 -0700 All reviewed patches have been landed. Closing bug. 230114 2014-04-24 15:47:22 -0700 2014-04-24 21:00:13 -0700 Patch bug-132151-20140425074700.patch text/plain 4474 gyuyoung.kim U3VidmVyc2lvbiBSZXZpc2lvbjogMTY3NzI5CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggNTFjYzdkNWViOTAyYTIy NjgyNmZlM2NmMDNhZjM2MWQ4YTgwMjQxNy4uMzQ1ZGNlODg0ODc3ZjAwMWEyZjNkYjhkZTIwNGY3 NDAyMDQ4ODBhNCAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDI0IEBACisyMDE0LTA0LTI0ICBHeXV5 b3VuZyBLaW0gIDxneXV5b3VuZy5raW1Ac2Ftc3VuZy5jb20+CisKKyAgICAgICAgTWFyayBTdXBw bGVtZW50IGluc3RlYWQgb2YgUmVmQ291bnRlZFN1cHBsZW1lbnQgaW4gTmF2aWdhdG9yQ29udGVu dFV0aWxzIAorICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9 MTMyMTUxCisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAg VGhvdWdoIE9yaWdpbmFsIGdvYWwgd2FzIHRvIG1ha2UgaXQgc2hhcmFibGUgYWNyb3NzIG5hdmln YXRvciBpbnN0YW5jZXMsIHRoZSBOYXZpZ2F0b3JDb250ZW50VXRpbHMKKyAgICAgICAgaGFzIHVz ZWQgUmVmQ291bnRlZFN1cHBsZW1lbnQ8UGFnZT4gaW5zdGVhZCBvZiBSZWZDb3VudGVkU3VwcGxl bWVudDxOYXZpZ2F0b3I+LiBUaGlzIHBhdGNoIG1ha2VzIGl0CisgICAgICAgIHVzZSBTdXBwbGVt ZW50PFBhZ2U+IGJlY2F1c2UgdGhlcmUgaXMgbm8gc2NlbmFyaW8gd2hpY2ggbmVlZHMgdG8gYmUg c2hhcmVkIGFjcm9zcyBuYXZpZ2F0b3IgaW5zdGFuY2VzLgorCisgICAgICAgIEJsaW5rIG1lcmdl IGZyb20gaHR0cHM6Ly9zcmMuY2hyb21pdW0ub3JnL3ZpZXd2Yy9ibGluaz92aWV3PXJldiZyZXZp c2lvbj0xNzE0MDMuCisKKyAgICAgICAgTm8gbmV3IHRlc3RzLCBubyBiZWhhdmlvciBjaGFuZ2Vz LgorCisgICAgICAgICogTW9kdWxlcy9uYXZpZ2F0b3Jjb250ZW50dXRpbHMvTmF2aWdhdG9yQ29u dGVudFV0aWxzLmNwcDoKKyAgICAgICAgKFdlYkNvcmU6Ok5hdmlnYXRvckNvbnRlbnRVdGlsczo6 ZnJvbSk6CisgICAgICAgIChXZWJDb3JlOjpOYXZpZ2F0b3JDb250ZW50VXRpbHM6OmNyZWF0ZSk6 CisgICAgICAgIChXZWJDb3JlOjpwcm92aWRlTmF2aWdhdG9yQ29udGVudFV0aWxzVG8pOgorICAg ICAgICAqIE1vZHVsZXMvbmF2aWdhdG9yY29udGVudHV0aWxzL05hdmlnYXRvckNvbnRlbnRVdGls cy5oOgorCiAyMDE0LTA0LTIzICBEYXZpZCBIeWF0dCAgPGh5YXR0QGFwcGxlLmNvbT4KIAogICAg ICAgICBbTmV3IE11bHRpY29sdW1uXSBmYXN0L211bHRpY29sL2ZpeGVkLWNvbHVtbi1wZXJjZW50 LWxvZ2ljYWwtaGVpZ2h0LW9ydGhvZ29uYWwtd3JpdGluZy1tb2RlLmh0bWwgZmFpbHMKZGlmZiAt LWdpdCBhL1NvdXJjZS9XZWJDb3JlL01vZHVsZXMvbmF2aWdhdG9yY29udGVudHV0aWxzL05hdmln YXRvckNvbnRlbnRVdGlscy5jcHAgYi9Tb3VyY2UvV2ViQ29yZS9Nb2R1bGVzL25hdmlnYXRvcmNv bnRlbnR1dGlscy9OYXZpZ2F0b3JDb250ZW50VXRpbHMuY3BwCmluZGV4IGRkODhhNTQ4YWY2NTFl ZjdmYWYwZTkxNWZkZjdiMTAzZjY5YTg0OTUuLjliMDYyN2E5YmM4YWYyOGFlYjY2ZmU4MDBhNThj NDNkYWJiYzJkZDkgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJDb3JlL01vZHVsZXMvbmF2aWdhdG9y Y29udGVudHV0aWxzL05hdmlnYXRvckNvbnRlbnRVdGlscy5jcHAKKysrIGIvU291cmNlL1dlYkNv cmUvTW9kdWxlcy9uYXZpZ2F0b3Jjb250ZW50dXRpbHMvTmF2aWdhdG9yQ29udGVudFV0aWxzLmNw cApAQCAtMTE5LDE2ICsxMTksMTYgQEAgc3RhdGljIGJvb2wgdmVyaWZ5UHJvdG9jb2xIYW5kbGVy U2NoZW1lKGNvbnN0IFN0cmluZyYgc2NoZW1lLCBFeGNlcHRpb25Db2RlJiBlYykKIAogTmF2aWdh dG9yQ29udGVudFV0aWxzKiBOYXZpZ2F0b3JDb250ZW50VXRpbHM6OmZyb20oUGFnZSogcGFnZSkK IHsKLSAgICByZXR1cm4gc3RhdGljX2Nhc3Q8TmF2aWdhdG9yQ29udGVudFV0aWxzKj4oUmVmQ291 bnRlZFN1cHBsZW1lbnQ8UGFnZSwgTmF2aWdhdG9yQ29udGVudFV0aWxzPjo6ZnJvbShwYWdlLCBO YXZpZ2F0b3JDb250ZW50VXRpbHM6OnN1cHBsZW1lbnROYW1lKCkpKTsKKyAgICByZXR1cm4gc3Rh dGljX2Nhc3Q8TmF2aWdhdG9yQ29udGVudFV0aWxzKj4oU3VwcGxlbWVudDxQYWdlPjo6ZnJvbShw YWdlLCBzdXBwbGVtZW50TmFtZSgpKSk7CiB9CiAKIE5hdmlnYXRvckNvbnRlbnRVdGlsczo6fk5h dmlnYXRvckNvbnRlbnRVdGlscygpCiB7CiB9CiAKLVBhc3NSZWY8TmF2aWdhdG9yQ29udGVudFV0 aWxzPiBOYXZpZ2F0b3JDb250ZW50VXRpbHM6OmNyZWF0ZShzdGQ6OnVuaXF1ZV9wdHI8TmF2aWdh dG9yQ29udGVudFV0aWxzQ2xpZW50PiBjbGllbnQpCitQYXNzT3duUHRyPE5hdmlnYXRvckNvbnRl bnRVdGlscz4gTmF2aWdhdG9yQ29udGVudFV0aWxzOjpjcmVhdGUoc3RkOjp1bmlxdWVfcHRyPE5h dmlnYXRvckNvbnRlbnRVdGlsc0NsaWVudD4gY2xpZW50KQogewotICAgIHJldHVybiBhZG9wdFJl ZigqbmV3IE5hdmlnYXRvckNvbnRlbnRVdGlscyhzdGQ6Om1vdmUoY2xpZW50KSkpOworICAgIHJl dHVybiBhZG9wdFB0cihuZXcgTmF2aWdhdG9yQ29udGVudFV0aWxzKHN0ZDo6bW92ZShjbGllbnQp KSk7CiB9CiAKIHZvaWQgTmF2aWdhdG9yQ29udGVudFV0aWxzOjpyZWdpc3RlclByb3RvY29sSGFu ZGxlcihOYXZpZ2F0b3IqIG5hdmlnYXRvciwgY29uc3QgU3RyaW5nJiBzY2hlbWUsIGNvbnN0IFN0 cmluZyYgdXJsLCBjb25zdCBTdHJpbmcmIHRpdGxlLCBFeGNlcHRpb25Db2RlJiBlYykKQEAgLTIw OSw3ICsyMDksNyBAQCBjb25zdCBjaGFyKiBOYXZpZ2F0b3JDb250ZW50VXRpbHM6OnN1cHBsZW1l bnROYW1lKCkKIAogdm9pZCBwcm92aWRlTmF2aWdhdG9yQ29udGVudFV0aWxzVG8oUGFnZSogcGFn ZSwgc3RkOjp1bmlxdWVfcHRyPE5hdmlnYXRvckNvbnRlbnRVdGlsc0NsaWVudD4gY2xpZW50KQog ewotICAgIFJlZkNvdW50ZWRTdXBwbGVtZW50PFBhZ2UsIE5hdmlnYXRvckNvbnRlbnRVdGlscz46 OnByb3ZpZGVUbyhwYWdlLCBOYXZpZ2F0b3JDb250ZW50VXRpbHM6OnN1cHBsZW1lbnROYW1lKCks IE5hdmlnYXRvckNvbnRlbnRVdGlsczo6Y3JlYXRlKHN0ZDo6bW92ZShjbGllbnQpKSk7CisgICAg TmF2aWdhdG9yQ29udGVudFV0aWxzOjpwcm92aWRlVG8ocGFnZSwgTmF2aWdhdG9yQ29udGVudFV0 aWxzOjpzdXBwbGVtZW50TmFtZSgpLCBOYXZpZ2F0b3JDb250ZW50VXRpbHM6OmNyZWF0ZShzdGQ6 Om1vdmUoY2xpZW50KSkpOwogfQogCiB9IC8vIG5hbWVzcGFjZSBXZWJDb3JlCmRpZmYgLS1naXQg YS9Tb3VyY2UvV2ViQ29yZS9Nb2R1bGVzL25hdmlnYXRvcmNvbnRlbnR1dGlscy9OYXZpZ2F0b3JD b250ZW50VXRpbHMuaCBiL1NvdXJjZS9XZWJDb3JlL01vZHVsZXMvbmF2aWdhdG9yY29udGVudHV0 aWxzL05hdmlnYXRvckNvbnRlbnRVdGlscy5oCmluZGV4IDBlOTRmZmFmYzk4MmUxY2Q4MzIzMzdk MjkwZDc1OTcwNTkxNDIyZWQuLjVhNDAyOWM3MzYwMTU1MzYwYmE5MTJmNjA5ZjAzMjg5MmM5ZjY3 OWIgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJDb3JlL01vZHVsZXMvbmF2aWdhdG9yY29udGVudHV0 aWxzL05hdmlnYXRvckNvbnRlbnRVdGlscy5oCisrKyBiL1NvdXJjZS9XZWJDb3JlL01vZHVsZXMv bmF2aWdhdG9yY29udGVudHV0aWxzL05hdmlnYXRvckNvbnRlbnRVdGlscy5oCkBAIC00MSw3ICs0 MSw3IEBAIGNsYXNzIE5hdmlnYXRvcjsKIAogdHlwZWRlZiBpbnQgRXhjZXB0aW9uQ29kZTsKIAot Y2xhc3MgTmF2aWdhdG9yQ29udGVudFV0aWxzIGZpbmFsIDogcHVibGljIFJlZkNvdW50ZWRTdXBw bGVtZW50PFBhZ2UsIE5hdmlnYXRvckNvbnRlbnRVdGlscz4geworY2xhc3MgTmF2aWdhdG9yQ29u dGVudFV0aWxzIGZpbmFsIDogcHVibGljIFN1cHBsZW1lbnQ8UGFnZT4gewogcHVibGljOgogICAg IHZpcnR1YWwgfk5hdmlnYXRvckNvbnRlbnRVdGlscygpOwogCkBAIC01NSw3ICs1NSw3IEBAIHB1 YmxpYzoKICAgICBzdGF0aWMgdm9pZCB1bnJlZ2lzdGVyUHJvdG9jb2xIYW5kbGVyKE5hdmlnYXRv ciosIGNvbnN0IFN0cmluZyYgc2NoZW1lLCBjb25zdCBTdHJpbmcmIHVybCwgRXhjZXB0aW9uQ29k ZSYpOwogI2VuZGlmCiAKLSAgICBzdGF0aWMgUGFzc1JlZjxOYXZpZ2F0b3JDb250ZW50VXRpbHM+ IGNyZWF0ZShzdGQ6OnVuaXF1ZV9wdHI8TmF2aWdhdG9yQ29udGVudFV0aWxzQ2xpZW50Pik7Cisg ICAgc3RhdGljIFBhc3NPd25QdHI8TmF2aWdhdG9yQ29udGVudFV0aWxzPiBjcmVhdGUoc3RkOjp1 bmlxdWVfcHRyPE5hdmlnYXRvckNvbnRlbnRVdGlsc0NsaWVudD4pOwogCiBwcml2YXRlOgogICAg IGV4cGxpY2l0IE5hdmlnYXRvckNvbnRlbnRVdGlscyhzdGQ6OnVuaXF1ZV9wdHI8TmF2aWdhdG9y Q29udGVudFV0aWxzQ2xpZW50PiBjbGllbnQpCg==