132147 2014-04-24 15:15:18 -0700 REGRESSION: Apparent hang of PCE.js Mac OS System 7.0.1 on ARM64 devices 2014-04-24 17:14:46 -0700 1 1 1 Unclassified WebKit JavaScriptCore 528+ (Nightly build) iPhone / iPad All RESOLVED FIXED P2 Normal --- 1 msaboff msaboff oldest_to_newest 1003796 0 msaboff 2014-04-24 15:15:18 -0700 This is fundamentally an 68K instruction emulator. Tracked the issue to MacroAssemblerARM64.h where we inadvertently use the destination register for both the source and destination in two arg or64(), eor32( ) and eor64(). 1003799 1 230111 msaboff 2014-04-24 15:20:29 -0700 Created attachment 230111 Patch 1003803 2 230111 mhahnenberg 2014-04-24 15:22:52 -0700 Comment on attachment 230111 Patch r=me. Is it possible to write a test? 1003819 3 msaboff 2014-04-24 15:42:51 -0700 (In reply to comment #2) > (From update of attachment 230111 [details]) > r=me. Is it possible to write a test? I think so. I'll spend some time to see if I can come up with one. 1003882 4 230118 msaboff 2014-04-24 16:56:44 -0700 Created attachment 230118 Patch with test added 1003888 5 230118 mark.lam 2014-04-24 17:04:03 -0700 Comment on attachment 230118 Patch with test added r=me 1003898 6 msaboff 2014-04-24 17:14:46 -0700 Committed r167782: <http://trac.webkit.org/changeset/167782> 230111 2014-04-24 15:20:29 -0700 2014-04-24 16:56:44 -0700 Patch 132147.patch text/plain 2144 msaboff SW5kZXg6IFNvdXJjZS9KYXZhU2NyaXB0Q29yZS9DaGFuZ2VMb2cKPT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PQotLS0gU291 cmNlL0phdmFTY3JpcHRDb3JlL0NoYW5nZUxvZwkocmV2aXNpb24gMTY3Nzc3KQorKysgU291cmNl L0phdmFTY3JpcHRDb3JlL0NoYW5nZUxvZwkod29ya2luZyBjb3B5KQpAQCAtMSwzICsxLDE3IEBA CisyMDE0LTA0LTI0ICBNaWNoYWVsIFNhYm9mZiAgPG1zYWJvZmZAYXBwbGUuY29tPgorCisgICAg ICAgIFJFR1JFU1NJT046IEFwcGFyZW50IGhhbmcgb2YgUENFLmpzIE1hYyBPUyBTeXN0ZW0gNy4w LjEgb24gQVJNNjQgZGV2aWNlcworICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93 X2J1Zy5jZ2k/aWQ9MTMyMTQ3CisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISku CisKKyAgICAgICAgRml4ZWQgb3I2NCgpLCBlb3IzMiggKSBhbmQgZW9yNjQoKSB0byB1c2UgInNy YyIgcmVnaXN0ZXIgd2hlbiB3ZSBoYXZlIGEgdmFsaWQgbG9naWNhbEltbS4KKworICAgICAgICAq IGFzc2VtYmxlci9NYWNyb0Fzc2VtYmxlckFSTTY0Lmg6CisgICAgICAgIChKU0M6Ok1hY3JvQXNz ZW1ibGVyQVJNNjQ6Om9yNjQpOgorICAgICAgICAoSlNDOjpNYWNyb0Fzc2VtYmxlckFSTTY0Ojp4 b3IzMik6CisgICAgICAgIChKU0M6Ok1hY3JvQXNzZW1ibGVyQVJNNjQ6OnhvcjY0KToKKwogMjAx NC0wNC0yNCAgTWFyayBMYW0gIDxtYXJrLmxhbUBhcHBsZS5jb20+CiAKICAgICAgICAgTWFrZSBz bG93UGF0aEFsbG9jc0JldHdlZW5HQ3MgYSBydW50aW1lIG9wdGlvbi4KSW5kZXg6IFNvdXJjZS9K YXZhU2NyaXB0Q29yZS9hc3NlbWJsZXIvTWFjcm9Bc3NlbWJsZXJBUk02NC5oCj09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0K LS0tIFNvdXJjZS9KYXZhU2NyaXB0Q29yZS9hc3NlbWJsZXIvTWFjcm9Bc3NlbWJsZXJBUk02NC5o CShyZXZpc2lvbiAxNjc2ODMpCisrKyBTb3VyY2UvSmF2YVNjcmlwdENvcmUvYXNzZW1ibGVyL01h Y3JvQXNzZW1ibGVyQVJNNjQuaAkod29ya2luZyBjb3B5KQpAQCAtNTA0LDcgKzUwNCw3IEBAIHB1 YmxpYzoKICAgICAgICAgTG9naWNhbEltbWVkaWF0ZSBsb2dpY2FsSW1tID0gTG9naWNhbEltbWVk aWF0ZTo6Y3JlYXRlNjQoc3RhdGljX2Nhc3Q8aW50cHRyX3Q+KHN0YXRpY19jYXN0PGludDY0X3Q+ KGltbS5tX3ZhbHVlKSkpOwogCiAgICAgICAgIGlmIChsb2dpY2FsSW1tLmlzVmFsaWQoKSkgewot ICAgICAgICAgICAgbV9hc3NlbWJsZXIub3JyPDY0PihkZXN0LCBkZXN0LCBsb2dpY2FsSW1tKTsK KyAgICAgICAgICAgIG1fYXNzZW1ibGVyLm9ycjw2ND4oZGVzdCwgc3JjLCBsb2dpY2FsSW1tKTsK ICAgICAgICAgICAgIHJldHVybjsKICAgICAgICAgfQogCkBAIC03MTMsNyArNzEzLDcgQEAgcHVi bGljOgogICAgICAgICAgICAgTG9naWNhbEltbWVkaWF0ZSBsb2dpY2FsSW1tID0gTG9naWNhbElt bWVkaWF0ZTo6Y3JlYXRlMzIoaW1tLm1fdmFsdWUpOwogCiAgICAgICAgICAgICBpZiAobG9naWNh bEltbS5pc1ZhbGlkKCkpIHsKLSAgICAgICAgICAgICAgICBtX2Fzc2VtYmxlci5lb3I8MzI+KGRl c3QsIGRlc3QsIGxvZ2ljYWxJbW0pOworICAgICAgICAgICAgICAgIG1fYXNzZW1ibGVyLmVvcjwz Mj4oZGVzdCwgc3JjLCBsb2dpY2FsSW1tKTsKICAgICAgICAgICAgICAgICByZXR1cm47CiAgICAg ICAgICAgICB9CiAKQEAgLTc1Miw3ICs3NTIsNyBAQCBwdWJsaWM6CiAgICAgICAgICAgICBMb2dp Y2FsSW1tZWRpYXRlIGxvZ2ljYWxJbW0gPSBMb2dpY2FsSW1tZWRpYXRlOjpjcmVhdGU2NChzdGF0 aWNfY2FzdDxpbnRwdHJfdD4oc3RhdGljX2Nhc3Q8aW50NjRfdD4oaW1tLm1fdmFsdWUpKSk7CiAK ICAgICAgICAgICAgIGlmIChsb2dpY2FsSW1tLmlzVmFsaWQoKSkgewotICAgICAgICAgICAgICAg IG1fYXNzZW1ibGVyLmVvcjw2ND4oZGVzdCwgZGVzdCwgbG9naWNhbEltbSk7CisgICAgICAgICAg ICAgICAgbV9hc3NlbWJsZXIuZW9yPDY0PihkZXN0LCBzcmMsIGxvZ2ljYWxJbW0pOwogICAgICAg ICAgICAgICAgIHJldHVybjsKICAgICAgICAgICAgIH0KIAo= 230118 2014-04-24 16:56:44 -0700 2014-04-24 17:04:02 -0700 Patch with test added 132147-2.patch text/plain 2959 msaboff SW5kZXg6IFNvdXJjZS9KYXZhU2NyaXB0Q29yZS9DaGFuZ2VMb2cKPT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PQotLS0gU291 cmNlL0phdmFTY3JpcHRDb3JlL0NoYW5nZUxvZwkocmV2aXNpb24gMTY3NzgwKQorKysgU291cmNl L0phdmFTY3JpcHRDb3JlL0NoYW5nZUxvZwkod29ya2luZyBjb3B5KQpAQCAtMSwzICsxLDE4IEBA CisyMDE0LTA0LTI0ICBNaWNoYWVsIFNhYm9mZiAgPG1zYWJvZmZAYXBwbGUuY29tPgorCisgICAg ICAgIFJFR1JFU1NJT046IEFwcGFyZW50IGhhbmcgb2YgUENFLmpzIE1hYyBPUyBTeXN0ZW0gNy4w LjEgb24gQVJNNjQgZGV2aWNlcworICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93 X2J1Zy5jZ2k/aWQ9MTMyMTQ3CisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISku CisKKyAgICAgICAgRml4ZWQgb3I2NCgpLCBlb3IzMiggKSBhbmQgZW9yNjQoKSB0byB1c2UgInNy YyIgcmVnaXN0ZXIgd2hlbiB3ZSBoYXZlIGEgdmFsaWQgbG9naWNhbEltbS4KKworICAgICAgICAq IGFzc2VtYmxlci9NYWNyb0Fzc2VtYmxlckFSTTY0Lmg6CisgICAgICAgIChKU0M6Ok1hY3JvQXNz ZW1ibGVyQVJNNjQ6Om9yNjQpOgorICAgICAgICAoSlNDOjpNYWNyb0Fzc2VtYmxlckFSTTY0Ojp4 b3IzMik6CisgICAgICAgIChKU0M6Ok1hY3JvQXNzZW1ibGVyQVJNNjQ6OnhvcjY0KToKKyAgICAg ICAgKiB0ZXN0cy9zdHJlc3MvcmVncmVzcy0xMzIxNDcuanM6IEFkZGVkIHRlc3QuCisKIDIwMTQt MDQtMjQgIE1hcmsgTGFtICA8bWFyay5sYW1AYXBwbGUuY29tPgogCiAgICAgICAgIE1ha2Ugc2xv d1BhdGhBbGxvY3NCZXR3ZWVuR0NzIGEgcnVudGltZSBvcHRpb24uCkluZGV4OiBTb3VyY2UvSmF2 YVNjcmlwdENvcmUvYXNzZW1ibGVyL01hY3JvQXNzZW1ibGVyQVJNNjQuaAo9PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0t LSBTb3VyY2UvSmF2YVNjcmlwdENvcmUvYXNzZW1ibGVyL01hY3JvQXNzZW1ibGVyQVJNNjQuaAko cmV2aXNpb24gMTY3NjgzKQorKysgU291cmNlL0phdmFTY3JpcHRDb3JlL2Fzc2VtYmxlci9NYWNy b0Fzc2VtYmxlckFSTTY0LmgJKHdvcmtpbmcgY29weSkKQEAgLTUwNCw3ICs1MDQsNyBAQCBwdWJs aWM6CiAgICAgICAgIExvZ2ljYWxJbW1lZGlhdGUgbG9naWNhbEltbSA9IExvZ2ljYWxJbW1lZGlh dGU6OmNyZWF0ZTY0KHN0YXRpY19jYXN0PGludHB0cl90PihzdGF0aWNfY2FzdDxpbnQ2NF90Pihp bW0ubV92YWx1ZSkpKTsKIAogICAgICAgICBpZiAobG9naWNhbEltbS5pc1ZhbGlkKCkpIHsKLSAg ICAgICAgICAgIG1fYXNzZW1ibGVyLm9ycjw2ND4oZGVzdCwgZGVzdCwgbG9naWNhbEltbSk7Cisg ICAgICAgICAgICBtX2Fzc2VtYmxlci5vcnI8NjQ+KGRlc3QsIHNyYywgbG9naWNhbEltbSk7CiAg ICAgICAgICAgICByZXR1cm47CiAgICAgICAgIH0KIApAQCAtNzEzLDcgKzcxMyw3IEBAIHB1Ymxp YzoKICAgICAgICAgICAgIExvZ2ljYWxJbW1lZGlhdGUgbG9naWNhbEltbSA9IExvZ2ljYWxJbW1l ZGlhdGU6OmNyZWF0ZTMyKGltbS5tX3ZhbHVlKTsKIAogICAgICAgICAgICAgaWYgKGxvZ2ljYWxJ bW0uaXNWYWxpZCgpKSB7Ci0gICAgICAgICAgICAgICAgbV9hc3NlbWJsZXIuZW9yPDMyPihkZXN0 LCBkZXN0LCBsb2dpY2FsSW1tKTsKKyAgICAgICAgICAgICAgICBtX2Fzc2VtYmxlci5lb3I8MzI+ KGRlc3QsIHNyYywgbG9naWNhbEltbSk7CiAgICAgICAgICAgICAgICAgcmV0dXJuOwogICAgICAg ICAgICAgfQogCkBAIC03NTIsNyArNzUyLDcgQEAgcHVibGljOgogICAgICAgICAgICAgTG9naWNh bEltbWVkaWF0ZSBsb2dpY2FsSW1tID0gTG9naWNhbEltbWVkaWF0ZTo6Y3JlYXRlNjQoc3RhdGlj X2Nhc3Q8aW50cHRyX3Q+KHN0YXRpY19jYXN0PGludDY0X3Q+KGltbS5tX3ZhbHVlKSkpOwogCiAg ICAgICAgICAgICBpZiAobG9naWNhbEltbS5pc1ZhbGlkKCkpIHsKLSAgICAgICAgICAgICAgICBt X2Fzc2VtYmxlci5lb3I8NjQ+KGRlc3QsIGRlc3QsIGxvZ2ljYWxJbW0pOworICAgICAgICAgICAg ICAgIG1fYXNzZW1ibGVyLmVvcjw2ND4oZGVzdCwgc3JjLCBsb2dpY2FsSW1tKTsKICAgICAgICAg ICAgICAgICByZXR1cm47CiAgICAgICAgICAgICB9CiAKSW5kZXg6IFNvdXJjZS9KYXZhU2NyaXB0 Q29yZS90ZXN0cy9zdHJlc3MvcmVncmVzcy0xMzIxNDcuanMKPT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PQotLS0gU291cmNl L0phdmFTY3JpcHRDb3JlL3Rlc3RzL3N0cmVzcy9yZWdyZXNzLTEzMjE0Ny5qcwkocmV2aXNpb24g MCkKKysrIFNvdXJjZS9KYXZhU2NyaXB0Q29yZS90ZXN0cy9zdHJlc3MvcmVncmVzcy0xMzIxNDcu anMJKHdvcmtpbmcgY29weSkKQEAgLTAsMCArMSwyOCBAQAordmFyIGZvbyA9IGZ1bmN0aW9uKGEs IGIsIGNvdW50KSB7CisgICAgYSA9IGEgfCAwOworICAgIGIgPSBiIHwgMDsKKworICAgIGlmIChm YWxzZSkgeworICAgICAgICByZXR1cm4gMTsKKyAgICB9IGVsc2UgeworICAgICAgICBhID0gYSAm IDB4ZmYwMDsKKyAgICAgICAgYiA9IGIgJiAweDAwZmY7CisKKyAgICAgICAgb3JBID0gYSB8IDB4 ZmYwMDsKKyAgICAgICAgeG9yQiA9IGIgXiAweGZmOworICAgIH0KKworICAgIHJldHVybiBvckEg fCB4b3JCOworfTsKKwordmFyIGFyZ0EgPSAwOwordmFyIGFyZ0IgPSAweDIyOwordmFyIHJlc3Vs dCA9IDA7CisKK25vSW5saW5lKGZvbykKKworZm9yIChpID0gMDsgaSA8IDEwMDAwMDsgaSsrKQor ICAgIHJlc3VsdCA9IHJlc3VsdCB8IGZvbyhhcmdBLCBhcmdCLCA0KQorCitpZiAocmVzdWx0ICE9 IDB4ZmZkZCkKKyAgICB0aHJvdyBuZXcgRXJyb3IoIkluY29ycmVjdCByZXN1bHQhIik7Cg==