132146 2014-04-24 15:03:30 -0700 Crash in platform/mac/accessibility/table-visible-rows.html 2014-04-28 17:32:17 -0700 1 1 1 Unclassified WebKit Tools / Tests 528+ (Nightly build) All All RESOLVED FIXED InRadar P2 Normal --- 1 mark.lam msaboff bfulgham mark.lam webkit-bug-importer oldest_to_newest 1003790 0 mark.lam 2014-04-24 15:03:30 -0700 Build a debug build of ToT (any revision after r167772), and run the following: $ JSC_slowPathAllocsBetweenGCs=1 DumpRenderTree LayoutTests/platform/mac/accessibility/table-visible-rows.html You will see the following crash: (lldb) r LayoutTests/platform/mac/accessibility/table-visible-rows.html Process 60125 launched: '/Volumes/Data/ws4/OpenSource/WebKitBuild/Debug/DumpRenderTree' (x86_64) Process 60125 stopped * thread #1: tid = 0xe97def, 0x000000010033c81c JavaScriptCore`JSC::JSCell::structure(this=0x0000000000000000, vm=0x000000010b842c00) const + 44 at JSCellInlines.h:104, queue = 'com.apple.main-thread', stop reason = EXC_BAD_ACCESS (code=1, address=0x0) frame #0: 0x000000010033c81c JavaScriptCore`JSC::JSCell::structure(this=0x0000000000000000, vm=0x000000010b842c00) const + 44 at JSCellInlines.h:104 101 102 inline Structure* JSCell::structure(VM& vm) const 103 { -> 104 return vm.heap.structureIDTable().get(m_structureID); 105 } 106 107 inline void JSCell::visitChildren(JSCell* cell, SlotVisitor& visitor) (lldb) bt * thread #1: tid = 0xe97def, 0x000000010033c81c JavaScriptCore`JSC::JSCell::structure(this=0x0000000000000000, vm=0x000000010b842c00) const + 44 at JSCellInlines.h:104, queue = 'com.apple.main-thread', stop reason = EXC_BAD_ACCESS (code=1, address=0x0) * frame #0: 0x000000010033c81c JavaScriptCore`JSC::JSCell::structure(this=0x0000000000000000, vm=0x000000010b842c00) const + 44 at JSCellInlines.h:104 frame #1: 0x0000000100359f76 JavaScriptCore`JSC::JSCell::methodTable(this=0x000000011951f8b0) const + 70 at JSCellInlines.h:192 frame #2: 0x000000010073bdde JavaScriptCore`toJS(exec=0x00007fff5fbfb920, v=0x000000011951f8b0) + 158 at APICast.h:81 frame #3: 0x00000001007cfc2d JavaScriptCore`JSObjectMakeArray(ctx=0x00007fff5fbfb920, argumentCount=3, arguments=0x0000000114814b60, exception=0x00007fff5fbfb4d0) + 189 at JSObjectRef.cpp:177 frame #4: 0x000000010000a1a6 DumpRenderTree`convertElementsToObjectArray(context=0x00007fff5fbfb920, elements=0x00007fff5fbfb3e0, exception=0x00007fff5fbfb4d0) + 566 at AccessibilityUIElement.cpp:526 frame #5: 0x0000000100007f6e DumpRenderTree`uiElementArrayAttributeValueCallback(context=0x00007fff5fbfb920, function=0x000000011951f930, thisObject=0x000000011951f990, argumentCount=1, arguments=0x00007fff5fbfb500, exception=0x00007fff5fbfb4d0) + 190 at AccessibilityUIElement.cpp:552 frame #6: 0x000000010075acb7 JavaScriptCore`long long JSC::APICallbackFunction::call<JSC::JSCallbackFunction>(exec=0x00007fff5fbfb920) + 455 at APICallbackFunction.h:61 frame #7: 0x000000010086dd62 JavaScriptCore`JSC::LLInt::handleHostCall(execCallee=0x00007fff5fbfb920, pc=0x000000010f8064f8, callee=JSValue at 0x00007fff5fbfb718, kind=CodeForCall) + 306 at LLIntSlowPaths.cpp:1035 frame #8: 0x000000010086ebdc JavaScriptCore`JSC::LLInt::setUpCall(execCallee=0x00007fff5fbfb920, pc=0x000000010f8064f8, kind=CodeForCall, calleeAsValue=JSValue at 0x00007fff5fbfb840, callLinkInfo=0x0000000110612fa0) + 92 at LLIntSlowPaths.cpp:1079 frame #9: 0x000000010086eb6c JavaScriptCore`JSC::LLInt::genericCall(exec=0x00007fff5fbfb980, pc=0x000000010f8064f8, kind=CodeForCall) + 236 at LLIntSlowPaths.cpp:1145 frame #10: 0x000000010086b26c JavaScriptCore`llint_slow_path_call(exec=0x00007fff5fbfb980, pc=0x000000010f8064f8) + 60 at LLIntSlowPaths.cpp:1151 frame #11: 0x00000001008784d9 JavaScriptCore`llint_entry + 26147 frame #12: 0x0000000100871c44 JavaScriptCore`callToJavaScript + 356 frame #13: 0x00007fff70a2e850 Foundation`__block_descriptor_tmp234 + 32 (lldb) up frame #1: 0x0000000100359f76 JavaScriptCore`JSC::JSCell::methodTable(this=0x000000011951f8b0) const + 70 at JSCellInlines.h:192 189 { 190 VM& vm = *Heap::heap(this)->vm(); 191 Structure* structure = this->structure(vm); -> 192 if (Structure* rootStructure = structure->structure(vm)) 193 RELEASE_ASSERT(rootStructure == rootStructure->structure(vm)); 194 195 return &structure->classInfo()->methodTable; 1003791 1 webkit-bug-importer 2014-04-24 15:05:06 -0700 <rdar://problem/16718045> 1004172 2 230192 msaboff 2014-04-25 13:00:11 -0700 Created attachment 230192 Patch 1004177 3 230192 mark.lam 2014-04-25 13:16:20 -0700 Comment on attachment 230192 Patch r=me. But can you do a quick grep for JSObjectMakeArray to see if anyone in our system is doing the wrong thing, but happens to be uncaught by tests? 1004178 4 msaboff 2014-04-25 13:17:16 -0700 (In reply to comment #3) > (From update of attachment 230192 [details]) > r=me. But can you do a quick grep for JSObjectMakeArray to see if anyone in our system is doing the wrong thing, but happens to be uncaught by tests? I already did and the patch contains the other instances. 1004186 5 msaboff 2014-04-25 13:35:20 -0700 Committed r167819: <http://trac.webkit.org/changeset/167819> 1004396 6 230192 ossy 2014-04-27 03:26:51 -0700 Comment on attachment 230192 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=230192&action=review > Tools/DumpRenderTree/AccessibilityUIElement.cpp:522 > - auto valueElements = std::make_unique<JSValueRef[]>(elementCount); > + JSValueRef valueElements[elementCount]; It broke the Apple Windows build: 1>..\..\AccessibilityUIElement.cpp(522): error C2057: expected constant expression 1>..\..\AccessibilityUIElement.cpp(522): error C2466: cannot allocate an array of constant size 0 1>..\..\AccessibilityUIElement.cpp(522): error C2133: 'valueElements' : unknown size Unfortunately you weren't able to catch this build failure, because others broke the Windows build previously and didn't care about the buildfix at all. 1004735 7 bfulgham 2014-04-28 14:38:43 -0700 Unfortunately, Visual Studio isn't smart about this logic: size_t elementCount = elements.size(); JSValueRef valueElements[elementCount]; ... giving the following errors: AccessibilityUIElement.cpp TestRunner.cpp 1>..\..\AccessibilityUIElement.cpp(522): error C2057: expected constant expression 1>..\..\AccessibilityUIElement.cpp(522): error C2466: cannot allocate an array of constant size 0 1>..\..\AccessibilityUIElement.cpp(522): error C2133: 'valueElements' : unknown size 1>Done Building Project "C:\cygwin\home\buildbot\slave\win-debug\build\Tools\DumpRenderTree\DumpRenderTree.vcxproj\DumpRenderTree\DumpRenderTree.vcxproj" (Build target(s)) -- FAILED. 1004773 8 msaboff 2014-04-28 16:28:25 -0700 Will post an updated fix that should work for windows. 1004779 9 230336 msaboff 2014-04-28 16:44:07 -0700 Created attachment 230336 Updated patch with speculative Windows fix 1004796 10 msaboff 2014-04-28 17:32:17 -0700 Committed r167913: <http://trac.webkit.org/changeset/167913> 230192 2014-04-25 13:00:11 -0700 2014-04-28 16:44:07 -0700 Patch 132146.patch text/plain 4520 msaboff SW5kZXg6IFRvb2xzL0NoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBUb29scy9DaGFuZ2VMb2cJKHJl dmlzaW9uIDE2NzgxMykKKysrIFRvb2xzL0NoYW5nZUxvZwkod29ya2luZyBjb3B5KQpAQCAtMSwz ICsxLDIyIEBACisyMDE0LTA0LTI1ICBNaWNoYWVsIFNhYm9mZiAgPG1zYWJvZmZAYXBwbGUuY29t PgorCisgICAgICAgIENyYXNoIGluIHBsYXRmb3JtL21hYy9hY2Nlc3NpYmlsaXR5L3RhYmxlLXZp c2libGUtcm93cy5odG1sCisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVn LmNnaT9pZD0xMzIxNDYKKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKwor ICAgICAgICBDaGFuZ2VkIHRvIHVzZSBhIGxvY2FsIEpTVmFsdWVSZWYgYXJyYXkgdGVtcG9yYXJ5 IGluc3RlYWQgb2YgYQorICAgICAgICBzdGQ6Om1ha2VfdW5pcXVlPEpTVmFsdWVSZWZbXT4gd2hl biBtYWtpbmcgYW4gYXJyYXkgb2YgSlNWYWx1ZXMgc28gdGhhdCB0aGUgdGVtcG9yYXJ5CisgICAg ICAgIEpTVmFsdWVzIGFyZSB2aXNpdGVkIGR1cmluZyBnYXJiYWdlIGNvbGxlY3Rpb24gd2hlbiB0 aGUgc3RhY2sgaXMgc2Nhbm5lZC4gIE90aGVyd2lzZSwKKyAgICAgICAgdGhlIHRlbXBvcmFyeSB2 YWx1ZXMgY291bGQgYmUgY29sbGVjdGVkLgorCisgICAgICAgICogRHVtcFJlbmRlclRyZWUvQWNj ZXNzaWJpbGl0eVVJRWxlbWVudC5jcHA6CisgICAgICAgIChjb252ZXJ0RWxlbWVudHNUb09iamVj dEFycmF5KToKKyAgICAgICAgKiBXZWJLaXRUZXN0UnVubmVyL0luamVjdGVkQnVuZGxlL0V2ZW50 U2VuZGluZ0NvbnRyb2xsZXIuY3BwOgorICAgICAgICAoV1RSOjpFdmVudFNlbmRpbmdDb250cm9s bGVyOjpjb250ZXh0Q2xpY2spOgorICAgICAgICAqIFdlYktpdFRlc3RSdW5uZXIvSW5qZWN0ZWRC dW5kbGUvbWFjL0FjY2Vzc2liaWxpdHlVSUVsZW1lbnRNYWMubW06CisgICAgICAgIChXVFI6OmNv bnZlcnRFbGVtZW50c1RvT2JqZWN0QXJyYXkpOgorCiAyMDE0LTA0LTI0ICBFZHVhcmRvIExpbWEg TWl0ZXYgIDxlbGltYUBpZ2FsaWEuY29tPgogCiAgICAgICAgIFVucmV2aWV3ZWQgR1RLIGdhcmRl bmluZwpJbmRleDogVG9vbHMvRHVtcFJlbmRlclRyZWUvQWNjZXNzaWJpbGl0eVVJRWxlbWVudC5j cHAKPT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PQotLS0gVG9vbHMvRHVtcFJlbmRlclRyZWUvQWNjZXNzaWJpbGl0eVVJRWxl bWVudC5jcHAJKHJldmlzaW9uIDE2NzgwNikKKysrIFRvb2xzL0R1bXBSZW5kZXJUcmVlL0FjY2Vz c2liaWxpdHlVSUVsZW1lbnQuY3BwCSh3b3JraW5nIGNvcHkpCkBAIC01MTksMTEgKzUxOSwxMSBA QCBzdGF0aWMgSlNWYWx1ZVJlZiBzdHJpbmdBdHRyaWJ1dGVWYWx1ZUNhCiBzdGF0aWMgSlNWYWx1 ZVJlZiBjb252ZXJ0RWxlbWVudHNUb09iamVjdEFycmF5KEpTQ29udGV4dFJlZiBjb250ZXh0LCBW ZWN0b3I8QWNjZXNzaWJpbGl0eVVJRWxlbWVudD4mIGVsZW1lbnRzLCBKU1ZhbHVlUmVmKiBleGNl cHRpb24pCiB7CiAgICAgc2l6ZV90IGVsZW1lbnRDb3VudCA9IGVsZW1lbnRzLnNpemUoKTsKLSAg ICBhdXRvIHZhbHVlRWxlbWVudHMgPSBzdGQ6Om1ha2VfdW5pcXVlPEpTVmFsdWVSZWZbXT4oZWxl bWVudENvdW50KTsKKyAgICBKU1ZhbHVlUmVmIHZhbHVlRWxlbWVudHNbZWxlbWVudENvdW50XTsK ICAgICBmb3IgKHNpemVfdCBpID0gMDsgaSA8IGVsZW1lbnRDb3VudDsgKytpKQogICAgICAgICB2 YWx1ZUVsZW1lbnRzW2ldID0gQWNjZXNzaWJpbGl0eVVJRWxlbWVudDo6bWFrZUpTQWNjZXNzaWJp bGl0eVVJRWxlbWVudChjb250ZXh0LCBlbGVtZW50c1tpXSk7CiAgICAgCi0gICAgcmV0dXJuIEpT T2JqZWN0TWFrZUFycmF5KGNvbnRleHQsIGVsZW1lbnRDb3VudCwgdmFsdWVFbGVtZW50cy5nZXQo KSwgZXhjZXB0aW9uKTsKKyAgICByZXR1cm4gSlNPYmplY3RNYWtlQXJyYXkoY29udGV4dCwgZWxl bWVudENvdW50LCB2YWx1ZUVsZW1lbnRzLCBleGNlcHRpb24pOwogfQogCiBzdGF0aWMgSlNWYWx1 ZVJlZiBjb2x1bW5IZWFkZXJzQ2FsbGJhY2soSlNDb250ZXh0UmVmIGNvbnRleHQsIEpTT2JqZWN0 UmVmIGZ1bmN0aW9uLCBKU09iamVjdFJlZiB0aGlzT2JqZWN0LCBzaXplX3QgYXJndW1lbnRDb3Vu dCwgY29uc3QgSlNWYWx1ZVJlZiBhcmd1bWVudHNbXSwgSlNWYWx1ZVJlZiogZXhjZXB0aW9uKQpJ bmRleDogVG9vbHMvV2ViS2l0VGVzdFJ1bm5lci9JbmplY3RlZEJ1bmRsZS9FdmVudFNlbmRpbmdD b250cm9sbGVyLmNwcAo9PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBUb29scy9XZWJLaXRUZXN0UnVubmVyL0luamVj dGVkQnVuZGxlL0V2ZW50U2VuZGluZ0NvbnRyb2xsZXIuY3BwCShyZXZpc2lvbiAxNjc4MDYpCisr KyBUb29scy9XZWJLaXRUZXN0UnVubmVyL0luamVjdGVkQnVuZGxlL0V2ZW50U2VuZGluZ0NvbnRy b2xsZXIuY3BwCSh3b3JraW5nIGNvcHkpCkBAIC00MzgsNyArNDM4LDcgQEAgSlNWYWx1ZVJlZiBF dmVudFNlbmRpbmdDb250cm9sbGVyOjpjb250ZQogCiAgICAgV0tSZXRhaW5QdHI8V0tBcnJheVJl Zj4gbWVudUVudHJpZXMgPSBhZG9wdFdLKFdLQnVuZGxlUGFnZUNvcHlDb250ZXh0TWVudUl0ZW1z KHBhZ2UpKTsKICAgICBzaXplX3QgZW50cmllc1NpemUgPSBXS0FycmF5R2V0U2l6ZShtZW51RW50 cmllcy5nZXQoKSk7Ci0gICAgYXV0byBqc1ZhbHVlc0FycmF5ID0gc3RkOjptYWtlX3VuaXF1ZTxK U1ZhbHVlUmVmW10+KGVudHJpZXNTaXplKTsKKyAgICBKU1ZhbHVlUmVmIGpzVmFsdWVzQXJyYXlb ZW50cmllc1NpemVdOwogICAgIGZvciAoc2l6ZV90IGkgPSAwOyBpIDwgZW50cmllc1NpemU7ICsr aSkgewogICAgICAgICBBU1NFUlQoV0tHZXRUeXBlSUQoV0tBcnJheUdldEl0ZW1BdEluZGV4KG1l bnVFbnRyaWVzLmdldCgpLCBpKSkgPT0gV0tDb250ZXh0TWVudUl0ZW1HZXRUeXBlSUQoKSk7CiAK QEAgLTQ0Nyw3ICs0NDcsNyBAQCBKU1ZhbHVlUmVmIEV2ZW50U2VuZGluZ0NvbnRyb2xsZXI6OmNv bnRlCiAgICAgICAgIGpzVmFsdWVzQXJyYXlbaV0gPSBKU09iamVjdE1ha2UoY29udGV4dCwgZ2V0 TWVudUl0ZW1DbGFzcygpLCBwcml2YXRlRGF0YSk7CiAgICAgfQogCi0gICAgcmV0dXJuIEpTT2Jq ZWN0TWFrZUFycmF5KGNvbnRleHQsIGVudHJpZXNTaXplLCBqc1ZhbHVlc0FycmF5LmdldCgpLCAw KTsKKyAgICByZXR1cm4gSlNPYmplY3RNYWtlQXJyYXkoY29udGV4dCwgZW50cmllc1NpemUsIGpz VmFsdWVzQXJyYXksIDApOwogI2Vsc2UKICAgICByZXR1cm4gSlNWYWx1ZU1ha2VVbmRlZmluZWQo Y29udGV4dCk7CiAjZW5kaWYKSW5kZXg6IFRvb2xzL1dlYktpdFRlc3RSdW5uZXIvSW5qZWN0ZWRC dW5kbGUvbWFjL0FjY2Vzc2liaWxpdHlVSUVsZW1lbnRNYWMubW0KPT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PQotLS0gVG9v bHMvV2ViS2l0VGVzdFJ1bm5lci9JbmplY3RlZEJ1bmRsZS9tYWMvQWNjZXNzaWJpbGl0eVVJRWxl bWVudE1hYy5tbQkocmV2aXNpb24gMTY3ODA2KQorKysgVG9vbHMvV2ViS2l0VGVzdFJ1bm5lci9J bmplY3RlZEJ1bmRsZS9tYWMvQWNjZXNzaWJpbGl0eVVJRWxlbWVudE1hYy5tbQkod29ya2luZyBj b3B5KQpAQCAtMTc5LDExICsxNzksMTEgQEAgc3RhdGljIE5TU3RyaW5nKiBhdHRyaWJ1dGVzT2ZF bGVtZW50KGlkIAogc3RhdGljIEpTVmFsdWVSZWYgY29udmVydEVsZW1lbnRzVG9PYmplY3RBcnJh eShKU0NvbnRleHRSZWYgY29udGV4dCwgVmVjdG9yPFJlZlB0cjxBY2Nlc3NpYmlsaXR5VUlFbGVt ZW50Pj4mIGVsZW1lbnRzKQogewogICAgIHNpemVfdCBlbGVtZW50Q291bnQgPSBlbGVtZW50cy5z aXplKCk7Ci0gICAgYXV0byB2YWx1ZUVsZW1lbnRzID0gc3RkOjptYWtlX3VuaXF1ZTxKU1ZhbHVl UmVmW10+KGVsZW1lbnRDb3VudCk7CisgICAgSlNWYWx1ZVJlZiB2YWx1ZUVsZW1lbnRzW2VsZW1l bnRDb3VudF07CiAgICAgZm9yIChzaXplX3QgaSA9IDA7IGkgPCBlbGVtZW50Q291bnQ7ICsraSkK ICAgICAgICAgdmFsdWVFbGVtZW50c1tpXSA9IEpTT2JqZWN0TWFrZShjb250ZXh0LCBlbGVtZW50 c1tpXS0+d3JhcHBlckNsYXNzKCksIGVsZW1lbnRzW2ldLmdldCgpKTsKICAgICAKLSAgICByZXR1 cm4gSlNPYmplY3RNYWtlQXJyYXkoY29udGV4dCwgZWxlbWVudENvdW50LCB2YWx1ZUVsZW1lbnRz LmdldCgpLCBudWxscHRyKTsKKyAgICByZXR1cm4gSlNPYmplY3RNYWtlQXJyYXkoY29udGV4dCwg ZWxlbWVudENvdW50LCB2YWx1ZUVsZW1lbnRzLCBudWxscHRyKTsKIH0KIAogc3RhdGljIEpTU3Ry aW5nUmVmIGNvbmNhdGVuYXRlQXR0cmlidXRlQW5kVmFsdWUoTlNTdHJpbmcqIGF0dHJpYnV0ZSwg TlNTdHJpbmcqIHZhbHVlKQo= 230336 2014-04-28 16:44:07 -0700 2014-04-28 17:05:48 -0700 Updated patch with speculative Windows fix 132146-2.patch text/plain 7391 msaboff SW5kZXg6IFRvb2xzL0NoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBUb29scy9DaGFuZ2VMb2cJKHJl dmlzaW9uIDE2NzkxMikKKysrIFRvb2xzL0NoYW5nZUxvZwkod29ya2luZyBjb3B5KQpAQCAtMSwz ICsxLDI0IEBACisyMDE0LTA0LTI4ICBNaWNoYWVsIFNhYm9mZiAgPG1zYWJvZmZAYXBwbGUuY29t PgorCisgICAgICAgIENyYXNoIGluIHBsYXRmb3JtL21hYy9hY2Nlc3NpYmlsaXR5L3RhYmxlLXZp c2libGUtcm93cy5odG1sCisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVn LmNnaT9pZD0xMzIxNDYKKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKwor ICAgICAgICBJbnN0ZWFkIG9mIGNyZWF0aW5nIGEgbG9jYWwgSlNWYWx1ZVJlZiBhcnJheSBvbiB0 aGUgc3RhY2sgYW5kIHBhc3NpbmcgdGhhdCB0bworICAgICAgICBKU09iamVjdE1ha2VBcnJheSgp LCBjaGFuZ2VkIHRvIGNyZWF0ZSBhbiBlbXB0eSBKU0FycmF5IGFuZCB0aGVuIHBvcHVsYXRlIHRo ZQorICAgICAgICB2YWx1ZXMgdXNpbmcgdGhlIEpTT2JqZWN0U2V0UHJvcGVydHlBdEluZGV4KCkg QVBJLgorCisgICAgICAgICogRHVtcFJlbmRlclRyZWUvQWNjZXNzaWJpbGl0eVVJRWxlbWVudC5j cHA6CisgICAgICAgIChlbGVtZW50c0ZvclJhbmdlQ2FsbGJhY2spOgorICAgICAgICAoY29udmVy dEVsZW1lbnRzVG9PYmplY3RBcnJheSk6CisgICAgICAgICogV2ViS2l0VGVzdFJ1bm5lci9Jbmpl Y3RlZEJ1bmRsZS9FdmVudFNlbmRpbmdDb250cm9sbGVyLmNwcDoKKyAgICAgICAgKFdUUjo6RXZl bnRTZW5kaW5nQ29udHJvbGxlcjo6Y29udGV4dENsaWNrKToKKyAgICAgICAgKiBXZWJLaXRUZXN0 UnVubmVyL0luamVjdGVkQnVuZGxlL1Rlc3RSdW5uZXIuY3BwOgorICAgICAgICAoV1RSOjpzdHJp bmdBcnJheVRvSlMpOgorICAgICAgICAqIFdlYktpdFRlc3RSdW5uZXIvSW5qZWN0ZWRCdW5kbGUv bWFjL0FjY2Vzc2liaWxpdHlVSUVsZW1lbnRNYWMubW06CisgICAgICAgIChXVFI6OmNvbnZlcnRF bGVtZW50c1RvT2JqZWN0QXJyYXkpOgorCiAyMDE0LTA0LTI4ICBGaWxpcCBQaXpsbyAgPGZwaXps b0BhcHBsZS5jb20+CiAKICAgICAgICAgTWFrZSBzdXJlIHRoYXQgdGhlIGNvdmVyYWdlIG9mIG91 ciB0ZXN0cyBkb2Vzbid0IGNoYW5nZSBtdWNoIGlmIHdlIGNoYW5nZSB0aGUgdGhyZXNob2xkcyBu b3cgYW5kIGluIHRoZSBmdXR1cmUsIGJ1dCBtYWtpbmcKSW5kZXg6IFRvb2xzL0R1bXBSZW5kZXJU cmVlL0FjY2Vzc2liaWxpdHlVSUVsZW1lbnQuY3BwCj09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIFRvb2xzL0R1bXBS ZW5kZXJUcmVlL0FjY2Vzc2liaWxpdHlVSUVsZW1lbnQuY3BwCShyZXZpc2lvbiAxNjc5MTIpCisr KyBUb29scy9EdW1wUmVuZGVyVHJlZS9BY2Nlc3NpYmlsaXR5VUlFbGVtZW50LmNwcAkod29ya2lu ZyBjb3B5KQpAQCAtMzEyLDEyICszMTIsMTMgQEAgc3RhdGljIEpTVmFsdWVSZWYgZWxlbWVudHNG b3JSYW5nZUNhbGxiYQogICAgIFZlY3RvcjxBY2Nlc3NpYmlsaXR5VUlFbGVtZW50PiBlbGVtZW50 czsKICAgICB0b0FYRWxlbWVudCh0aGlzT2JqZWN0KS0+ZWxlbWVudHNGb3JSYW5nZShsb2NhdGlv biwgbGVuZ3RoLCBlbGVtZW50cyk7CiAgICAgCisgICAgSlNWYWx1ZVJlZiBhcnJheVJlc3VsdCA9 IEpTT2JqZWN0TWFrZUFycmF5KGNvbnRleHQsIDAsIDAsIDApOworICAgIEpTT2JqZWN0UmVmIGFy cmF5T2JqID0gSlNWYWx1ZVRvT2JqZWN0KGNvbnRleHQsIGFycmF5UmVzdWx0LCAwKTsKICAgICB1 bnNpZ25lZCBlbGVtZW50c1NpemUgPSBlbGVtZW50cy5zaXplKCk7Ci0gICAgSlNWYWx1ZVJlZiB2 YWx1ZUVsZW1lbnRzW2VsZW1lbnRzU2l6ZV07CiAgICAgZm9yICh1bnNpZ25lZCBrID0gMDsgayA8 IGVsZW1lbnRzU2l6ZTsgKytrKQotICAgICAgICB2YWx1ZUVsZW1lbnRzW2tdID0gQWNjZXNzaWJp bGl0eVVJRWxlbWVudDo6bWFrZUpTQWNjZXNzaWJpbGl0eVVJRWxlbWVudChjb250ZXh0LCBlbGVt ZW50c1trXSk7CisgICAgICAgIEpTT2JqZWN0U2V0UHJvcGVydHlBdEluZGV4KGNvbnRleHQsIGFy cmF5T2JqLCBrLCBBY2Nlc3NpYmlsaXR5VUlFbGVtZW50OjptYWtlSlNBY2Nlc3NpYmlsaXR5VUlF bGVtZW50KGNvbnRleHQsIGVsZW1lbnRzW2tdKSwgMCk7CiAgICAgCi0gICAgcmV0dXJuIEpTT2Jq ZWN0TWFrZUFycmF5KGNvbnRleHQsIGVsZW1lbnRzU2l6ZSwgdmFsdWVFbGVtZW50cywgMCk7Cisg ICAgcmV0dXJuIGFycmF5UmVzdWx0OwogfQogCiBzdGF0aWMgSlNWYWx1ZVJlZiBpbmNyZWFzZVRl eHRTZWxlY3Rpb25DYWxsYmFjayhKU0NvbnRleHRSZWYgY29udGV4dCwgSlNPYmplY3RSZWYgZnVu Y3Rpb24sIEpTT2JqZWN0UmVmIHRoaXNPYmplY3QsIHNpemVfdCBhcmd1bWVudENvdW50LCBjb25z dCBKU1ZhbHVlUmVmIGFyZ3VtZW50c1tdLCBKU1ZhbHVlUmVmKiBleGNlcHRpb24pCkBAIC01MTgs MTIgKzUxOSwxNCBAQCBzdGF0aWMgSlNWYWx1ZVJlZiBzdHJpbmdBdHRyaWJ1dGVWYWx1ZUNhCiAK IHN0YXRpYyBKU1ZhbHVlUmVmIGNvbnZlcnRFbGVtZW50c1RvT2JqZWN0QXJyYXkoSlNDb250ZXh0 UmVmIGNvbnRleHQsIFZlY3RvcjxBY2Nlc3NpYmlsaXR5VUlFbGVtZW50PiYgZWxlbWVudHMsIEpT VmFsdWVSZWYqIGV4Y2VwdGlvbikKIHsKKyAgICBKU1ZhbHVlUmVmIGFycmF5UmVzdWx0ID0gSlNP YmplY3RNYWtlQXJyYXkoY29udGV4dCwgMCwgMCwgMCk7CisgICAgSlNPYmplY3RSZWYgYXJyYXlP YmogPSBKU1ZhbHVlVG9PYmplY3QoY29udGV4dCwgYXJyYXlSZXN1bHQsIDApOworCiAgICAgc2l6 ZV90IGVsZW1lbnRDb3VudCA9IGVsZW1lbnRzLnNpemUoKTsKLSAgICBKU1ZhbHVlUmVmIHZhbHVl RWxlbWVudHNbZWxlbWVudENvdW50XTsKICAgICBmb3IgKHNpemVfdCBpID0gMDsgaSA8IGVsZW1l bnRDb3VudDsgKytpKQotICAgICAgICB2YWx1ZUVsZW1lbnRzW2ldID0gQWNjZXNzaWJpbGl0eVVJ RWxlbWVudDo6bWFrZUpTQWNjZXNzaWJpbGl0eVVJRWxlbWVudChjb250ZXh0LCBlbGVtZW50c1tp XSk7Ci0gICAgCi0gICAgcmV0dXJuIEpTT2JqZWN0TWFrZUFycmF5KGNvbnRleHQsIGVsZW1lbnRD b3VudCwgdmFsdWVFbGVtZW50cywgZXhjZXB0aW9uKTsKKyAgICAgICAgSlNPYmplY3RTZXRQcm9w ZXJ0eUF0SW5kZXgoY29udGV4dCwgYXJyYXlPYmosIGksIEFjY2Vzc2liaWxpdHlVSUVsZW1lbnQ6 Om1ha2VKU0FjY2Vzc2liaWxpdHlVSUVsZW1lbnQoY29udGV4dCwgZWxlbWVudHNbaV0pLCAwKTsK KworICAgIHJldHVybiBhcnJheVJlc3VsdDsKIH0KIAogc3RhdGljIEpTVmFsdWVSZWYgY29sdW1u SGVhZGVyc0NhbGxiYWNrKEpTQ29udGV4dFJlZiBjb250ZXh0LCBKU09iamVjdFJlZiBmdW5jdGlv biwgSlNPYmplY3RSZWYgdGhpc09iamVjdCwgc2l6ZV90IGFyZ3VtZW50Q291bnQsIGNvbnN0IEpT VmFsdWVSZWYgYXJndW1lbnRzW10sIEpTVmFsdWVSZWYqIGV4Y2VwdGlvbikKSW5kZXg6IFRvb2xz L1dlYktpdFRlc3RSdW5uZXIvSW5qZWN0ZWRCdW5kbGUvRXZlbnRTZW5kaW5nQ29udHJvbGxlci5j cHAKPT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PQotLS0gVG9vbHMvV2ViS2l0VGVzdFJ1bm5lci9JbmplY3RlZEJ1bmRsZS9F dmVudFNlbmRpbmdDb250cm9sbGVyLmNwcAkocmV2aXNpb24gMTY3OTEyKQorKysgVG9vbHMvV2Vi S2l0VGVzdFJ1bm5lci9JbmplY3RlZEJ1bmRsZS9FdmVudFNlbmRpbmdDb250cm9sbGVyLmNwcAko d29ya2luZyBjb3B5KQpAQCAtNDM3LDE3ICs0MzcsMTggQEAgSlNWYWx1ZVJlZiBFdmVudFNlbmRp bmdDb250cm9sbGVyOjpjb250ZQogICAgIG1vdXNlVXAoMiwgMCk7CiAKICAgICBXS1JldGFpblB0 cjxXS0FycmF5UmVmPiBtZW51RW50cmllcyA9IGFkb3B0V0soV0tCdW5kbGVQYWdlQ29weUNvbnRl eHRNZW51SXRlbXMocGFnZSkpOworICAgIEpTVmFsdWVSZWYgYXJyYXlSZXN1bHQgPSBKU09iamVj dE1ha2VBcnJheShjb250ZXh0LCAwLCAwLCAwKTsKKyAgICBKU09iamVjdFJlZiBhcnJheU9iaiA9 IEpTVmFsdWVUb09iamVjdChjb250ZXh0LCBhcnJheVJlc3VsdCwgMCk7CiAgICAgc2l6ZV90IGVu dHJpZXNTaXplID0gV0tBcnJheUdldFNpemUobWVudUVudHJpZXMuZ2V0KCkpOwotICAgIEpTVmFs dWVSZWYganNWYWx1ZXNBcnJheVtlbnRyaWVzU2l6ZV07CiAgICAgZm9yIChzaXplX3QgaSA9IDA7 IGkgPCBlbnRyaWVzU2l6ZTsgKytpKSB7CiAgICAgICAgIEFTU0VSVChXS0dldFR5cGVJRChXS0Fy cmF5R2V0SXRlbUF0SW5kZXgobWVudUVudHJpZXMuZ2V0KCksIGkpKSA9PSBXS0NvbnRleHRNZW51 SXRlbUdldFR5cGVJRCgpKTsKIAogICAgICAgICBXS0NvbnRleHRNZW51SXRlbVJlZiBpdGVtID0g c3RhdGljX2Nhc3Q8V0tDb250ZXh0TWVudUl0ZW1SZWY+KFdLQXJyYXlHZXRJdGVtQXRJbmRleCht ZW51RW50cmllcy5nZXQoKSwgaSkpOwogICAgICAgICBNZW51SXRlbVByaXZhdGVEYXRhKiBwcml2 YXRlRGF0YSA9IG5ldyBNZW51SXRlbVByaXZhdGVEYXRhKHBhZ2UsIGl0ZW0pOwotICAgICAgICBq c1ZhbHVlc0FycmF5W2ldID0gSlNPYmplY3RNYWtlKGNvbnRleHQsIGdldE1lbnVJdGVtQ2xhc3Mo KSwgcHJpdmF0ZURhdGEpOworICAgICAgICBKU09iamVjdFNldFByb3BlcnR5QXRJbmRleChjb250 ZXh0LCBhcnJheU9iaiwgaSwgSlNPYmplY3RNYWtlKGNvbnRleHQsIGdldE1lbnVJdGVtQ2xhc3Mo KSwgcHJpdmF0ZURhdGEpLCAwKTsKICAgICB9CiAKLSAgICByZXR1cm4gSlNPYmplY3RNYWtlQXJy YXkoY29udGV4dCwgZW50cmllc1NpemUsIGpzVmFsdWVzQXJyYXksIDApOworICAgIHJldHVybiBh cnJheVJlc3VsdDsKICNlbHNlCiAgICAgcmV0dXJuIEpTVmFsdWVNYWtlVW5kZWZpbmVkKGNvbnRl eHQpOwogI2VuZGlmCkluZGV4OiBUb29scy9XZWJLaXRUZXN0UnVubmVyL0luamVjdGVkQnVuZGxl L1Rlc3RSdW5uZXIuY3BwCj09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIFRvb2xzL1dlYktpdFRlc3RSdW5uZXIvSW5q ZWN0ZWRCdW5kbGUvVGVzdFJ1bm5lci5jcHAJKHJldmlzaW9uIDE2NzkxMikKKysrIFRvb2xzL1dl YktpdFRlc3RSdW5uZXIvSW5qZWN0ZWRCdW5kbGUvVGVzdFJ1bm5lci5jcHAJKHdvcmtpbmcgY29w eSkKQEAgLTI3NSwxNCArMjc1LDE1IEBAIHN0YXRpYyBpbmxpbmUgSlNWYWx1ZVJlZiBzdHJpbmdB cnJheVRvSlMKIHsKICAgICBjb25zdCBzaXplX3QgY291bnQgPSBXS0FycmF5R2V0U2l6ZShzdHJp bmdzKTsKIAotICAgIGF1dG8ganNTdHJpbmdzQXJyYXkgPSBzdGQ6Om1ha2VfdW5pcXVlPEpTVmFs dWVSZWZbXT4oY291bnQpOworICAgIEpTVmFsdWVSZWYgYXJyYXlSZXN1bHQgPSBKU09iamVjdE1h a2VBcnJheShjb250ZXh0LCAwLCAwLCAwKTsKKyAgICBKU09iamVjdFJlZiBhcnJheU9iaiA9IEpT VmFsdWVUb09iamVjdChjb250ZXh0LCBhcnJheVJlc3VsdCwgMCk7CiAgICAgZm9yIChzaXplX3Qg aSA9IDA7IGkgPCBjb3VudDsgKytpKSB7CiAgICAgICAgIFdLU3RyaW5nUmVmIHN0cmluZ1JlZiA9 IHN0YXRpY19jYXN0PFdLU3RyaW5nUmVmPihXS0FycmF5R2V0SXRlbUF0SW5kZXgoc3RyaW5ncywg aSkpOwogICAgICAgICBKU1JldGFpblB0cjxKU1N0cmluZ1JlZj4gc3RyaW5nSlMgPSB0b0pTKHN0 cmluZ1JlZik7Ci0gICAgICAgIGpzU3RyaW5nc0FycmF5W2ldID0gSlNWYWx1ZU1ha2VTdHJpbmco Y29udGV4dCwgc3RyaW5nSlMuZ2V0KCkpOworICAgICAgICBKU09iamVjdFNldFByb3BlcnR5QXRJ bmRleChjb250ZXh0LCBhcnJheU9iaiwgaSwgSlNWYWx1ZU1ha2VTdHJpbmcoY29udGV4dCwgc3Ry aW5nSlMuZ2V0KCkpLCAwKTsKICAgICB9CiAKLSAgICByZXR1cm4gSlNPYmplY3RNYWtlQXJyYXko Y29udGV4dCwgY291bnQsIGpzU3RyaW5nc0FycmF5LmdldCgpLCAwKTsKKyAgICByZXR1cm4gYXJy YXlSZXN1bHQ7CiB9CiAKIEpTVmFsdWVSZWYgVGVzdFJ1bm5lcjo6b3JpZ2luc1dpdGhBcHBsaWNh dGlvbkNhY2hlKCkKSW5kZXg6IFRvb2xzL1dlYktpdFRlc3RSdW5uZXIvSW5qZWN0ZWRCdW5kbGUv bWFjL0FjY2Vzc2liaWxpdHlVSUVsZW1lbnRNYWMubW0KPT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PQotLS0gVG9vbHMvV2Vi S2l0VGVzdFJ1bm5lci9JbmplY3RlZEJ1bmRsZS9tYWMvQWNjZXNzaWJpbGl0eVVJRWxlbWVudE1h Yy5tbQkocmV2aXNpb24gMTY3OTEyKQorKysgVG9vbHMvV2ViS2l0VGVzdFJ1bm5lci9JbmplY3Rl ZEJ1bmRsZS9tYWMvQWNjZXNzaWJpbGl0eVVJRWxlbWVudE1hYy5tbQkod29ya2luZyBjb3B5KQpA QCAtMTc4LDEyICsxNzgsMTMgQEAgc3RhdGljIE5TU3RyaW5nKiBhdHRyaWJ1dGVzT2ZFbGVtZW50 KGlkIAogCiBzdGF0aWMgSlNWYWx1ZVJlZiBjb252ZXJ0RWxlbWVudHNUb09iamVjdEFycmF5KEpT Q29udGV4dFJlZiBjb250ZXh0LCBWZWN0b3I8UmVmUHRyPEFjY2Vzc2liaWxpdHlVSUVsZW1lbnQ+ PiYgZWxlbWVudHMpCiB7CisgICAgSlNWYWx1ZVJlZiBhcnJheVJlc3VsdCA9IEpTT2JqZWN0TWFr ZUFycmF5KGNvbnRleHQsIDAsIDAsIDApOworICAgIEpTT2JqZWN0UmVmIGFycmF5T2JqID0gSlNW YWx1ZVRvT2JqZWN0KGNvbnRleHQsIGFycmF5UmVzdWx0LCAwKTsKICAgICBzaXplX3QgZWxlbWVu dENvdW50ID0gZWxlbWVudHMuc2l6ZSgpOwotICAgIEpTVmFsdWVSZWYgdmFsdWVFbGVtZW50c1tl bGVtZW50Q291bnRdOwogICAgIGZvciAoc2l6ZV90IGkgPSAwOyBpIDwgZWxlbWVudENvdW50OyAr K2kpCi0gICAgICAgIHZhbHVlRWxlbWVudHNbaV0gPSBKU09iamVjdE1ha2UoY29udGV4dCwgZWxl bWVudHNbaV0tPndyYXBwZXJDbGFzcygpLCBlbGVtZW50c1tpXS5nZXQoKSk7CisgICAgICAgIEpT T2JqZWN0U2V0UHJvcGVydHlBdEluZGV4KGNvbnRleHQsIGFycmF5T2JqLCBpLCBKU09iamVjdE1h a2UoY29udGV4dCwgZWxlbWVudHNbaV0tPndyYXBwZXJDbGFzcygpLCBlbGVtZW50c1tpXS5nZXQo KSksIDApOwogICAgIAotICAgIHJldHVybiBKU09iamVjdE1ha2VBcnJheShjb250ZXh0LCBlbGVt ZW50Q291bnQsIHZhbHVlRWxlbWVudHMsIG51bGxwdHIpOworICAgIHJldHVybiBhcnJheVJlc3Vs dDsKIH0KIAogc3RhdGljIEpTU3RyaW5nUmVmIGNvbmNhdGVuYXRlQXR0cmlidXRlQW5kVmFsdWUo TlNTdHJpbmcqIGF0dHJpYnV0ZSwgTlNTdHJpbmcqIHZhbHVlKQo=