132120 2014-04-24 02:51:11 -0700 [CSS Regions] Don't relayout when updating the region range unless necessary 2014-05-14 07:35:39 -0700 1 1 1 Unclassified WebKit WebCore Misc. 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED AdobeTracked P2 Normal --- 128243 1 abucur abucur commit-queue esprehn+autocc glenn koivisto kondapallykalyan WebkitBugTracker oldest_to_newest 1003595 0 abucur 2014-04-24 02:51:11 -0700 When we update the region range of a box we always relayout if the range has changed. This can be optimized in simple cases, when the box doesn't contain any trailing floats (that don't affect the height of the block). 1009234 1 231446 abucur 2014-05-14 06:06:23 -0700 Created attachment 231446 Patch 1009235 2 koivisto 2014-05-14 06:10:07 -0700 r=me 1009251 3 231446 commit-queue 2014-05-14 07:35:36 -0700 Comment on attachment 231446 Patch Clearing flags on attachment: 231446 Committed r168836: <http://trac.webkit.org/changeset/168836> 1009252 4 commit-queue 2014-05-14 07:35:39 -0700 All reviewed patches have been landed. Closing bug. 231446 2014-05-14 06:06:23 -0700 2014-05-14 07:35:36 -0700 Patch bug-132120-20140514160558.patch text/plain 6077 abucur U3VidmVyc2lvbiBSZXZpc2lvbjogMTY4NzkxCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggNzAxYTg4ZDYzYTAxMWIy NjU3NTBiYzk2YzUxM2I1ZjM2ZGM0YTdkZS4uYTY0MjI3MTI5YTQwNWU2MDVlNGY1MWRlN2ZhNjZk NjZiZTBlZmJkMiAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDMyIEBACisyMDE0LTA1LTE0ICBBbmRy ZWkgQnVjdXIgIDxhYnVjdXJAYWRvYmUuY29tPgorCisgICAgICAgIFtDU1MgUmVnaW9uc10gRG9u J3QgcmVsYXlvdXQgd2hlbiB1cGRhdGluZyB0aGUgcmVnaW9uIHJhbmdlIHVubGVzcyBuZWNlc3Nh cnkKKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTEzMjEy MAorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgIFRoZSBw YXRjaCByZWR1Y2VzIHRoZSBjYXNlcyB3aGVuIGEgcmVsYXlvdXQgaXMgbWFkZSBmb3IgYm94ZXMg dGhhdCBjaGFuZ2UgdGhlIHJlZ2lvbiByYW5nZS4KKyAgICAgICAgVGhpcyBsb3dlcnMgdGhlIGFt b3VudCBvZiBuZXN0ZWQgbGF5b3V0cyBpbiBtb3N0IGNhc2VzIGFuZCBwcm9kdWNlcyBiaWcgbGF5 b3V0IHNwZWVkdXBzIGZvciB0cmVlcworICAgICAgICB3aXRob3V0IG92ZXJoYW5naW5nIGZsb2F0 cy4KKworICAgICAgICBUZXN0czogTWFqb3IgcGVyZm9ybWFuY2UgaW1wcm92ZW1lbnQgd2l0aCBz cGVlZHVwcyBvZiA1MC02MCUgb246CisgICAgICAgIExheW91dC9SZWdpb25zQXV0by5odG1sLCBM YXlvdXQvUmVnaW9uc0F1dG9NYXhIZWlnaHQuaHRtbCBhbmQgTGF5b3V0L1JlZ2lvbnNGaXhlZC5o dG1sCisKKyAgICAgICAgKiByZW5kZXJpbmcvUmVuZGVyQmxvY2suY3BwOgorICAgICAgICAoV2Vi Q29yZTo6UmVuZGVyQmxvY2s6OnVwZGF0ZVJlZ2lvblJhbmdlRm9yQm94Q2hpbGQpOiBBc2sgdGhl IGNoaWxkIGJveCBpZiBpdCBuZWVkcyBhIHJlbGF5b3V0CisgICAgICAgIGluIGNhc2UgaXRzIHJl Z2lvbiByYW5nZSBjaGFuZ2VzLgorICAgICAgICAqIHJlbmRlcmluZy9SZW5kZXJCbG9ja0Zsb3cu Y3BwOgorICAgICAgICAoV2ViQ29yZTo6UmVuZGVyQmxvY2tGbG93OjpsYXlvdXRCbG9ja0NoaWxk KTogSXQncyBub3QgbmVjZXNzYXJ5IHRvIGRvIHR3byBsYXlvdXRzIGhlcmUgYmVjYXVzZQorICAg ICAgICB0aGVyZSdzIG5vIGJsb2NrIGRpcmVjdGlvbiBwb3NpdGlvbiBjaGFuZ2UgYmV0d2VlbiB0 aGVtIGZvciB0aGUgY2hpbGQuCisgICAgICAgIChXZWJDb3JlOjpSZW5kZXJCbG9ja0Zsb3c6Om5l ZWRzTGF5b3V0QWZ0ZXJSZWdpb25SYW5nZUNoYW5nZSk6IElmIHRoZSBibG9jayBkb2Vzbid0IGhh dmUgZmxvYXRzCisgICAgICAgIG9yIGlmIGl0IGV4cGFuZHMgdG8gZW5jbG9zZSB0aGUgZmxvYXRz IGl0IGRvZXNuJ3QgbmVlZCB0byByZWxheW91dCBhZnRlciBhIHJlZ2lvbiByYW5nZSBjaGFnZS4K KyAgICAgICAgSXQncyBub3QgcG9zc2libGUgZm9yIGl0IHRvIGhhdmUgYSBmbG9hdCBpbnNpZGUg b3ZlcmZsb3cgdGhhdCBtdXN0IGJlIHJlcG9zaXRpb25lZCB1c2luZyB0aGUgbmV3CisgICAgICAg IHJhbmdlLgorICAgICAgICAqIHJlbmRlcmluZy9SZW5kZXJCbG9ja0Zsb3cuaDoKKyAgICAgICAg KiByZW5kZXJpbmcvUmVuZGVyQm94Lmg6CisgICAgICAgIChXZWJDb3JlOjpSZW5kZXJCb3g6Om5l ZWRzTGF5b3V0QWZ0ZXJSZWdpb25SYW5nZUNoYW5nZSk6IEJ5IGRlZmF1bHQgZG9uJ3QgcmVsYXlv dXQgYWZ0ZXIgYSByZWdpb24KKyAgICAgICAgcmFuZ2UgY2hhbmdlLgorCiAyMDE0LTA1LTEzICBB bmRyZWkgQnVjdXIgIDxhYnVjdXJAYWRvYmUuY29tPgogCiAgICAgICAgIFtDU1MgUmVnaW9uc10g QXNzZXJ0aW9uIGZhaWx1cmUgaW4gc29tZSBjYXNlcyB3aXRoIGlubGluZSBibG9ja3MKZGlmZiAt LWdpdCBhL1NvdXJjZS9XZWJDb3JlL3JlbmRlcmluZy9SZW5kZXJCbG9jay5jcHAgYi9Tb3VyY2Uv V2ViQ29yZS9yZW5kZXJpbmcvUmVuZGVyQmxvY2suY3BwCmluZGV4IGM1MDdkNjZiYjhmMmQ4NmY1 ZTA1ZDlmYzBiZTdhMmYzNTczNjdlNmYuLjhlYjU3YTQ2MWU4MTFkY2Y0YTA1ZWNjODJjNDI2MzM3 NzdhNmNiYWQgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJDb3JlL3JlbmRlcmluZy9SZW5kZXJCbG9j ay5jcHAKKysrIGIvU291cmNlL1dlYkNvcmUvcmVuZGVyaW5nL1JlbmRlckJsb2NrLmNwcApAQCAt Mzk2NiwxMCArMzk2NiwxNCBAQCBib29sIFJlbmRlckJsb2NrOjp1cGRhdGVSZWdpb25SYW5nZUZv ckJveENoaWxkKGNvbnN0IFJlbmRlckJveCYgYm94KSBjb25zdAogICAgIFJlbmRlclJlZ2lvbiog bmV3RW5kUmVnaW9uID0gbnVsbHB0cjsKICAgICBmbG93VGhyZWFkLT5nZXRSZWdpb25SYW5nZUZv ckJveCgmYm94LCBuZXdTdGFydFJlZ2lvbiwgbmV3RW5kUmVnaW9uKTsKIAorCisgICAgLy8gQ2hh bmdpbmcgdGhlIHN0YXJ0IHJlZ2lvbiBtZWFucyB3ZSBzaGlmdCBldmVyeXRoaW5nIGFuZCBhIHJl bGF5b3V0IGlzIG5lZWRlZC4KKyAgICBpZiAobmV3U3RhcnRSZWdpb24gIT0gc3RhcnRSZWdpb24p CisgICAgICAgIHJldHVybiB0cnVlOworCiAgICAgLy8gVGhlIHJlZ2lvbiByYW5nZSBvZiB0aGUg Ym94IGhhcyBjaGFuZ2VkLiBTb21lIGJveGVzIChlLmcgZmxvYXRzKSBtYXkgaGF2ZSBiZWVuIHBv c2l0aW9uZWQgYXNzdW1pbmcKICAgICAvLyBhIGRpZmZlcmVudCByYW5nZS4KLSAgICAvLyBGSVhN RTogQmUgc21hcnRlciBhYm91dCB0aGlzLiBXZSBkb24ndCBuZWVkIHRvIHJlbGF5b3V0IGFsbCB0 aGUgdGltZS4KLSAgICBpZiAobmV3U3RhcnRSZWdpb24gIT0gc3RhcnRSZWdpb24gfHwgbmV3RW5k UmVnaW9uICE9IGVuZFJlZ2lvbikKKyAgICBpZiAoYm94Lm5lZWRzTGF5b3V0QWZ0ZXJSZWdpb25S YW5nZUNoYW5nZSgpICYmIG5ld0VuZFJlZ2lvbiAhPSBlbmRSZWdpb24pCiAgICAgICAgIHJldHVy biB0cnVlOwogCiAgICAgcmV0dXJuIGZhbHNlOwpkaWZmIC0tZ2l0IGEvU291cmNlL1dlYkNvcmUv cmVuZGVyaW5nL1JlbmRlckJsb2NrRmxvdy5jcHAgYi9Tb3VyY2UvV2ViQ29yZS9yZW5kZXJpbmcv UmVuZGVyQmxvY2tGbG93LmNwcAppbmRleCA2NTFkOTE2ZjYwMTIxYmI4NmNkNmRhOTk5NjNiZGI4 MjhjMmJmMDA3Li4xZDU4YjZhN2Q4MmY3ZjFmNDc1OWVhZDQ4NTNlOThmYmFkMDc4YTYyIDEwMDY0 NAotLS0gYS9Tb3VyY2UvV2ViQ29yZS9yZW5kZXJpbmcvUmVuZGVyQmxvY2tGbG93LmNwcAorKysg Yi9Tb3VyY2UvV2ViQ29yZS9yZW5kZXJpbmcvUmVuZGVyQmxvY2tGbG93LmNwcApAQCAtNzQ2LDE1 ICs3NDYsMTMgQEAgdm9pZCBSZW5kZXJCbG9ja0Zsb3c6OmxheW91dEJsb2NrQ2hpbGQoUmVuZGVy Qm94JiBjaGlsZCwgTWFyZ2luSW5mbyYgbWFyZ2luSW5mbywKICAgICAgICAgICAgIGlmICghY2hp bGQubmVlZHNMYXlvdXQoKSkKICAgICAgICAgICAgICAgICBjaGlsZC5tYXJrRm9yUGFnaW5hdGlv blJlbGF5b3V0SWZOZWVkZWQoKTsKICAgICAgICAgfQotCi0gICAgICAgIC8vIE91ciBndWVzcyB3 YXMgd3JvbmcuIE1ha2UgdGhlIGNoaWxkIGxheSBpdHNlbGYgb3V0IGFnYWluLgotICAgICAgICBj aGlsZC5sYXlvdXRJZk5lZWRlZCgpOwogICAgIH0KIAotICAgIGlmICh1cGRhdGVSZWdpb25SYW5n ZUZvckJveENoaWxkKGNoaWxkKSkgeworICAgIGlmICh1cGRhdGVSZWdpb25SYW5nZUZvckJveENo aWxkKGNoaWxkKSkKICAgICAgICAgY2hpbGQuc2V0TmVlZHNMYXlvdXQoTWFya09ubHlUaGlzKTsK LSAgICAgICAgY2hpbGQubGF5b3V0SWZOZWVkZWQoKTsKLSAgICB9CisKKyAgICAvLyBJbiBjYXNl IG91ciBndWVzcyB3YXMgd3JvbmcsIHJlbGF5b3V0IHRoZSBjaGlsZC4KKyAgICBjaGlsZC5sYXlv dXRJZk5lZWRlZCgpOwogCiAgICAgLy8gV2UgYXJlIG5vIGxvbmdlciBhdCB0aGUgdG9wIG9mIHRo ZSBibG9jayBpZiB3ZSBlbmNvdW50ZXIgYSBub24tZW1wdHkgY2hpbGQuICAKICAgICAvLyBUaGlz IGhhcyB0byBiZSBkb25lIGFmdGVyIGNoZWNraW5nIGZvciBjbGVhciwgc28gdGhhdCBtYXJnaW5z IGNhbiBiZSByZXNldCBpZiBhIGNsZWFyIG9jY3VycmVkLgpAQCAtMzAwMyw2ICszMDAxLDE3IEBA IHZvaWQgUmVuZGVyQmxvY2tGbG93OjpjcmVhdGVSZW5kZXJOYW1lZEZsb3dGcmFnbWVudElmTmVl ZGVkKCkKICAgICB9CiB9CiAKK2Jvb2wgUmVuZGVyQmxvY2tGbG93OjpuZWVkc0xheW91dEFmdGVy UmVnaW9uUmFuZ2VDaGFuZ2UoKSBjb25zdAoreworICAgIC8vIEEgYmxvY2sgd2l0aG91dCBmbG9h dHMgb3IgdGhhdCBleHBhbmRzIHRvIGVuY2xvc2UgdGhlbSB3b24ndCBuZWVkIGEgcmVsYXlvdXQK KyAgICAvLyBhZnRlciBhIHJlZ2lvbiByYW5nZSBjaGFuZ2UuIFRoZXJlIGlzIG5vIG92ZXJmbG93 IGNvbnRlbnQgbmVlZGluZyByZWxheW91dAorICAgIC8vIGluIHRoZSByZWdpb24gY2hhaW4gYmVj YXVzZSB0aGUgcmVnaW9uIHJhbmdlIGNhbiBvbmx5IHNocmluayBhZnRlciB0aGUgZXN0aW1hdGlv bi4KKyAgICBpZiAoIWNvbnRhaW5zRmxvYXRzKCkgfHwgZXhwYW5kc1RvRW5jbG9zZU92ZXJoYW5n aW5nRmxvYXRzKCkpCisgICAgICAgIHJldHVybiBmYWxzZTsKKworICAgIHJldHVybiB0cnVlOwor fQorCiBib29sIFJlbmRlckJsb2NrRmxvdzo6Y2FuSGF2ZUNoaWxkcmVuKCkgY29uc3QKIHsKICAg ICByZXR1cm4gIXJlbmRlck5hbWVkRmxvd0ZyYWdtZW50KCkgPyBSZW5kZXJCbG9jazo6Y2FuSGF2 ZUNoaWxkcmVuKCkgOiByZW5kZXJOYW1lZEZsb3dGcmFnbWVudCgpLT5jYW5IYXZlQ2hpbGRyZW4o KTsKZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJDb3JlL3JlbmRlcmluZy9SZW5kZXJCbG9ja0Zsb3cu aCBiL1NvdXJjZS9XZWJDb3JlL3JlbmRlcmluZy9SZW5kZXJCbG9ja0Zsb3cuaAppbmRleCAwMzUz NmU5NzU5YzgyN2JiODdhZmU4ZGVjOWFmZGEwYmRlZGRiZGYwLi4wODI3OTU4YTZiNjYzNzZhZGEx NDdlMTBiNDBmODA0ZGJjZjI0ZGM0IDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViQ29yZS9yZW5kZXJp bmcvUmVuZGVyQmxvY2tGbG93LmgKKysrIGIvU291cmNlL1dlYkNvcmUvcmVuZGVyaW5nL1JlbmRl ckJsb2NrRmxvdy5oCkBAIC0zODgsNiArMzg4LDggQEAgcHVibGljOgogICAgIAogICAgIHZvaWQg dXBkYXRlQ29sdW1uUHJvZ3Jlc3Npb25Gcm9tU3R5bGUoUmVuZGVyU3R5bGUqKTsKIAorICAgIHZp cnR1YWwgYm9vbCBuZWVkc0xheW91dEFmdGVyUmVnaW9uUmFuZ2VDaGFuZ2UoKSBjb25zdCBvdmVy cmlkZTsKKwogcHJvdGVjdGVkOgogICAgIHZpcnR1YWwgdm9pZCBjb21wdXRlSW50cmluc2ljTG9n aWNhbFdpZHRocyhMYXlvdXRVbml0JiBtaW5Mb2dpY2FsV2lkdGgsIExheW91dFVuaXQmIG1heExv Z2ljYWxXaWR0aCkgY29uc3Qgb3ZlcnJpZGU7CiAgICAgCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2Vi Q29yZS9yZW5kZXJpbmcvUmVuZGVyQm94LmggYi9Tb3VyY2UvV2ViQ29yZS9yZW5kZXJpbmcvUmVu ZGVyQm94LmgKaW5kZXggZTU0NzZmYzZhMTAyM2NjMGFjNzE1ODZmY2U5ZmJhMGMyNzc1MmY1MC4u M2VjZTMxMjE4OWM3YTk3OGU5MmRhMTAwMTg1YmI1MzBhYjM3NDQwNSAxMDA2NDQKLS0tIGEvU291 cmNlL1dlYkNvcmUvcmVuZGVyaW5nL1JlbmRlckJveC5oCisrKyBiL1NvdXJjZS9XZWJDb3JlL3Jl bmRlcmluZy9SZW5kZXJCb3guaApAQCAtNjE1LDYgKzYxNSw3IEBAIHB1YmxpYzoKIAogICAgIC8v IFRydWUgaWYgdGhpcyBib3ggY2FuIGhhdmUgYSByYW5nZSBpbiBhbiBvdXRzaWRlIGZyYWdtZW50 YXRpb24gY29udGV4dC4KICAgICBib29sIGNhbkhhdmVPdXRzaWRlUmVnaW9uUmFuZ2UoKSBjb25z dCB7IHJldHVybiAhaXNJbkZsb3dSZW5kZXJGbG93VGhyZWFkKCk7IH0KKyAgICB2aXJ0dWFsIGJv b2wgbmVlZHNMYXlvdXRBZnRlclJlZ2lvblJhbmdlQ2hhbmdlKCkgY29uc3QgeyByZXR1cm4gZmFs c2U7IH0KIAogcHJvdGVjdGVkOgogICAgIFJlbmRlckJveChFbGVtZW50JiwgUGFzc1JlZjxSZW5k ZXJTdHlsZT4sIHVuc2lnbmVkIGJhc2VUeXBlRmxhZ3MpOwo=