13212 2007-03-27 18:08:11 -0700 Submit initial version of WebKit Apollo bitmap interface for feedback 2008-07-28 11:22:06 -0700 1 1 1 Unclassified WebKit WebKit API 523.x (Safari 3) Other OS X 10.4 RESOLVED WONTFIX P2 Normal --- 0 chrisb webkit-unassigned ap webkit oldest_to_newest 16891 0 chrisb 2007-03-27 18:08:11 -0700 Creating a patch with this one file that defines the interfaces between WebKit Apollo and the bitmap surfaces it draws into. The point of this patch is to get feed back on the coding style and the directory layout in WebKit/apollo. 16893 1 13838 chrisb 2007-03-27 18:17:32 -0700 Created attachment 13838 Initial patch of a few web kit apollo interface files. Initial patch of a few web kit apollo interface files. Please just review. Do not commit. 16889 2 chrisb 2007-03-27 18:24:08 -0700 There will be a source directory that contains all the implementation files for WebKitApollo at WebKit/apollo/source. Headers private to WebKitApollo will live in WebKit/apollo/source. Public headers will all be in WebKitApollo/apollo/include/WebKitApollo, WebKit/apollo/include/mac/WebKitApollo, WebKit/apollo/include/linux/WebKitApollo, or WebKit/apollo/include/win/WebKitApollo. I also realized I forgot to put in a copyright notice in WebConfig.h. 4699 3 13838 mrowe 2007-07-15 11:23:13 -0700 Comment on attachment 13838 Initial patch of a few web kit apollo interface files. About the directory naming: I'm not sure what having the extra level "WebKitApollo" adds to things. On the Mac at least the <WebKitApollo/HeaderName.h> framework-style references would work for free due to how Xcode's header copying build phase works. You may want to take a look at how we handle the Windows WebKit layer accessing WebCore headers using the <WebCore/HeaderName.h> style import and use a similar approach here. Miscellaneous coding style points: *) There is a lot of extraneous whitespace inside parentheses in your typedef's. *) The *-placement inside your typedefs isn't consistent. *) The name m_pVTable in WebKitApolloBitmap seems like it's bordering on Hungarian notation. What is the purpose of the WEBKIT_APOLLO_PROTO1 and WEBKIT_APOLLO_PROTO2 macros? Their names provide no information as to the reason for their existence, and their empty definitions are not particularly enlightening either. 87170 4 webkit 2008-07-28 10:45:13 -0700 Chris, do you plan to proceed with the bug? 87177 5 chrisb 2008-07-28 11:20:28 -0700 (In reply to comment #4) > Chris, do you plan to proceed with the bug? > Not at this time. You can kill the bug. 13838 2007-03-27 18:17:32 -0700 2007-07-15 04:35:05 -0700 Initial patch of a few web kit apollo interface files. webkit.initial.patch.txt text/plain 4271 chrisb SW5kZXg6IFdlYktpdC9DaGFuZ2VMb2cKPT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PQotLS0gV2ViS2l0L0NoYW5nZUxvZwko cmV2aXNpb24gMjA1NDQpCisrKyBXZWJLaXQvQ2hhbmdlTG9nCSh3b3JraW5nIGNvcHkpCkBAIC0x LDMgKzEsMjAgQEAKKzIwMDctMDMtMjcgIENocmlzdG9waGVyIEJyaWNoZm9yZCAgPGNocmlzYkBh ZG9iZS5jb20+CisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAg ICAgLSBGaXggZm9yOiBCdWcgMTMyMTI6IFN1Ym1pdCBpbml0aWFsIHZlcnNpb24gb2YgV2ViS2l0 IEFwb2xsbyBiaXRtYXAgaW50ZXJmYWNlIGZvciBmZWVkYmFjaworICAgICAgICAgIGh0dHA6Ly9i dWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTEzMjEyCisKKyAgICAgICAgLSBEb24ndCBh Y3R1YWxseSBhcHBseSB0aGlzIHBhdGNoLCBwbGVhc2UganVzdCBnaXZlIGZlZWRiYWNrIG9uIHRo ZSBkaXJlY3RvcnkKKyAgICAgICAgICBsYXlvdXQgYW5kIGNvZGluZyBzdHlsZS4gCisgCisgICAg ICAgIC0gRmlsZXMgYXJlIGxhaWQgb3V0IHN1Y2ggdGhhdCBpbmNsdWRlIHBhdGggaGFzIHR3byBl bnRyaWVzOgorICAgICAgICAgIFdlYktpdC9pbmNsdWRlIGFuZCBXZWJLaXQvaW5jbHVkZS9tYWMu ICBBbGwgZmlsZXMgaW4gdGhvc2UgZGlyZWN0b3JpZXMKKyAgICAgICAgICBhcmUgdGhlbiByZWZl cmVuY2VkIHVzaW5nICNpbmNsdWRlIDxXZWJLaXRBcG9sbG8vTmFtZS5oPgorCisgICAgICAgICog YXBvbGxvL2luY2x1ZGUvV2ViS2l0QXBvbGxvL1dlYkJpdG1hcC5oOiBBZGRlZC4KKyAgICAgICAg KiBhcG9sbG8vaW5jbHVkZS9tYWMvV2ViS2l0QXBvbGxvL1dlYkNvbmZpZy5oOiBBZGRlZC4KKwog MjAwNy0wMy0yNyAgSm9obiBTdWxsaXZhbiAgPHN1bGxpdmFuQGFwcGxlLmNvbT4KIAogICAgICAg ICBSZXZpZXdlZCBieSBUaW0KSW5kZXg6IFdlYktpdC9hcG9sbG8vaW5jbHVkZS9XZWJLaXRBcG9s bG8vV2ViQml0bWFwLmgKPT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PQotLS0gV2ViS2l0L2Fwb2xsby9pbmNsdWRlL1dlYktp dEFwb2xsby9XZWJCaXRtYXAuaAkocmV2aXNpb24gMCkKKysrIFdlYktpdC9hcG9sbG8vaW5jbHVk ZS9XZWJLaXRBcG9sbG8vV2ViQml0bWFwLmgJKHJldmlzaW9uIDApCkBAIC0wLDAgKzEsNTUgQEAK Ky8qCisgKiBDb3B5cmlnaHQgKEMpIDIwMDcgQWRvYmUgU3lzdGVtcyBJbmNvcnBvcmF0ZWQuICBB bGwgcmlnaHRzIHJlc2VydmVkLgorICoKKyAqIFJlZGlzdHJpYnV0aW9uIGFuZCB1c2UgaW4gc291 cmNlIGFuZCBiaW5hcnkgZm9ybXMsIHdpdGggb3Igd2l0aG91dAorICogbW9kaWZpY2F0aW9uLCBh cmUgcGVybWl0dGVkIHByb3ZpZGVkIHRoYXQgdGhlIGZvbGxvd2luZyBjb25kaXRpb25zCisgKiBh cmUgbWV0OgorICogMS4gUmVkaXN0cmlidXRpb25zIG9mIHNvdXJjZSBjb2RlIG11c3QgcmV0YWlu IHRoZSBhYm92ZSBjb3B5cmlnaHQKKyAqICAgIG5vdGljZSwgdGhpcyBsaXN0IG9mIGNvbmRpdGlv bnMgYW5kIHRoZSBmb2xsb3dpbmcgZGlzY2xhaW1lci4KKyAqIDIuIFJlZGlzdHJpYnV0aW9ucyBp biBiaW5hcnkgZm9ybSBtdXN0IHJlcHJvZHVjZSB0aGUgYWJvdmUgY29weXJpZ2h0CisgKiAgICBu b3RpY2UsIHRoaXMgbGlzdCBvZiBjb25kaXRpb25zIGFuZCB0aGUgZm9sbG93aW5nIGRpc2NsYWlt ZXIgaW4gdGhlCisgKiAgICBkb2N1bWVudGF0aW9uIGFuZC9vciBvdGhlciBtYXRlcmlhbHMgcHJv dmlkZWQgd2l0aCB0aGUgZGlzdHJpYnV0aW9uLgorICogMy4gTmVpdGhlciB0aGUgbmFtZSBvZiB0 aGUgQWRvYmUgU3lzdGVtcyBJbmNvcnBvcmF0ZWQgbm9yIHRoZSBuYW1lcyBvZgorICogICAgaXRz IGNvbnRyaWJ1dG9ycyBtYXkgYmUgdXNlZCB0byBlbmRvcnNlIG9yIHByb21vdGUgcHJvZHVjdHMg ZGVyaXZlZAorICogICAgZnJvbSB0aGlzIHNvZnR3YXJlIHdpdGhvdXQgc3BlY2lmaWMgcHJpb3Ig d3JpdHRlbiBwZXJtaXNzaW9uLgorICoKKyAqIFRISVMgU09GVFdBUkUgSVMgUFJPVklERUQgQlkg QURPQkUgU1lTVEVNUyBJTkNPUlBPUkFURUQgIkFTIElTIiBBTkQgQU5ZCisgKiBFWFBSRVNTIE9S IElNUExJRUQgV0FSUkFOVElFUywgSU5DTFVESU5HLCBCVVQgTk9UIExJTUlURUQgVE8sIFRIRQor ICogSU1QTElFRCBXQVJSQU5USUVTIE9GIE1FUkNIQU5UQUJJTElUWSBBTkQgRklUTkVTUyBGT1Ig QSBQQVJUSUNVTEFSCisgKiBQVVJQT1NFIEFSRSBESVNDTEFJTUVELiAgSU4gTk8gRVZFTlQgU0hB TEwgQURPQkUgU1lTVEVNUyBJTkNPUlBPUkFURUQKKyAqIE9SIENPTlRSSUJVVE9SUyBCRSBMSUFC TEUgRk9SIEFOWSBESVJFQ1QsIElORElSRUNULCBJTkNJREVOVEFMLAorICogU1BFQ0lBTCwgRVhF TVBMQVJZLCBPUiBDT05TRVFVRU5USUFMIERBTUFHRVMgKElOQ0xVRElORywgQlVUIE5PVAorICog TElNSVRFRCBUTywgUFJPQ1VSRU1FTlQgT0YgU1VCU1RJVFVURSBHT09EUyBPUiBTRVJWSUNFUzsg TE9TUyBPRiBVU0UsCisgKiBEQVRBLCBPUiBQUk9GSVRTOyBPUiBCVVNJTkVTUyBJTlRFUlJVUFRJ T04pIEhPV0VWRVIgQ0FVU0VEIEFORCBPTiBBTlkKKyAqIFRIRU9SWSBPRiBMSUFCSUxJVFksIFdI RVRIRVIgSU4gQ09OVFJBQ1QsIFNUUklDVCBMSUFCSUxJVFksIE9SIFRPUlQKKyAqIChJTkNMVURJ TkcgTkVHTElHRU5DRSBPUiBPVEhFUldJU0UpIEFSSVNJTkcgSU4gQU5ZIFdBWSBPVVQgT0YgVEhF IFVTRQorICogT0YgVEhJUyBTT0ZUV0FSRSwgRVZFTiBJRiBBRFZJU0VEIE9GIFRIRSBQT1NTSUJJ TElUWSBPRiBTVUNIIERBTUFHRS4KKyovCisjaWZuZGVmIFdlYkJpdG1hcF9oCisjZGVmaW5lIFdl YkJpdG1hcF9oCisKKyNpbmNsdWRlIDxXZWJLaXRBcG9sbG8vV2ViQ29uZmlnLmg+CisKK3N0cnVj dCBXZWJLaXRBcG9sbG9CaXRtYXBWVGFibGU7CitzdHJ1Y3QgV2ViS2l0QXBvbGxvQml0bWFwOwor Cit0eXBlZGVmIFdFQktJVF9BUE9MTE9fUFJPVE8xIHZvaWQqICggV0VCS0lUX0FQT0xMT19QUk9U TzIgKldlYkJpdG1hcEdldFBpeGVsRGF0YUZ1bmN0aW9uICkoIHN0cnVjdCBXZWJLaXRBcG9sbG9C aXRtYXAqICk7CisKK3R5cGVkZWYgV0VCS0lUX0FQT0xMT19QUk9UTzEgdW5zaWduZWQgbG9uZyAo IFdFQktJVF9BUE9MTE9fUFJPVE8yICpXZWJCaXRtYXBHZXRXaWR0aEZ1bmN0aW9uICkoIHN0cnVj dCBXZWJLaXRBcG9sbG9CaXRtYXAqICk7CisKK3R5cGVkZWYgV0VCS0lUX0FQT0xMT19QUk9UTzEg dW5zaWduZWQgbG9uZyAoIFdFQktJVF9BUE9MTE9fUFJPVE8yICpXZWJCaXRtYXBHZXRIZWlnaHRG dW5jdGlvbiApKCBzdHJ1Y3QgV2ViS2l0QXBvbGxvQml0bWFwKiApOworCit0eXBlZGVmIFdFQktJ VF9BUE9MTE9fUFJPVE8xIHVuc2lnbmVkIGxvbmcgKCBXRUJLSVRfQVBPTExPX1BST1RPMiAqV2Vi Qml0bWFwR2V0U3RyaWRlRnVuY3Rpb24gKSggc3RydWN0IFdlYktpdEFwb2xsb0JpdG1hcCogKTsK Kworc3RydWN0IFdlYktpdEFwb2xsb0JpdG1hcFZUYWJsZSB7CisgICAgV2ViQml0bWFwR2V0UGl4 ZWxEYXRhRnVuY3Rpb24gZ2V0UGl4ZWxEYXRhOworICAgIFdlYkJpdG1hcEdldFdpZHRoRnVuY3Rp b24gZ2V0V2lkdGg7CisgICAgV2ViQml0bWFwR2V0SGVpZ2h0RnVuY3Rpb24gZ2V0SGVpZ2h0Owor ICAgIFdlYkJpdG1hcEdldFN0cmlkZUZ1bmN0aW9uIGdldFN0cmlkZTsKK307CisKK3N0cnVjdCBX ZWJLaXRBcG9sbG9CaXRtYXAgeworICAgIGNvbnN0IFdlYktpdEFwb2xsb0JpdG1hcFZUYWJsZSog bV9wVlRhYmxlOworfTsKKworI2VuZGlmCkluZGV4OiBXZWJLaXQvYXBvbGxvL2luY2x1ZGUvbWFj L1dlYktpdEFwb2xsby9XZWJDb25maWcuaAo9PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBXZWJLaXQvYXBvbGxvL2lu Y2x1ZGUvbWFjL1dlYktpdEFwb2xsby9XZWJDb25maWcuaAkocmV2aXNpb24gMCkKKysrIFdlYktp dC9hcG9sbG8vaW5jbHVkZS9tYWMvV2ViS2l0QXBvbGxvL1dlYkNvbmZpZy5oCShyZXZpc2lvbiAw KQpAQCAtMCwwICsxLDkgQEAKKyNpZm5kZWYgV2ViQ29uZmlnX2gKKyNkZWZpbmUgV2ViQ29uZmln X2gKKworI2RlZmluZSBXRUJLSVRfQVBPTExPX1BST1RPMQorI2RlZmluZSBXRUJLSVRfQVBPTExP X1BST1RPMgorCisjZGVmaW5lIFdFQktJVF9BUE9MTE9fTk9fVlRBQkxFCisKKyNlbmRpZgo=