132118 2014-04-24 01:57:52 -0700 [EFL] WebKit build fails when MEDIA_SOURCE is enabled 2014-04-24 19:44:56 -0700 1 1 1 Unclassified WebKit WebKit EFL 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 1 praveen.j webkit-unassigned bunhere commit-queue dev_sachin gyuyoung.kim lucas.de.marchi rakuco sergio oldest_to_newest 1003591 0 praveen.j 2014-04-24 01:57:52 -0700 Enable MEDIA_SOURCE for EFL build in the file Tools/Scripts/webkitperl/FeatureList.pm and compile the code. Build breaks with the following error. CMakeFiles/WebCore.dir/platform/graphics/gstreamer/MediaPlayerPrivateGStreamer.cpp.o: In function `WebCore::initializeGStreamerAndRegisterWebKitElements()': MediaPlayerPrivateGStreamer.cpp:(.text._ZN7WebCore44initializeGStreamerAndRegisterWebKitElementsEv+0xc1): undefined reference to `webkit_media_src_get_type' CMakeFiles/WebCore.dir/platform/graphics/gstreamer/MediaPlayerPrivateGStreamer.cpp.o: In function `WebCore::MediaPlayerPrivateGStreamer::sourceChanged()': MediaPlayerPrivateGStreamer.cpp:(.text._ZN7WebCore27MediaPlayerPrivateGStreamer13sourceChangedEv+0x8c): undefined reference to `webkit_media_src_get_type' MediaPlayerPrivateGStreamer.cpp:(.text._ZN7WebCore27MediaPlayerPrivateGStreamer13sourceChangedEv+0xc1): undefined reference to `webkit_media_src_get_type' MediaPlayerPrivateGStreamer.cpp:(.text._ZN7WebCore27MediaPlayerPrivateGStreamer13sourceChangedEv+0xdf): undefined reference to `WebCore::MediaSourceGStreamer::open(WebCore::MediaSourcePrivateClient*, _WebKitMediaSrc*)' MediaPlayerPrivateGStreamer.cpp:(.text._ZN7WebCore27MediaPlayerPrivateGStreamer13sourceChangedEv+0xeb): undefined reference to `webkit_media_src_get_type' MediaPlayerPrivateGStreamer.cpp:(.text._ZN7WebCore27MediaPlayerPrivateGStreamer13sourceChangedEv+0x109): undefined reference to `webKitMediaSrcSetPlayBin' collect2: error: ld returned 1 exit status make[2]: *** [lib/libwebcore_efl.so.0.1.0] Error 1 make[1]: *** [Source/WebCore/CMakeFiles/WebCore.dir/all] Error 2 make: *** [all] Error 2 1003597 1 230066 praveen.j 2014-04-24 02:57:49 -0700 Created attachment 230066 Patch PlatformEfl.cmake is modified to include MediaSourceGStreamer.cpp, SourceBufferPrivateGStreamer.cpp and WebKitMediaSourceGStreamer.cpp for compilation. 1003605 2 230066 gyuyoung.kim 2014-04-24 03:50:24 -0700 Comment on attachment 230066 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=230066&action=review It would be nice to move those file from PlatofrmGTK|EFL to CMakeLists.txt because GTK port also use it. However, we can't do that because wince port doesn't use it. > Source/WebCore/CMakeLists.txt:3111 > + "${WEBCORE_DIR}/platform/mock/mediasource" PlatformGTK.cmake also includes this path. I think you need to remove it from the PlatformGTK.cmake if you want to add the path to CMakeLists.txt But, wince port doesn't need to include this path. So, I think you need to move this to PlatformEfl.cmake as well. 1003615 3 230074 praveen.j 2014-04-24 06:26:14 -0700 Created attachment 230074 Patch Patch updated. All changes are included in PlatformEfl.cmake to ensure other bots are not affected. 1003643 4 230074 bfulgham 2014-04-24 09:01:19 -0700 Comment on attachment 230074 Patch r=me. Are similar changes needed on Gtk? 1003667 5 230074 commit-queue 2014-04-24 09:31:49 -0700 Comment on attachment 230074 Patch Clearing flags on attachment: 230074 Committed r167762: <http://trac.webkit.org/changeset/167762> 1003668 6 commit-queue 2014-04-24 09:31:53 -0700 All reviewed patches have been landed. Closing bug. 1003944 7 praveen.j 2014-04-24 19:44:56 -0700 (In reply to comment #4) > (From update of attachment 230074 [details]) > r=me. Are similar changes needed on Gtk? Gtk already has these changes. 230066 2014-04-24 02:57:49 -0700 2014-04-24 06:26:14 -0700 Patch MediaSource-132118.txt text/plain 2416 praveen.j SW5kZXg6IFNvdXJjZS9XZWJDb3JlL0NoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBTb3VyY2UvV2Vi Q29yZS9DaGFuZ2VMb2cJKHJldmlzaW9uIDE2Nzc1MikKKysrIFNvdXJjZS9XZWJDb3JlL0NoYW5n ZUxvZwkod29ya2luZyBjb3B5KQpAQCAtMSwzICsxLDE5IEBACisyMDE0LTA0LTI0ICBQcmF2ZWVu IFIgSmFkaGF2ICA8cHJhdmVlbi5qQHNhbXN1bmcuY29tPgorCisgICAgICAgIFtFRkxdIFdlYktp dCBidWlsZCBmYWlscyB3aGVuIE1FRElBX1NPVVJDRSBpcyBlbmFibGVkCisgICAgICAgIGh0dHBz Oi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0xMzIxMTgKKworICAgICAgICBSZXZp ZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICBGaWxlcyBNZWRpYVNvdXJjZUdTdHJl YW1lci5jcHAsIFNvdXJjZUJ1ZmZlclByaXZhdGVHU3RyZWFtZXIuY3BwIGFuZAorICAgICAgICBX ZWJLaXRNZWRpYVNvdXJjZUdTdHJlYW1lci5jcHAgYXJlIGluY2x1ZGVkIGZvciBFRkwgcG9ydCBi dWlsZC4KKworICAgICAgICBObyBuZXcgdGVzdHMuIE5vIGNoYW5nZSBpbiBiZWhhdmlvdXIuCisK KyAgICAgICAgKiBDTWFrZUxpc3RzLnR4dDoKKyAgICAgICAgKiBQbGF0Zm9ybUVmbC5jbWFrZTog TWVkaWFTb3VyY2VHU3RyZWFtZXIuY3BwLCBTb3VyY2VCdWZmZXJQcml2YXRlR1N0cmVhbWVyLmNw cAorICAgICAgICBhbmQgV2ViS2l0TWVkaWFTb3VyY2VHU3RyZWFtZXIuY3BwIGFyZSBpbmNsdWRl ZCBmb3IgY29tcGlsYXRpb24uCisKIDIwMTQtMDQtMjMgIENhcmxvcyBHYXJjaWEgQ2FtcG9zICA8 Y2dhcmNpYUBpZ2FsaWEuY29tPgogCiAgICAgICAgIFtHVEtdIEhUTUwgTWVkaWEgY2FwdHVyZSBh dHRyaWJ1dGUgaXMgYSBib29sZWFuIHNpbmNlIHIxNjM5NTgKSW5kZXg6IFNvdXJjZS9XZWJDb3Jl L0NNYWtlTGlzdHMudHh0Cj09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIFNvdXJjZS9XZWJDb3JlL0NNYWtlTGlzdHMu dHh0CShyZXZpc2lvbiAxNjc3NDkpCisrKyBTb3VyY2UvV2ViQ29yZS9DTWFrZUxpc3RzLnR4dAko d29ya2luZyBjb3B5KQpAQCAtMzEwOCw2ICszMTA4LDcgQEAgZW5kaWYgKCkKIAogc2V0KFdlYkNv cmVUZXN0U3VwcG9ydF9JTkNMVURFX0RJUkVDVE9SSUVTCiAgICAgIiR7V0VCQ09SRV9ESVJ9L3Bs YXRmb3JtL21vY2siCisgICAgIiR7V0VCQ09SRV9ESVJ9L3BsYXRmb3JtL21vY2svbWVkaWFzb3Vy Y2UiCiAgICAgIiR7V0VCQ09SRV9ESVJ9L3Rlc3RpbmciCiApCiAKSW5kZXg6IFNvdXJjZS9XZWJD b3JlL1BsYXRmb3JtRWZsLmNtYWtlCj09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIFNvdXJjZS9XZWJDb3JlL1BsYXRm b3JtRWZsLmNtYWtlCShyZXZpc2lvbiAxNjc3NDkpCisrKyBTb3VyY2UvV2ViQ29yZS9QbGF0Zm9y bUVmbC5jbWFrZQkod29ya2luZyBjb3B5KQpAQCAtMTM2LDExICsxMzYsMTQgQEAgbGlzdChBUFBF TkQgV2ViQ29yZV9TT1VSQ0VTCiAgICAgcGxhdGZvcm0vZ3JhcGhpY3MvZ3N0cmVhbWVyL0luYmFu ZFRleHRUcmFja1ByaXZhdGVHU3RyZWFtZXIuY3BwCiAgICAgcGxhdGZvcm0vZ3JhcGhpY3MvZ3N0 cmVhbWVyL01lZGlhUGxheWVyUHJpdmF0ZUdTdHJlYW1lci5jcHAKICAgICBwbGF0Zm9ybS9ncmFw aGljcy9nc3RyZWFtZXIvTWVkaWFQbGF5ZXJQcml2YXRlR1N0cmVhbWVyQmFzZS5jcHAKKyAgICBw bGF0Zm9ybS9ncmFwaGljcy9nc3RyZWFtZXIvTWVkaWFTb3VyY2VHU3RyZWFtZXIuY3BwCisgICAg cGxhdGZvcm0vZ3JhcGhpY3MvZ3N0cmVhbWVyL1NvdXJjZUJ1ZmZlclByaXZhdGVHU3RyZWFtZXIu Y3BwCiAgICAgcGxhdGZvcm0vZ3JhcGhpY3MvZ3N0cmVhbWVyL1RleHRDb21iaW5lckdTdHJlYW1l ci5jcHAKICAgICBwbGF0Zm9ybS9ncmFwaGljcy9nc3RyZWFtZXIvVGV4dFNpbmtHU3RyZWFtZXIu Y3BwCiAgICAgcGxhdGZvcm0vZ3JhcGhpY3MvZ3N0cmVhbWVyL1RyYWNrUHJpdmF0ZUJhc2VHU3Ry ZWFtZXIuY3BwCiAgICAgcGxhdGZvcm0vZ3JhcGhpY3MvZ3N0cmVhbWVyL1ZpZGVvU2lua0dTdHJl YW1lci5jcHAKICAgICBwbGF0Zm9ybS9ncmFwaGljcy9nc3RyZWFtZXIvVmlkZW9UcmFja1ByaXZh dGVHU3RyZWFtZXIuY3BwCisgICAgcGxhdGZvcm0vZ3JhcGhpY3MvZ3N0cmVhbWVyL1dlYktpdE1l ZGlhU291cmNlR1N0cmVhbWVyLmNwcAogICAgIHBsYXRmb3JtL2dyYXBoaWNzL2dzdHJlYW1lci9X ZWJLaXRXZWJTb3VyY2VHU3RyZWFtZXIuY3BwCiAKICAgICBwbGF0Zm9ybS9ncmFwaGljcy9oYXJm YnV6ei9IYXJmQnV6ekZhY2UuY3BwCg== 230074 2014-04-24 06:26:14 -0700 2014-04-24 09:31:49 -0700 Patch MediaSource-132118.txt text/plain 2360 praveen.j SW5kZXg6IFNvdXJjZS9XZWJDb3JlL0NoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBTb3VyY2UvV2Vi Q29yZS9DaGFuZ2VMb2cJKHJldmlzaW9uIDE2Nzc1NCkKKysrIFNvdXJjZS9XZWJDb3JlL0NoYW5n ZUxvZwkod29ya2luZyBjb3B5KQpAQCAtMSwzICsxLDE4IEBACisyMDE0LTA0LTI0ICBQcmF2ZWVu IFIgSmFkaGF2ICA8cHJhdmVlbi5qQHNhbXN1bmcuY29tPgorCisgICAgICAgIFtFRkxdIFdlYktp dCBidWlsZCBmYWlscyB3aGVuIE1FRElBX1NPVVJDRSBpcyBlbmFibGVkCisgICAgICAgIGh0dHBz Oi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0xMzIxMTgKKworICAgICAgICBSZXZp ZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICBGaWxlcyBNZWRpYVNvdXJjZUdTdHJl YW1lci5jcHAsIFNvdXJjZUJ1ZmZlclByaXZhdGVHU3RyZWFtZXIuY3BwIGFuZAorICAgICAgICBX ZWJLaXRNZWRpYVNvdXJjZUdTdHJlYW1lci5jcHAgYXJlIGluY2x1ZGVkIGZvciBFRkwgcG9ydCBi dWlsZC4KKworICAgICAgICBObyBuZXcgdGVzdHMuIE5vIGNoYW5nZSBpbiBiZWhhdmlvdXIuCisK KyAgICAgICAgKiBQbGF0Zm9ybUVmbC5jbWFrZTogTWVkaWFTb3VyY2VHU3RyZWFtZXIuY3BwLCBT b3VyY2VCdWZmZXJQcml2YXRlR1N0cmVhbWVyLmNwcAorICAgICAgICBhbmQgV2ViS2l0TWVkaWFT b3VyY2VHU3RyZWFtZXIuY3BwIGFyZSBpbmNsdWRlZCBmb3IgY29tcGlsYXRpb24uCisKIDIwMTQt MDQtMjMgIENhcmxvcyBHYXJjaWEgQ2FtcG9zICA8Y2dhcmNpYUBpZ2FsaWEuY29tPgogCiAgICAg ICAgIFtHVEtdIEhUTUwgTWVkaWEgY2FwdHVyZSBhdHRyaWJ1dGUgaXMgYSBib29sZWFuIHNpbmNl IHIxNjM5NTgKSW5kZXg6IFNvdXJjZS9XZWJDb3JlL1BsYXRmb3JtRWZsLmNtYWtlCj09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT0KLS0tIFNvdXJjZS9XZWJDb3JlL1BsYXRmb3JtRWZsLmNtYWtlCShyZXZpc2lvbiAxNjc3NTMp CisrKyBTb3VyY2UvV2ViQ29yZS9QbGF0Zm9ybUVmbC5jbWFrZQkod29ya2luZyBjb3B5KQpAQCAt MTMsNiArMTMsNyBAQCBsaXN0KEFQUEVORCBXZWJDb3JlX0lOQ0xVREVfRElSRUNUT1JJRVMKICAg ICAiJHtXRUJDT1JFX0RJUn0vcGxhdGZvcm0vZ3JhcGhpY3MvdGV4bWFwL2Nvb3JkaW5hdGVkIgog ICAgICIke1dFQkNPUkVfRElSfS9wbGF0Zm9ybS9saW51eCIKICAgICAiJHtXRUJDT1JFX0RJUn0v cGxhdGZvcm0vbWVkaWFzdHJlYW0vZ3N0cmVhbWVyIgorICAgICIke1dFQkNPUkVfRElSfS9wbGF0 Zm9ybS9tb2NrL21lZGlhc291cmNlIgogICAgICIke1dFQkNPUkVfRElSfS9wbGF0Zm9ybS9uZXR3 b3JrL3NvdXAiCiAgICAgIiR7V0VCQ09SRV9ESVJ9L3BsYXRmb3JtL3RleHQvZWZsIgogICAgICIk e1dFQkNPUkVfRElSfS9wbHVnaW5zL2VmbCIKQEAgLTEzNiwxMSArMTM3LDE0IEBAIGxpc3QoQVBQ RU5EIFdlYkNvcmVfU09VUkNFUwogICAgIHBsYXRmb3JtL2dyYXBoaWNzL2dzdHJlYW1lci9JbmJh bmRUZXh0VHJhY2tQcml2YXRlR1N0cmVhbWVyLmNwcAogICAgIHBsYXRmb3JtL2dyYXBoaWNzL2dz dHJlYW1lci9NZWRpYVBsYXllclByaXZhdGVHU3RyZWFtZXIuY3BwCiAgICAgcGxhdGZvcm0vZ3Jh cGhpY3MvZ3N0cmVhbWVyL01lZGlhUGxheWVyUHJpdmF0ZUdTdHJlYW1lckJhc2UuY3BwCisgICAg cGxhdGZvcm0vZ3JhcGhpY3MvZ3N0cmVhbWVyL01lZGlhU291cmNlR1N0cmVhbWVyLmNwcAorICAg IHBsYXRmb3JtL2dyYXBoaWNzL2dzdHJlYW1lci9Tb3VyY2VCdWZmZXJQcml2YXRlR1N0cmVhbWVy LmNwcAogICAgIHBsYXRmb3JtL2dyYXBoaWNzL2dzdHJlYW1lci9UZXh0Q29tYmluZXJHU3RyZWFt ZXIuY3BwCiAgICAgcGxhdGZvcm0vZ3JhcGhpY3MvZ3N0cmVhbWVyL1RleHRTaW5rR1N0cmVhbWVy LmNwcAogICAgIHBsYXRmb3JtL2dyYXBoaWNzL2dzdHJlYW1lci9UcmFja1ByaXZhdGVCYXNlR1N0 cmVhbWVyLmNwcAogICAgIHBsYXRmb3JtL2dyYXBoaWNzL2dzdHJlYW1lci9WaWRlb1NpbmtHU3Ry ZWFtZXIuY3BwCiAgICAgcGxhdGZvcm0vZ3JhcGhpY3MvZ3N0cmVhbWVyL1ZpZGVvVHJhY2tQcml2 YXRlR1N0cmVhbWVyLmNwcAorICAgIHBsYXRmb3JtL2dyYXBoaWNzL2dzdHJlYW1lci9XZWJLaXRN ZWRpYVNvdXJjZUdTdHJlYW1lci5jcHAKICAgICBwbGF0Zm9ybS9ncmFwaGljcy9nc3RyZWFtZXIv V2ViS2l0V2ViU291cmNlR1N0cmVhbWVyLmNwcAogCiAgICAgcGxhdGZvcm0vZ3JhcGhpY3MvaGFy ZmJ1enovSGFyZkJ1enpGYWNlLmNwcAo=