132097 2014-04-23 19:02:05 -0700 [iOS WK2] Make -webkit-overflow-scrolling:touch work 2014-04-23 20:32:44 -0700 1 1 1 Unclassified WebKit New Bugs 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED InRadar P2 Normal --- 1 simon.fraser simon.fraser benjamin commit-queue simon.fraser thorton oldest_to_newest 1003465 0 simon.fraser 2014-04-23 19:02:05 -0700 [iOS WK2] Make -webkit-overflow-scrolling:touch work 1003467 1 230031 simon.fraser 2014-04-23 19:09:43 -0700 Created attachment 230031 Patch 1003469 2 simon.fraser 2014-04-23 19:11:09 -0700 <rdar://problem/16655349> 1003471 3 commit-queue 2014-04-23 19:11:12 -0700 Attachment 230031 did not pass style-queue: ERROR: Source/WebKit2/UIProcess/ios/RemoteLayerTreeHostIOS.mm:58: Place brace on its own line for function definitions. [whitespace/braces] [4] Total errors found: 1 in 3 files If any of these errors are false positives, please file a bug against check-webkit-style. 1003479 4 230031 thorton 2014-04-23 19:23:59 -0700 Comment on attachment 230031 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=230031&action=review > Source/WebKit2/UIProcess/ios/RemoteLayerTreeHostIOS.mm:57 > + __block UIView* foundView = nil; star on the wrong side > Source/WebKit2/UIProcess/ios/RemoteLayerTreeHostIOS.mm:64 > + if ([view subviews]) { early return? 1003491 5 simon.fraser 2014-04-23 19:47:24 -0700 *** Bug 132015 has been marked as a duplicate of this bug. *** 1003500 6 simon.fraser 2014-04-23 20:32:44 -0700 http://trac.webkit.org/changeset/167740 230031 2014-04-23 19:09:43 -0700 2014-04-23 19:23:59 -0700 Patch bug-132097-20140423190920.patch text/plain 6481 simon.fraser U3VidmVyc2lvbiBSZXZpc2lvbjogMTY3NjM4CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViS2l0Mi9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViS2l0Mi9DaGFuZ2VMb2cKaW5kZXggMTRmZDAwYjVhZmE0Y2Jm OTRhZGFlNTQzNTIxMTExNzQzMjJiMzc0Yi4uMDYzOWNlOTIyOTE2NzMwNjNjNGRkNjc1MDNlNjEw OGNhODZhNDAyYyAxMDA2NDQKLS0tIGEvU291cmNlL1dlYktpdDIvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJLaXQyL0NoYW5nZUxvZwpAQCAtMSwzICsxLDMyIEBACisyMDE0LTA0LTIzICBTaW1v biBGcmFzZXIgIDxzaW1vbi5mcmFzZXJAYXBwbGUuY29tPgorCisgICAgICAgIFtpT1MgV0syXSBN YWtlIC13ZWJraXQtb3ZlcmZsb3ctc2Nyb2xsaW5nOnRvdWNoIHdvcmsKKyAgICAgICAgaHR0cHM6 Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTEzMjA5NworCisgICAgICAgIFJldmll d2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorICAgICAgICAKKyAgICAgICAgU2Nyb2xsaW5nIG9mIFVJ U2Nyb2xsVmlld3MgaW4gY29udGVudCAoZm9yIC13ZWJraXQtb3ZlcmZsb3ctc2Nyb2xsaW5nOnRv dWNoKQorICAgICAgICBkZXBlbmRzIG9uIHRoZW0gZ2V0dGluZyBoaXQtdGVzdGVkIGNvcnJlY3Rs eS4gVUlLaXQgaGl0IHRlc3RpbmcgYXNzdW1lcworICAgICAgICB0aGF0IHN1YnZpZXdzIGFyZSBl bmNsb3NlZCBieSB0aGVpciBhbmNlc3RvcnMsIGJ1dCB0aGlzIGlzIG5vdCB0cnVlIG9mCisgICAg ICAgIHdlYiBjb250ZW50LiBJbiBhZGRpdGlvbiwgd2UgaGFkIGEgcm9vdCBsYXllciB0aGF0IHdh cyB6ZXJvIHNpemVkLgorICAgICAgICAKKyAgICAgICAgRml4IGJ5IG92ZXJyaWRpbmcgaGl0VGVz dDp3aXRoRXZlbnQ6IG9uIG91ciBjb250ZW50IFdLVmlld3MgdG8gaGl0CisgICAgICAgIHRlc3Qg c3Vidmlld3MgZXZlbiBpZiB0aGV5IGFyZSBub3QgZW5jbG9zZWQuCisKKyAgICAgICAgKiBVSVBy b2Nlc3MvaW9zL1JlbW90ZUxheWVyVHJlZUhvc3RJT1MubW06CisgICAgICAgICgtW1VJVmlldyBf cmVjdXJzaXZlRmluZERlc2NlbmRhbnRWaWV3QXRQb2ludDp3aXRoRXZlbnQ6XSk6CisgICAgICAg ICgtW1VJVmlldyBfZmluZERlc2NlbmRhbnRWaWV3QXRQb2ludDp3aXRoRXZlbnQ6XSk6CisgICAg ICAgICgtW1dLQ29tcG9zaXRpbmdWaWV3IGhpdFRlc3Q6d2l0aEV2ZW50Ol0pOgorICAgICAgICAo LVtXS1RyYW5zZm9ybVZpZXcgaGl0VGVzdDp3aXRoRXZlbnQ6XSk6CisgICAgICAgICgtW1dLUmVt b3RlVmlldyBoaXRUZXN0OndpdGhFdmVudDpdKToKKyAgICAgICAgKFdlYktpdDo6UmVtb3RlTGF5 ZXJUcmVlSG9zdDo6Y3JlYXRlTGF5ZXIpOgorICAgICAgICAqIFdlYlByb2Nlc3MvV2ViUGFnZS9t YWMvUmVtb3RlTGF5ZXJUcmVlRHJhd2luZ0FyZWEubW06CisgICAgICAgIChXZWJLaXQ6OlJlbW90 ZUxheWVyVHJlZURyYXdpbmdBcmVhOjp1cGRhdGVQcmVmZXJlbmNlcyk6CisgICAgICAgIFVwZGF0 ZSBkZWJ1ZyBib3JkZXJzIG9uIHRoZSByb290IGxheWVyLgorICAgICAgICAoV2ViS2l0OjpSZW1v dGVMYXllclRyZWVEcmF3aW5nQXJlYTo6bWFpbkZyYW1lQ29udGVudFNpemVDaGFuZ2VkKToKKyAg ICAgICAgU2l6ZSB0aGUgcm9vdCBsYXllciB0byB0aGUgY29udGVudHMgc2l6ZS4gVGhpcyBpc24n dCBzdHJpY3RseSBuZWNlc3NhcnkKKyAgICAgICAgZ2l2ZW4gdGhlIGhpdCB0ZXN0aW5nIG92ZXJy aWRlcywgYnV0IHNlZW1zIHNlbnNpYmxlIHRvIGRvIGFueXdheS4KKwogMjAxNC0wNC0yMSAgU2lt b24gRnJhc2VyICA8c2ltb24uZnJhc2VyQGFwcGxlLmNvbT4KIAogICAgICAgICBEb24ndCB0cnkg dG8gdXNlIGEgbnVsbCBjb25uZWN0aW9uKCktPnhwY0Nvbm5lY3Rpb24oKQpkaWZmIC0tZ2l0IGEv U291cmNlL1dlYktpdDIvVUlQcm9jZXNzL2lvcy9SZW1vdGVMYXllclRyZWVIb3N0SU9TLm1tIGIv U291cmNlL1dlYktpdDIvVUlQcm9jZXNzL2lvcy9SZW1vdGVMYXllclRyZWVIb3N0SU9TLm1tCmlu ZGV4IGY2MzhlZjk2MjllMWYwYTFmMzVjM2M3Yjg4NWYzNWRmODc5OTFjOWMuLjQ2NTI5NzQyMDNi M2RiZDZmYWZiN2Q0NjAzOGFhMDZhYTZkZTBiNmEgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJLaXQy L1VJUHJvY2Vzcy9pb3MvUmVtb3RlTGF5ZXJUcmVlSG9zdElPUy5tbQorKysgYi9Tb3VyY2UvV2Vi S2l0Mi9VSVByb2Nlc3MvaW9zL1JlbW90ZUxheWVyVHJlZUhvc3RJT1MubW0KQEAgLTQxLDYgKzQx LDUyIEBAIEBpbnRlcmZhY2UgQ0FMYXllcihXS0xheWVySW50ZXJuYWwpCiAtICh2b2lkKXNldENv bnRleHRJZDoodWludDMyX3QpY29udGV4dElEOwogQGVuZAogCitAaW50ZXJmYWNlIFVJVmlldyAo V0tIaXRUZXN0aW5nKQorLSAoVUlWaWV3ICopX2ZpbmREZXNjZW5kYW50Vmlld0F0UG9pbnQ6KENH UG9pbnQpcG9pbnQgd2l0aEV2ZW50OihVSUV2ZW50ICopZXZlbnQ7CitAZW5kCisKK0BpbXBsZW1l bnRhdGlvbiBVSVZpZXcgKFdLSGl0VGVzdGluZykKKworLy8gVUlWaWV3IGhpdCB0ZXN0aW5nIGFz c3VtZXMgdGhhdCB2aWV3cyBzaG91bGQgb25seSBoaXQgdGVzdCBzdWJ2aWV3cyB0aGF0IGFyZSBl bnRpcmVseSBjb250YWluZWQKKy8vIGluIHRoZSB2aWV3LiBUaGlzIGlzIG5vdCB0cnVlIG9mIHdl YiBjb250ZW50LgorLSAoVUlWaWV3ICopX3JlY3Vyc2l2ZUZpbmREZXNjZW5kYW50Vmlld0F0UG9p bnQ6KENHUG9pbnQpcG9pbnQgd2l0aEV2ZW50OihVSUV2ZW50ICopZXZlbnQKK3sKKyAgICBpZiAo c2VsZi5jbGlwc1RvQm91bmRzICYmICFbc2VsZiBwb2ludEluc2lkZTpwb2ludCB3aXRoRXZlbnQ6 ZXZlbnRdKQorICAgICAgICByZXR1cm4gbmlsOworCisgICAgX19ibG9jayBVSVZpZXcqIGZvdW5k VmlldyA9IG5pbDsKKyAgICBbW3NlbGYgc3Vidmlld3NdIGVudW1lcmF0ZU9iamVjdHNVc2luZ0Js b2NrOl4oVUlWaWV3ICp2aWV3LCBOU1VJbnRlZ2VyIGlkeCwgQk9PTCAqc3RvcCkgeworICAgICAg ICBDR1BvaW50IHN1YnZpZXdQb2ludCA9IFt2aWV3IGNvbnZlcnRQb2ludDpwb2ludCBmcm9tVmll dzpzZWxmXTsKKworICAgICAgICBpZiAoW3ZpZXcgcG9pbnRJbnNpZGU6c3Vidmlld1BvaW50IHdp dGhFdmVudDpldmVudF0pCisgICAgICAgICAgICBmb3VuZFZpZXcgPSB2aWV3OworCisgICAgICAg IGlmIChbdmlldyBzdWJ2aWV3c10pIHsKKyAgICAgICAgICAgIGlmIChVSVZpZXcgKmhpdFZpZXcg PSBbdmlldyBfcmVjdXJzaXZlRmluZERlc2NlbmRhbnRWaWV3QXRQb2ludDpzdWJ2aWV3UG9pbnQg d2l0aEV2ZW50OmV2ZW50XSkKKyAgICAgICAgICAgICAgICBmb3VuZFZpZXcgPSBoaXRWaWV3Owor ICAgICAgICB9CisgICAgfV07CisKKyAgICByZXR1cm4gZm91bmRWaWV3OworfQorCistIChVSVZp ZXcgKilfZmluZERlc2NlbmRhbnRWaWV3QXRQb2ludDooQ0dQb2ludClwb2ludCB3aXRoRXZlbnQ6 KFVJRXZlbnQgKilldmVudAoreworICAgIHJldHVybiBbc2VsZiBfcmVjdXJzaXZlRmluZERlc2Nl bmRhbnRWaWV3QXRQb2ludDpwb2ludCB3aXRoRXZlbnQ6ZXZlbnRdOworfQorCitAZW5kCisKK0Bp bnRlcmZhY2UgV0tDb21wb3NpdGluZ1ZpZXcgOiBVSVZpZXcKK0BlbmQKKworQGltcGxlbWVudGF0 aW9uIFdLQ29tcG9zaXRpbmdWaWV3CistIChVSVZpZXcgKiloaXRUZXN0OihDR1BvaW50KXBvaW50 IHdpdGhFdmVudDooVUlFdmVudCAqKWV2ZW50Cit7CisgICAgcmV0dXJuIFtzZWxmIF9maW5kRGVz Y2VuZGFudFZpZXdBdFBvaW50OnBvaW50IHdpdGhFdmVudDpldmVudF07Cit9CitAZW5kCisKIEBp bnRlcmZhY2UgV0tUcmFuc2Zvcm1WaWV3IDogVUlWaWV3CiBAZW5kCiAKQEAgLTQ5LDYgKzk1LDEx IEBAICsgKENsYXNzKWxheWVyQ2xhc3MKIHsKICAgICByZXR1cm4gW0NBVHJhbnNmb3JtTGF5ZXIg c2VsZl07CiB9CisKKy0gKFVJVmlldyAqKWhpdFRlc3Q6KENHUG9pbnQpcG9pbnQgd2l0aEV2ZW50 OihVSUV2ZW50ICopZXZlbnQKK3sKKyAgICByZXR1cm4gW3NlbGYgX2ZpbmREZXNjZW5kYW50Vmll d0F0UG9pbnQ6cG9pbnQgd2l0aEV2ZW50OmV2ZW50XTsKK30KIEBlbmQKIAogQGludGVyZmFjZSBX S1JlbW90ZVZpZXcgOiBVSVZpZXcKQEAgLTY4LDYgKzExOSwxMiBAQCArIChDbGFzcylsYXllckNs YXNzCiB7CiAgICAgcmV0dXJuIE5TQ2xhc3NGcm9tU3RyaW5nKEAiQ0FMYXllckhvc3QiKTsKIH0K KworLSAoVUlWaWV3ICopaGl0VGVzdDooQ0dQb2ludClwb2ludCB3aXRoRXZlbnQ6KFVJRXZlbnQg KilldmVudAoreworICAgIHJldHVybiBbc2VsZiBfZmluZERlc2NlbmRhbnRWaWV3QXRQb2ludDpw b2ludCB3aXRoRXZlbnQ6ZXZlbnRdOworfQorCiBAZW5kCiAKIG5hbWVzcGFjZSBXZWJLaXQgewpA QCAtODksNyArMTQ2LDcgQEAgTGF5ZXJPclZpZXcgKlJlbW90ZUxheWVyVHJlZUhvc3Q6OmNyZWF0 ZUxheWVyKGNvbnN0IFJlbW90ZUxheWVyVHJlZVRyYW5zYWN0aW9uOjoKICAgICAgICAgaWYgKGxh eWVyUHJvcGVydGllcyAmJiBsYXllclByb3BlcnRpZXMtPmN1c3RvbUJlaGF2aW9yID09IEdyYXBo aWNzTGF5ZXI6OkN1c3RvbVNjcm9sbGluZ0JlaGF2aW9yKQogICAgICAgICAgICAgbGF5ZXJPclZp ZXcgPSBhZG9wdE5TKFtbVUlTY3JvbGxWaWV3IGFsbG9jXSBpbml0XSk7CiAgICAgICAgIGVsc2UK LSAgICAgICAgICAgIGxheWVyT3JWaWV3ID0gYWRvcHROUyhbW1VJVmlldyBhbGxvY10gaW5pdF0p OworICAgICAgICAgICAgbGF5ZXJPclZpZXcgPSBhZG9wdE5TKFtbV0tDb21wb3NpdGluZ1ZpZXcg YWxsb2NdIGluaXRdKTsKICAgICAgICAgYnJlYWs7CiAgICAgY2FzZSBQbGF0Zm9ybUNBTGF5ZXI6 OkxheWVyVHlwZVRyYW5zZm9ybUxheWVyOgogICAgICAgICBsYXllck9yVmlldyA9IGFkb3B0TlMo W1tXS1RyYW5zZm9ybVZpZXcgYWxsb2NdIGluaXRdKTsKQEAgLTk4LDcgKzE1NSw3IEBAIExheWVy T3JWaWV3ICpSZW1vdGVMYXllclRyZWVIb3N0OjpjcmVhdGVMYXllcihjb25zdCBSZW1vdGVMYXll clRyZWVUcmFuc2FjdGlvbjo6CiAgICAgICAgIGlmICghbV9pc0RlYnVnTGF5ZXJUcmVlSG9zdCkK ICAgICAgICAgICAgIGxheWVyT3JWaWV3ID0gYWRvcHROUyhbW1dLUmVtb3RlVmlldyBhbGxvY10g aW5pdFdpdGhGcmFtZTpDR1JlY3RaZXJvIGNvbnRleHRJRDpwcm9wZXJ0aWVzLmhvc3RpbmdDb250 ZXh0SURdKTsKICAgICAgICAgZWxzZQotICAgICAgICAgICAgbGF5ZXJPclZpZXcgPSBhZG9wdE5T KFtbVUlWaWV3IGFsbG9jXSBpbml0XSk7CisgICAgICAgICAgICBsYXllck9yVmlldyA9IGFkb3B0 TlMoW1tXS0NvbXBvc2l0aW5nVmlldyBhbGxvY10gaW5pdF0pOwogICAgICAgICBicmVhazsKICAg ICBkZWZhdWx0OgogICAgICAgICBBU1NFUlRfTk9UX1JFQUNIRUQoKTsKZGlmZiAtLWdpdCBhL1Nv dXJjZS9XZWJLaXQyL1dlYlByb2Nlc3MvV2ViUGFnZS9tYWMvUmVtb3RlTGF5ZXJUcmVlRHJhd2lu Z0FyZWEubW0gYi9Tb3VyY2UvV2ViS2l0Mi9XZWJQcm9jZXNzL1dlYlBhZ2UvbWFjL1JlbW90ZUxh eWVyVHJlZURyYXdpbmdBcmVhLm1tCmluZGV4IDFkMGNkOGY1NTM1OWViOGVlNDcyZDdlMDcyMmM4 ZGYyZTZlMDg4NzAuLjk2N2RjYjI2NmYxYmQxN2UzMDE0NTE4NjJlYzRlZmQwNDU1YTQ0YjAgMTAw NjQ0Ci0tLSBhL1NvdXJjZS9XZWJLaXQyL1dlYlByb2Nlc3MvV2ViUGFnZS9tYWMvUmVtb3RlTGF5 ZXJUcmVlRHJhd2luZ0FyZWEubW0KKysrIGIvU291cmNlL1dlYktpdDIvV2ViUHJvY2Vzcy9XZWJQ YWdlL21hYy9SZW1vdGVMYXllclRyZWVEcmF3aW5nQXJlYS5tbQpAQCAtMTE5LDYgKzExOSw4IEBA IHZvaWQgUmVtb3RlTGF5ZXJUcmVlRHJhd2luZ0FyZWE6OnVwZGF0ZVByZWZlcmVuY2VzKGNvbnN0 IFdlYlByZWZlcmVuY2VzU3RvcmUmKQogICAgIC8vIGluIG9yZGVyIHRvIGJlIHNjcm9sbGVkIGJ5 IHRoZSBTY3JvbGxpbmdDb29yZGluYXRvci4KICAgICBzZXR0aW5ncy5zZXRBY2NlbGVyYXRlZENv bXBvc2l0aW5nRm9yRml4ZWRQb3NpdGlvbkVuYWJsZWQodHJ1ZSk7CiAgICAgc2V0dGluZ3Muc2V0 Rml4ZWRQb3NpdGlvbkNyZWF0ZXNTdGFja2luZ0NvbnRleHQodHJ1ZSk7CisKKyAgICBtX3Jvb3RM YXllci0+c2V0U2hvd0RlYnVnQm9yZGVyKHNldHRpbmdzLnNob3dEZWJ1Z0JvcmRlcnMoKSk7CiB9 CiAKICNpZiBQTEFURk9STShJT1MpCkBAIC0yOTUsOCArMjk3LDkgQEAgdm9pZCBSZW1vdGVMYXll clRyZWVEcmF3aW5nQXJlYTo6ZGlkVXBkYXRlKCkKICAgICB9CiB9CiAKLXZvaWQgUmVtb3RlTGF5 ZXJUcmVlRHJhd2luZ0FyZWE6Om1haW5GcmFtZUNvbnRlbnRTaXplQ2hhbmdlZChjb25zdCBJbnRT aXplJikKK3ZvaWQgUmVtb3RlTGF5ZXJUcmVlRHJhd2luZ0FyZWE6Om1haW5GcmFtZUNvbnRlbnRT aXplQ2hhbmdlZChjb25zdCBJbnRTaXplJiBjb250ZW50c1NpemUpCiB7CisgICAgbV9yb290TGF5 ZXItPnNldFNpemUoY29udGVudHNTaXplKTsKICAgICBtX3dlYlBhZ2UtPnBhZ2VPdmVybGF5Q29u dHJvbGxlcigpLmRpZENoYW5nZURvY3VtZW50U2l6ZSgpOwogfQogCg==