132094 2014-04-23 18:46:28 -0700 [EFL][WK1] Add *const* keyword to _get() APIs 2014-04-23 19:25:41 -0700 1 1 1 Unclassified WebKit WebKit EFL 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 1 gyuyoung.kim hw1008.kim bunhere cdumez commit-queue gyuyoung.kim hw1008.kim lucas.de.marchi sergio oldest_to_newest 1003456 0 gyuyoung.kim 2014-04-23 18:46:28 -0700 Some _get() EFL APIs don't have *const* keyword though the _get() APIs don't modify passed argument. We need to add *const* keyword to those APIs. 1003459 1 230029 hw1008.kim 2014-04-23 18:50:50 -0700 Created attachment 230029 Patch 1003462 2 gyuyoung.kim 2014-04-23 18:55:56 -0700 LGTM 1003480 3 230029 commit-queue 2014-04-23 19:25:35 -0700 Comment on attachment 230029 Patch Clearing flags on attachment: 230029 Committed r167737: <http://trac.webkit.org/changeset/167737> 1003481 4 commit-queue 2014-04-23 19:25:41 -0700 All reviewed patches have been landed. Closing bug. 230029 2014-04-23 18:50:50 -0700 2014-04-23 19:25:35 -0700 Patch bug-132094-20140424105028.patch text/plain 3398 hw1008.kim U3VidmVyc2lvbiBSZXZpc2lvbjogMTY3NzI5CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViS2l0L2Vm bC9DaGFuZ2VMb2cgYi9Tb3VyY2UvV2ViS2l0L2VmbC9DaGFuZ2VMb2cKaW5kZXggNTE3YmI2ZWNm ODZjMWVlNzQ5NWU1YTJkNmE0OGI4MWFkYmQ4ZDBiMi4uNGJiNjEyOTk2YTA5NDY4NWVhZTQ1ODZl YjIwMDNjODI4MWE2MTViNyAxMDA2NDQKLS0tIGEvU291cmNlL1dlYktpdC9lZmwvQ2hhbmdlTG9n CisrKyBiL1NvdXJjZS9XZWJLaXQvZWZsL0NoYW5nZUxvZwpAQCAtMSwzICsxLDIwIEBACisyMDE0 LTA0LTIzICBIeW93b24gS2ltICA8aHcxMDA4LmtpbUBzYW1zdW5nLmNvbT4KKworICAgICAgICBb RUZMXVtXSzFdIEFkZCAqY29uc3QqIGtleXdvcmQgdG8gX2dldCgpIEFQSXMKKyAgICAgICAgaHR0 cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTEzMjA5NAorCisgICAgICAgIFJl dmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgIFNvbWUgX2dldCgpIEVGTCBBUElz IGRvbid0IGhhdmUgKmNvbnN0KiBrZXl3b3JkIHRob3VnaCB0aGUgX2dldCgpIEFQSXMgZG9uJ3Qg bW9kaWZ5IHBhc3NlZCBhcmd1bWVudC4KKyAgICAgICAgV2UgbmVlZCB0byBhZGQgKmNvbnN0KiBr ZXl3b3JkIHRvIHRob3NlIEFQSXMuCisKKyAgICAgICAgKiBld2svZXdrX2hpc3RvcnkuY3BwOgor ICAgICAgICAoZXdrX2hpc3RvcnlfbGltaXRfZ2V0KToKKyAgICAgICAgKiBld2svZXdrX2hpc3Rv cnkuaDoKKyAgICAgICAgKiBld2svZXdrX2pzLmNwcDoKKyAgICAgICAgKGV3a19qc19vYmplY3Rf dHlwZV9nZXQpOgorICAgICAgICAqIGV3ay9ld2tfanMuaDoKKwogMjAxNC0wNC0yMiAgUnl1YW4g Q2hvaSAgPHJ5dWFuLmNob2lAc2Ftc3VuZy5jb20+CiAKICAgICAgICAgW0VGTF1bV0sxXSBUaGVy ZSBhcmUgbWFueSBmYWlsdXJlcyBpbiBmYXN0L2Zvcm1zIHNpbmNlIHIxNjMwMzMKZGlmZiAtLWdp dCBhL1NvdXJjZS9XZWJLaXQvZWZsL2V3ay9ld2tfaGlzdG9yeS5jcHAgYi9Tb3VyY2UvV2ViS2l0 L2VmbC9ld2svZXdrX2hpc3RvcnkuY3BwCmluZGV4IDZlNTZhYWZkZGRjNTM3Mzg1NDY0MWEyYmQ3 NTg5YjVjNjhlNTI2N2MuLjc3ZjBhNmQzMjhiZTIwMjk3YTYzZTA2NTg0NTdkY2QyNTU0M2EyYjIg MTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJLaXQvZWZsL2V3ay9ld2tfaGlzdG9yeS5jcHAKKysrIGIv U291cmNlL1dlYktpdC9lZmwvZXdrL2V3a19oaXN0b3J5LmNwcApAQCAtMjE5LDcgKzIxOSw3IEBA IGludCBld2tfaGlzdG9yeV9iYWNrX2xpc3RfbGVuZ3RoKGNvbnN0IEV3a19IaXN0b3J5KiBoaXN0 b3J5KQogICAgIHJldHVybiBjb3JlLT5iYWNrTGlzdENvdW50KCk7CiB9CiAKLWludCBld2tfaGlz dG9yeV9saW1pdF9nZXQoRXdrX0hpc3RvcnkqIGhpc3RvcnkpCitpbnQgZXdrX2hpc3RvcnlfbGlt aXRfZ2V0KGNvbnN0IEV3a19IaXN0b3J5KiBoaXN0b3J5KQogewogICAgIEVXS19ISVNUT1JZX0NP UkVfR0VUX09SX1JFVFVSTihoaXN0b3J5LCBjb3JlLCAwKTsKICAgICByZXR1cm4gY29yZS0+Y2Fw YWNpdHkoKTsKZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJLaXQvZWZsL2V3ay9ld2tfaGlzdG9yeS5o IGIvU291cmNlL1dlYktpdC9lZmwvZXdrL2V3a19oaXN0b3J5LmgKaW5kZXggYjUxMzdjZTdkN2Ix MjQ5NTYwODQ3ZTY0MzZlOGQ2ODc2MWJmMTVhZS4uMWQwNDc2Yjc2MGJkNDMzNGJlNWFjZjZkNDcx N2ViNTdiM2ZmZGZhYyAxMDA2NDQKLS0tIGEvU291cmNlL1dlYktpdC9lZmwvZXdrL2V3a19oaXN0 b3J5LmgKKysrIGIvU291cmNlL1dlYktpdC9lZmwvZXdrL2V3a19oaXN0b3J5LmgKQEAgLTI1MSw3 ICsyNTEsNyBAQCBFQVBJIGludCAgICAgICAgICAgICAgIGV3a19oaXN0b3J5X2JhY2tfbGlzdF9s ZW5ndGgoY29uc3QgRXdrX0hpc3RvcnkgKmhpc3RvcnkpOwogICoKICAqIEByZXR1cm4gbWF4aW11 bSBudW1iZXIgb2YgZW50cmllcyB0aGlzIGhpc3Rvcnkgd2lsbCBob2xkLgogICovCi1FQVBJIGlu dCAgICAgICAgICAgICAgIGV3a19oaXN0b3J5X2xpbWl0X2dldChFd2tfSGlzdG9yeSAqaGlzdG9y eSk7CitFQVBJIGludCAgICAgICAgICAgICAgIGV3a19oaXN0b3J5X2xpbWl0X2dldChjb25zdCBF d2tfSGlzdG9yeSAqaGlzdG9yeSk7CiAKIC8qKgogICogU2V0IG1heGltdW0gY2FwYWNpdHkgb2Yg Z2l2ZW4gaGlzdG9yeS4KZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJLaXQvZWZsL2V3ay9ld2tfanMu Y3BwIGIvU291cmNlL1dlYktpdC9lZmwvZXdrL2V3a19qcy5jcHAKaW5kZXggZmI4MjE1YzhmNjM1 NjI2YjgwNmRiYTAzNGZiOWQzMjAyOTI0Yjg3ZS4uNDgxZDRkMWY2NTk3N2Q2ODg5ZDhkMGI5ZWYw MTA0NjVhYTFmMDdjZSAxMDA2NDQKLS0tIGEvU291cmNlL1dlYktpdC9lZmwvZXdrL2V3a19qcy5j cHAKKysrIGIvU291cmNlL1dlYktpdC9lZmwvZXdrL2V3a19qcy5jcHAKQEAgLTY5Myw3ICs2OTMs NyBAQCBlbmQ6CiAjZW5kaWYKIH0KIAotRXdrX0pTX09iamVjdF9UeXBlIGV3a19qc19vYmplY3Rf dHlwZV9nZXQoRXdrX0pTX09iamVjdCoganNPYmplY3QpCitFd2tfSlNfT2JqZWN0X1R5cGUgZXdr X2pzX29iamVjdF90eXBlX2dldChjb25zdCBFd2tfSlNfT2JqZWN0KiBqc09iamVjdCkKIHsKICNp ZiBFTkFCTEUoTkVUU0NBUEVfUExVR0lOX0FQSSkKICAgICBFSU5BX1NBRkVUWV9PTl9OVUxMX1JF VFVSTl9WQUwoanNPYmplY3QsIEVXS19KU19PQkpFQ1RfT0JKRUNUKTsKZGlmZiAtLWdpdCBhL1Nv dXJjZS9XZWJLaXQvZWZsL2V3ay9ld2tfanMuaCBiL1NvdXJjZS9XZWJLaXQvZWZsL2V3ay9ld2tf anMuaAppbmRleCAyODNlNmY3NzRmNWIxNDE4MDFiOWQwZmI2ZmQxNGU1YzFiMTIyZGI2Li5hNzQz NjIwNWU4ZGJjMzdkMDgwNzA0M2YwYjZkYzFjMmUyNDM3ZGY2IDEwMDY0NAotLS0gYS9Tb3VyY2Uv V2ViS2l0L2VmbC9ld2svZXdrX2pzLmgKKysrIGIvU291cmNlL1dlYktpdC9lZmwvZXdrL2V3a19q cy5oCkBAIC0xOTEsNyArMTkxLDcgQEAgRUFQSSBFaW5hX0Jvb2wgZXdrX2pzX29iamVjdF9pbnZv a2UoRXdrX0pTX09iamVjdCAqb2JqLCBFd2tfSlNfVmFyaWFudCAqYXJncywgaW4KICAqIEByZXR1 cm4gQGMgRVdLX0pTX09CSkVDVCBpZiBpdCBpcyBhbiBvYmplY3QsIEBjIEVXS19KU19BUlJBWSBp ZiBpdCBpcyBhbiBhcnJheSBhbmQKICAqIEBjIEVXS19KU19GVU5DVElPTiBpZiBpdCBpcyBhIGZ1 bmN0aW9uLgogICovCi1FQVBJIEV3a19KU19PYmplY3RfVHlwZSBld2tfanNfb2JqZWN0X3R5cGVf Z2V0KEV3a19KU19PYmplY3QgKm9iaik7CitFQVBJIEV3a19KU19PYmplY3RfVHlwZSBld2tfanNf b2JqZWN0X3R5cGVfZ2V0KGNvbnN0IEV3a19KU19PYmplY3QgKm9iaik7CiAKIC8qKgogICogU2V0 cyB0aGUgdHlwZSB0aGlzIG9iamVjdCByZXByZXNlbnRzLgo=