132083 2014-04-23 15:20:58 -0700 Web Inspector: gradient editor does not appear for linear-gradient with no specified angle 2014-04-24 07:37:49 -0700 1 1 1 Unclassified WebKit Web Inspector 528+ (Nightly build) All All RESOLVED FIXED InRadar P2 Normal --- 1 betravis graouts commit-queue graouts joepeck timothy webkit-bug-importer oldest_to_newest 1003403 0 betravis 2014-04-23 15:20:58 -0700 Some gradients do not appear to trigger the new gradient editor. I used styles.css: .float { background: linear-gradient(green, blue); } and test.html: <!doctype html> <html> <head> <link href='styles.css' rel='stylesheet'> <style> .float { width: 200px; height: 200px; float: left; } </style> </head> <body> <div class='float'></div> </div> </body> </html> Changing the gradient to linear-gradient(0deg, green, blue) did work. 1003404 1 webkit-bug-importer 2014-04-23 15:21:31 -0700 <rdar://problem/16705257> 1003577 2 230062 graouts 2014-04-24 01:05:20 -0700 Created attachment 230062 Reduced testcase. 1003584 3 graouts 2014-04-24 01:43:48 -0700 WebInspector.LinearGradient.linearGradientWithComponents() is being called with components = [["green"], ["blue"]] and hits the following branch: // We don't support any of the legacy linear gradient formats. return null; … which was added in http://trac.webkit.org/changeset/165017 to fix https://bugs.webkit.org/show_bug.cgi?id=129623. 1003590 4 230065 graouts 2014-04-24 01:57:31 -0700 Created attachment 230065 Patch 1003627 5 230065 commit-queue 2014-04-24 07:37:46 -0700 Comment on attachment 230065 Patch Clearing flags on attachment: 230065 Committed r167756: <http://trac.webkit.org/changeset/167756> 1003628 6 commit-queue 2014-04-24 07:37:49 -0700 All reviewed patches have been landed. Closing bug. 230062 2014-04-24 01:05:20 -0700 2014-04-24 01:05:20 -0700 Reduced testcase. linear-gradient-no-angle.html text/html 83 graouts PHN0eWxlPgogICAgYm9keSB7CiAgICAgICAgYmFja2dyb3VuZDogbGluZWFyLWdyYWRpZW50KGdy ZWVuLCBibHVlKTsKICAgIH0KPC9zdHlsZT4= 230065 2014-04-24 01:57:31 -0700 2014-04-24 07:37:45 -0700 Patch bug-132083-20140424105708.patch text/plain 1725 graouts U3VidmVyc2lvbiBSZXZpc2lvbjogMTY3NzUyCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViSW5zcGVj dG9yVUkvQ2hhbmdlTG9nIGIvU291cmNlL1dlYkluc3BlY3RvclVJL0NoYW5nZUxvZwppbmRleCBj YmUwNjM3NGYxMjg3Yjk4NGZkODJlMGZmZmM5N2EyMjI5NDJjNzcwLi40MjMzY2JiOWFmNzUyZmMy MjkzYzRiNzRjYmEzYjhiNDIwYmY2YTRkIDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViSW5zcGVjdG9y VUkvQ2hhbmdlTG9nCisrKyBiL1NvdXJjZS9XZWJJbnNwZWN0b3JVSS9DaGFuZ2VMb2cKQEAgLTEs MyArMSwxNSBAQAorMjAxNC0wNC0yNCAgQW50b2luZSBRdWludCAgPGdyYW91dHNAd2Via2l0Lm9y Zz4KKworICAgICAgICBXZWIgSW5zcGVjdG9yOiBncmFkaWVudCBlZGl0b3IgZG9lcyBub3QgYXBw ZWFyIGZvciBsaW5lYXItZ3JhZGllbnQgd2l0aCBubyBzcGVjaWZpZWQgYW5nbGUKKyAgICAgICAg aHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTEzMjA4MworCisgICAgICAg IFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgIE9ubHkgYXNzdW1lIHdlJ3Jl IHBhcnNpbmcgYSBsZWdhY3ktZm9ybWF0dGVkIGdyYWRpZW50IGlmIHRoZSBmaXJzdCBwYXJhbWV0 ZXIgaXMgbm90IGEgY29sb3IuCisKKyAgICAgICAgKiBVc2VySW50ZXJmYWNlL01vZGVscy9HcmFk aWVudC5qczoKKyAgICAgICAgKFdlYkluc3BlY3Rvci5MaW5lYXJHcmFkaWVudC5saW5lYXJHcmFk aWVudFdpdGhDb21wb25lbnRzKToKKwogMjAxNC0wNC0yMiAgQnJlbnQgRnVsZ2hhbSAgPGJmdWxn aGFtQGFwcGxlLmNvbT4KIAogICAgICAgICBbV2luXSBTdXBwb3J0IFB5dGhvbiAyLjcgaW4gQ3ln d2luCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViSW5zcGVjdG9yVUkvVXNlckludGVyZmFjZS9Nb2Rl bHMvR3JhZGllbnQuanMgYi9Tb3VyY2UvV2ViSW5zcGVjdG9yVUkvVXNlckludGVyZmFjZS9Nb2Rl bHMvR3JhZGllbnQuanMKaW5kZXggYmVhYWNiYmE0NThkOGUyYjkxNjgwYWFjYTAzOTYwNDVjYmE2 MWVlMy4uMTBhYTNmNjA1ZGY3MGFhMzc1ZTc0Nzg3YmExYjJiMGYxOGY1MmIxYiAxMDA2NDQKLS0t IGEvU291cmNlL1dlYkluc3BlY3RvclVJL1VzZXJJbnRlcmZhY2UvTW9kZWxzL0dyYWRpZW50Lmpz CisrKyBiL1NvdXJjZS9XZWJJbnNwZWN0b3JVSS9Vc2VySW50ZXJmYWNlL01vZGVscy9HcmFkaWVu dC5qcwpAQCAtMTg4LDggKzE4OCw5IEBAIFdlYkluc3BlY3Rvci5MaW5lYXJHcmFkaWVudC5saW5l YXJHcmFkaWVudFdpdGhDb21wb25lbnRzID0gZnVuY3Rpb24oY29tcG9uZW50cykKICAgICAgICAg ICAgIHJldHVybiBudWxsOwogICAgICAgICB9CiAgICAgICAgIGNvbXBvbmVudHMuc2hpZnQoKTsK LSAgICB9IGVsc2UgewotICAgICAgICAvLyBXZSBkb24ndCBzdXBwb3J0IGFueSBvZiB0aGUgbGVn YWN5IGxpbmVhciBncmFkaWVudCBmb3JtYXRzLgorICAgIH0gZWxzZSBpZiAoY29tcG9uZW50c1sw XS5sZW5ndGggIT09IDEgJiYgIVdlYkluc3BlY3Rvci5Db2xvci5mcm9tU3RyaW5nKGNvbXBvbmVu dHNbMF1bMF0pKSB7CisgICAgICAgIC8vIElmIHRoZSBmaXJzdCBjb21wb25lbnQgaXMgbm90IGEg Y29sb3IsIHRoZW4gd2UncmUgZGVhbGluZyB3aXRoIGEKKyAgICAgICAgLy8gbGVnYWN5IGxpbmVh ciBncmFkaWVudCBmb3JtYXQgdGhhdCB3ZSBkb24ndCBzdXBwb3J0LgogICAgICAgICByZXR1cm4g bnVsbDsKICAgICB9CiAK