132082 2014-04-23 15:00:55 -0700 Mock scrollbars don't always work in DumpRenderTree 2014-04-23 20:01:22 -0700 1 1 1 Unclassified WebKit Tools / Tests 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED InRadar P2 Normal --- 1 thorton thorton ap bfulgham hyatt jonlee sam simon.fraser webkit-bug-importer oldest_to_newest 1003395 0 thorton 2014-04-23 15:00:55 -0700 The mock scrollbar Setting is set after view creation in DRT. If any scrollbars are created during view creation and do not get replaced later, they will be platform scrollbars instead of mock scrollbars (because setting the setting doesn't force the scrollbars to be recreated). WebKitTestRunner gets around this by setting the preference before creating the view; doing so in DRT as well makes everything happy. 1003397 1 230013 thorton 2014-04-23 15:03:36 -0700 Created attachment 230013 patch 1003399 2 thorton 2014-04-23 15:05:00 -0700 At some point we should probably fix the FIXME in Settings::setMockScrollbarsEnabled, but that is harder. 1003401 3 ap 2014-04-23 15:16:41 -0700 Should we remove that from resetWebPreferencesToConsistentValues()? Can tests change the value of this preference at all? 1003405 4 thorton 2014-04-23 15:21:35 -0700 (In reply to comment #3) > Should we remove that from resetWebPreferencesToConsistentValues()? Can tests change the value of this preference at all? Since it's a WebCore setting and exposed via internals, they CAN, but shouldn't, and the only tests that set it set it to true (why‽). 1003407 5 thorton 2014-04-23 15:23:55 -0700 http://trac.webkit.org/changeset/167728 1003413 6 ap 2014-04-23 15:50:58 -0700 Filed bug 132085 to kill it. 1003495 7 webkit-bug-importer 2014-04-23 20:01:22 -0700 <rdar://problem/16708329> 230013 2014-04-23 15:03:36 -0700 2014-04-23 15:15:39 -0700 patch mock.diff text/plain 1579 thorton ZGlmZiAtLWdpdCBhL1Rvb2xzL0NoYW5nZUxvZyBiL1Rvb2xzL0NoYW5nZUxvZwppbmRleCAyYmFh MmZkLi5hMDNmYjYwIDEwMDY0NAotLS0gYS9Ub29scy9DaGFuZ2VMb2cKKysrIGIvVG9vbHMvQ2hh bmdlTG9nCkBAIC0xLDMgKzEsMTkgQEAKKzIwMTQtMDQtMjMgIFRpbSBIb3J0b24gIDx0aW1vdGh5 X2hvcnRvbkBhcHBsZS5jb20+CisKKyAgICAgICAgTW9jayBzY3JvbGxiYXJzIGRvbid0IGFsd2F5 cyB3b3JrIGluIER1bXBSZW5kZXJUcmVlCisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3Jn L3Nob3dfYnVnLmNnaT9pZD0xMzIwODIKKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9P UFMhKS4KKworICAgICAgICAqIER1bXBSZW5kZXJUcmVlL21hYy9EdW1wUmVuZGVyVHJlZS5tbToK KyAgICAgICAgKHByZXBhcmVDb25zaXN0ZW50VGVzdGluZ0Vudmlyb25tZW50KToKKyAgICAgICAg U2V0IHRoZSBtb2NrIHNjcm9sbGJhciBzZXR0aW5nIGJlZm9yZSBjcmVhdGluZyB0aGUgV2ViVmll dywgYXMgdGhpcyBzZXR0aW5nCisgICAgICAgIGNhbm5vdCBiZSBkeW5hbWljYWxseSBjaGFuZ2Vk LCBzbyBhbnkgc2Nyb2xsYmFycyB0aGF0IGFyZSBjcmVhdGVkIGR1cmluZworICAgICAgICBXZWJW aWV3IGluaXRpYWxpemF0aW9uIGFuZCBhcmUgbm90IHJlcGxhY2VkIGJlZm9yZSBzbmFwc2hvdHRp bmcgd2lsbCBlbmQKKyAgICAgICAgdXAgYmVpbmcgcGxhdGZvcm0gc2Nyb2xsYmFycyBpbnN0ZWFk IG9mIG1vY2sgb25lcy4KKyAgICAgICAgV2ViS2l0VGVzdFJ1bm5lciBhbHJlYWR5IHNldHMgdGhp cyBwcmVmZXJlbmNlIGJlZm9yZSBjcmVhdGluZyBXS1ZpZXdzLAorICAgICAgICBzbyB3ZSdyZSBq dXN0IG1hdGNoaW5nIGl0cyBiZWhhdmlvci4KKwogMjAxNC0wNC0yMiAgVGltIEhvcnRvbiAgPHRp bW90aHlfaG9ydG9uQGFwcGxlLmNvbT4KIAogICAgICAgICBEdW1wUmVuZGVyVHJlZSBnZW5lcmF0 ZXMgYmxhY2sgc25hcHNob3RzIG9uIHNvbWUgcGxhdGZvcm1zCmRpZmYgLS1naXQgYS9Ub29scy9E dW1wUmVuZGVyVHJlZS9tYWMvRHVtcFJlbmRlclRyZWUubW0gYi9Ub29scy9EdW1wUmVuZGVyVHJl ZS9tYWMvRHVtcFJlbmRlclRyZWUubW0KaW5kZXggMTIzOTg3NC4uNDYzMDg3MCAxMDA2NDQKLS0t IGEvVG9vbHMvRHVtcFJlbmRlclRyZWUvbWFjL0R1bXBSZW5kZXJUcmVlLm1tCisrKyBiL1Rvb2xz L0R1bXBSZW5kZXJUcmVlL21hYy9EdW1wUmVuZGVyVHJlZS5tbQpAQCAtMTA5OCw2ICsxMDk4LDkg QEAgc3RhdGljIHZvaWQgcHJlcGFyZUNvbnNpc3RlbnRUZXN0aW5nRW52aXJvbm1lbnQoKQogCiAg ICAgYWRqdXN0Rm9udHMoKTsKICAgICByZWdpc3Rlck1vY2tTY3JvbGxiYXJzKCk7CisKKyAgICAv LyBUaGUgbW9jayBzY3JvbGxiYXJzIHNldHRpbmcgY2Fubm90IGJlIG1vZGlmaWVkIGFmdGVyIGNy ZWF0aW5nIGEgdmlldywgc28gd2UgaGF2ZSB0byBkbyBpdCBub3cuCisgICAgW1tXZWJQcmVmZXJl bmNlcyBzdGFuZGFyZFByZWZlcmVuY2VzXSBzZXRNb2NrU2Nyb2xsYmFyc0VuYWJsZWQ6WUVTXTsK ICNlbHNlCiAgICAgYWN0aXZhdGVGb250c0lPUygpOwogI2VuZGlmCg==