132053 2014-04-23 02:45:45 -0700 [Mac] REGRESSION (r164823): Building JavaScriptCore creates files under /tmp/JavaScriptCore.dst 2021-11-10 08:43:14 -0800 1 1 1 Unclassified WebKit New Bugs 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED https://bugs.webkit.org/show_bug.cgi?id=232940 P1 Blocker --- 129399 1 ossy ossy commit-queue ddkilzer joepeck mitz mrowe ossy oldest_to_newest 1003236 0 ossy 2014-04-23 02:45:45 -0700 http://trac.webkit.org/changeset/164823 http://trac.webkit.org/changeset/164828 After this change build-jsc unconditionally tries to remove and recreate a symlink to /tmp/JavaScriptCore.dst/usr/local/bin: jsc -> ../../../System/Library/Frameworks/JavaScriptCore.framework/Versions/A/Resources/jsc Additionally this symlink is broken, it points to a non-existent path. If there are more user work on a Mac, the second user won't be able to remove and recreate this symlink and build-jsc will fail. Could you possibly give us some hint how can we solve this problem? 1003238 1 229969 ossy 2014-04-23 02:51:33 -0700 Created attachment 229969 Patch I propose to revert r164823 and r164828, because now build-webkit always try to remove and recreate a broken and useless symlink unconditionally. It is a huge regression that now only one user can build WebKit on a Mac. 1003241 2 229969 mrowe 2014-04-23 03:03:39 -0700 Comment on attachment 229969 Patch Rolling those changes out reintroduces a much more serious issue. This should be trivial to fix properly, so let's just do that instead. 1003242 3 ossy 2014-04-23 03:05:04 -0700 (In reply to comment #2) > (From update of attachment 229969 [details]) > Rolling those changes out reintroduces a much more serious issue. This should be trivial to fix properly, so let's just do that instead. Could you give us any hint how can it be fixed properly? 1003243 4 229970 mrowe 2014-04-23 03:10:29 -0700 Created attachment 229970 Patch 1003244 5 229971 mrowe 2014-04-23 03:13:07 -0700 Created attachment 229971 Patch 1003246 6 ossy 2014-04-23 03:41:20 -0700 (In reply to comment #5) > Created an attachment (id=229971) [details] > Patch Thanks for the patch, it fixes the multi user issue I mentioned in the description. But I don't have expertise in Mac deployment, I let others to review the fix. 1003293 7 229971 commit-queue 2014-04-23 07:40:14 -0700 Comment on attachment 229971 Patch Clearing flags on attachment: 229971 Committed r167709: <http://trac.webkit.org/changeset/167709> 1003294 8 commit-queue 2014-04-23 07:40:17 -0700 All reviewed patches have been landed. Closing bug. 229969 2014-04-23 02:51:33 -0700 2014-04-23 03:10:26 -0700 Patch bug-132053-20140423115439.patch text/plain 2872 ossy U3VidmVyc2lvbiBSZXZpc2lvbjogMTY3NzAyCmRpZmYgLS1naXQgYS9Tb3VyY2UvSmF2YVNjcmlw dENvcmUvQ2hhbmdlTG9nIGIvU291cmNlL0phdmFTY3JpcHRDb3JlL0NoYW5nZUxvZwppbmRleCA2 ZjNkOTZiOTU5MjBmOGRhODQ1YjNmNWY4ODJiY2E4M2MwMTQ0NWNjLi5jNmZiZDZmMzkzMTYyOTlm MTM1NTMzYzhlYmE3MjgzMmEyNjdjMDg2IDEwMDY0NAotLS0gYS9Tb3VyY2UvSmF2YVNjcmlwdENv cmUvQ2hhbmdlTG9nCisrKyBiL1NvdXJjZS9KYXZhU2NyaXB0Q29yZS9DaGFuZ2VMb2cKQEAgLTEs MyArMSwyMCBAQAorMjAxNC0wNC0yMyAgQ3NhYmEgT3N6dHJvZ29uw6FjICA8b3NzeUB3ZWJraXQu b3JnPgorCisgICAgICAgIFtNYWNdIFJFR1JFU1NJT04ocjE2NDgyMyBhbmQgcjE2NDgyOCk6IEl0 IG1hZGUgaW1wb3NzaWJsZSB0byBidWlsZCBXZWJLaXQgYnkgZGlmZmVyZW50IHVzZXJzCisgICAg ICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0xMzIwNTMKKworICAg ICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICBSZXZlcnRlZCBjaGFu Z2VzZXRzOgorCisgICAgICAgICJDcmVhdGUgc3ltbGluayB0byAvdXNyL2xvY2FsL2Jpbi9qc2Mg ZHVyaW5nIGluc3RhbGxhdGlvbiIKKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hv d19idWcuY2dpP2lkPTEyOTM5OQorICAgICAgICBodHRwOi8vdHJhYy53ZWJraXQub3JnL2NoYW5n ZXNldC8xNjQ4MjMKKworICAgICAgICAiUmVtb3ZlIGpzYyBzeW1saW5rIGlmIGl0IGFscmVhZHkg ZXhpc3RzIgorICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9 MTI5Mzk5CisgICAgICAgIGh0dHA6Ly90cmFjLndlYmtpdC5vcmcvY2hhbmdlc2V0LzE2NDgyOAor CiAyMDE0LTA0LTIyICBNYXJrIExhbSAgPG1hcmsubGFtQGFwcGxlLmNvbT4KIAogICAgICAgICBE Rkc6OldvcmtsaXN0IHNob3VsZCBhY3F1aXJlIHRoZSBtX2xvY2sgYmVmb3JlIGl0ZXJhdGluZyBE RkcgcGxhbnMuCmRpZmYgLS1naXQgYS9Tb3VyY2UvSmF2YVNjcmlwdENvcmUvSmF2YVNjcmlwdENv cmUueGNvZGVwcm9qL3Byb2plY3QucGJ4cHJvaiBiL1NvdXJjZS9KYXZhU2NyaXB0Q29yZS9KYXZh U2NyaXB0Q29yZS54Y29kZXByb2ovcHJvamVjdC5wYnhwcm9qCmluZGV4IDY4MmQyMjE5NjIyNDFk MTI2OTAyNjEzYjUxNTFkN2NjNzFhMDMyMmEuLjExODAzNTdlYjlkOGEyNGZkNzVmMDUzM2Y4MWYx OTU0ZTYxYmRhZjUgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9KYXZhU2NyaXB0Q29yZS9KYXZhU2NyaXB0 Q29yZS54Y29kZXByb2ovcHJvamVjdC5wYnhwcm9qCisrKyBiL1NvdXJjZS9KYXZhU2NyaXB0Q29y ZS9KYXZhU2NyaXB0Q29yZS54Y29kZXByb2ovcHJvamVjdC5wYnhwcm9qCkBAIC02NDQxLDcgKzY0 NDEsNiBAQAogCQkJYnVpbGRQaGFzZXMgPSAoCiAJCQkJOTMyRjVCREMwODIyQTFDNzAwNzM2OTc1 IC8qIFNvdXJjZXMgKi8sCiAJCQkJOTMyRjVCREUwODIyQTFDNzAwNzM2OTc1IC8qIEZyYW1ld29y a3MgKi8sCi0JCQkJNUQ1RDhBQkYwRTBEMEIwMzAwRjlDNjkyIC8qIENyZWF0ZSAvdXNyL2xvY2Fs L2Jpbi9qc2Mgc3ltbGluayAqLywKIAkJCSk7CiAJCQlidWlsZFJ1bGVzID0gKAogCQkJKTsKQEAg LTY2NDgsMjIgKzY2NDcsNiBAQAogCQkJc2hlbGxQYXRoID0gL2Jpbi9zaDsKIAkJCXNoZWxsU2Ny aXB0ID0gInNldCAtZVxuXG5UUkFDSU5HX0Q9XCIkU1JDUk9PVC9ydW50aW1lL1RyYWNpbmcuZFwi O1xuVFJBQ0lOR19IPVwiJEJVSUxUX1BST0RVQ1RTX0RJUi9EZXJpdmVkU291cmNlcy9KYXZhU2Ny aXB0Q29yZS9UcmFjaW5nRHRyYWNlLmhcIjtcblxuaWYgW1sgXCIkSEFWRV9EVFJBQ0VcIiA9IFwi MVwiICYmIFwiJFRSQUNJTkdfRFwiIC1udCBcIiRUUkFDSU5HX0hcIiBdXTtcbnRoZW5cblx0ZHRy YWNlIC1oIC1vIFwiJFRSQUNJTkdfSFwiIC1zIFwiJFRSQUNJTkdfRFwiO1xuZmk7XG4iOwogCQl9 OwotCQk1RDVEOEFCRjBFMEQwQjAzMDBGOUM2OTIgLyogQ3JlYXRlIC91c3IvbG9jYWwvYmluL2pz YyBzeW1saW5rICovID0gewotCQkJaXNhID0gUEJYU2hlbGxTY3JpcHRCdWlsZFBoYXNlOwotCQkJ YnVpbGRBY3Rpb25NYXNrID0gMjE0NzQ4MzY0NzsKLQkJCWZpbGVzID0gKAotCQkJKTsKLQkJCWlu cHV0UGF0aHMgPSAoCi0JCQkJIiQoRFNUUk9PVCkkKElOU1RBTExfUEFUSCkvanNjIiwKLQkJCSk7 Ci0JCQluYW1lID0gIkNyZWF0ZSAvdXNyL2xvY2FsL2Jpbi9qc2Mgc3ltbGluayI7Ci0JCQlvdXRw dXRQYXRocyA9ICgKLQkJCQkiJChEU1RST09UKSQoSU5TVEFMTF9QQVRIX1BSRUZJWCkvdXNyL2xv Y2FsL2Jpbi9qc2MiLAotCQkJKTsKLQkJCXJ1bk9ubHlGb3JEZXBsb3ltZW50UG9zdHByb2Nlc3Np bmcgPSAwOwotCQkJc2hlbGxQYXRoID0gIi9iaW4vc2ggLXgiOwotCQkJc2hlbGxTY3JpcHQgPSAi aWYgW1sgXCIke1NLSVBfSU5TVEFMTH1cIiA9PSBcIk5PXCIgXV07IHRoZW5cbiAgICBta2RpciAt cCBcIiR7RFNUUk9PVH0ke0lOU1RBTExfUEFUSF9QUkVGSVh9L3Vzci9sb2NhbC9iaW5cIlxuICAg IGNkIFwiJHtEU1RST09UfSR7SU5TVEFMTF9QQVRIX1BSRUZJWH0vdXNyL2xvY2FsL2JpblwiXG4g ICAgaWYgWyAtTCBqc2MgXTsgdGhlblxuICAgICAgICBybSAtZiBqc2NcbiAgICBmaVxuICAgIGxu IC1zIFwiLi4vLi4vLi4ke0lOU1RBTExfUEFUSF9BQ1RVQUx9L2pzY1wiIGpzY1xuICAgIGV4aXRc bmZpXG4iOwotCQl9OwogCQk1REFGRDZDRDE0NkI2QjZFMDBGQkVGQjQgLyogSW5zdGFsbCBTdXBw b3J0IFNjcmlwdCAqLyA9IHsKIAkJCWlzYSA9IFBCWFNoZWxsU2NyaXB0QnVpbGRQaGFzZTsKIAkJ CWJ1aWxkQWN0aW9uTWFzayA9IDg7Cg== 229970 2014-04-23 03:10:29 -0700 2014-04-23 03:13:05 -0700 Patch bug-132053-20140423031007.patch text/plain 1990 mrowe U3VidmVyc2lvbiBSZXZpc2lvbjogMTY3Njc3CmRpZmYgLS1naXQgYS9Tb3VyY2UvSmF2YVNjcmlw dENvcmUvQ2hhbmdlTG9nIGIvU291cmNlL0phdmFTY3JpcHRDb3JlL0NoYW5nZUxvZwppbmRleCBl ZGQ5OTVlMjU1NDYyNGVhOGQwMzM4NzQ2MTg3NWRjMTI1MWQxMWZkLi4zOWU2YWUxMTU3NTU2ZWU5 OWM0OWQ1YzdkMGUwMTkyMGYyYjgyOTBhIDEwMDY0NAotLS0gYS9Tb3VyY2UvSmF2YVNjcmlwdENv cmUvQ2hhbmdlTG9nCisrKyBiL1NvdXJjZS9KYXZhU2NyaXB0Q29yZS9DaGFuZ2VMb2cKQEAgLTEs MyArMSwxNCBAQAorMjAxNC0wNC0yMyAgTWFyayBSb3dlICA8bXJvd2VAYXBwbGUuY29tPgorCisg ICAgICAgIFtNYWNdIFJFR1JFU1NJT04gKHIxNjQ4MjMpOiBCdWlsZGluZyBKYXZhU2NyaXB0Q29y ZSBjcmVhdGVzIGZpbGVzIHVuZGVyIC90bXAvSmF2YVNjcmlwdENvcmUuZHN0CisgICAgICAgIDxo dHRwczovL3dlYmtpdC5vcmcvYi8xMzIwNTM+CisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZ IChPT1BTISkuCisKKyAgICAgICAgKiBKYXZhU2NyaXB0Q29yZS54Y29kZXByb2ovcHJvamVjdC5w Ynhwcm9qOiBEb24ndCB0cnkgYW5kIGNyZWF0ZSBhIHN5bWxpbmsgYXQgL3Vzci9sb2NhbC9iaW4v anNjIGluc2lkZQorICAgICAgICB0aGUgRFNUUk9PVCB1bmxlc3Mgd2UncmUgYnVpbGRpbmcgaW4g dG8gdGhlIGRlcGxveW1lbnQgbG9jYXRpb24uIEFsc28gcmVtb3ZlIHRoZSB1bm5lY2Vzc2FyeSAt eCBhcmd1bWVudAorICAgICAgICBmcm9tIC9iaW4vc2ggc2luY2UgdGhhdCBsZWFkcyB0byB1bm5l Y2Vzc2FyeSBvdXRwdXQuCisKIDIwMTQtMDQtMjIgIEZpbGlwIFBpemxvICA8ZnBpemxvQGFwcGxl LmNvbT4KIAogICAgICAgICBTd2l0Y2ggdGhlIExMVk1Gb3JKU0MgdGFyZ2V0IHRvIHVzaW5nIHRo ZSBMTFZNIGluIC91c3IvbG9jYWwgcmF0aGVyIHRoYW4gL3Vzci9sb2NhbC9MTFZNRm9ySmF2YVNj cmlwdENvcmUgb24gaU9TCmRpZmYgLS1naXQgYS9Tb3VyY2UvSmF2YVNjcmlwdENvcmUvSmF2YVNj cmlwdENvcmUueGNvZGVwcm9qL3Byb2plY3QucGJ4cHJvaiBiL1NvdXJjZS9KYXZhU2NyaXB0Q29y ZS9KYXZhU2NyaXB0Q29yZS54Y29kZXByb2ovcHJvamVjdC5wYnhwcm9qCmluZGV4IDY4MmQyMjE5 NjIyNDFkMTI2OTAyNjEzYjUxNTFkN2NjNzFhMDMyMmEuLjZhMGRkYWVkMjMxYTA4ZDY5YTg3ZmM0 M2VlNmIwZGJkMTk2ODZkZTEgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9KYXZhU2NyaXB0Q29yZS9KYXZh U2NyaXB0Q29yZS54Y29kZXByb2ovcHJvamVjdC5wYnhwcm9qCisrKyBiL1NvdXJjZS9KYXZhU2Ny aXB0Q29yZS9KYXZhU2NyaXB0Q29yZS54Y29kZXByb2ovcHJvamVjdC5wYnhwcm9qCkBAIC02NjYw LDggKzY2NjAsOCBAQAogCQkJb3V0cHV0UGF0aHMgPSAoCiAJCQkJIiQoRFNUUk9PVCkkKElOU1RB TExfUEFUSF9QUkVGSVgpL3Vzci9sb2NhbC9iaW4vanNjIiwKIAkJCSk7Ci0JCQlydW5Pbmx5Rm9y RGVwbG95bWVudFBvc3Rwcm9jZXNzaW5nID0gMDsKLQkJCXNoZWxsUGF0aCA9ICIvYmluL3NoIC14 IjsKKwkJCXJ1bk9ubHlGb3JEZXBsb3ltZW50UG9zdHByb2Nlc3NpbmcgPSAxOworCQkJc2hlbGxQ YXRoID0gL2Jpbi9zaDsKIAkJCXNoZWxsU2NyaXB0ID0gImlmIFtbIFwiJHtTS0lQX0lOU1RBTEx9 XCIgPT0gXCJOT1wiIF1dOyB0aGVuXG4gICAgbWtkaXIgLXAgXCIke0RTVFJPT1R9JHtJTlNUQUxM X1BBVEhfUFJFRklYfS91c3IvbG9jYWwvYmluXCJcbiAgICBjZCBcIiR7RFNUUk9PVH0ke0lOU1RB TExfUEFUSF9QUkVGSVh9L3Vzci9sb2NhbC9iaW5cIlxuICAgIGlmIFsgLUwganNjIF07IHRoZW5c biAgICAgICAgcm0gLWYganNjXG4gICAgZmlcbiAgICBsbiAtcyBcIi4uLy4uLy4uJHtJTlNUQUxM X1BBVEhfQUNUVUFMfS9qc2NcIiBqc2NcbiAgICBleGl0XG5maVxuIjsKIAkJfTsKIAkJNURBRkQ2 Q0QxNDZCNkI2RTAwRkJFRkI0IC8qIEluc3RhbGwgU3VwcG9ydCBTY3JpcHQgKi8gPSB7Cg== 229971 2014-04-23 03:13:07 -0700 2014-04-23 07:40:13 -0700 Patch bug-132053-20140423031245.patch text/plain 1987 mrowe U3VidmVyc2lvbiBSZXZpc2lvbjogMTY3Njc3CmRpZmYgLS1naXQgYS9Tb3VyY2UvSmF2YVNjcmlw dENvcmUvQ2hhbmdlTG9nIGIvU291cmNlL0phdmFTY3JpcHRDb3JlL0NoYW5nZUxvZwppbmRleCBl ZGQ5OTVlMjU1NDYyNGVhOGQwMzM4NzQ2MTg3NWRjMTI1MWQxMWZkLi5lMTY5ZTRjNjJiNTFlNjg2 ZjMwZjliZjliNDA1NTRiZDQ2YjU4M2FhIDEwMDY0NAotLS0gYS9Tb3VyY2UvSmF2YVNjcmlwdENv cmUvQ2hhbmdlTG9nCisrKyBiL1NvdXJjZS9KYXZhU2NyaXB0Q29yZS9DaGFuZ2VMb2cKQEAgLTEs MyArMSwxNCBAQAorMjAxNC0wNC0yMyAgTWFyayBSb3dlICA8bXJvd2VAYXBwbGUuY29tPgorCisg ICAgICAgIFtNYWNdIFJFR1JFU1NJT04gKHIxNjQ4MjMpOiBCdWlsZGluZyBKYXZhU2NyaXB0Q29y ZSBjcmVhdGVzIGZpbGVzIHVuZGVyIC90bXAvSmF2YVNjcmlwdENvcmUuZHN0CisgICAgICAgIDxo dHRwczovL3dlYmtpdC5vcmcvYi8xMzIwNTM+CisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZ IChPT1BTISkuCisKKyAgICAgICAgKiBKYXZhU2NyaXB0Q29yZS54Y29kZXByb2ovcHJvamVjdC5w Ynhwcm9qOiBEb24ndCB0cnkgdG8gY3JlYXRlIGEgc3ltbGluayBhdCAvdXNyL2xvY2FsL2Jpbi9q c2MgaW5zaWRlCisgICAgICAgIHRoZSBEU1RST09UIHVubGVzcyB3ZSdyZSBidWlsZGluZyB0byB0 aGUgZGVwbG95bWVudCBsb2NhdGlvbi4gQWxzbyByZW1vdmUgdGhlIHVubmVjZXNzYXJ5IC14IGFy Z3VtZW50CisgICAgICAgIGZyb20gL2Jpbi9zaCBzaW5jZSB0aGF0IGdlbmVyYXRlcyB1bm5lY2Vz c2FyeSBvdXRwdXQuCisKIDIwMTQtMDQtMjIgIEZpbGlwIFBpemxvICA8ZnBpemxvQGFwcGxlLmNv bT4KIAogICAgICAgICBTd2l0Y2ggdGhlIExMVk1Gb3JKU0MgdGFyZ2V0IHRvIHVzaW5nIHRoZSBM TFZNIGluIC91c3IvbG9jYWwgcmF0aGVyIHRoYW4gL3Vzci9sb2NhbC9MTFZNRm9ySmF2YVNjcmlw dENvcmUgb24gaU9TCmRpZmYgLS1naXQgYS9Tb3VyY2UvSmF2YVNjcmlwdENvcmUvSmF2YVNjcmlw dENvcmUueGNvZGVwcm9qL3Byb2plY3QucGJ4cHJvaiBiL1NvdXJjZS9KYXZhU2NyaXB0Q29yZS9K YXZhU2NyaXB0Q29yZS54Y29kZXByb2ovcHJvamVjdC5wYnhwcm9qCmluZGV4IDY4MmQyMjE5NjIy NDFkMTI2OTAyNjEzYjUxNTFkN2NjNzFhMDMyMmEuLjZhMGRkYWVkMjMxYTA4ZDY5YTg3ZmM0M2Vl NmIwZGJkMTk2ODZkZTEgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9KYXZhU2NyaXB0Q29yZS9KYXZhU2Ny aXB0Q29yZS54Y29kZXByb2ovcHJvamVjdC5wYnhwcm9qCisrKyBiL1NvdXJjZS9KYXZhU2NyaXB0 Q29yZS9KYXZhU2NyaXB0Q29yZS54Y29kZXByb2ovcHJvamVjdC5wYnhwcm9qCkBAIC02NjYwLDgg KzY2NjAsOCBAQAogCQkJb3V0cHV0UGF0aHMgPSAoCiAJCQkJIiQoRFNUUk9PVCkkKElOU1RBTExf UEFUSF9QUkVGSVgpL3Vzci9sb2NhbC9iaW4vanNjIiwKIAkJCSk7Ci0JCQlydW5Pbmx5Rm9yRGVw bG95bWVudFBvc3Rwcm9jZXNzaW5nID0gMDsKLQkJCXNoZWxsUGF0aCA9ICIvYmluL3NoIC14IjsK KwkJCXJ1bk9ubHlGb3JEZXBsb3ltZW50UG9zdHByb2Nlc3NpbmcgPSAxOworCQkJc2hlbGxQYXRo ID0gL2Jpbi9zaDsKIAkJCXNoZWxsU2NyaXB0ID0gImlmIFtbIFwiJHtTS0lQX0lOU1RBTEx9XCIg PT0gXCJOT1wiIF1dOyB0aGVuXG4gICAgbWtkaXIgLXAgXCIke0RTVFJPT1R9JHtJTlNUQUxMX1BB VEhfUFJFRklYfS91c3IvbG9jYWwvYmluXCJcbiAgICBjZCBcIiR7RFNUUk9PVH0ke0lOU1RBTExf UEFUSF9QUkVGSVh9L3Vzci9sb2NhbC9iaW5cIlxuICAgIGlmIFsgLUwganNjIF07IHRoZW5cbiAg ICAgICAgcm0gLWYganNjXG4gICAgZmlcbiAgICBsbiAtcyBcIi4uLy4uLy4uJHtJTlNUQUxMX1BB VEhfQUNUVUFMfS9qc2NcIiBqc2NcbiAgICBleGl0XG5maVxuIjsKIAkJfTsKIAkJNURBRkQ2Q0Qx NDZCNkI2RTAwRkJFRkI0IC8qIEluc3RhbGwgU3VwcG9ydCBTY3JpcHQgKi8gPSB7Cg==