132051 2014-04-23 01:45:57 -0700 [GTK] run-webkit-tests script is failing to invoke run-launcher 2014-04-23 02:40:22 -0700 1 1 1 Unclassified WebKit WebKitGTK 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 1 ltilve ltilve andersca commit-queue glenn jhoneycutt mrobinson pnormand oldest_to_newest 1003227 0 ltilve 2014-04-23 01:45:57 -0700 When manually running a test like: Tools/Scripts/run-webkit-tests --gtk webaudio/codec-tests/mp3/128kbps-44khz.html As the --no-show-results parameter is not used, if there is some failing test, run-launcher is invoked to show the diffs, but this call seems to be failing due to be receiving a -2 parameter that is not longer supported. 0 tests ran as expected, 1 didn't: ScriptError raised: Failed to run "['Tools/Scripts/run-launcher', '--release', '--gtk', u'file:///home/ltilve/WebKit/WebKitBuild/Release/layout-test-results/results.html', '-2']" exit_code: 1 cwd: /home/ltilve/WebKit Traceback (most recent call last): File "/home/ltilve/WebKit/Tools/Scripts/webkitpy/layout_tests/run_webkit_tests.py", line 80, in main run_details = run(port, options, args, stderr) File "/home/ltilve/WebKit/Tools/Scripts/webkitpy/layout_tests/run_webkit_tests.py", line 401, in run run_details = manager.run(args) File "/home/ltilve/WebKit/Tools/Scripts/webkitpy/layout_tests/controllers/manager.py", line 242, in run self._port.show_results_html_file(results_path) File "/home/ltilve/WebKit/Tools/Scripts/webkitpy/port/gtk.py", line 191, in show_results_html_file self._run_script("run-launcher", run_launcher_args) File "/home/ltilve/WebKit/Tools/Scripts/webkitpy/port/base.py", line 1283, in _run_script output = self._executive.run_command(run_script_command, cwd=self.webkit_base(), decode_output=decode_output, env=env) File "/home/ltilve/WebKit/Tools/Scripts/webkitpy/common/system/executive.py", line 452, in run_command (error_handler or self.default_error_handler)(script_error) File "/home/ltilve/WebKit/Tools/Scripts/webkitpy/common/system/executive.py", line 370, in default_error_handler raise error ScriptError: Failed to run "['Tools/Scripts/run-launcher', '--release', '--gtk', u'file:///home/ltilve/WebKit/WebKitBuild/Release/layout-test-results/results.html', '-2']" exit_code: 1 cwd: /home/ltilve/WebKit 1003231 1 229966 ltilve 2014-04-23 02:00:27 -0700 Created attachment 229966 Patch 1003234 2 229966 commit-queue 2014-04-23 02:40:18 -0700 Comment on attachment 229966 Patch Clearing flags on attachment: 229966 Committed r167702: <http://trac.webkit.org/changeset/167702> 1003235 3 commit-queue 2014-04-23 02:40:22 -0700 All reviewed patches have been landed. Closing bug. 229966 2014-04-23 02:00:27 -0700 2014-04-23 02:40:18 -0700 Patch bug-132051-20140423110004.patch text/plain 1732 ltilve U3VidmVyc2lvbiBSZXZpc2lvbjogMTY3NzAxCmRpZmYgLS1naXQgYS9Ub29scy9DaGFuZ2VMb2cg Yi9Ub29scy9DaGFuZ2VMb2cKaW5kZXggMmJhYTJmZDllOWM5MDMyNzc0OTM1OWNjYzRiNDJiZmUy MDJhMjlmNy4uNzEwMmMxZDkyOTI0ZjA1NmUxYjVhMWI4N2UyZjBhYjY0N2Q2ZTJiYSAxMDA2NDQK LS0tIGEvVG9vbHMvQ2hhbmdlTG9nCisrKyBiL1Rvb2xzL0NoYW5nZUxvZwpAQCAtMSwzICsxLDE3 IEBACisyMDE0LTA0LTIzICBMb3JlbnpvIFRpbHZlICA8bHRpbHZlQGlnYWxpYS5jb20+CisKKyAg ICAgICAgW0dUS10gcnVuLXdlYmtpdC10ZXN0cyBzY3JpcHQgaXMgZmFpbGluZyB0byBpbnZva2Ug cnVuLWxhdW5jaGVyCisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNn aT9pZD0xMzIwNTEKKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAg ICAgICBBZnRlciB0aGUgV0sxIHN1cHBvcnQgd2FzIGRyb3BwZWQsIGlmIHJ1bi13ZWJraXQtdGVz dHMgaXMgZXhlY3V0ZWQKKyAgICAgICAgd2l0aG91dCAtLW5vLXNob3ctcmVzdWx0cyBwYXJhbWV0 ZXIsIHRoZSBsYXVuY2hlciBpcyBiZWluZyBjYWxsZWQKKyAgICAgICAgdXNpbmcgYSAtMiBwYXJh bWV0ZXIgdGhhdCBpcyBpdCBjYXVzaW5nIHRoZSBydW4tbGF1bmNoZXIgdG8gYnJlYWsuCisKKyAg ICAgICAgKiBTY3JpcHRzL3dlYmtpdHB5L3BvcnQvZ3RrLnB5OgorICAgICAgICAoR3RrUG9ydC5z aG93X3Jlc3VsdHNfaHRtbF9maWxlKToKKwogMjAxNC0wNC0yMiAgVGltIEhvcnRvbiAgPHRpbW90 aHlfaG9ydG9uQGFwcGxlLmNvbT4KIAogICAgICAgICBEdW1wUmVuZGVyVHJlZSBnZW5lcmF0ZXMg YmxhY2sgc25hcHNob3RzIG9uIHNvbWUgcGxhdGZvcm1zCmRpZmYgLS1naXQgYS9Ub29scy9TY3Jp cHRzL3dlYmtpdHB5L3BvcnQvZ3RrLnB5IGIvVG9vbHMvU2NyaXB0cy93ZWJraXRweS9wb3J0L2d0 ay5weQppbmRleCBjYmMxMDZmZWMwZDRlZjBkM2VkMDk2YzJkZDE1MmQ5YWRjYjU0OWU1Li5hZmEz MTljNjhhYWQ1MDdjODU5NTAxMTBkOGE0MTdlYTViNjJlZmIzIDEwMDY0NAotLS0gYS9Ub29scy9T Y3JpcHRzL3dlYmtpdHB5L3BvcnQvZ3RrLnB5CisrKyBiL1Rvb2xzL1NjcmlwdHMvd2Via2l0cHkv cG9ydC9ndGsucHkKQEAgLTE4NCw4ICsxODQsNiBAQCBjbGFzcyBHdGtQb3J0KFBvcnQpOgogICAg ICMgb3IgdGVhY2ggcnVuLWxhdW5jaGVyIGhvdyB0byBjYWxsIHJ1bi1zYWZhcmkgYW5kIG1vdmUg dGhpcyBkb3duIHRvIFBvcnQuCiAgICAgZGVmIHNob3dfcmVzdWx0c19odG1sX2ZpbGUoc2VsZiwg cmVzdWx0c19maWxlbmFtZSk6CiAgICAgICAgIHJ1bl9sYXVuY2hlcl9hcmdzID0gWyJmaWxlOi8v JXMiICUgcmVzdWx0c19maWxlbmFtZV0KLSAgICAgICAgaWYgc2VsZi5nZXRfb3B0aW9uKCd3ZWJr aXRfdGVzdF9ydW5uZXInKToKLSAgICAgICAgICAgIHJ1bl9sYXVuY2hlcl9hcmdzLmFwcGVuZCgn LTInKQogICAgICAgICAjIEZJWE1FOiBvbGQtcnVuLXdlYmtpdC10ZXN0cyBhbHNvIGFkZGVkIFsi LWdyYXBoaWNzc3lzdGVtIiwgInJhc3RlciIsICItc3R5bGUiLCAid2luZG93cyJdCiAgICAgICAg ICMgRklYTUU6IG9sZC1ydW4td2Via2l0LXRlc3RzIGNvbnZlcnRlZCByZXN1bHRzX2ZpbGVuYW1l IHBhdGggZm9yIGN5Z3dpbi4KICAgICAgICAgc2VsZi5fcnVuX3NjcmlwdCgicnVuLWxhdW5jaGVy IiwgcnVuX2xhdW5jaGVyX2FyZ3MpCg==