132044 2014-04-23 00:55:52 -0700 [GTK] Test TestWebKitAPI/WebKit2Gtk/TestInspectorServer fails 2014-10-21 00:32:34 -0700 1 1 1 Unclassified WebKit WebKit2 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED Gtk, Regression P2 Normal --- 1 cgarcia webkit-unassigned burg gyuyoung.kim pnormand timothy oldest_to_newest 1003214 0 cgarcia 2014-04-23 00:55:52 -0700 TEST: WebKitBuild/Release/bin/TestWebKitAPI/WebKit2Gtk/TestInspectorServer... (pid=30953) ** ERROR:../../Tools/TestWebKitAPI/Tests/WebKit2Gtk/TestInspectorServer.cpp:241:void openRemoteDebuggingSession(InspectorServerTest*, gconstpointer): assertion failed: (javascriptResult) GTester: last random seed: R02S76a375c7b7e9a9fb04f17fded1d0cf78 (pid=31125) FAIL: WebKitBuild/Release/bin/TestWebKitAPI/WebKit2Gtk/TestInspectorServer Tests failed (1): WebKitBuild/Release/bin/TestWebKitAPI/WebKit2Gtk/TestInspectorServer 1011945 1 pnormand 2014-05-27 06:22:26 -0700 I'm starting a patch. 1038855 2 cgarcia 2014-10-02 06:35:36 -0700 I think one of the problems is that in r164543 the order of the scripts in Main.html changed. One of the problems I see in the console is: ReferenceError: Can't find variable: InspectorFrontendHost That happens in Platform.js, because InspectorFrontendHostStub.js hasn't been loaded yet. With the local inspector doesn't happen because the InspectorFrontendHost is injected directly from the code on window object cleared. There might be more errors like this, I also see 'IndexedDB' domain was not found, not sure that was if fatal, though. 1041508 3 239787 cgarcia 2014-10-14 02:13:14 -0700 Created attachment 239787 Patch The inspector still doesn't work because of bug #137340, but reverting r174025 and applying this patch makes the remote inspector work again and the test to pass. 1042876 4 burg 2014-10-20 10:45:07 -0700 (In reply to comment #2) > I think one of the problems is that in r164543 the order of the scripts in > Main.html changed. One of the problems I see in the console is: > > ReferenceError: Can't find variable: InspectorFrontendHost > > That happens in Platform.js, because InspectorFrontendHostStub.js hasn't > been loaded yet. With the local inspector doesn't happen because the > InspectorFrontendHost is injected directly from the code on window object > cleared. There might be more errors like this, I also see 'IndexedDB' domain > was not found, not sure that was if fatal, though. It should be able to fail cleanly with no IndexedDB domain, since it's an optional feature. If the inspector or tests break with !ENABLE(INDEXED_DATABASE) please file a bug. 1043126 5 cgarcia 2014-10-21 00:32:34 -0700 Committed r174926: <http://trac.webkit.org/changeset/174926> 239787 2014-10-14 02:13:14 -0700 2014-10-20 10:43:17 -0700 Patch wk2-remote-inspector.diff text/plain 3377 cgarcia ZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJJbnNwZWN0b3JVSS9DaGFuZ2VMb2cgYi9Tb3VyY2UvV2Vi SW5zcGVjdG9yVUkvQ2hhbmdlTG9nCmluZGV4IDY5MzY2YjYuLmEzMWVkYjIgMTAwNjQ0Ci0tLSBh L1NvdXJjZS9XZWJJbnNwZWN0b3JVSS9DaGFuZ2VMb2cKKysrIGIvU291cmNlL1dlYkluc3BlY3Rv clVJL0NoYW5nZUxvZwpAQCAtMSwzICsxLDE2IEBACisyMDE0LTEwLTE0ICBDYXJsb3MgR2FyY2lh IENhbXBvcyAgPGNnYXJjaWFAaWdhbGlhLmNvbT4KKworICAgICAgICBbR1RLXSBUZXN0IFRlc3RX ZWJLaXRBUEkvV2ViS2l0Mkd0ay9UZXN0SW5zcGVjdG9yU2VydmVyIGZhaWxzCisgICAgICAgIGh0 dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0xMzIwNDQKKworICAgICAgICBS ZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICBNYWtlIHN1cmUgUHJvdG9jb2wv SW5zcGVjdG9yRnJvbnRlbmRIb3N0U3R1Yi5qcyBpcyBsb2FkZWQgYmVmb3JlCisgICAgICAgIEJh c2UvUGxhdGZvcm0uanMsIGJlY2F1c2UgUGxhdGZvcm0gdXNlcyB0aGUgSW5zcGVjdG9yRnJvbnRl bmRIb3N0CisgICAgICAgIG9iamVjdC4KKworICAgICAgICAqIFVzZXJJbnRlcmZhY2UvTWFpbi5o dG1sOgorCiAyMDE0LTEwLTEzICBKb3NlcGggUGVjb3Jhcm8gIDxwZWNvcmFyb0BhcHBsZS5jb20+ CiAKICAgICAgICAgV2ViIEluc3BlY3RvcjogUGFpbnQgRmxhc2hpbmcgYnV0dG9uIGRvZXMgbm90 IG1hdGNoIHBhZ2Ugc3RhdGUgYWZ0ZXIgcmVsb2FkCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViSW5z cGVjdG9yVUkvVXNlckludGVyZmFjZS9NYWluLmh0bWwgYi9Tb3VyY2UvV2ViSW5zcGVjdG9yVUkv VXNlckludGVyZmFjZS9NYWluLmh0bWwKaW5kZXggOWRiMjllNC4uMjYyZDU0YiAxMDA2NDQKLS0t IGEvU291cmNlL1dlYkluc3BlY3RvclVJL1VzZXJJbnRlcmZhY2UvTWFpbi5odG1sCisrKyBiL1Nv dXJjZS9XZWJJbnNwZWN0b3JVSS9Vc2VySW50ZXJmYWNlL01haW4uaHRtbApAQCAtMTYxLDYgKzE2 MSw3IEBACiAgICAgPHNjcmlwdCBzcmM9IkV4dGVybmFsL0NvZGVNaXJyb3IveG1sLmpzIj48L3Nj cmlwdD4KIAogICAgIDxzY3JpcHQgc3JjPSJCYXNlL1dlYkluc3BlY3Rvci5qcyI+PC9zY3JpcHQ+ CisgICAgPHNjcmlwdCBzcmM9IlByb3RvY29sL0luc3BlY3RvckZyb250ZW5kSG9zdFN0dWIuanMi Pjwvc2NyaXB0PgogICAgIDxzY3JpcHQgc3JjPSJCYXNlL1BsYXRmb3JtLmpzIj48L3NjcmlwdD4K ICAgICA8c2NyaXB0IHNyYz0iQmFzZS9PYmplY3QuanMiPjwvc2NyaXB0PgogCkBAIC0xODQsNyAr MTg1LDYgQEAKICAgICA8c2NyaXB0IHNyYz0iUHJvdG9jb2wvRGVidWdnZXJPYnNlcnZlci5qcyI+ PC9zY3JpcHQ+CiAgICAgPHNjcmlwdCBzcmM9IlByb3RvY29sL0luc3BlY3RvckJhY2tlbmQuanMi Pjwvc2NyaXB0PgogICAgIDxzY3JpcHQgc3JjPSJQcm90b2NvbC9JbnNwZWN0b3JGcm9udGVuZEFQ SS5qcyI+PC9zY3JpcHQ+Ci0gICAgPHNjcmlwdCBzcmM9IlByb3RvY29sL0luc3BlY3RvckZyb250 ZW5kSG9zdFN0dWIuanMiPjwvc2NyaXB0PgogICAgIDxzY3JpcHQgc3JjPSJQcm90b2NvbC9JbnNw ZWN0b3JPYnNlcnZlci5qcyI+PC9zY3JpcHQ+CiAgICAgPHNjcmlwdCBzcmM9IlByb3RvY29sL0xh eWVyVHJlZU9ic2VydmVyLmpzIj48L3NjcmlwdD4KICAgICA8c2NyaXB0IHNyYz0iUHJvdG9jb2wv TG9hZEluc3BlY3RvckJhY2tlbmRDb21tYW5kcy5qcyI+PC9zY3JpcHQ+CmRpZmYgLS1naXQgYS9U b29scy9DaGFuZ2VMb2cgYi9Ub29scy9DaGFuZ2VMb2cKaW5kZXggYjQ1ZjU5ZS4uNzU1OWIwYSAx MDA2NDQKLS0tIGEvVG9vbHMvQ2hhbmdlTG9nCisrKyBiL1Rvb2xzL0NoYW5nZUxvZwpAQCAtMSwz ICsxLDE1IEBACisyMDE0LTEwLTE0ICBDYXJsb3MgR2FyY2lhIENhbXBvcyAgPGNnYXJjaWFAaWdh bGlhLmNvbT4KKworICAgICAgICBbR1RLXSBUZXN0IFRlc3RXZWJLaXRBUEkvV2ViS2l0Mkd0ay9U ZXN0SW5zcGVjdG9yU2VydmVyIGZhaWxzCisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3Jn L3Nob3dfYnVnLmNnaT9pZD0xMzIwNDQKKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9P UFMhKS4KKworICAgICAgICAqIFRlc3RXZWJLaXRBUEkvVGVzdHMvV2ViS2l0Mkd0ay9UZXN0SW5z cGVjdG9yU2VydmVyLmNwcDoKKyAgICAgICAgKG9wZW5SZW1vdGVEZWJ1Z2dpbmdTZXNzaW9uKTog UmVtb3ZlIHRyYWlsaW5nIHNsYXNoIHdoZW4KKyAgICAgICAgY29uY2F0ZW5hdGluZyBiYXNlIGlu c3BlY3RvciBVUkwgd2l0aCB0aGUgcGFnZSwgYmVjYXVzZSB0aGUKKyAgICAgICAgaW5zcGVjdG9y IHJldHVybnMgdGhlIHJlbGF0aXZlIHBhdGhzIHdpdGggYSBsZWFkaW5nIHNsYXNoLgorCiAyMDE0 LTEwLTEzICBKZXIgTm9ibGUgIDxqZXIubm9ibGVAYXBwbGUuY29tPgogCiAgICAgICAgIE1lZGlh UGxheWVyOjpjaGFyYWN0ZXJpc3RpY0NoYW5nZWQoKSBpcyBub3QgY2FsbGVkIHdoZW4gbmV3IHRy YWNrcyBhcmUgZm91bmQgaW4gU291cmNlQnVmZmVyUHJpdmF0ZUFWRk9iakMKZGlmZiAtLWdpdCBh L1Rvb2xzL1Rlc3RXZWJLaXRBUEkvVGVzdHMvV2ViS2l0Mkd0ay9UZXN0SW5zcGVjdG9yU2VydmVy LmNwcCBiL1Rvb2xzL1Rlc3RXZWJLaXRBUEkvVGVzdHMvV2ViS2l0Mkd0ay9UZXN0SW5zcGVjdG9y U2VydmVyLmNwcAppbmRleCAyNTIxZDJlLi41OGZlZmVhIDEwMDY0NAotLS0gYS9Ub29scy9UZXN0 V2ViS2l0QVBJL1Rlc3RzL1dlYktpdDJHdGsvVGVzdEluc3BlY3RvclNlcnZlci5jcHAKKysrIGIv VG9vbHMvVGVzdFdlYktpdEFQSS9UZXN0cy9XZWJLaXQyR3RrL1Rlc3RJbnNwZWN0b3JTZXJ2ZXIu Y3BwCkBAIC0yMzMsNyArMjMzLDcgQEAgc3RhdGljIHZvaWQgb3BlblJlbW90ZURlYnVnZ2luZ1Nl c3Npb24oSW5zcGVjdG9yU2VydmVyVGVzdCogdGVzdCwgZ2NvbnN0cG9pbnRlcikKICAgICBnX2Fz c2VydChqYXZhc2NyaXB0UmVzdWx0KTsKICAgICBnX2Fzc2VydCghZXJyb3IuZ2V0KCkpOwogCi0g ICAgU3RyaW5nIHJlc29sdmVkVVJMID0gU3RyaW5nKCJodHRwOi8vMTI3LjAuMC4xOjI5OTkvIikg KyBTdHJpbmc6OmZyb21VVEY4KFdlYlZpZXdUZXN0OjpqYXZhc2NyaXB0UmVzdWx0VG9DU3RyaW5n KGphdmFzY3JpcHRSZXN1bHQpKTsKKyAgICBTdHJpbmcgcmVzb2x2ZWRVUkwgPSBTdHJpbmcoImh0 dHA6Ly8xMjcuMC4wLjE6Mjk5OSIpICsgU3RyaW5nOjpmcm9tVVRGOChXZWJWaWV3VGVzdDo6amF2 YXNjcmlwdFJlc3VsdFRvQ1N0cmluZyhqYXZhc2NyaXB0UmVzdWx0KSk7CiAgICAgdGVzdC0+bG9h ZFVSSShyZXNvbHZlZFVSTC51dGY4KCkuZGF0YSgpKTsKICAgICB0ZXN0LT53YWl0VW50aWxMb2Fk RmluaXNoZWQoKTsKIAo=