132040 2014-04-22 22:35:13 -0700 Support encoding/decoding NSUInteger arguments in WKRemoteObjectCoder. 2014-04-23 12:39:12 -0700 1 1 1 Unclassified WebKit WebKit2 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 1 yongjun_zhang webkit-unassigned commit-queue oldest_to_newest 1003188 0 yongjun_zhang 2014-04-22 22:35:13 -0700 It would be nice to support NSUInteger argument type for remote invocations. 1003191 1 229958 yongjun_zhang 2014-04-22 22:46:04 -0700 Created attachment 229958 Patch. 1003192 2 commit-queue 2014-04-22 22:48:25 -0700 Attachment 229958 did not pass style-queue: ERROR: Source/WebKit2/Shared/API/Cocoa/WKRemoteObjectCoder.mm:179: More than one command on the same line [whitespace/newline] [4] Total errors found: 1 in 2 files If any of these errors are false positives, please file a bug against check-webkit-style. 1003197 3 229959 yongjun_zhang 2014-04-22 22:54:07 -0700 Created attachment 229959 Fix a style issue. 1003349 4 229959 commit-queue 2014-04-23 12:39:09 -0700 Comment on attachment 229959 Fix a style issue. Clearing flags on attachment: 229959 Committed r167719: <http://trac.webkit.org/changeset/167719> 1003350 5 commit-queue 2014-04-23 12:39:12 -0700 All reviewed patches have been landed. Closing bug. 229958 2014-04-22 22:46:04 -0700 2014-04-22 22:53:39 -0700 Patch. nsuinteger.patch text/plain 2449 yongjun_zhang Y29tbWl0IGMwOWU3MjNlMTJkYTFhZjFjZTUzNWJiNjU2OGFmMjRkZWJhMmI3MGIKQXV0aG9yOiBZ b25nanVuIFpoYW5nIDx5b25nanVuX3poYW5nQGFwcGxlLmNvbT4KRGF0ZTogICBUdWUgQXByIDIy IDIyOjQwOjM3IDIwMTQgLTA3MDAKCiAgICBTdXBwb3J0IGVuY29kaW5nL2RlY29kaW5nIE5TVUlu dGVnZXIgYXJndW1lbnRzIGluIFdLUmVtb3RlT2JqZWN0Q29kZXIuCiAgICBodHRwczovL2J1Z3Mu d2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MTMyMDQwCiAgICAKICAgIEFkZCBzdXBwb3J0IGZv ciBlbmNvZGluZy9kZWNvZGluZyBOU1VJbnRlZ2VyIGFyZ3VtZW50cy4KICAgIAogICAgKiBTaGFy ZWQvQVBJL0NvY29hL1dLUmVtb3RlT2JqZWN0Q29kZXIubW06CiAgICAoZW5jb2RlSW52b2NhdGlv bik6CiAgICAoZGVjb2RlSW52b2NhdGlvbkFyZ3VtZW50cyk6CgpkaWZmIC0tZ2l0IGEvU291cmNl L1dlYktpdDIvQ2hhbmdlTG9nIGIvU291cmNlL1dlYktpdDIvQ2hhbmdlTG9nCmluZGV4IGY2N2Vh OTcuLjYwZmY0YjcgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJLaXQyL0NoYW5nZUxvZworKysgYi9T b3VyY2UvV2ViS2l0Mi9DaGFuZ2VMb2cKQEAgLTEsNSArMSwxOCBAQAogMjAxNC0wNC0yMiAgWW9u Z2p1biBaaGFuZyAgPHlvbmdqdW5femhhbmdAYXBwbGUuY29tPgogCisgICAgICAgIFN1cHBvcnQg ZW5jb2RpbmcvZGVjb2RpbmcgTlNVSW50ZWdlciBhcmd1bWVudHMgaW4gV0tSZW1vdGVPYmplY3RD b2Rlci4KKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTEz MjA0MAorCisgICAgICAgIEFkZCBzdXBwb3J0IGZvciBlbmNvZGluZy9kZWNvZGluZyBOU1VJbnRl Z2VyIGFyZ3VtZW50cy4KKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKwor ICAgICAgICAqIFNoYXJlZC9BUEkvQ29jb2EvV0tSZW1vdGVPYmplY3RDb2Rlci5tbToKKyAgICAg ICAgKGVuY29kZUludm9jYXRpb24pOgorICAgICAgICAoZGVjb2RlSW52b2NhdGlvbkFyZ3VtZW50 cyk6CisKKzIwMTQtMDQtMjIgIFlvbmdqdW4gWmhhbmcgIDx5b25nanVuX3poYW5nQGFwcGxlLmNv bT4KKwogICAgICAgICBBZGQgU1BJIHRvIGV4cG9zZSBwcm92aXNpb25hbCBVUkwgZnJvbSBGcmFt ZS4KICAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTEzMjAx NAogCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViS2l0Mi9TaGFyZWQvQVBJL0NvY29hL1dLUmVtb3Rl T2JqZWN0Q29kZXIubW0gYi9Tb3VyY2UvV2ViS2l0Mi9TaGFyZWQvQVBJL0NvY29hL1dLUmVtb3Rl T2JqZWN0Q29kZXIubW0KaW5kZXggZTU0M2JkYi4uMDAyMjY0ZSAxMDA2NDQKLS0tIGEvU291cmNl L1dlYktpdDIvU2hhcmVkL0FQSS9Db2NvYS9XS1JlbW90ZU9iamVjdENvZGVyLm1tCisrKyBiL1Nv dXJjZS9XZWJLaXQyL1NoYXJlZC9BUEkvQ29jb2EvV0tSZW1vdGVPYmplY3RDb2Rlci5tbQpAQCAt MTczLDYgKzE3MywxNSBAQCBzdGF0aWMgdm9pZCBlbmNvZGVJbnZvY2F0aW9uKFdLUmVtb3RlT2Jq ZWN0RW5jb2RlciAqZW5jb2RlciwgTlNJbnZvY2F0aW9uICppbnZvYwogICAgICAgICAgICAgYnJl YWs7CiAgICAgICAgIH0KIAorICAgICAgICAvLyBOU1VJbnRlZ2VyCisgICAgICAgIGNhc2UgJ1En OiB7CisgICAgICAgICAgICBOU1VJbnRlZ2VyIHZhbHVlOworICAgICAgICAgICAgW2ludm9jYXRp b24gZ2V0QXJndW1lbnQ6JnZhbHVlIGF0SW5kZXg6aV07OworCisgICAgICAgICAgICBlbmNvZGVU b09iamVjdFN0cmVhbShlbmNvZGVyLCBAKHZhbHVlKSk7CisgICAgICAgICAgICBicmVhazsKKyAg ICAgICAgfQorCiAgICAgICAgIC8vIE9iamVjdGl2ZS1DIG9iamVjdAogICAgICAgICBjYXNlICdA JzogewogICAgICAgICAgICAgaWQgdmFsdWU7CkBAIC00MzMsNiArNDQyLDEzIEBAIHN0YXRpYyB2 b2lkIGRlY29kZUludm9jYXRpb25Bcmd1bWVudHMoV0tSZW1vdGVPYmplY3REZWNvZGVyICpkZWNv ZGVyLCBOU0ludm9jYXRpCiAgICAgICAgICAgICBicmVhazsKICAgICAgICAgfQogCisgICAgICAg IC8vIE5TVUludGVnZXIKKyAgICAgICAgY2FzZSAnUSc6IHsKKyAgICAgICAgICAgIE5TVUludGVn ZXIgdmFsdWUgPSBbZGVjb2RlT2JqZWN0RnJvbU9iamVjdFN0cmVhbShkZWNvZGVyLCBbTlNTZXQg c2V0V2l0aE9iamVjdDpbTlNOdW1iZXIgY2xhc3NdXSkgdW5zaWduZWRJbnRlZ2VyVmFsdWVdOwor ICAgICAgICAgICAgW2ludm9jYXRpb24gc2V0QXJndW1lbnQ6JnZhbHVlIGF0SW5kZXg6aV07Cisg ICAgICAgICAgICBicmVhazsKKyAgICAgICAgfQorICAgICAgICAgICAgCiAgICAgICAgIC8vIE9i amVjdGl2ZS1DIG9iamVjdAogICAgICAgICBjYXNlICdAJzogewogICAgICAgICAgICAgTlNTZXQg KmFsbG93ZWRDbGFzc2VzID0gYWxsb3dlZEFyZ3VtZW50Q2xhc3Nlc1tpIC0gMl0uZ2V0KCk7Cg== 229959 2014-04-22 22:54:07 -0700 2014-04-23 12:39:09 -0700 Fix a style issue. nsuinteger.patch text/plain 2955 yongjun_zhang Y29tbWl0IDNiMTY3OTcyYWQ1YzVmMjg3MWU3Nzg0NzYwNGJmZDhlOTg1NWI3NzMKQXV0aG9yOiBZ b25nanVuIFpoYW5nIDx5b25nanVuX3poYW5nQGFwcGxlLmNvbT4KRGF0ZTogICBUdWUgQXByIDIy IDIyOjQwOjM3IDIwMTQgLTA3MDAKCiAgICBTdXBwb3J0IGVuY29kaW5nL2RlY29kaW5nIE5TVUlu dGVnZXIgYXJndW1lbnRzIGluIFdLUmVtb3RlT2JqZWN0Q29kZXIuCiAgICBodHRwczovL2J1Z3Mu d2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MTMyMDQwCiAgICAKICAgIEFkZCBzdXBwb3J0IGZv ciBlbmNvZGluZy9kZWNvZGluZyBOU1VJbnRlZ2VyIGFyZ3VtZW50cy4KICAgIAogICAgKiBTaGFy ZWQvQVBJL0NvY29hL1dLUmVtb3RlT2JqZWN0Q29kZXIubW06CiAgICAoZW5jb2RlSW52b2NhdGlv bik6CiAgICAoZGVjb2RlSW52b2NhdGlvbkFyZ3VtZW50cyk6CgpkaWZmIC0tZ2l0IGEvU291cmNl L1dlYktpdDIvQ2hhbmdlTG9nIGIvU291cmNlL1dlYktpdDIvQ2hhbmdlTG9nCmluZGV4IGY2N2Vh OTcuLjYwZmY0YjcgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJLaXQyL0NoYW5nZUxvZworKysgYi9T b3VyY2UvV2ViS2l0Mi9DaGFuZ2VMb2cKQEAgLTEsNSArMSwxOCBAQAogMjAxNC0wNC0yMiAgWW9u Z2p1biBaaGFuZyAgPHlvbmdqdW5femhhbmdAYXBwbGUuY29tPgogCisgICAgICAgIFN1cHBvcnQg ZW5jb2RpbmcvZGVjb2RpbmcgTlNVSW50ZWdlciBhcmd1bWVudHMgaW4gV0tSZW1vdGVPYmplY3RD b2Rlci4KKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTEz MjA0MAorCisgICAgICAgIEFkZCBzdXBwb3J0IGZvciBlbmNvZGluZy9kZWNvZGluZyBOU1VJbnRl Z2VyIGFyZ3VtZW50cy4KKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKwor ICAgICAgICAqIFNoYXJlZC9BUEkvQ29jb2EvV0tSZW1vdGVPYmplY3RDb2Rlci5tbToKKyAgICAg ICAgKGVuY29kZUludm9jYXRpb24pOgorICAgICAgICAoZGVjb2RlSW52b2NhdGlvbkFyZ3VtZW50 cyk6CisKKzIwMTQtMDQtMjIgIFlvbmdqdW4gWmhhbmcgIDx5b25nanVuX3poYW5nQGFwcGxlLmNv bT4KKwogICAgICAgICBBZGQgU1BJIHRvIGV4cG9zZSBwcm92aXNpb25hbCBVUkwgZnJvbSBGcmFt ZS4KICAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTEzMjAx NAogCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViS2l0Mi9TaGFyZWQvQVBJL0NvY29hL1dLUmVtb3Rl T2JqZWN0Q29kZXIubW0gYi9Tb3VyY2UvV2ViS2l0Mi9TaGFyZWQvQVBJL0NvY29hL1dLUmVtb3Rl T2JqZWN0Q29kZXIubW0KaW5kZXggZTU0M2JkYi4uMWIzZGI2ZCAxMDA2NDQKLS0tIGEvU291cmNl L1dlYktpdDIvU2hhcmVkL0FQSS9Db2NvYS9XS1JlbW90ZU9iamVjdENvZGVyLm1tCisrKyBiL1Nv dXJjZS9XZWJLaXQyL1NoYXJlZC9BUEkvQ29jb2EvV0tSZW1vdGVPYmplY3RDb2Rlci5tbQpAQCAt MTU4LDcgKzE1OCw3IEBAIHN0YXRpYyB2b2lkIGVuY29kZUludm9jYXRpb24oV0tSZW1vdGVPYmpl Y3RFbmNvZGVyICplbmNvZGVyLCBOU0ludm9jYXRpb24gKmludm9jCiAgICAgICAgIC8vIGJvb2wK ICAgICAgICAgY2FzZSAnQic6IHsKICAgICAgICAgICAgIEJPT0wgdmFsdWU7Ci0gICAgICAgICAg ICBbaW52b2NhdGlvbiBnZXRBcmd1bWVudDomdmFsdWUgYXRJbmRleDppXTs7CisgICAgICAgICAg ICBbaW52b2NhdGlvbiBnZXRBcmd1bWVudDomdmFsdWUgYXRJbmRleDppXTsKIAogICAgICAgICAg ICAgZW5jb2RlVG9PYmplY3RTdHJlYW0oZW5jb2RlciwgQCh2YWx1ZSkpOwogICAgICAgICAgICAg YnJlYWs7CkBAIC0xNjcsNyArMTY3LDE2IEBAIHN0YXRpYyB2b2lkIGVuY29kZUludm9jYXRpb24o V0tSZW1vdGVPYmplY3RFbmNvZGVyICplbmNvZGVyLCBOU0ludm9jYXRpb24gKmludm9jCiAgICAg ICAgIC8vIE5TSW50ZWdlcgogICAgICAgICBjYXNlICdxJzogewogICAgICAgICAgICAgTlNJbnRl Z2VyIHZhbHVlOwotICAgICAgICAgICAgW2ludm9jYXRpb24gZ2V0QXJndW1lbnQ6JnZhbHVlIGF0 SW5kZXg6aV07OworICAgICAgICAgICAgW2ludm9jYXRpb24gZ2V0QXJndW1lbnQ6JnZhbHVlIGF0 SW5kZXg6aV07CisKKyAgICAgICAgICAgIGVuY29kZVRvT2JqZWN0U3RyZWFtKGVuY29kZXIsIEAo dmFsdWUpKTsKKyAgICAgICAgICAgIGJyZWFrOworICAgICAgICB9CisKKyAgICAgICAgLy8gTlNV SW50ZWdlcgorICAgICAgICBjYXNlICdRJzogeworICAgICAgICAgICAgTlNVSW50ZWdlciB2YWx1 ZTsKKyAgICAgICAgICAgIFtpbnZvY2F0aW9uIGdldEFyZ3VtZW50OiZ2YWx1ZSBhdEluZGV4Omld OwogCiAgICAgICAgICAgICBlbmNvZGVUb09iamVjdFN0cmVhbShlbmNvZGVyLCBAKHZhbHVlKSk7 CiAgICAgICAgICAgICBicmVhazsKQEAgLTQzMyw2ICs0NDIsMTMgQEAgc3RhdGljIHZvaWQgZGVj b2RlSW52b2NhdGlvbkFyZ3VtZW50cyhXS1JlbW90ZU9iamVjdERlY29kZXIgKmRlY29kZXIsIE5T SW52b2NhdGkKICAgICAgICAgICAgIGJyZWFrOwogICAgICAgICB9CiAKKyAgICAgICAgLy8gTlNV SW50ZWdlcgorICAgICAgICBjYXNlICdRJzogeworICAgICAgICAgICAgTlNVSW50ZWdlciB2YWx1 ZSA9IFtkZWNvZGVPYmplY3RGcm9tT2JqZWN0U3RyZWFtKGRlY29kZXIsIFtOU1NldCBzZXRXaXRo T2JqZWN0OltOU051bWJlciBjbGFzc11dKSB1bnNpZ25lZEludGVnZXJWYWx1ZV07CisgICAgICAg ICAgICBbaW52b2NhdGlvbiBzZXRBcmd1bWVudDomdmFsdWUgYXRJbmRleDppXTsKKyAgICAgICAg ICAgIGJyZWFrOworICAgICAgICB9CisgICAgICAgICAgICAKICAgICAgICAgLy8gT2JqZWN0aXZl LUMgb2JqZWN0CiAgICAgICAgIGNhc2UgJ0AnOiB7CiAgICAgICAgICAgICBOU1NldCAqYWxsb3dl ZENsYXNzZXMgPSBhbGxvd2VkQXJndW1lbnRDbGFzc2VzW2kgLSAyXS5nZXQoKTsK