132039 2014-04-22 22:02:22 -0700 [EFL][WK1] There are many failures in fast/forms since r163033 2014-04-22 22:34:45 -0700 1 1 1 Unclassified WebKit WebKit EFL 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 1 ryuan.choi ryuan.choi bunhere cdumez commit-queue gyuyoung.kim lucas.de.marchi sergio oldest_to_newest 1003180 0 ryuan.choi 2014-04-22 22:02:22 -0700 SSIA 1003181 1 229954 ryuan.choi 2014-04-22 22:05:02 -0700 Created attachment 229954 Patch 1003183 2 229954 gyuyoung.kim 2014-04-22 22:12:05 -0700 Comment on attachment 229954 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=229954&action=review LGTM > Source/WebKit/efl/ewk/ewk_view.cpp:3686 > + break; Additionally, I think we need to add ASSERT_NOT_REACHED() when user passes unsupported type. default: ASSERT_NOT_REACHED(); break; 1003186 3 ryuan.choi 2014-04-22 22:29:10 -0700 Committed r167697: <http://trac.webkit.org/changeset/167697> 1003187 4 229954 ryuan.choi 2014-04-22 22:34:45 -0700 Comment on attachment 229954 Patch clearing flags. landed with gyuyoung's suggestion 229954 2014-04-22 22:05:02 -0700 2014-04-22 22:34:45 -0700 Patch bug-132039-20140423140439.patch text/plain 1995 ryuan.choi U3VidmVyc2lvbiBSZXZpc2lvbjogMTY3NjkxCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViS2l0L2Vm bC9DaGFuZ2VMb2cgYi9Tb3VyY2UvV2ViS2l0L2VmbC9DaGFuZ2VMb2cKaW5kZXggNTQ1Zjk5ODIw ODQ2MDI5MDUxZTZlMzJkMjhmZTE4ZWY1ZWVmNzMwMC4uYjQyMzg5OTQxNWEzNjA0YmRjMmY3NDZh YTJjMDBkYzdlZGU5ZmE5NSAxMDA2NDQKLS0tIGEvU291cmNlL1dlYktpdC9lZmwvQ2hhbmdlTG9n CisrKyBiL1NvdXJjZS9XZWJLaXQvZWZsL0NoYW5nZUxvZwpAQCAtMSw1ICsxLDE1IEBACiAyMDE0 LTA0LTIyICBSeXVhbiBDaG9pICA8cnl1YW4uY2hvaUBzYW1zdW5nLmNvbT4KIAorICAgICAgICBb RUZMXVtXSzFdIFRoZXJlIGFyZSBtYW55IGZhaWx1cmVzIGluIGZhc3QvZm9ybXMgc2luY2UgcjE2 MzAzMworICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MTMy MDM5CisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgKiBl d2svZXdrX3ZpZXcuY3BwOiBBZGRlZCBicmVhayBzdGF0ZW1lbnRzIHdoaWNoIGlzIG1pc3Npbmcg d2hpbGUgcmVtb3ZlIENPTVBJTEVfQVNTRVJUX01BVENISU5HX0VOVU0KKyAgICAgICAgKGV3a192 aWV3X25hdmlnYXRpb25fcG9saWN5X2RlY2lzaW9uKToKKworMjAxNC0wNC0yMiAgUnl1YW4gQ2hv aSAgPHJ5dWFuLmNob2lAc2Ftc3VuZy5jb20+CisKICAgICAgICAgW0VGTF1bV0sxXSBUaGVyZSBh cmUgbWFueSB3YXJuaW5ncyBpbiBsYXlvdXQgdGVzdCBzaW5jZSByMTY3NDI4CiAgICAgICAgIGh0 dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0xMzE5ODUKIApkaWZmIC0tZ2l0 IGEvU291cmNlL1dlYktpdC9lZmwvZXdrL2V3a192aWV3LmNwcCBiL1NvdXJjZS9XZWJLaXQvZWZs L2V3ay9ld2tfdmlldy5jcHAKaW5kZXggN2M2MWZmMWM4M2FhNGViZjk3MjJlMzM4ZDQyOGRiMTg1 MjY2ZjA3ZC4uZGI4ZDE0MTZiNTIzNjQzMDIwZGM4YjE1Y2Y1ZGUyODdkMGViYTU0YyAxMDA2NDQK LS0tIGEvU291cmNlL1dlYktpdC9lZmwvZXdrL2V3a192aWV3LmNwcAorKysgYi9Tb3VyY2UvV2Vi S2l0L2VmbC9ld2svZXdrX3ZpZXcuY3BwCkBAIC0zNjY4LDE2ICszNjY4LDIyIEBAIGJvb2wgZXdr X3ZpZXdfbmF2aWdhdGlvbl9wb2xpY3lfZGVjaXNpb24oRXZhc19PYmplY3QqIGV3a1ZpZXcsIEV3 a19GcmFtZV9SZXNvdXJjCiAgICAgc3dpdGNoIChuYXZpZ2F0aW9uVHlwZSkgewogICAgIGNhc2Ug V2ViQ29yZTo6TmF2aWdhdGlvblR5cGVMaW5rQ2xpY2tlZDoKICAgICAgICAgdHlwZSA9IEVXS19O QVZJR0FUSU9OX1RZUEVfTElOS19DTElDS0VEOworICAgICAgICBicmVhazsKICAgICBjYXNlIFdl YkNvcmU6Ok5hdmlnYXRpb25UeXBlRm9ybVN1Ym1pdHRlZDoKICAgICAgICAgdHlwZSA9IEVXS19O QVZJR0FUSU9OX1RZUEVfRk9STV9TVUJNSVRURUQ7CisgICAgICAgIGJyZWFrOwogICAgIGNhc2Ug V2ViQ29yZTo6TmF2aWdhdGlvblR5cGVCYWNrRm9yd2FyZDoKICAgICAgICAgdHlwZSA9IEVXS19O QVZJR0FUSU9OX1RZUEVfQkFDS19GT1JXQVJEOworICAgICAgICBicmVhazsKICAgICBjYXNlIFdl YkNvcmU6Ok5hdmlnYXRpb25UeXBlUmVsb2FkOgogICAgICAgICB0eXBlID0gRVdLX05BVklHQVRJ T05fVFlQRV9SRUxPQUQ7CisgICAgICAgIGJyZWFrOwogICAgIGNhc2UgV2ViQ29yZTo6TmF2aWdh dGlvblR5cGVGb3JtUmVzdWJtaXR0ZWQ6CiAgICAgICAgIHR5cGUgPSBFV0tfTkFWSUdBVElPTl9U WVBFX0ZPUk1fUkVTVUJNSVRURUQ7CisgICAgICAgIGJyZWFrOwogICAgIGNhc2UgV2ViQ29yZTo6 TmF2aWdhdGlvblR5cGVPdGhlcjoKICAgICAgICAgdHlwZSA9IEVXS19OQVZJR0FUSU9OX1RZUEVf T1RIRVI7CisgICAgICAgIGJyZWFrOwogICAgIH0KIAogICAgIHJldHVybiBzbWFydERhdGEtPmFw aS0+bmF2aWdhdGlvbl9wb2xpY3lfZGVjaXNpb24oc21hcnREYXRhLCByZXF1ZXN0LCB0eXBlKTsK