132034 2014-04-22 18:33:46 -0700 ASSERTION FAILED: scrollerImp == scrollbarPainterForScrollbar(_scrollbar) on two API tests 2014-04-22 18:38:20 -0700 1 1 1 Unclassified WebKit WebCore Misc. 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED InRadar P2 Normal --- 1 thorton thorton ap bdakin simon.fraser oldest_to_newest 1003144 0 thorton 2014-04-22 18:33:46 -0700 scrollerImpWithStyle:controlSize:horizontal:replacingScrollerImp: moves the delegate from the old scrollerImp to the new one, and also happens to call shouldUseLayerPerPartForScrollerImp. Since scrollerImpWithStyle: has not returned yet, the scrollbarPainterForScrollbar still returns the old scrollerImp, so this assertion fires. It's safe to remove this because supportsUpdateOnSecondaryThread doesn't make use of the imp. <rdar://problem/16624332> 1003145 1 229937 thorton 2014-04-22 18:34:50 -0700 Created attachment 229937 patch 1003148 2 thorton 2014-04-22 18:38:20 -0700 http://trac.webkit.org/changeset/167693 229937 2014-04-22 18:34:50 -0700 2014-04-22 18:36:31 -0700 patch scroll.diff text/plain 1805 thorton ZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJDb3JlL0NoYW5nZUxvZyBiL1NvdXJjZS9XZWJDb3JlL0No YW5nZUxvZwppbmRleCA3YWFjMzg3Li5lN2YwOThmIDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViQ29y ZS9DaGFuZ2VMb2cKKysrIGIvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMTgg QEAKKzIwMTQtMDQtMjIgIFRpbSBIb3J0b24gIDx0aW1vdGh5X2hvcnRvbkBhcHBsZS5jb20+CisK KyAgICAgICAgQVNTRVJUSU9OIEZBSUxFRDogc2Nyb2xsZXJJbXAgPT0gc2Nyb2xsYmFyUGFpbnRl ckZvclNjcm9sbGJhcihfc2Nyb2xsYmFyKSBvbiB0d28gQVBJIHRlc3RzCisgICAgICAgIGh0dHBz Oi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0xMzIwMzQKKyAgICAgICAgPHJkYXI6 Ly9wcm9ibGVtLzE2NjI0MzMyPgorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEp LgorCisgICAgICAgICogcGxhdGZvcm0vbWFjL1Njcm9sbEFuaW1hdG9yTWFjLm1tOgorICAgICAg ICAoLVtXZWJTY3JvbGxiYXJQYWludGVyRGVsZWdhdGUgc2hvdWxkVXNlTGF5ZXJQZXJQYXJ0Rm9y U2Nyb2xsZXJJbXA6XSk6CisgICAgICAgIHNjcm9sbGVySW1wV2l0aFN0eWxlOmNvbnRyb2xTaXpl Omhvcml6b250YWw6cmVwbGFjaW5nU2Nyb2xsZXJJbXA6IG1vdmVzIHRoZSBkZWxlZ2F0ZQorICAg ICAgICBmcm9tIHRoZSBvbGQgc2Nyb2xsZXJJbXAgdG8gdGhlIG5ldyBvbmUsIGFuZCBhbHNvIGhh cHBlbnMgdG8gY2FsbCBzaG91bGRVc2VMYXllclBlclBhcnRGb3JTY3JvbGxlckltcC4KKyAgICAg ICAgU2luY2Ugc2Nyb2xsZXJJbXBXaXRoU3R5bGU6IGhhcyBub3QgcmV0dXJuZWQgeWV0LCB0aGUg c2Nyb2xsYmFyUGFpbnRlckZvclNjcm9sbGJhciBzdGlsbCByZXR1cm5zIHRoZSBvbGQgc2Nyb2xs ZXJJbXAsCisgICAgICAgIHNvIHRoaXMgYXNzZXJ0aW9uIGZpcmVzLiBJdCdzIHNhZmUgdG8gcmVt b3ZlIHRoaXMgYmVjYXVzZSBzdXBwb3J0c1VwZGF0ZU9uU2Vjb25kYXJ5VGhyZWFkIGRvZXNuJ3Qg bWFrZSB1c2Ugb2YgdGhlIGltcC4KKwogMjAxNC0wNC0yMiAgUnlvc3VrZSBOaXdhICA8cm5pd2FA d2Via2l0Lm9yZz4KIAogICAgICAgICBSRUdSRVNTSU9OIChyMTU3MzI4KTogcG9wb3ZlciB0byBj aGVjayBpbnRvIGZsaWdodCBiYS5jb20gZGlzbWlzc2VzIGluc3RhbnRseSB3aGVuIGZvY3VzaW5n IGZvcm0KZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJDb3JlL3BsYXRmb3JtL21hYy9TY3JvbGxBbmlt YXRvck1hYy5tbSBiL1NvdXJjZS9XZWJDb3JlL3BsYXRmb3JtL21hYy9TY3JvbGxBbmltYXRvck1h Yy5tbQppbmRleCAxNzc4NjhiLi5jOGVmN2M5IDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViQ29yZS9w bGF0Zm9ybS9tYWMvU2Nyb2xsQW5pbWF0b3JNYWMubW0KKysrIGIvU291cmNlL1dlYkNvcmUvcGxh dGZvcm0vbWFjL1Njcm9sbEFuaW1hdG9yTWFjLm1tCkBAIC00NjQsMTEgKzQ2NCwxMSBAQCBlbnVt IEZlYXR1cmVUb0FuaW1hdGUgewogCiAtIChCT09MKXNob3VsZFVzZUxheWVyUGVyUGFydEZvclNj cm9sbGVySW1wOihpZClzY3JvbGxlckltcAogeworICAgIFVOVVNFRF9QQVJBTShzY3JvbGxlcklt cCk7CisKICAgICBpZiAoIV9zY3JvbGxiYXIpCiAgICAgICAgIHJldHVybiBmYWxzZTsKIAotICAg IEFTU0VSVF9VTlVTRUQoc2Nyb2xsZXJJbXAsIHNjcm9sbGVySW1wID09IHNjcm9sbGJhclBhaW50 ZXJGb3JTY3JvbGxiYXIoX3Njcm9sbGJhcikpOwotCiAgICAgcmV0dXJuIF9zY3JvbGxiYXItPnN1 cHBvcnRzVXBkYXRlT25TZWNvbmRhcnlUaHJlYWQoKTsKIH0KIAo=