132020 2014-04-22 12:04:31 -0700 Remove unused local variable 2014-04-22 13:53:08 -0700 1 1 1 Unclassified WebKit WebKit2 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 1 joepeck webkit-unassigned commit-queue enrica joepeck timothy oldest_to_newest 1003021 0 joepeck 2014-04-22 12:04:31 -0700 UIProcess/ios/forms/WKFormSelectPopover.mm warning: Value stored to 'titleHeight' is never read titleHeight = navController.navigationBar.bounds.size.height; 1003022 1 229905 joepeck 2014-04-22 12:05:42 -0700 Created attachment 229905 [PATCH] Proposed Fix 1003054 2 229905 commit-queue 2014-04-22 13:53:06 -0700 Comment on attachment 229905 [PATCH] Proposed Fix Clearing flags on attachment: 229905 Committed r167682: <http://trac.webkit.org/changeset/167682> 1003055 3 commit-queue 2014-04-22 13:53:08 -0700 All reviewed patches have been landed. Closing bug. 229905 2014-04-22 12:05:42 -0700 2014-04-22 13:53:05 -0700 [PATCH] Proposed Fix unused.patch text/plain 2069 joepeck ZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJLaXQyL0NoYW5nZUxvZyBiL1NvdXJjZS9XZWJLaXQyL0No YW5nZUxvZwppbmRleCA4Y2E2YmQxLi4wYzYxNDE5IDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViS2l0 Mi9DaGFuZ2VMb2cKKysrIGIvU291cmNlL1dlYktpdDIvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMTMg QEAKKzIwMTQtMDQtMjIgIEpvc2VwaCBQZWNvcmFybyAgPHBlY29yYXJvQGFwcGxlLmNvbT4KKwor ICAgICAgICBSZW1vdmUgdW51c2VkIGxvY2FsIHZhcmlhYmxlCisgICAgICAgIGh0dHBzOi8vYnVn cy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0xMzIwMjAKKworICAgICAgICBSZXZpZXdlZCBi eSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICAqIFVJUHJvY2Vzcy9pb3MvZm9ybXMvV0tGb3Jt U2VsZWN0UG9wb3Zlci5tbToKKyAgICAgICAgKC1bV0tTZWxlY3RQb3BvdmVyIGluaXRXaXRoVmll dzpoYXNHcm91cHM6XSk6CisKIDIwMTQtMDQtMjAgIERhbiBCZXJuc3RlaW4gIDxtaXR6QGFwcGxl LmNvbT4KIAogICAgICAgICBbQ29jb2FdIFJlbW92ZSBpbnRlcmZhY2VzIGluIHRoZSBUbyBCZSBS ZW1vdmVkIGdyb3VwcwpkaWZmIC0tZ2l0IGEvU291cmNlL1dlYktpdDIvVUlQcm9jZXNzL2lvcy9m b3Jtcy9XS0Zvcm1TZWxlY3RQb3BvdmVyLm1tIGIvU291cmNlL1dlYktpdDIvVUlQcm9jZXNzL2lv cy9mb3Jtcy9XS0Zvcm1TZWxlY3RQb3BvdmVyLm1tCmluZGV4IDcyZDkxYzEuLmM3ODVkM2EgMTAw NjQ0Ci0tLSBhL1NvdXJjZS9XZWJLaXQyL1VJUHJvY2Vzcy9pb3MvZm9ybXMvV0tGb3JtU2VsZWN0 UG9wb3Zlci5tbQorKysgYi9Tb3VyY2UvV2ViS2l0Mi9VSVByb2Nlc3MvaW9zL2Zvcm1zL1dLRm9y bVNlbGVjdFBvcG92ZXIubW0KQEAgLTM5MCw3ICszOTAsNiBAQCBzdGF0aWMgTlNTdHJpbmcgKnN0 cmluZ1dpdGhXcml0aW5nRGlyZWN0aW9uKE5TU3RyaW5nICpzdHJpbmcsIFVJVGV4dFdyaXRpbmdE aXJlYwogICAgIFVJVmlld0NvbnRyb2xsZXIgKnBvcG92ZXJWaWV3Q29udHJvbGxlciA9IF90YWJs ZVZpZXdDb250cm9sbGVyLmdldCgpOwogICAgIFVJTmF2aWdhdGlvbkNvbnRyb2xsZXIgKm5hdkNv bnRyb2xsZXIgPSBuaWw7CiAgICAgTlNTdHJpbmcgKnRpdGxlID0gdmlldy5hc3Npc3RlZE5vZGVJ bmZvcm1hdGlvbi50aXRsZTsKLSAgICBDR0Zsb2F0IHRpdGxlSGVpZ2h0ID0gMDsKICAgICBCT09M IG5lZWRzTmF2aWdhdGlvbkNvbnRyb2xsZXIgPSAoX3ZpZXcgJiYgX1VJQXBwbGljYXRpb25Vc2Vz TGVnYWN5VUkoKSkgfHwgW3RpdGxlIGxlbmd0aF07CiAgICAgaWYgKG5lZWRzTmF2aWdhdGlvbkNv bnRyb2xsZXIpIHsKICAgICAgICAgbmF2Q29udHJvbGxlciA9IFtbVUlOYXZpZ2F0aW9uQ29udHJv bGxlciBhbGxvY10gaW5pdFdpdGhSb290Vmlld0NvbnRyb2xsZXI6X3RhYmxlVmlld0NvbnRyb2xs ZXIuZ2V0KCldOwpAQCAtMzk4LDggKzM5Nyw2IEBAIHN0YXRpYyBOU1N0cmluZyAqc3RyaW5nV2l0 aFdyaXRpbmdEaXJlY3Rpb24oTlNTdHJpbmcgKnN0cmluZywgVUlUZXh0V3JpdGluZ0RpcmVjCiAg ICAgICAgIAogICAgICAgICBpZiAoX3ZpZXcuYXNzaXN0ZWROb2RlSW5mb3JtYXRpb24uaXNNdWx0 aVNlbGVjdCAmJiBfVUlBcHBsaWNhdGlvblVzZXNMZWdhY3lVSSgpKQogICAgICAgICAgICAgX3Rh YmxlVmlld0NvbnRyb2xsZXIuZ2V0KCkubmF2aWdhdGlvbkl0ZW0ucmlnaHRCYXJCdXR0b25JdGVt ID0gW1tbVUlCYXJCdXR0b25JdGVtIGFsbG9jXSBpbml0V2l0aEJhckJ1dHRvblN5c3RlbUl0ZW06 VUlCYXJCdXR0b25TeXN0ZW1JdGVtRG9uZSB0YXJnZXQ6c2VsZiBhY3Rpb246QHNlbGVjdG9yKF91 c2VyQWN0aW9uRGlzbWlzc2VkUG9wb3ZlcjopXSBhdXRvcmVsZWFzZV07Ci0gICAgICAgIAotICAg ICAgICB0aXRsZUhlaWdodCA9IG5hdkNvbnRyb2xsZXIubmF2aWdhdGlvbkJhci5ib3VuZHMuc2l6 ZS5oZWlnaHQ7CiAgICAgfQogICAgIAogICAgIENHU2l6ZSBwb3BvdmVyU2l6ZSA9IFtfdGFibGVW aWV3Q29udHJvbGxlci5nZXQoKS50YWJsZVZpZXcgc2l6ZVRoYXRGaXRzOkNHU2l6ZU1ha2UoMzIw LCBDR0ZMT0FUX01BWCldOwo=