132017 2014-04-22 11:42:06 -0700 DocumentLoader::dataReceived assertion failed 2014-05-07 07:07:38 -0700 1 1 1 Unclassified WebKit WebKit Misc. 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 1 alex.christensen webkit-unassigned ap bfulgham commit-queue galpeter mmatyas ossy peavo sipka oldest_to_newest 1003010 0 alex.christensen 2014-04-22 11:42:06 -0700 Whenever I open any website via http in any recent WinCairo build, the last assert in DocumentLoader::dataReceived fails. This is new within the last thousand changes or so. This is the assertion that fails: ASSERT(!m_response.isNull()); Does anyone else have this problem? Does anyone know where it comes from or how to solve it? 1003371 1 230005 peavo 2014-04-23 13:56:25 -0700 Created attachment 230005 Patch 1003429 2 230005 bfulgham 2014-04-23 16:29:40 -0700 Comment on attachment 230005 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=230005&action=review Wow -- uninitialized variables. Double-check that network tests still pass with this change. That 'didReceiveResponse' might be needed to flush the client state in cases where the response wasn't received earlier... > Source/WebCore/platform/network/curl/ResourceHandleManager.cpp:-687 > - d->client()->didReceiveResponse(job, d->m_response); Its possible that this is needed in addition to the one you added above, to handle cases where the client did not receive a valid/complete response, but WebKit needs to be told to "move to the next state". Maybe double-check that HTTP and network tests work properly after this change. 1003477 3 alex.christensen 2014-04-23 19:17:34 -0700 > Maybe double-check that HTTP and network tests work properly after this change. Not all the network tests pass with this change, but it makes WinLauncher usable again. It undoes some changes from https://bugs.webkit.org/show_bug.cgi?id=127555 so I'd be interested in what they have to say about this. 1003714 4 peavo 2014-04-24 11:18:11 -0700 (In reply to comment #2) Thanks for reviewing :) > (From update of attachment 230005 [details]) > View in context: https://bugs.webkit.org/attachment.cgi?id=230005&action=review > > Wow -- uninitialized variables. > The initialization was not needed to fix the problem, I only includeded it to be on the safe side. > Double-check that network tests still pass with this change. That 'didReceiveResponse' might be needed to flush the client state in cases where the response wasn't received earlier... > > > Source/WebCore/platform/network/curl/ResourceHandleManager.cpp:-687 > > - d->client()->didReceiveResponse(job, d->m_response); > > Its possible that this is needed in addition to the one you added above, to handle cases where the client did not receive a valid/complete response, but WebKit needs to be told to "move to the next state". > > Maybe double-check that HTTP and network tests work properly after this change. Where do I find these tests? 1003752 5 alex.christensen 2014-04-24 13:36:58 -0700 I'm not authorized to cq+ this patch, otherwise I would. Brent? To run the tests, I use a command like this one: perl Tools/Scripts/run-webkit-tests --debug --no-build --root WebKitBuild/Debug_WinCairo/bin32 http http is the subdirectory of LayoutTests to run. fast is also a good subdirectory to run if you don't want to run all 23000 tests, many of which fail right now. 1003754 6 peavo 2014-04-24 13:42:35 -0700 (In reply to comment #5) > I'm not authorized to cq+ this patch, otherwise I would. Brent? > > To run the tests, I use a command like this one: > perl Tools/Scripts/run-webkit-tests --debug --no-build --root WebKitBuild/Debug_WinCairo/bin32 http > http is the subdirectory of LayoutTests to run. fast is also a good subdirectory to run if you don't want to run all 23000 tests, many of which fail right now. Ok, thanks :) 1005438 7 peavo 2014-04-30 11:27:06 -0700 These are the http test result I get when running with this patch: $ perl Tools/Scripts/run-webkit-tests --debug --no-build --root WebKitBuild/Debug_WinCairo/bin32 http Found 1992 tests; running 223, skipping 1769. /usr/sbin/lighttpd The _NT_SYMBOL_PATH environment variable is not set. Using Microsoft Symbol Server. Running 1 DumpRenderTree. [25/223] http/tests/media/pdf-served-as-pdf.html failed unexpectedly (text diff) [28/223] http/tests/media/video-cancel-load.html failed unexpectedly (text diff) [45/223] http/tests/navigation/response204.html passed unexpectedly [71/223] http/tests/security/xss-DENIED-getSVGDocument-iframe.html failed unexpectedly (text diff) [72/223] http/tests/security/xss-DENIED-getSVGDocument-object.html failed unexpectedly (text diff) [194/223] http/tests/w3c/webperf/approved/navigation-timing/html/test_performance_attributes_exist_in_object.html passed unexpectedly [223/223] http/tests/xmlhttprequest/redirect-cross-origin-tripmine.html failed unexpectedly (text diff) Retrying 5 unexpected failure(s) ... Running 1 DumpRenderTree. [1/5] http/tests/media/video-cancel-load.html failed unexpectedly (text diff) [2/5] http/tests/media/pdf-served-as-pdf.html failed unexpectedly (text diff) [3/5] http/tests/security/xss-DENIED-getSVGDocument-object.html failed unexpectedly (text diff) [4/5] http/tests/security/xss-DENIED-getSVGDocument-iframe.html failed unexpectedly (text diff) [5/5] http/tests/xmlhttprequest/redirect-cross-origin-tripmine.html failed unexpectedly (text diff) 216 tests ran as expected, 7 didn't: 1005815 8 peavo 2014-05-01 12:55:55 -0700 Without this patch, I get many failures (crashes) when running the http tests: $ perl Tools/Scripts/run-webkit-tests --debug --no-build --root WebKitBuild/Debug_WinCairo/bin32 http Using port 'win-future' Test configuration: <future, x86, debug> Placing test results in /cygdrive/c/cygwin/home/per.arne.vollan/WebKit/WebKitBuild/Debug_WinCairo/bin32/layout-test-results Baseline search path: win -> mac-mountainlion -> mac -> generic Using Debug build Pixel tests disabled Regular timeout: 35000, slow test timeout: 175000 Command line: /cygdrive/c/cygwin/home/per.arne.vollan/WebKit/WebKitBuild/Debug_WinCairo/bin32/DumpRenderTree - --lint-test-files warnings: LayoutTests/platform/win/TestExpectations:46 Path does not exist. fast/canvas/canvas-currentPath.html LayoutTests/platform/win/TestExpectations:1424 Path does not exist. media/track/opera/interfaces/TextTrackList/onremovetrack.html LayoutTests/platform/win/TestExpectations:2248 Path does not exist. svg/custom/masking-clipping-hidpi.svg LayoutTests/platform/win/TestExpectations:2329 Path does not exist. fast/dom/is-protocol-handler-registered.html LayoutTests/platform/win/TestExpectations:2332 Path does not exist. js/regress/emscripten-memops.html LayoutTests/platform/win/TestExpectations:2336 Path does not exist. js/regress/chain-custom-getter.html LayoutTests/platform/win/TestExpectations:2338 Path does not exist. js/regress/marsaglia.html LayoutTests/platform/win/TestExpectations:2339 Path does not exist. js/regress/proto-custom-getter.html LayoutTests/platform/win/TestExpectations:2341 Path does not exist. js/regress/simple-custom-getter.html LayoutTests/platform/win/TestExpectations:2532 Path does not exist. csswg/contributors/adobe/submitted/shapes/shape-outside/shape-outside-floats-horizontal-rectangle-002.html Found 1992 tests; running 223, skipping 1769. /usr/sbin/lighttpd The _NT_SYMBOL_PATH environment variable is not set. Using Microsoft Symbol Server. Running 1 DumpRenderTree. [1/223] http/tests/cache/subresource-expiration-1.html failed unexpectedly (DumpRenderTree crashed [pid=7120]) [2/223] http/tests/cache/subresource-expiration-2.html failed unexpectedly (DumpRenderTree crashed [pid=9540]) [3/223] http/tests/cookies/multiple-cookies.html failed unexpectedly (DumpRenderTree crashed [pid=6872]) [4/223] http/tests/cookies/single-quoted-value.html failed unexpectedly (DumpRenderTree crashed [pid=1852]) [5/223] http/tests/cookies/third-party-cookie-relaxing.html failed unexpectedly (DumpRenderTree crashed [pid=5196]) [6/223] http/tests/incremental/slow-utf8-text.pl failed unexpectedly (DumpRenderTree crashed [pid=7612]) ... [209/223] http/tests/w3c/webperf/submission/Google/resource-timing/html/test_resource_ignore_data_url.html failed unexpectedly (DumpRenderTree crashed [pid=9412]) [210/223] http/tests/w3c/webperf/submission/Google/resource-timing/html/test_resource_ignore_failures.html failed unexpectedly (DumpRenderTree crashed [pid=5544]) [211/223] http/tests/w3c/webperf/submission/Google/resource-timing/html/test_resource_initiator_types.html failed unexpectedly (DumpRenderTree crashed [pid=7280]) [212/223] http/tests/w3c/webperf/submission/Google/resource-timing/html/test_resource_redirects.html failed unexpectedly (DumpRenderTree crashed [pid=8076]) [213/223] http/tests/w3c/webperf/submission/Google/resource-timing/html/test_resource_reparenting.html failed unexpectedly (DumpRenderTree crashed [pid=7228]) [214/223] http/tests/w3c/webperf/submission/Google/resource-timing/html/test_resource_script_types.html failed unexpectedly (DumpRenderTree crashed [pid=6464]) [215/223] http/tests/xmlhttprequest/abort-should-cancel-load.html failed unexpectedly (DumpRenderTree crashed [pid=10608]) [216/223] http/tests/xmlhttprequest/access-control-basic-non-simple-deny-cached.html failed unexpectedly (DumpRenderTree crashed [pid=7236]) [217/223] http/tests/xmlhttprequest/access-control-basic-whitelist-request-headers.html failed unexpectedly (DumpRenderTree crashed [pid=10668]) [218/223] http/tests/xmlhttprequest/cache-override.html failed unexpectedly (DumpRenderTree crashed [pid=2700]) [219/223] http/tests/xmlhttprequest/cross-origin-no-authorization.html failed unexpectedly (DumpRenderTree crashed [pid=2404]) [220/223] http/tests/xmlhttprequest/redirect-cross-origin-post-sync.html failed unexpectedly (DumpRenderTree crashed [pid=10816]) [221/223] http/tests/xmlhttprequest/redirect-cross-origin-sync-double.html failed unexpectedly (DumpRenderTree crashed [pid=7284]) [222/223] http/tests/xmlhttprequest/redirect-cross-origin-sync.html failed unexpectedly (DumpRenderTree crashed [pid=5488]) 18 tests ran as expected, 205 didn't: 1006118 9 peavo 2014-05-02 13:19:07 -0700 cq+? ;) 1007317 10 230005 commit-queue 2014-05-07 07:07:31 -0700 Comment on attachment 230005 Patch Clearing flags on attachment: 230005 Committed r168425: <http://trac.webkit.org/changeset/168425> 1007318 11 commit-queue 2014-05-07 07:07:38 -0700 All reviewed patches have been landed. Closing bug. 230005 2014-04-23 13:56:25 -0700 2014-05-07 07:07:31 -0700 Patch bug-132017-20140423225534.patch text/plain 3285 peavo SW5kZXg6IFNvdXJjZS9XZWJDb3JlL0NoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBTb3VyY2UvV2Vi Q29yZS9DaGFuZ2VMb2cJKHJldmlzaW9uIDE2NzcyMCkKKysrIFNvdXJjZS9XZWJDb3JlL0NoYW5n ZUxvZwkod29ya2luZyBjb3B5KQpAQCAtMSwzICsxLDE5IEBACisyMDE0LTA0LTIzICBwZWF2b0Bv dXRsb29rLmNvbSAgPHBlYXZvQG91dGxvb2suY29tPgorCisgICAgICAgIERvY3VtZW50TG9hZGVy OjpkYXRhUmVjZWl2ZWQgYXNzZXJ0aW9uIGZhaWxlZAorICAgICAgICBodHRwczovL2J1Z3Mud2Vi a2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MTMyMDE3CisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9C T0RZIChPT1BTISkuCisKKyAgICAgICAgV2UgbmVlZCB0byBjYWxsIGRpZFJlY2VpdmVSZXNwb25z ZSBjbGllbnQgbWV0aG9kIGJlZm9yZSB0aGUgZGlkUmVjZWl2ZURhdGEgY2xpZW50IG1ldGhvZCwg b3RoZXJ3aXNlIHdlIGdldCBhIGxvdCBvZiBhc3NlcnRzLgorICAgICAgICBUaGlzIHBhdGNoIGFs c28gZml4ZXMgZnJlcXVlbnQgY3Jhc2hlcyBpbiBkb3dubG9hZFRpbWVyQ2FsbGJhY2sgbWV0aG9k IG9uIHBhZ2UgbG9hZGluZy4KKworICAgICAgICAqIHBsYXRmb3JtL25ldHdvcmsvY3VybC9SZXNv dXJjZUhhbmRsZU1hbmFnZXIuY3BwOgorICAgICAgICAoV2ViQ29yZTo6Y2FsY3VsYXRlV2ViVGlt aW5nSW5mb3JtYXRpb25zKTogSW5pdGlhbGl6ZSBsb2NhbCB2YXJpYWJsZXMuCisgICAgICAgIChX ZWJDb3JlOjpoZWFkZXJDYWxsYmFjayk6IENhbGwgZGlkUmVjZWl2ZVJlc3BvbnNlIGNsaWVudCBt ZXRob2QgaGVyZSBpbnN0ZWFkIG9mIGluIGRvd25sb2FkVGltZXJDYWxsYmFjay4KKyAgICAgICAg KFdlYkNvcmU6OlJlc291cmNlSGFuZGxlTWFuYWdlcjo6ZG93bmxvYWRUaW1lckNhbGxiYWNrKTog UmVtb3ZlIGNhbGwgdG8gZGlkUmVjZWl2ZVJlc3BvbnNlIG1ldGhvZC4KKyAgICAgICAgKFdlYkNv cmU6OlJlc291cmNlSGFuZGxlTWFuYWdlcjo6ZGlzcGF0Y2hTeW5jaHJvbm91c0pvYik6IFJlbW92 ZWQgZW1wdHkgbGluZS4KKwogMjAxNC0wNC0yMyAgRGF2aWQgSHlhdHQgIDxoeWF0dEBhcHBsZS5j b20+CiAKICAgICAgICAgW05ldyBNdWx0aWNvbHVtbl0gQXNzZXJ0aW9uIGZhaWx1cmUgaW4gaHVn ZS1jb2x1bW4tY291bnQuaHRtbApJbmRleDogU291cmNlL1dlYkNvcmUvcGxhdGZvcm0vbmV0d29y ay9jdXJsL1Jlc291cmNlSGFuZGxlTWFuYWdlci5jcHAKPT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PQotLS0gU291cmNlL1dl YkNvcmUvcGxhdGZvcm0vbmV0d29yay9jdXJsL1Jlc291cmNlSGFuZGxlTWFuYWdlci5jcHAJKHJl dmlzaW9uIDE2NzY2MykKKysrIFNvdXJjZS9XZWJDb3JlL3BsYXRmb3JtL25ldHdvcmsvY3VybC9S ZXNvdXJjZUhhbmRsZU1hbmFnZXIuY3BwCSh3b3JraW5nIGNvcHkpCkBAIC0xNTgsMTEgKzE1OCwx MSBAQCBzdGF0aWMgaW50IG1pbGlzZWNvbmRzU2luY2VSZXF1ZXN0KGRvdWJsCiAKIHN0YXRpYyB2 b2lkIGNhbGN1bGF0ZVdlYlRpbWluZ0luZm9ybWF0aW9ucyhSZXNvdXJjZUhhbmRsZUludGVybmFs KiBkKQogewotICAgIGRvdWJsZSBzdGFydFRyYW5zZmVydFRpbWU7Ci0gICAgZG91YmxlIHByZVRy YW5zZmVyVGltZTsKLSAgICBkb3VibGUgZG5zbG9va3VwVGltZTsKLSAgICBkb3VibGUgY29ubmVj dFRpbWU7Ci0gICAgZG91YmxlIGFwcENvbm5lY3RUaW1lOworICAgIGRvdWJsZSBzdGFydFRyYW5z ZmVydFRpbWUgPSAwOworICAgIGRvdWJsZSBwcmVUcmFuc2ZlclRpbWUgPSAwOworICAgIGRvdWJs ZSBkbnNsb29rdXBUaW1lID0gMDsKKyAgICBkb3VibGUgY29ubmVjdFRpbWUgPSAwOworICAgIGRv dWJsZSBhcHBDb25uZWN0VGltZSA9IDA7CiAKICAgICBjdXJsX2Vhc3lfZ2V0aW5mbyhkLT5tX2hh bmRsZSwgQ1VSTElORk9fTkFNRUxPT0tVUF9USU1FLCAmZG5zbG9va3VwVGltZSk7CiAgICAgY3Vy bF9lYXN5X2dldGluZm8oZC0+bV9oYW5kbGUsIENVUkxJTkZPX0NPTk5FQ1RfVElNRSwgJmNvbm5l Y3RUaW1lKTsKQEAgLTUzMSw5ICs1MzEsMTAgQEAgc3RhdGljIHNpemVfdCBoZWFkZXJDYWxsYmFj ayhjaGFyKiBwdHIsCiAgICAgICAgICAgICB9CiAgICAgICAgIH0KIAotICAgICAgICBpZiAoY2xp ZW50KQorICAgICAgICBpZiAoY2xpZW50KSB7CisgICAgICAgICAgICBjbGllbnQtPmRpZFJlY2Vp dmVSZXNwb25zZShqb2IsIGQtPm1fcmVzcG9uc2UpOyAKICAgICAgICAgICAgIEN1cmxDYWNoZU1h bmFnZXI6OmdldEluc3RhbmNlKCkuZGlkUmVjZWl2ZVJlc3BvbnNlKGpvYiwgZC0+bV9yZXNwb25z ZSk7Ci0KKyAgICAgICAgfQogICAgICAgICBkLT5tX3Jlc3BvbnNlLnNldFJlc3BvbnNlRmlyZWQo dHJ1ZSk7CiAKICAgICB9IGVsc2UgewpAQCAtNjY4LDcgKzY2OSw2IEBAIHZvaWQgUmVzb3VyY2VI YW5kbGVNYW5hZ2VyOjpkb3dubG9hZFRpbWUKIAogCiAgICAgICAgIGlmIChDVVJMRV9PSyA9PSBt c2ctPmRhdGEucmVzdWx0KSB7Ci0KICNpZiBFTkFCTEUoV0VCX1RJTUlORykKICAgICAgICAgICAg IGNhbGN1bGF0ZVdlYlRpbWluZ0luZm9ybWF0aW9ucyhkKTsKICNlbmRpZgpAQCAtNjg0LDcgKzY4 NCw2IEBAIHZvaWQgUmVzb3VyY2VIYW5kbGVNYW5hZ2VyOjpkb3dubG9hZFRpbWUKICAgICAgICAg ICAgICAgICBkLT5tX211bHRpcGFydEhhbmRsZS0+Y29udGVudEVuZGVkKCk7CiAKICAgICAgICAg ICAgIGlmIChkLT5jbGllbnQoKSkgewotICAgICAgICAgICAgICAgIGQtPmNsaWVudCgpLT5kaWRS ZWNlaXZlUmVzcG9uc2Uoam9iLCBkLT5tX3Jlc3BvbnNlKTsKICAgICAgICAgICAgICAgICBkLT5j bGllbnQoKS0+ZGlkRmluaXNoTG9hZGluZyhqb2IsIDApOwogICAgICAgICAgICAgICAgIEN1cmxD YWNoZU1hbmFnZXI6OmdldEluc3RhbmNlKCkuZGlkRmluaXNoTG9hZGluZyhqb2ItPmZpcnN0UmVx dWVzdCgpLnVybCgpLnN0cmluZygpKTsKICAgICAgICAgICAgIH0KQEAgLTkxOSw3ICs5MTgsNiBA QCB2b2lkIFJlc291cmNlSGFuZGxlTWFuYWdlcjo6ZGlzcGF0Y2hTeW5jCiAgICAgICAgICAgICBo YW5kbGUtPmNsaWVudCgpLT5kaWRSZWNlaXZlUmVzcG9uc2Uoam9iLCBoYW5kbGUtPm1fcmVzcG9u c2UpOwogICAgIH0KIAotCiAjaWYgRU5BQkxFKFdFQl9USU1JTkcpCiAgICAgY2FsY3VsYXRlV2Vi VGltaW5nSW5mb3JtYXRpb25zKGhhbmRsZSk7CiAjZW5kaWYK