132014 2014-04-22 10:45:55 -0700 Add SPI to expose provisional and committed URL from Frame. 2014-04-22 23:00:05 -0700 1 1 1 Unclassified WebKit WebKit2 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 1 yongjun_zhang webkit-unassigned andersca commit-queue mitz sam oldest_to_newest 1002989 0 yongjun_zhang 2014-04-22 10:45:55 -0700 It would be nice to expose the provisional URL and committed URL from WKWebProcessPlugInFrame. 1002991 1 229896 yongjun_zhang 2014-04-22 10:50:22 -0700 Created attachment 229896 Patch. 1003061 2 229896 mitz 2014-04-22 14:13:12 -0700 Comment on attachment 229896 Patch. View in context: https://bugs.webkit.org/attachment.cgi?id=229896&action=review > Source/WebKit2/WebProcess/InjectedBundle/API/Cocoa/WKWebProcessPlugInFramePrivate.h:41 > +@property (nonatomic, readonly) NSURL *_committedURL; This is already exposed via the URL property. Other than that, looks good. 1003062 3 229896 mitz 2014-04-22 14:13:49 -0700 Comment on attachment 229896 Patch. r=me on the _provisionalURL part. 1003063 4 yongjun_zhang 2014-04-22 14:18:02 -0700 (In reply to comment #3) > (From update of attachment 229896 [details]) > r=me on the _provisionalURL part. aha, I somehow missed URL. Will remove _committedURL. thanks! 1003185 5 229956 yongjun_zhang 2014-04-22 22:24:41 -0700 Created attachment 229956 Remove _committedURL from the previous patch before landing. 1003199 6 229956 commit-queue 2014-04-22 23:00:02 -0700 Comment on attachment 229956 Remove _committedURL from the previous patch before landing. Clearing flags on attachment: 229956 Committed r167699: <http://trac.webkit.org/changeset/167699> 1003200 7 commit-queue 2014-04-22 23:00:05 -0700 All reviewed patches have been landed. Closing bug. 229896 2014-04-22 10:50:22 -0700 2014-04-22 22:24:41 -0700 Patch. expose_urls.patch text/plain 2903 yongjun_zhang Y29tbWl0IGU3NWMwZDMxYzdhODQzOTg1M2Q0MTRhY2I4ZGQxZWY5ZjcxNjE1NmEKQXV0aG9yOiBZ b25nanVuIFpoYW5nIDx5b25nanVuX3poYW5nQGFwcGxlLmNvbT4KRGF0ZTogICBUdWUgQXByIDIy IDA5OjI1OjI0IDIwMTQgLTA3MDAKCiAgICBBZGQgU1BJIHRvIGV4cG9zZSBwcm92aXNpb25hbCBh bmQgY29tbWl0dGVkIFVSTCBmcm9tIEZyYW1lLgogICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcv c2hvd19idWcuY2dpP2lkPTEzMjAxNAogICAgCiAgICBBZGQgbWV0aG9kcyB0byByZXR1cm4gdGhl IHByb3Zpc2lvbmFsIFVSTCBhbmQgY29tbWl0dGVkIFVSTCBmcm9tIFdLV2ViUHJvY2Vzc1BsdWdJ bkZyYW1lLgogICAgCiAgICAqIFdlYlByb2Nlc3MvSW5qZWN0ZWRCdW5kbGUvQVBJL0NvY29hL1dL V2ViUHJvY2Vzc1BsdWdJbkZyYW1lLm1tOgogICAgKC1bV0tXZWJQcm9jZXNzUGx1Z0luRnJhbWUg X3Byb3Zpc2lvbmFsVVJMXSk6CiAgICAoLVtXS1dlYlByb2Nlc3NQbHVnSW5GcmFtZSBfY29tbWl0 dGVkVVJMXSk6CiAgICAqIFdlYlByb2Nlc3MvSW5qZWN0ZWRCdW5kbGUvQVBJL0NvY29hL1dLV2Vi UHJvY2Vzc1BsdWdJbkZyYW1lUHJpdmF0ZS5oOgoKZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJLaXQy L0NoYW5nZUxvZyBiL1NvdXJjZS9XZWJLaXQyL0NoYW5nZUxvZwppbmRleCA1ODViZDdlLi44MmM0 ZTEyIDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViS2l0Mi9DaGFuZ2VMb2cKKysrIGIvU291cmNlL1dl YktpdDIvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMTcgQEAKKzIwMTQtMDQtMjIgIFlvbmdqdW4gWmhh bmcgIDx5b25nanVuX3poYW5nQGFwcGxlLmNvbT4KKworICAgICAgICBBZGQgU1BJIHRvIGV4cG9z ZSBwcm92aXNpb25hbCBhbmQgY29tbWl0dGVkIFVSTCBmcm9tIEZyYW1lLgorICAgICAgICBodHRw czovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MTMyMDE0CisKKyAgICAgICAgQWRk IG1ldGhvZHMgdG8gcmV0dXJuIHRoZSBwcm92aXNpb25hbCBVUkwgYW5kIGNvbW1pdHRlZCBVUkwg ZnJvbSBXS1dlYlByb2Nlc3NQbHVnSW5GcmFtZS4KKworICAgICAgICBSZXZpZXdlZCBieSBOT0JP RFkgKE9PUFMhKS4KKworICAgICAgICAqIFdlYlByb2Nlc3MvSW5qZWN0ZWRCdW5kbGUvQVBJL0Nv Y29hL1dLV2ViUHJvY2Vzc1BsdWdJbkZyYW1lLm1tOgorICAgICAgICAoLVtXS1dlYlByb2Nlc3NQ bHVnSW5GcmFtZSBfcHJvdmlzaW9uYWxVUkxdKToKKyAgICAgICAgKC1bV0tXZWJQcm9jZXNzUGx1 Z0luRnJhbWUgX2NvbW1pdHRlZFVSTF0pOgorICAgICAgICAqIFdlYlByb2Nlc3MvSW5qZWN0ZWRC dW5kbGUvQVBJL0NvY29hL1dLV2ViUHJvY2Vzc1BsdWdJbkZyYW1lUHJpdmF0ZS5oOgorCiAyMDE0 LTA0LTIyICBUaW0gSG9ydG9uICA8dGltb3RoeV9ob3J0b25AYXBwbGUuY29tPgogCiAgICAgICAg IFdLVGh1bWJuYWlsVmlldyBkb2Vzbid0IHF1aXRlIHdvcmsgd2l0aCB0b3BDb250ZW50SW5zZXQK ZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJLaXQyL1dlYlByb2Nlc3MvSW5qZWN0ZWRCdW5kbGUvQVBJ L0NvY29hL1dLV2ViUHJvY2Vzc1BsdWdJbkZyYW1lLm1tIGIvU291cmNlL1dlYktpdDIvV2ViUHJv Y2Vzcy9JbmplY3RlZEJ1bmRsZS9BUEkvQ29jb2EvV0tXZWJQcm9jZXNzUGx1Z0luRnJhbWUubW0K aW5kZXggMTM5NTcyOC4uZTRjOWM5NiAxMDA2NDQKLS0tIGEvU291cmNlL1dlYktpdDIvV2ViUHJv Y2Vzcy9JbmplY3RlZEJ1bmRsZS9BUEkvQ29jb2EvV0tXZWJQcm9jZXNzUGx1Z0luRnJhbWUubW0K KysrIGIvU291cmNlL1dlYktpdDIvV2ViUHJvY2Vzcy9JbmplY3RlZEJ1bmRsZS9BUEkvQ29jb2Ev V0tXZWJQcm9jZXNzUGx1Z0luRnJhbWUubW0KQEAgLTExNiw2ICsxMTYsMTYgQEAgdXNpbmcgbmFt ZXNwYWNlIFdlYktpdDsKICAgICByZXR1cm4gKE5TQXJyYXkgKilfZnJhbWUtPmNlcnRpZmljYXRl SW5mbygpLmNlcnRpZmljYXRlQ2hhaW4oKTsKIH0KIAorLSAoTlNVUkwgKilfcHJvdmlzaW9uYWxV UkwKK3sKKyAgICByZXR1cm4gW05TVVJMIF93ZWJfVVJMV2l0aFdURlN0cmluZzpfZnJhbWUtPnBy b3Zpc2lvbmFsVVJMKCldOworfQorCistIChOU1VSTCAqKV9jb21taXR0ZWRVUkwKK3sKKyAgICBy ZXR1cm4gW05TVVJMIF93ZWJfVVJMV2l0aFdURlN0cmluZzpfZnJhbWUtPnVybCgpXTsKK30KKwog I3ByYWdtYSBtYXJrIFdLT2JqZWN0IHByb3RvY29sIGltcGxlbWVudGF0aW9uCiAKIC0gKEFQSTo6 T2JqZWN0JilfYXBpT2JqZWN0CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViS2l0Mi9XZWJQcm9jZXNz L0luamVjdGVkQnVuZGxlL0FQSS9Db2NvYS9XS1dlYlByb2Nlc3NQbHVnSW5GcmFtZVByaXZhdGUu aCBiL1NvdXJjZS9XZWJLaXQyL1dlYlByb2Nlc3MvSW5qZWN0ZWRCdW5kbGUvQVBJL0NvY29hL1dL V2ViUHJvY2Vzc1BsdWdJbkZyYW1lUHJpdmF0ZS5oCmluZGV4IDI3N2FiNzUuLjE5MmRlY2QgMTAw NjQ0Ci0tLSBhL1NvdXJjZS9XZWJLaXQyL1dlYlByb2Nlc3MvSW5qZWN0ZWRCdW5kbGUvQVBJL0Nv Y29hL1dLV2ViUHJvY2Vzc1BsdWdJbkZyYW1lUHJpdmF0ZS5oCisrKyBiL1NvdXJjZS9XZWJLaXQy L1dlYlByb2Nlc3MvSW5qZWN0ZWRCdW5kbGUvQVBJL0NvY29hL1dLV2ViUHJvY2Vzc1BsdWdJbkZy YW1lUHJpdmF0ZS5oCkBAIC0zNyw2ICszNyw4IEBACiAKIEBwcm9wZXJ0eSAobm9uYXRvbWljLCBy ZWFkb25seSkgQk9PTCBfaGFzQ3VzdG9tQ29udGVudFByb3ZpZGVyOwogQHByb3BlcnR5IChub25h dG9taWMsIHJlYWRvbmx5KSBOU0FycmF5ICpfY2VydGlmaWNhdGVDaGFpbjsKK0Bwcm9wZXJ0eSAo bm9uYXRvbWljLCByZWFkb25seSkgTlNVUkwgKl9wcm92aXNpb25hbFVSTDsKK0Bwcm9wZXJ0eSAo bm9uYXRvbWljLCByZWFkb25seSkgTlNVUkwgKl9jb21taXR0ZWRVUkw7CiAKIEBlbmQKIAo= 229956 2014-04-22 22:24:41 -0700 2014-04-22 23:00:02 -0700 Remove _committedURL from the previous patch before landing. provisional_url.patch text/plain 2601 yongjun_zhang Y29tbWl0IGYzYWFhYzkyMzU2YWI5NTI1NzA0NzJhZTIxZTQwMTg0MmQwYWMxYTUKQXV0aG9yOiBZ b25nanVuIFpoYW5nIDx5b25nanVuX3poYW5nQGFwcGxlLmNvbT4KRGF0ZTogICBUdWUgQXByIDIy IDA5OjI1OjI0IDIwMTQgLTA3MDAKCiAgICBBZGQgU1BJIHRvIGV4cG9zZSBwcm92aXNpb25hbCBh bmQgY29tbWl0dGVkIFVSTCBmcm9tIEZyYW1lLgogICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcv c2hvd19idWcuY2dpP2lkPTEzMjAxNAogICAgCiAgICBBZGQgbWV0aG9kcyB0byByZXR1cm4gdGhl IHByb3Zpc2lvbmFsIFVSTCBhbmQgY29tbWl0dGVkIFVSTCBmcm9tIFdLV2ViUHJvY2Vzc1BsdWdJ bkZyYW1lLgogICAgCiAgICAqIFdlYlByb2Nlc3MvSW5qZWN0ZWRCdW5kbGUvQVBJL0NvY29hL1dL V2ViUHJvY2Vzc1BsdWdJbkZyYW1lLm1tOgogICAgKC1bV0tXZWJQcm9jZXNzUGx1Z0luRnJhbWUg X3Byb3Zpc2lvbmFsVVJMXSk6CiAgICAqIFdlYlByb2Nlc3MvSW5qZWN0ZWRCdW5kbGUvQVBJL0Nv Y29hL1dLV2ViUHJvY2Vzc1BsdWdJbkZyYW1lUHJpdmF0ZS5oOgoKZGlmZiAtLWdpdCBhL1NvdXJj ZS9XZWJLaXQyL0NoYW5nZUxvZyBiL1NvdXJjZS9XZWJLaXQyL0NoYW5nZUxvZwppbmRleCAyNDEw OTNkLi5mNjdlYTk3IDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViS2l0Mi9DaGFuZ2VMb2cKKysrIGIv U291cmNlL1dlYktpdDIvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMTYgQEAKKzIwMTQtMDQtMjIgIFlv bmdqdW4gWmhhbmcgIDx5b25nanVuX3poYW5nQGFwcGxlLmNvbT4KKworICAgICAgICBBZGQgU1BJ IHRvIGV4cG9zZSBwcm92aXNpb25hbCBVUkwgZnJvbSBGcmFtZS4KKyAgICAgICAgaHR0cHM6Ly9i dWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTEzMjAxNAorCisgICAgICAgIEFkZCBtZXRo b2RzIHRvIHJldHVybiB0aGUgcHJvdmlzaW9uYWwgVVJMIGZyb20gV0tXZWJQcm9jZXNzUGx1Z0lu RnJhbWUuCisKKyAgICAgICAgUmV2aWV3ZWQgYnkgRGFuIEJlcm5zdGVpbi4KKworICAgICAgICAq IFdlYlByb2Nlc3MvSW5qZWN0ZWRCdW5kbGUvQVBJL0NvY29hL1dLV2ViUHJvY2Vzc1BsdWdJbkZy YW1lLm1tOgorICAgICAgICAoLVtXS1dlYlByb2Nlc3NQbHVnSW5GcmFtZSBfcHJvdmlzaW9uYWxV UkxdKToKKyAgICAgICAgKiBXZWJQcm9jZXNzL0luamVjdGVkQnVuZGxlL0FQSS9Db2NvYS9XS1dl YlByb2Nlc3NQbHVnSW5GcmFtZVByaXZhdGUuaDoKKwogMjAxNC0wNC0yMiAgQ29tbWl0IFF1ZXVl ICA8Y29tbWl0LXF1ZXVlQHdlYmtpdC5vcmc+CiAKICAgICAgICAgVW5yZXZpZXdlZCwgcm9sbGlu ZyBvdXQgcjE2NzY3NC4KZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJLaXQyL1dlYlByb2Nlc3MvSW5q ZWN0ZWRCdW5kbGUvQVBJL0NvY29hL1dLV2ViUHJvY2Vzc1BsdWdJbkZyYW1lLm1tIGIvU291cmNl L1dlYktpdDIvV2ViUHJvY2Vzcy9JbmplY3RlZEJ1bmRsZS9BUEkvQ29jb2EvV0tXZWJQcm9jZXNz UGx1Z0luRnJhbWUubW0KaW5kZXggMTM5NTcyOC4uYTJiNWRiMCAxMDA2NDQKLS0tIGEvU291cmNl L1dlYktpdDIvV2ViUHJvY2Vzcy9JbmplY3RlZEJ1bmRsZS9BUEkvQ29jb2EvV0tXZWJQcm9jZXNz UGx1Z0luRnJhbWUubW0KKysrIGIvU291cmNlL1dlYktpdDIvV2ViUHJvY2Vzcy9JbmplY3RlZEJ1 bmRsZS9BUEkvQ29jb2EvV0tXZWJQcm9jZXNzUGx1Z0luRnJhbWUubW0KQEAgLTExNiw2ICsxMTYs MTEgQEAgdXNpbmcgbmFtZXNwYWNlIFdlYktpdDsKICAgICByZXR1cm4gKE5TQXJyYXkgKilfZnJh bWUtPmNlcnRpZmljYXRlSW5mbygpLmNlcnRpZmljYXRlQ2hhaW4oKTsKIH0KIAorLSAoTlNVUkwg KilfcHJvdmlzaW9uYWxVUkwKK3sKKyAgICByZXR1cm4gW05TVVJMIF93ZWJfVVJMV2l0aFdURlN0 cmluZzpfZnJhbWUtPnByb3Zpc2lvbmFsVVJMKCldOworfQorCiAjcHJhZ21hIG1hcmsgV0tPYmpl Y3QgcHJvdG9jb2wgaW1wbGVtZW50YXRpb24KIAogLSAoQVBJOjpPYmplY3QmKV9hcGlPYmplY3QK ZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJLaXQyL1dlYlByb2Nlc3MvSW5qZWN0ZWRCdW5kbGUvQVBJ L0NvY29hL1dLV2ViUHJvY2Vzc1BsdWdJbkZyYW1lUHJpdmF0ZS5oIGIvU291cmNlL1dlYktpdDIv V2ViUHJvY2Vzcy9JbmplY3RlZEJ1bmRsZS9BUEkvQ29jb2EvV0tXZWJQcm9jZXNzUGx1Z0luRnJh bWVQcml2YXRlLmgKaW5kZXggMjc3YWI3NS4uZjc5ZDJiMSAxMDA2NDQKLS0tIGEvU291cmNlL1dl YktpdDIvV2ViUHJvY2Vzcy9JbmplY3RlZEJ1bmRsZS9BUEkvQ29jb2EvV0tXZWJQcm9jZXNzUGx1 Z0luRnJhbWVQcml2YXRlLmgKKysrIGIvU291cmNlL1dlYktpdDIvV2ViUHJvY2Vzcy9JbmplY3Rl ZEJ1bmRsZS9BUEkvQ29jb2EvV0tXZWJQcm9jZXNzUGx1Z0luRnJhbWVQcml2YXRlLmgKQEAgLTM3 LDYgKzM3LDcgQEAKIAogQHByb3BlcnR5IChub25hdG9taWMsIHJlYWRvbmx5KSBCT09MIF9oYXND dXN0b21Db250ZW50UHJvdmlkZXI7CiBAcHJvcGVydHkgKG5vbmF0b21pYywgcmVhZG9ubHkpIE5T QXJyYXkgKl9jZXJ0aWZpY2F0ZUNoYWluOworQHByb3BlcnR5IChub25hdG9taWMsIHJlYWRvbmx5 KSBOU1VSTCAqX3Byb3Zpc2lvbmFsVVJMOwogCiBAZW5kCiAK