131983 2014-04-22 05:07:17 -0700 [GTK] Crash after getting web view context property with g_object_get 2014-04-22 06:36:55 -0700 1 1 1 Unclassified WebKit WebKit2 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED Gtk P2 Normal --- 1 cgarcia webkit-unassigned berto commit-queue gustavo mrobinson pnormand oldest_to_newest 1002867 0 cgarcia 2014-04-22 05:07:17 -0700 The problem is that the getter is using g_value_take_object() and the default context is destroyed when the caller releases its ref. We should use g_value_set_object instead. 1002868 1 229875 cgarcia 2014-04-22 05:09:12 -0700 Created attachment 229875 Patch 1002869 2 commit-queue 2014-04-22 05:10:51 -0700 Thanks for the patch. If this patch contains new public API please make sure it follows the guidelines for new WebKit2 GTK+ API. See http://trac.webkit.org/wiki/WebKitGTK/AddingNewWebKit2API 1002870 3 cgarcia 2014-04-22 06:36:55 -0700 Committed r167656: <http://trac.webkit.org/changeset/167656> 229875 2014-04-22 05:09:12 -0700 2014-04-22 05:25:14 -0700 Patch wk2-crash.diff text/plain 1472 cgarcia ZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJLaXQyL0NoYW5nZUxvZyBiL1NvdXJjZS9XZWJLaXQyL0No YW5nZUxvZwppbmRleCA4Y2E2YmQxLi5jZmVmMzg3IDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViS2l0 Mi9DaGFuZ2VMb2cKKysrIGIvU291cmNlL1dlYktpdDIvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMTcg QEAKKzIwMTQtMDQtMjIgIENhcmxvcyBHYXJjaWEgQ2FtcG9zICA8Y2dhcmNpYUBpZ2FsaWEuY29t PgorCisgICAgICAgIFtHVEtdIENyYXNoIGFmdGVyIGdldHRpbmcgd2ViIHZpZXcgY29udGV4dCBw cm9wZXJ0eSB3aXRoIGdfb2JqZWN0X2dldAorICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9y Zy9zaG93X2J1Zy5jZ2k/aWQ9MTMxOTgzCisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChP T1BTISkuCisKKyAgICAgICAgVGhlIHByb2JsZW0gaXMgdGhhdCB0aGUgZ2V0dGVyIGlzIHVzaW5n IGdfdmFsdWVfdGFrZV9vYmplY3QoKSBhbmQKKyAgICAgICAgdGhlIGRlZmF1bHQgY29udGV4dCBp cyBkZXN0cm95ZWQgd2hlbiB0aGUgY2FsbGVyIHJlbGVhc2VzIGl0cyByZWYuCisKKyAgICAgICAg KiBVSVByb2Nlc3MvQVBJL2d0ay9XZWJLaXRXZWJWaWV3LmNwcDoKKyAgICAgICAgKHdlYmtpdFdl YlZpZXdHZXRQcm9wZXJ0eSk6IFVzZSBnX3ZhbHVlX3NldF9vYmplY3QoKSBpbnN0ZWFkIG9mCisg ICAgICAgIGdfdmFsdWVfdGFrZV9vYmplY3QoKS4KKwogMjAxNC0wNC0yMCAgRGFuIEJlcm5zdGVp biAgPG1pdHpAYXBwbGUuY29tPgogCiAgICAgICAgIFtDb2NvYV0gUmVtb3ZlIGludGVyZmFjZXMg aW4gdGhlIFRvIEJlIFJlbW92ZWQgZ3JvdXBzCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViS2l0Mi9V SVByb2Nlc3MvQVBJL2d0ay9XZWJLaXRXZWJWaWV3LmNwcCBiL1NvdXJjZS9XZWJLaXQyL1VJUHJv Y2Vzcy9BUEkvZ3RrL1dlYktpdFdlYlZpZXcuY3BwCmluZGV4IGRkNmVmYTIuLmFlYjIxZjYgMTAw NjQ0Ci0tLSBhL1NvdXJjZS9XZWJLaXQyL1VJUHJvY2Vzcy9BUEkvZ3RrL1dlYktpdFdlYlZpZXcu Y3BwCisrKyBiL1NvdXJjZS9XZWJLaXQyL1VJUHJvY2Vzcy9BUEkvZ3RrL1dlYktpdFdlYlZpZXcu Y3BwCkBAIC01NjAsNyArNTYwLDcgQEAgc3RhdGljIHZvaWQgd2Via2l0V2ViVmlld0dldFByb3Bl cnR5KEdPYmplY3QqIG9iamVjdCwgZ3VpbnQgcHJvcElkLCBHVmFsdWUqIHZhbHUKIAogICAgIHN3 aXRjaCAocHJvcElkKSB7CiAgICAgY2FzZSBQUk9QX1dFQl9DT05URVhUOgotICAgICAgICBnX3Zh bHVlX3Rha2Vfb2JqZWN0KHZhbHVlLCB3ZWJWaWV3LT5wcml2LT5jb250ZXh0KTsKKyAgICAgICAg Z192YWx1ZV9zZXRfb2JqZWN0KHZhbHVlLCB3ZWJWaWV3LT5wcml2LT5jb250ZXh0KTsKICAgICAg ICAgYnJlYWs7CiAgICAgY2FzZSBQUk9QX0dST1VQOgogICAgICAgICBnX3ZhbHVlX3NldF9vYmpl Y3QodmFsdWUsIHdlYmtpdF93ZWJfdmlld19nZXRfZ3JvdXAod2ViVmlldykpOwo=